)]}'
{"rally/cli/commands/task.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        \"\"\""},{"line_number":616,"context_line":"        tasks \u003d filter(bool, [task1, task2] + kwargs.get(\"tasks\", []))"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        if args or len(tasks) !\u003d 2:"},{"line_number":619,"context_line":"            raise exceptions.InvalidArgumentsException("},{"line_number":620,"context_line":"                \"this command requires two tasks UUIDs \""},{"line_number":621,"context_line":"                \"or json files to be specified\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_9d73ac4d","line":618,"updated":"2015-10-28 03:13:36.000000000","message":"Why limit this to just two tasks? It\u0027d be awesome if we could do two or more.","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                               \"result\": x[\"data\"][\"raw\"],"},{"line_number":649,"context_line":"                               \"load_duration\": x[\"data\"][\"load_duration\"],"},{"line_number":650,"context_line":"                               \"full_duration\": x[\"data\"][\"full_duration\"]},"},{"line_number":651,"context_line":"                    objects.Task.get(task_file_or_uuid).get_results())"},{"line_number":652,"context_line":"            else:"},{"line_number":653,"context_line":"                print(_(\"ERROR: Invalid UUID or file name passed: %s\""},{"line_number":654,"context_line":"                        ) % task_file_or_uuid,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_fd0bc07b","line":651,"updated":"2015-10-28 03:13:36.000000000","message":"This duplicates code from lines 465-469; it\u0027s complex enough that it should be abstracted out into a function.","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"}],"rally/task/processing/plot.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    DIFF_BETTER \u003d \"better\""},{"line_number":323,"context_line":"    DIFF_WORSE \u003d \"worse\""},{"line_number":324,"context_line":"    DIFF_RANGE \u003d (\"a-lot\", \"much\", \"a-little\", \"slightly\")"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def __init__(self, task1, task2):"},{"line_number":327,"context_line":"        self._task1_name, self._task1_results \u003d task1"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_78557ec4","line":324,"updated":"2015-10-28 03:13:36.000000000","message":"Dashes aren\u0027t needed here -- \"a lot,\" not \"a-lot\".","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                              self._to_str(v)])"},{"line_number":341,"context_line":"                                    for k, v in value.items()]))"},{"line_number":342,"context_line":"        raise TypeError(\"Value %(value)r of unexpected type: %(vtype)s\""},{"line_number":343,"context_line":"                        % {\"value\": value, \"vtype\": type(value)})"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def _make_hash(self, obj):"},{"line_number":346,"context_line":"        return hashlib.md5(self._to_str(obj)).hexdigest()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_78033eb9","line":343,"updated":"2015-10-28 03:13:36.000000000","message":"Instead of doing strict type checking here, it might be better to make the default be to return str(value).strip(), if value is not None, a list/tuple, or a dict.","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":364,"context_line":"            if value1 is None:"},{"line_number":365,"context_line":"                value1 \u003d \"-\""},{"line_number":366,"context_line":"                if value2_is_numeric:"},{"line_number":367,"context_line":"                    change \u003d \" \".join(self.DIFF_BETTER, self.DIFF_RANGE[0])"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            if value2 is None:"},{"line_number":370,"context_line":"                value2 \u003d \"-\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_f8b3ce08","line":367,"updated":"2015-10-28 03:13:36.000000000","message":"Is \"a lot\" really the appropriate way to describe this? It\u0027s really *infinitely* better, or uncomparable, or something. But saying that 1 is \"a lot better\" than no result seems misleading.\n\nAlso, the order is wrong -- it should be \"a lot better\", not \"better a lot\".","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e85d80e6f9ebe0aeeb8ef252bb7ad5aec2715685","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                change \u003d \" \".join([self.DIFF_WORSE, self.DIFF_RANGE[0]])"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"            elif value2_is_numeric:"},{"line_number":387,"context_line":"                change \u003d \" \".join([self.DIFF_BETTER, self.DIFF_RANGE[0]])"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        return {\"param\": name, \"level\": level,"},{"line_number":390,"context_line":"                \"value1\": value1, \"value2\": value2, \"change\": change}"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_d81db210","line":387,"updated":"2015-10-28 03:13:36.000000000","message":"The way this is built is going to make translation basically impossible. I.e., it assumes that comparisons are done the way English does them, and while that may work in some other languages (French), it will not work in others (Mandarin).","commit_id":"01379ce66da00637f331c63f572a290ca5de5354"}]}
