)]}'
{"rally-jobs/cinder.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ea60b346739f682259851106445ec0c748c15e4","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  CinderVolumes.create_and_update_volume:"},{"line_number":100,"context_line":"    -"},{"line_number":101,"context_line":"      args:"},{"line_number":102,"context_line":"        update_volume_kwargs:"},{"line_number":103,"context_line":"           display_name: \"name_updated\""},{"line_number":104,"context_line":"           display_description: \"desc_updated\""},{"line_number":105,"context_line":"        size: 1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa1b9901_4d554b4e","line":102,"updated":"2015-08-18 08:56:57.000000000","message":"Lets add one more CinderVolumes.create_and_update_volume with specified image to test line 100 in volumes.py","commit_id":"88a0c86b69c23886198304eddb8c8255dbf0cb89"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ea60b346739f682259851106445ec0c748c15e4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        size: 1"},{"line_number":106,"context_line":"      runner:"},{"line_number":107,"context_line":"        type: \"constant\""},{"line_number":108,"context_line":"        times: 3"},{"line_number":109,"context_line":"        concurrency: 1"},{"line_number":110,"context_line":"      context:"},{"line_number":111,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa1b9901_ed30df58","line":108,"updated":"2015-08-18 08:56:57.000000000","message":"Lets  change values, to test concurrency, multi user work and multi tenant work. times: 2, concurrency: 2, tenants: 2, users_per_tenant: 2.","commit_id":"88a0c86b69c23886198304eddb8c8255dbf0cb89"}],"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"27170342f8e839e25eb46c95d6c3c2bad61820c2","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @base.atomic_action_timer(\"cinder.update_volume\")"},{"line_number":152,"context_line":"    def _update_volume(self, volume, **kwargs):"},{"line_number":153,"context_line":"        \"\"\"Update the volume name."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        This atomic function updates volume display name by"},{"line_number":156,"context_line":"        generating random name."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c674e69d","line":153,"updated":"2015-08-04 11:59:35.000000000","message":"It update not only name.","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"27170342f8e839e25eb46c95d6c3c2bad61820c2","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        \"\"\"Update the volume name."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        This atomic function updates volume display name by"},{"line_number":156,"context_line":"        generating random name."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        :param volume: volume object"},{"line_number":159,"context_line":"        :param kwargs: Other optional parameters to update the volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_663872d4","line":156,"updated":"2015-08-04 11:59:35.000000000","message":"Not only generated random name could be updated","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"27170342f8e839e25eb46c95d6c3c2bad61820c2","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        :param kwargs: Other optional parameters to update the volume"},{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        kwargs[\"display_name\"] \u003d self._generate_random_name()"},{"line_number":163,"context_line":"        self.clients(\"cinder\").volumes.update(volume, **kwargs)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    @base.atomic_action_timer(\"cinder.delete_volume\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_66db927d","line":162,"updated":"2015-08-04 11:59:35.000000000","message":"What if we have dispay_name in kwargs?","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"27170342f8e839e25eb46c95d6c3c2bad61820c2","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":92,"context_line":"        :param image: image to be used to create volume"},{"line_number":93,"context_line":"        :param kwargs: optional args to create a volume"},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":"        if image:"},{"line_number":96,"context_line":"            kwargs[\"imageRef\"] \u003d image"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c612a6b4","line":93,"updated":"2015-08-04 11:59:35.000000000","message":"You wrote that this kwargs used to create volume but use them also for updating volume","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"32804f67d293bdbc25f7f705b8dcb313df8d4091","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        :param kwargs: optional args to create a volume"},{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":"        if image:"},{"line_number":96,"context_line":"            kwargs[\"imageRef\"] \u003d image"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        volume \u003d self._create_volume(size, **kwargs)"},{"line_number":99,"context_line":"        self._update_volume(volume, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_ae695027","line":96,"updated":"2015-08-04 20:47:25.000000000","message":"Please, use different args for create and update methods","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"27170342f8e839e25eb46c95d6c3c2bad61820c2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            kwargs[\"imageRef\"] \u003d image"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        volume \u003d self._create_volume(size, **kwargs)"},{"line_number":99,"context_line":"        self._update_volume(volume, **kwargs)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @types.set(image\u003dtypes.ImageResourceType)"},{"line_number":102,"context_line":"    @validation.image_exists(\"image\", nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_26c6ea67","line":99,"updated":"2015-08-04 11:59:35.000000000","message":"https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volumes.py#L45 It update name and description","commit_id":"731eeefc13c4f35045a6bb8a6f2ed3eeea45c15f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9022474de97d9a708671b6208e14074a2aa1c452","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    @validation.required_services(consts.Service.CINDER)"},{"line_number":86,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":87,"context_line":"    @base.scenario(context\u003d{\"cleanup\": [\"cinder\"]})"},{"line_number":88,"context_line":"    def create_and_update_volume(self, size, volume_update_args,"},{"line_number":89,"context_line":"                                 image\u003dNone, **kwargs):"},{"line_number":90,"context_line":"        \"\"\"Create a volume and update its name and description."},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_e9aca0a0","line":88,"updated":"2015-08-07 11:11:19.000000000","message":"See example know to make its proper in line 511-512.  Use default values and explicit names.","commit_id":"4a96668dd66736bcba77c4ad7920664ab8d67199"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7180512b438ec848735e0f106d4d09449de975da","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def create_and_update_volume(self, size, image\u003dNone,"},{"line_number":89,"context_line":"                                 create_volume_kwargs\u003dNone,"},{"line_number":90,"context_line":"                                 update_volume_kwargs\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Create a volume and update its name and description."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":94,"context_line":"        :param image: image to be used to create volume"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_f2c39e55","line":91,"updated":"2015-08-25 09:16:12.000000000","message":"Please add do_delete parameter as it is done at https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/volumes.py#L440","commit_id":"f45651e0b99ecf6385ad2477ad351526024cd34f"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"fb4a51b0f2a55f7819fe1d39876c525840b197a5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def create_and_update_volume(self, size, image\u003dNone,"},{"line_number":89,"context_line":"                                 create_volume_kwargs\u003dNone,"},{"line_number":90,"context_line":"                                 update_volume_kwargs\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Create a volume and update its name and description."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        :param size: volume size (integer, in GB)"},{"line_number":94,"context_line":"        :param image: image to be used to create volume"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_16cdc984","line":91,"in_reply_to":"fa1b9901_f2c39e55","updated":"2015-08-25 18:07:09.000000000","message":"Yuriy we do not force at this point do_delete argument. \nSo we can merge this even without it","commit_id":"f45651e0b99ecf6385ad2477ad351526024cd34f"}]}