)]}'
{"install_rally.sh":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"10c2576516aed25f5668e115c6ad1151f1d9045c","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                OVERWRITEDIR\u003dno"},{"line_number":644,"context_line":"            else"},{"line_number":645,"context_line":"                echo \"Removing directory $VENVDIR as requested.\""},{"line_number":646,"context_line":"                rm $VERBOSE -rf \"$VENVDIR\"            "},{"line_number":647,"context_line":"            fi"},{"line_number":648,"context_line":"        elif [ $OVERWRITEDIR \u003d \u0027no\u0027 ]"},{"line_number":649,"context_line":"        then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_2792be4c","line":646,"updated":"2015-08-07 06:50:51.000000000","message":"extra whitespace","commit_id":"b88416badf739983284d3d154e88da936684a722"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a450337d74977f14468e0f8dde05b610725a6302","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                OVERWRITEDIR\u003dno"},{"line_number":644,"context_line":"            else"},{"line_number":645,"context_line":"                echo \"Removing directory $VENVDIR as requested.\""},{"line_number":646,"context_line":"                rm $VERBOSE -rf \"$VENVDIR\"            "},{"line_number":647,"context_line":"            fi"},{"line_number":648,"context_line":"        elif [ $OVERWRITEDIR \u003d \u0027no\u0027 ]"},{"line_number":649,"context_line":"        then"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_2995a831","line":646,"in_reply_to":"1a4dcd0f_2792be4c","updated":"2015-08-07 11:16:07.000000000","message":"Done","commit_id":"b88416badf739983284d3d154e88da936684a722"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"10c2576516aed25f5668e115c6ad1151f1d9045c","unresolved":false,"context_lines":[{"line_number":659,"context_line":"      overwrite the $VENVDIR directory, or"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    * specify a different path by running this script again adding the"},{"line_number":662,"context_line":"    option: \"--target\" followed by a non-existent directory."},{"line_number":663,"context_line":"__EOF__"},{"line_number":664,"context_line":"        elif [ $OVERWRITEDIR \u003d \u0027yes\u0027 ]; then"},{"line_number":665,"context_line":"            echo \"Removing directory $VENVDIR as requested.\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_27e07ecc","line":662,"updated":"2015-08-07 06:50:51.000000000","message":"align with \u0027specify\u0027","commit_id":"b88416badf739983284d3d154e88da936684a722"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a450337d74977f14468e0f8dde05b610725a6302","unresolved":false,"context_lines":[{"line_number":659,"context_line":"      overwrite the $VENVDIR directory, or"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    * specify a different path by running this script again adding the"},{"line_number":662,"context_line":"    option: \"--target\" followed by a non-existent directory."},{"line_number":663,"context_line":"__EOF__"},{"line_number":664,"context_line":"        elif [ $OVERWRITEDIR \u003d \u0027yes\u0027 ]; then"},{"line_number":665,"context_line":"            echo \"Removing directory $VENVDIR as requested.\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_e9b100e1","line":662,"in_reply_to":"1a4dcd0f_27e07ecc","updated":"2015-08-07 11:16:07.000000000","message":"Done","commit_id":"b88416badf739983284d3d154e88da936684a722"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"10c2576516aed25f5668e115c6ad1151f1d9045c","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            rm -rf $SOURCEDIR"},{"line_number":838,"context_line":"            echo \"Source directory is removed.\""},{"line_number":839,"context_line":"        else"},{"line_number":840,"context_line":"            echo \"Unabled to remove source directory, becaus this script was started from it.\""},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        fi"},{"line_number":843,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_478eea2e","line":840,"updated":"2015-08-07 06:50:51.000000000","message":"s/becaus/because","commit_id":"b88416badf739983284d3d154e88da936684a722"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a450337d74977f14468e0f8dde05b610725a6302","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            rm -rf $SOURCEDIR"},{"line_number":838,"context_line":"            echo \"Source directory is removed.\""},{"line_number":839,"context_line":"        else"},{"line_number":840,"context_line":"            echo \"Unabled to remove source directory, becaus this script was started from it.\""},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        fi"},{"line_number":843,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a4dcd0f_e936e04f","line":840,"in_reply_to":"1a4dcd0f_478eea2e","updated":"2015-08-07 11:16:07.000000000","message":"Done","commit_id":"b88416badf739983284d3d154e88da936684a722"}],"rally/cli/cliutils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"00a7c3e00eb2f2a9b6ef8179cb784f0f9858d6f7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"MARGIN \u003d 3"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def find_config_files(path_list):"},{"line_number":51,"context_line":"    for path in path_list:"},{"line_number":52,"context_line":"        abspath \u003d os.path.abspath(os.path.expanduser(path))"},{"line_number":53,"context_line":"        confname \u003d abspath + \"/rally.conf\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_1beaa5ac","line":50,"updated":"2015-08-06 12:09:19.000000000","message":"this looks more like check_","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a07b4df522663f2b773e6c2546d92d8d895a7044","unresolved":false,"context_lines":[{"line_number":47,"context_line":"MARGIN \u003d 3"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def find_config_files(path_list):"},{"line_number":51,"context_line":"    for path in path_list:"},{"line_number":52,"context_line":"        abspath \u003d os.path.abspath(os.path.expanduser(path))"},{"line_number":53,"context_line":"        confname \u003d abspath + \"/rally.conf\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_9956b85a","line":50,"in_reply_to":"1a4dcd0f_1beaa5ac","updated":"2015-08-06 17:31:31.000000000","message":"disagree","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"00a7c3e00eb2f2a9b6ef8179cb784f0f9858d6f7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    for path in path_list:"},{"line_number":52,"context_line":"        abspath \u003d os.path.abspath(os.path.expanduser(path))"},{"line_number":53,"context_line":"        confname \u003d abspath + \"/rally.conf\""},{"line_number":54,"context_line":"        if os.path.exists(confname):"},{"line_number":55,"context_line":"            return [confname]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_bb74d167","line":54,"updated":"2015-08-06 12:09:19.000000000","message":"os.path.isfile","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a07b4df522663f2b773e6c2546d92d8d895a7044","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    for path in path_list:"},{"line_number":52,"context_line":"        abspath \u003d os.path.abspath(os.path.expanduser(path))"},{"line_number":53,"context_line":"        confname \u003d abspath + \"/rally.conf\""},{"line_number":54,"context_line":"        if os.path.exists(confname):"},{"line_number":55,"context_line":"            return [confname]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_594cb0c7","line":54,"in_reply_to":"1a4dcd0f_bb74d167","updated":"2015-08-06 17:31:31.000000000","message":"Done","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"}],"tests/unit/cli/test_cliutils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"00a7c3e00eb2f2a9b6ef8179cb784f0f9858d6f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        def echo(text):"},{"line_number":55,"context_line":"            return text"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_os_path.expanduser \u003d echo"},{"line_number":58,"context_line":"        mock_os_path.abspath \u003d echo"},{"line_number":59,"context_line":"        mock_os_path.exists.return_value \u003d True"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_bbdff167","line":57,"updated":"2015-08-06 12:09:19.000000000","message":"Please use mock.Mock, and check arguments too:\n\n    mock_os_path.abspath.return_value \u003d \"abspath\"\n    mock_os_path.expanduser.return_value \u003d \"expandedpath\"\n    mock_os_path.abspath.assert_called_once_with(\"expandedpath\"","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"a07b4df522663f2b773e6c2546d92d8d895a7044","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        def echo(text):"},{"line_number":55,"context_line":"            return text"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        mock_os_path.expanduser \u003d echo"},{"line_number":58,"context_line":"        mock_os_path.abspath \u003d echo"},{"line_number":59,"context_line":"        mock_os_path.exists.return_value \u003d True"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a4dcd0f_94e99fe8","line":57,"in_reply_to":"1a4dcd0f_bbdff167","updated":"2015-08-06 17:31:31.000000000","message":"Done","commit_id":"58379c62da1e1f60610ddc3ac649439372ff5d03"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"811270e5f586fce1dc57265eb0fa28841beb018b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        mock_os_path.isfile.return_value \u003d False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        result \u003d cliutils.find_config_files([\"path1\", \"path2\"])"},{"line_number":70,"context_line":"        self.assertIsNone(result)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_make_header(self):"},{"line_number":73,"context_line":"        h1 \u003d cliutils.make_header(\"msg\", size\u003d4, symbol\u003d\"\u003d\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_19a1c3a9","line":70,"updated":"2015-08-10 13:47:52.000000000","message":"It might be better to have two separate tests here.","commit_id":"a1c986591f31b893e85a45abe801fd0c06a43408"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"b7a60a5eed94c500f16b5f6217f57d6428b3eae7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        mock_os_path.isfile.return_value \u003d False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        result \u003d cliutils.find_config_files([\"path1\", \"path2\"])"},{"line_number":70,"context_line":"        self.assertIsNone(result)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_make_header(self):"},{"line_number":73,"context_line":"        h1 \u003d cliutils.make_header(\"msg\", size\u003d4, symbol\u003d\"\u003d\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a4dcd0f_d9034975","line":70,"in_reply_to":"1a4dcd0f_19a1c3a9","updated":"2015-08-10 19:40:35.000000000","message":"disagree.\nThis is a test for small function, smaller than this test.\nSo, on my opinion, splitting is not an effective way.\nBesides, there are some double tests in Rally master.","commit_id":"a1c986591f31b893e85a45abe801fd0c06a43408"}]}
