)]}'
{"rally/plugins/openstack/context/network/networks.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"98523a691fe41d978c9b22106405ea6a9f3cc6f0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            for i in range(self.config[\"networks_per_tenant\"]):"},{"line_number":75,"context_line":"                # NOTE(amaretskiy): add_router and subnets_num take effect"},{"line_number":76,"context_line":"                #                   for Neutron only."},{"line_number":77,"context_line":"                kwargs \u003d self.config[\"network_create_args\"]"},{"line_number":78,"context_line":"                kwargs[\"subnets_num\"] \u003d self.config[\"subnets_per_network\"]"},{"line_number":79,"context_line":"                kwargs[\"add_router\"] \u003d True"},{"line_number":80,"context_line":"                network \u003d net_wrapper.create_network(tenant_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_eee1ecd0","line":77,"updated":"2015-09-08 08:27:08.000000000","message":"I believe we should do \n  copy.deepcopy(self.config[\"netwrk_create_args\"]) or \n\nor do changes of newtork_create_args once not in the loop","commit_id":"f070f873c5f4e5361c4a56674d53d7d611d18600"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"58e989149d9535bc629526edf7c55008372125e0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    tenant_id,"},{"line_number":79,"context_line":"                    add_router\u003dTrue,"},{"line_number":80,"context_line":"                    subnets_num\u003dself.config[\"subnets_per_network\"],"},{"line_number":81,"context_line":"                    **self.config[\"network_create_args\"])"},{"line_number":82,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Exit context: `network`\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_a8511edb","line":81,"updated":"2015-09-11 03:32:57.000000000","message":"neutron\u0027s wrapper does update kwargs from here:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/wrappers/network.py#L278-L284","commit_id":"671c0727541daf5a6e15f29bdfced0bf86520ca1"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b6ba33608c47128af9615edad9818d0a7c4d7039","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    tenant_id,"},{"line_number":79,"context_line":"                    add_router\u003dTrue,"},{"line_number":80,"context_line":"                    subnets_num\u003dself.config[\"subnets_per_network\"],"},{"line_number":81,"context_line":"                    **self.config[\"network_create_args\"])"},{"line_number":82,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Exit context: `network`\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_a0cca96a","line":81,"in_reply_to":"ba15a1d1_1192da9e","updated":"2015-09-17 12:19:07.000000000","message":"I\u0027m sorry for my typos. I wanna say network_args should be updated from your self.config[\"network_create_args\"] in that \u0027kwargs\u0027\n\nPlease see the reference in my last comment. The network_args still contains only two arguments in your patch: tenanet_id and name. But your network_create_args is trying to give operators a chance to add their own arguments like \u0027shared\u0027, \u0027valn_transparent\u0027...","commit_id":"671c0727541daf5a6e15f29bdfced0bf86520ca1"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"32a810d4decd4163540194894a26c16146eeaf54","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                    tenant_id,"},{"line_number":79,"context_line":"                    add_router\u003dTrue,"},{"line_number":80,"context_line":"                    subnets_num\u003dself.config[\"subnets_per_network\"],"},{"line_number":81,"context_line":"                    **self.config[\"network_create_args\"])"},{"line_number":82,"context_line":"                self.context[\"tenants\"][tenant_id][\"networks\"].append(network)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @utils.log_task_wrapper(LOG.info, _(\"Exit context: `network`\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_1192da9e","line":81,"in_reply_to":"da20952f_a8511edb","updated":"2015-09-15 19:05:42.000000000","message":"self.config[\"network_create_args\"] is passed in as keyword arguments with the ** operator. The wrapper does not (and cannot) update the kwargs; it creates a new variable, network_args, and populates that. No modification is done.","commit_id":"671c0727541daf5a6e15f29bdfced0bf86520ca1"}],"rally/plugins/openstack/wrappers/network.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"79ad359f21d56b366105a6573e8d7b29b00f9192","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # TODO(amaretskiy): Generate CIDRs unique for network, not cluster"},{"line_number":272,"context_line":"        return generate_cidr(start_cidr\u003dself.start_cidr)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def create_network(self, tenant_id, add_router\u003dFalse, subnets_num\u003d0,"},{"line_number":275,"context_line":"                       dns_nameservers\u003d(\"8.8.8.8\", \"8.8.4.4\"),"},{"line_number":276,"context_line":"                       network_create_args\u003dNone):"},{"line_number":277,"context_line":"        \"\"\"Create network."}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_0e4a4226","line":274,"updated":"2015-09-18 04:23:24.000000000","message":"Imho this introduce bug. \n\ncreate_network in case of interface, nova network and neutron has different  signature, which actually kills all idea of wrappers","commit_id":"946230b390363d5d19b6ac4ada94bf5047eea706"}]}