)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8884875a39d7b9ae2f85496009828d1c974f69b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nayna-patel \u003cnayna.patel@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-12 06:46:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Cinder create_and_update_volume_snapshot scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement create_and_update_volume_snapshot scenario for cinder."},{"line_number":10,"context_line":"Adds supporting method \u0027_update_snapshot\u0027 to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_c77d4d6e","line":7,"updated":"2015-08-12 08:58:48.000000000","message":"create_and_update_snapshot","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1cdd9857bd3b82e680708cd7d9de09e1c5cf3fbf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nayna-patel \u003cnayna.patel@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-12 06:46:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Cinder create_and_update_volume_snapshot scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement create_and_update_volume_snapshot scenario for cinder."},{"line_number":10,"context_line":"Adds supporting method \u0027_update_snapshot\u0027 to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_1dc5c25a","line":7,"in_reply_to":"1a4dcd0f_c77d4d6e","updated":"2015-08-12 09:44:11.000000000","message":"Agree","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8884875a39d7b9ae2f85496009828d1c974f69b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Cinder create_and_update_volume_snapshot scenario"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement create_and_update_volume_snapshot scenario for cinder."},{"line_number":10,"context_line":"Adds supporting method \u0027_update_snapshot\u0027 to"},{"line_number":11,"context_line":"\"rally/plugins/openstack/scenarios/cinder/utils.py\"."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_67979990","line":9,"updated":"2015-08-12 08:58:48.000000000","message":"ditto","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"}],"rally-jobs/cinder.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1cdd9857bd3b82e680708cd7d9de09e1c5cf3fbf","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        force: False"},{"line_number":314,"context_line":"      runner:"},{"line_number":315,"context_line":"        type: \"constant\""},{"line_number":316,"context_line":"        times: 1"},{"line_number":317,"context_line":"        concurrency: 1"},{"line_number":318,"context_line":"      context:"},{"line_number":319,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a4dcd0f_9db0f2fe","line":316,"updated":"2015-08-12 09:44:11.000000000","message":"Lets increase times, concurrency,tenants, user_per_tenant to 2.","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"}],"rally/plugins/openstack/scenarios/cinder/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d530771b8843b0a6f22112c06691786f1cf1f756","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        This atomic function updates snapshot display name and description"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        :param snapshot: snapshot object"},{"line_number":268,"context_line":"        :param snapshot_update_args: dict, contains values to be updated."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        kwargs \u003d {}"},{"line_number":271,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d16c7d0a","line":268,"updated":"2015-08-10 22:07:36.000000000","message":"You have wrote that this dict contains values to be updated but to the cinder you pass only display_name and display_description. I think we shoud add ability to pass other values.","commit_id":"ad2f847b756d93966a096baf6d114ec13583c480"},{"author":{"_account_id":2353,"name":"murali-koripally","username":"murali-koripally"},"change_message_id":"2752fbf140076989b059b8685683371f2418b8ec","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        This atomic function updates snapshot display name and description"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        :param snapshot: snapshot object"},{"line_number":268,"context_line":"        :param snapshot_update_args: dict, contains values to be updated."},{"line_number":269,"context_line":"        \"\"\""},{"line_number":270,"context_line":"        kwargs \u003d {}"},{"line_number":271,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_38a56703","line":268,"in_reply_to":"1a4dcd0f_d16c7d0a","updated":"2015-08-11 11:09:16.000000000","message":"I think, we can update only display_name or display_description for a snapshot. Please check  https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v1/volume_snapshots.py#L148.","commit_id":"ad2f847b756d93966a096baf6d114ec13583c480"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"917a10a91c9a4d0b9fab40a9dd3d90b4f2624a20","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                                    description key-values to be updated."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        kwargs \u003d {}"},{"line_number":272,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("},{"line_number":273,"context_line":"            \"display_name\", self._generate_random_name(\"_\"))"},{"line_number":274,"context_line":"        kwargs[\"display_description\"] \u003d snapshot_update_args.get("},{"line_number":275,"context_line":"            \"display_description\", self._generate_random_name(\"_\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_5d27ca11","line":272,"updated":"2015-08-12 09:54:53.000000000","message":"Please do not allow user to specify name directly. Name should be generated by _generate_random_name(). This makes it possible to delete resources by name (if some resources were left by rally in case of failure during the benchmark)","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"e9f41a4e0da7b7567af3ae7b023e7aaa8ed57b56","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                                    description key-values to be updated."},{"line_number":270,"context_line":"        \"\"\""},{"line_number":271,"context_line":"        kwargs \u003d {}"},{"line_number":272,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("},{"line_number":273,"context_line":"            \"display_name\", self._generate_random_name(\"_\"))"},{"line_number":274,"context_line":"        kwargs[\"display_description\"] \u003d snapshot_update_args.get("},{"line_number":275,"context_line":"            \"display_description\", self._generate_random_name(\"_\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_87fee269","line":272,"in_reply_to":"1a4dcd0f_5d27ca11","updated":"2015-08-18 08:10:19.000000000","message":"Thanks for the suggestions.\nAdded user to specify a name explicitly, as we got this suggestion for other similar test, \nhttps://review.openstack.org/#/c/208996/1/rally/plugins/openstack/scenarios/cinder/utils.py . Also, create_snapshot method above allows to specify a name explicitly.","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"917a10a91c9a4d0b9fab40a9dd3d90b4f2624a20","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("},{"line_number":273,"context_line":"            \"display_name\", self._generate_random_name(\"_\"))"},{"line_number":274,"context_line":"        kwargs[\"display_description\"] \u003d snapshot_update_args.get("},{"line_number":275,"context_line":"            \"display_description\", self._generate_random_name(\"_\"))"},{"line_number":276,"context_line":"        self.clients(\"cinder\").volume_snapshots.update(snapshot, **kwargs)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @base.atomic_action_timer(\"cinder.delete_snapshot\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_1d4b82b2","line":275,"updated":"2015-08-12 09:54:53.000000000","message":"Why \"_\" is passed to _generate_random_name?","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":10185,"name":"Sunil Mamillapalli","email":"sunil_mamillapalli@persistent.co.in","username":"sunil-mamillapalli"},"change_message_id":"e9f41a4e0da7b7567af3ae7b023e7aaa8ed57b56","unresolved":false,"context_lines":[{"line_number":272,"context_line":"        kwargs[\"display_name\"] \u003d snapshot_update_args.get("},{"line_number":273,"context_line":"            \"display_name\", self._generate_random_name(\"_\"))"},{"line_number":274,"context_line":"        kwargs[\"display_description\"] \u003d snapshot_update_args.get("},{"line_number":275,"context_line":"            \"display_description\", self._generate_random_name(\"_\"))"},{"line_number":276,"context_line":"        self.clients(\"cinder\").volume_snapshots.update(snapshot, **kwargs)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @base.atomic_action_timer(\"cinder.delete_snapshot\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_a703e672","line":275,"in_reply_to":"1a4dcd0f_1d4b82b2","updated":"2015-08-18 08:10:19.000000000","message":"Done","commit_id":"bc7654123102b2b73f6e9cd3d9f6a3c269a32d78"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7af26810f5f8ccec25c90c467ed0633d703d5d2","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        return snapshot"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    @atomic.action_timer(\"cinder.update_snapshot\")"},{"line_number":262,"context_line":"    def _update_snapshot(self, snapshot, **snapshot_update_args):"},{"line_number":263,"context_line":"        \"\"\"Update the snapshot name and discription."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        This atomic function updates snapshot display name and description"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_497a0af3","line":262,"updated":"2015-08-18 15:55:30.000000000","message":"1) I recommend using keyword arguments explicitly, because this will validate arguments (since ** accepts arbitrary arguments)\n\n2) If arguments are set, then _generate_random_name() runs too, and its work is useless but increases atomic time, so I recommend run _generate_random_name() conditionally:\n\n def _update_snapshot(self, snapshot, display_name\u003dNone,\n                      display_description\u003dNone):\n     \"\"\"...\"\"\"\n     name \u003d (display_name\n             or self._generate_random_name(\"updated_name_\"))\n     desc \u003d (display_description\n             or self._generate_random_name(\"updated_desc_\"))\n     self.clients(\"cinder\").volume_snapshots.update(\n         snapshot, display_name\u003dname, display_description\u003ddesc)","commit_id":"c6da925f8e12f50b0d16a2c5ca8bf0768ff87956"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d530771b8843b0a6f22112c06691786f1cf1f756","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                                   update_snapshot_kwargs\u003dNone):"},{"line_number":413,"context_line":"        \"\"\"Create and then update a volume-snapshot."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        :param force: when set to True, allows snapshot of a volume when"},{"line_number":416,"context_line":"                      the volume is attached to an instance"},{"line_number":417,"context_line":"        :param create_snapshot_kwargs: dict, to be used to create snapshot"},{"line_number":418,"context_line":"        :param update_snapshot_kwargs: dict, to be used to update snapshot"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_910cb543","line":415,"updated":"2015-08-10 22:07:36.000000000","message":"if its True, making a snapshot of the volume allowed...","commit_id":"ad2f847b756d93966a096baf6d114ec13583c480"},{"author":{"_account_id":2353,"name":"murali-koripally","username":"murali-koripally"},"change_message_id":"2752fbf140076989b059b8685683371f2418b8ec","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                                   update_snapshot_kwargs\u003dNone):"},{"line_number":413,"context_line":"        \"\"\"Create and then update a volume-snapshot."},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        :param force: when set to True, allows snapshot of a volume when"},{"line_number":416,"context_line":"                      the volume is attached to an instance"},{"line_number":417,"context_line":"        :param create_snapshot_kwargs: dict, to be used to create snapshot"},{"line_number":418,"context_line":"        :param update_snapshot_kwargs: dict, to be used to update snapshot"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5844f319","line":415,"in_reply_to":"1a4dcd0f_910cb543","updated":"2015-08-11 11:09:16.000000000","message":"Thanks for the review. Added these lines in accordance with other scenarios. Please check L240-241","commit_id":"ad2f847b756d93966a096baf6d114ec13583c480"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8db41215bc62cfe46855676db162fcfeb5296cf0","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    @validation.required_contexts(\"volumes\")"},{"line_number":408,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":409,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"cinder\"]})"},{"line_number":410,"context_line":"    def create_and_update_snapshot(self, force\u003dFalse,"},{"line_number":411,"context_line":"                                   create_snapshot_kwargs\u003dNone,"},{"line_number":412,"context_line":"                                   update_snapshot_kwargs\u003dNone):"},{"line_number":413,"context_line":"        \"\"\"Create and then update a volume-snapshot."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_5d37f2af","line":410,"updated":"2015-08-25 13:20:44.000000000","message":"TypeError: create_and_update_snapshot() got an unexpected keyword argument \u0027display_name\u0027\n\nhttp://logs.openstack.org/32/211132/5/check/gate-rally-dsvm-rally-cinder/95bfe16/rally-plot/results.html.gz#/CinderVolumes.create_and_update_snapshot/failures","commit_id":"1a8e6dfa117da400350adf02165759c9aef2281e"}],"samples/tasks/scenarios/cinder/create-and-update-snapshot.json":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7af26810f5f8ccec25c90c467ed0633d703d5d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","},{"line_number":13,"context_line":"                \"times\": 1,"},{"line_number":14,"context_line":"                \"concurrency\": 1"},{"line_number":15,"context_line":"            },"},{"line_number":16,"context_line":"            \"context\": {"}],"source_content_type":"application/json","patch_set":4,"id":"fa1b9901_ec0f6c2c","line":13,"updated":"2015-08-18 15:55:30.000000000","message":"1 is almost useless, put at least 2","commit_id":"c6da925f8e12f50b0d16a2c5ca8bf0768ff87956"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a38fd6f7f73869bae7232679b5e03360166f805a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"    \"CinderVolumes.create_and_update_snapshot\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"args\": {"},{"line_number":5,"context_line":"                \"display_name\": \"updated_name\","},{"line_number":6,"context_line":"                \"display_description\": \"updated_description\","},{"line_number":7,"context_line":"                \"force\": false"},{"line_number":8,"context_line":"            },"}],"source_content_type":"application/json","patch_set":6,"id":"da20952f_948be21e","line":5,"updated":"2015-08-31 12:53:58.000000000","message":"I recommend to add a `create_snapshot_kwargs: {},\u0027 here, so users will have a hint that this argument is available","commit_id":"ff41d6669e892a550880aa3dc60463e14cf5dca8"}],"tests/unit/plugins/openstack/scenarios/cinder/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7af26810f5f8ccec25c90c467ed0633d703d5d2","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        self._test_atomic_action_timer(self.scenario.atomic_actions(),"},{"line_number":230,"context_line":"                                       \"cinder.create_snapshot\")"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test__update_snapshot(self):"},{"line_number":233,"context_line":"        fake_snapshot \u003d mock.MagicMock()"},{"line_number":234,"context_line":"        snapshot_update_args \u003d {\"display_name\": \"updated_name\","},{"line_number":235,"context_line":"                                \"display_description\": \"updated_description\"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_ec644ce6","line":232,"updated":"2015-08-18 15:55:30.000000000","message":"It would be nice to have a test that checks that random names are generated in case of missed data","commit_id":"c6da925f8e12f50b0d16a2c5ca8bf0768ff87956"}],"tests/unit/plugins/openstack/scenarios/cinder/test_volumes.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a38fd6f7f73869bae7232679b5e03360166f805a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        scenario._create_snapshot \u003d mock.MagicMock(return_value\u003dfake_snapshot)"},{"line_number":188,"context_line":"        scenario._update_snapshot \u003d mock.MagicMock()"},{"line_number":189,"context_line":"        scenario.create_and_update_snapshot("},{"line_number":190,"context_line":"            False, display_name\u003d\"updated_name\","},{"line_number":191,"context_line":"            display_description\u003d\"updated_description\")"},{"line_number":192,"context_line":"        scenario._create_snapshot.assert_called_once_with(\"uuid\", force\u003dFalse)"},{"line_number":193,"context_line":"        scenario._update_snapshot.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_943442fc","line":190,"updated":"2015-08-31 12:53:58.000000000","message":"Use named argument for one with value of `False\u0027. \n\nScenario actually takes all arguments as key-value pairs, so this positional case will never take place","commit_id":"ff41d6669e892a550880aa3dc60463e14cf5dca8"}]}
