)]}'
{"rally/plugins/openstack/scenarios/sahara/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1c6b67d628c2e7e14493a42f2cc571404a3fb3e4","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                master_ng \u003d [x for x in node_groups"},{"line_number":177,"context_line":"                             if x[\"name\"] \u003d\u003d \"master-ng\"][0]"},{"line_number":178,"context_line":"                master_ng[\"is_proxy_gateway\"] \u003d True"},{"line_number":179,"context_line":"                master_ng[\"floating_ip_pool\"] \u003d floating_ip_pool_value"},{"line_number":180,"context_line":"            else:"},{"line_number":181,"context_line":"                for ng in node_groups:"},{"line_number":182,"context_line":"                    ng[\"floating_ip_pool\"] \u003d floating_ip_pool_value"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_e4e7913e","line":179,"updated":"2015-08-18 11:40:43.000000000","message":"You have created a new list master_ng but not use it and not return. Looks like something wrong.","commit_id":"27ecfda78bbe331071302c00936eed8e07a8ec8d"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"234e7c9a92f2bc8eaaa50820481d88882be7d9d1","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                for ng in node_groups:"},{"line_number":183,"context_line":"                    ng[\"floating_ip_pool\"] \u003d floating_ip_pool_value"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return node_groups"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _setup_volumes(self, node_groups, volumes_per_node, volumes_size):"},{"line_number":188,"context_line":"        if volumes_per_node:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_246b8d86","line":185,"updated":"2015-09-01 11:58:13.000000000","message":"If enable_proxy is True, should this return proxy_groups instead?","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"88699b4baa1dc450e8830ce1785299168c0eed42","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                for ng in node_groups:"},{"line_number":183,"context_line":"                    ng[\"floating_ip_pool\"] \u003d floating_ip_pool_value"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return node_groups"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _setup_volumes(self, node_groups, volumes_per_node, volumes_size):"},{"line_number":188,"context_line":"        if volumes_per_node:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_ffc28e52","line":185,"in_reply_to":"da20952f_246b8d86","updated":"2015-09-10 12:34:45.000000000","message":"It actually does not matter much because the real change happens inside of each group\u0027s dict.\n\nThe return statement is here for further development convenience. Its value is not assigned to anything.","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"ea3bf8a50f8de9cbe727799d0dd33ef03616652e","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        :returns: created cluster"},{"line_number":275,"context_line":"        \"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if enable_proxy:"},{"line_number":278,"context_line":"            # One proxy for each 20 workers"},{"line_number":279,"context_line":"            # Even if there are less than 20 workers a Master Node will serve"},{"line_number":280,"context_line":"            # a proxy"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_5a71ec74","line":277,"updated":"2015-08-31 14:56:01.000000000","message":"why 20? why not have it configurable from task input?","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"88699b4baa1dc450e8830ce1785299168c0eed42","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        :returns: created cluster"},{"line_number":275,"context_line":"        \"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if enable_proxy:"},{"line_number":278,"context_line":"            # One proxy for each 20 workers"},{"line_number":279,"context_line":"            # Even if there are less than 20 workers a Master Node will serve"},{"line_number":280,"context_line":"            # a proxy"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_9f035276","line":277,"in_reply_to":"da20952f_5a71ec74","updated":"2015-09-10 12:34:45.000000000","message":"Agree 20 is a magic number.\nBut there is a reason for it. 20 is a default batch size used by Sahara provisioning engine. So on average Sahara will provision on proxy node per batch. It could be a parameter which will make it easy to change but changing it will not affect Sahara\u0027s batches (those are configured in sahara.conf).","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"d712a7202ef4bd1f950f6cbcb87855db9716d388","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        :returns: created cluster"},{"line_number":275,"context_line":"        \"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if enable_proxy:"},{"line_number":278,"context_line":"            # One proxy for each 20 workers"},{"line_number":279,"context_line":"            # Even if there are less than 20 workers a Master Node will serve"},{"line_number":280,"context_line":"            # a proxy"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b4ebd411","line":277,"in_reply_to":"da20952f_9f035276","updated":"2015-09-10 15:28:05.000000000","message":"I think it is better to be put into a configuration variable.","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"d712a7202ef4bd1f950f6cbcb87855db9716d388","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        \"\"\""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        if enable_proxy:"},{"line_number":278,"context_line":"            # One proxy for each 20 workers"},{"line_number":279,"context_line":"            # Even if there are less than 20 workers a Master Node will serve"},{"line_number":280,"context_line":"            # a proxy"},{"line_number":281,"context_line":"            proxies_count \u003d int(workers_count / 20)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_115e5245","line":278,"updated":"2015-09-10 15:28:05.000000000","message":"Please use the appropriate format for comments:\n\n # NOTE(yourname): ....","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"2f647e122125ffd029ebb6ce327e1ee6fc0dd2ef","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        if enable_proxy:"},{"line_number":281,"context_line":"            # One proxy for each 20 workers"},{"line_number":282,"context_line":"            # Even if there are less than 20 workers a Master Node will serve"},{"line_number":283,"context_line":"            # a proxy"},{"line_number":284,"context_line":"            proxies_count \u003d int("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_ead9be84","line":281,"updated":"2015-09-21 06:41:40.000000000","message":"doc doesn\u0027t match the CONF value","commit_id":"a0eb5dca83683435bbaf8599abc077f10aa39fbb"}],"tests/unit/plugins/openstack/scenarios/sahara/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"234e7c9a92f2bc8eaaa50820481d88882be7d9d1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self.clients(\"sahara\").clusters.create.return_value \u003d mock.MagicMock("},{"line_number":313,"context_line":"            id\u003d\"test_cluster_id\")"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.clients(\"sahara\").clusters.get.return_value \u003d mock.MagicMock("},{"line_number":316,"context_line":"            status\u003d\"active\")"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        scenario._launch_cluster("}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_e706f784","line":315,"updated":"2015-09-01 11:58:13.000000000","message":"Same here:\n\n self.clients(\"sahara\").clusters.get.return_value.status \u003d \"active\"","commit_id":"c3b35afc1b29f56645e756249eb0768c8183816b"}]}