)]}'
{"rally/task/validation.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"86c4e4946fb7ccf97bc2d722934286cbeba18382","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        message \u003d _(\"Image \u0027%s\u0027 not found\") % image_args"},{"line_number":262,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":263,"context_line":"    except exceptions.InvalidScenarioArgument as e:"},{"line_number":264,"context_line":"        return (ValidationResult(False, e.kwargs), None)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"def _get_flavor_from_context(config, flavor_value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_c50152b1","line":264,"updated":"2015-08-14 08:10:37.000000000","message":"agreed, but we just need pass message here, not whole kwargs.","commit_id":"c6b18cbd2385043bc5d33b13974b6b48c5a4caff"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5124054ce88aea27625966ebf0f03504ee6032d1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        image \u003d clients.glance().images.get(image\u003dimage_id).to_dict()"},{"line_number":259,"context_line":"        return (ValidationResult(True), image)"},{"line_number":260,"context_line":"    except (glance_exc.HTTPNotFound, exceptions.InvalidScenarioArgument):"},{"line_number":261,"context_line":"        message \u003d _(\"Image \u0027%s\u0027 not found or multiple found\") % image_args"},{"line_number":262,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_49a7df0a","line":261,"updated":"2015-08-20 22:30:37.000000000","message":"So I believe we should be more precise and refactor InvalidScenarioArgument and catch separatly HTTPNotFound and case when many found and case when something other went wrong.","commit_id":"3f4c0192a96de01913e38d369b3b2f96d9d8cb3a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ea691f5d9c8fc6b3463b01a8c1d858f410d1ac10","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":298,"context_line":"    except exceptions.InvalidScenarioArgument as e:"},{"line_number":299,"context_line":"        message \u003d e.kwargs[\"message\"]"},{"line_number":300,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"@validator"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_48f08f67","line":300,"updated":"2015-10-15 15:30:35.000000000","message":"Here we could simply use ValidationResult(False, e) This will reduce the amount of code and simplify it.","commit_id":"5ddef1b5dee788ccd0ab15d0640677d7e72a993c"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"91d736793297d457b4f5d1c518d0fa2be57e4b39","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":298,"context_line":"    except exceptions.InvalidScenarioArgument as e:"},{"line_number":299,"context_line":"        message \u003d e.kwargs[\"message\"]"},{"line_number":300,"context_line":"        return (ValidationResult(False, message), None)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"@validator"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_65da09ea","line":300,"in_reply_to":"5a2ca52d_48f08f67","updated":"2015-10-17 04:14:15.000000000","message":"got it, this patch still misses some case, I will update all of these later","commit_id":"5ddef1b5dee788ccd0ab15d0640677d7e72a993c"}]}