)]}'
{"rally/plugins/openstack/context/manila/constants.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a376eeb3b358cd99d6c27a13ff7b11b36f7d4cce","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"SHARE_NETWORKS_CONTEXT_NAME \u003d \"manila_share_networks\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_c9c4a860","line":16,"updated":"2015-08-19 13:48:22.000000000","message":"This constant is longer that its value. I think its not good. Also I think that we could deal with utils.py if we really need consts.","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7c78576754dcb060a73d30586ce5df7fdfc3f88f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"SHARE_NETWORKS_CONTEXT_NAME \u003d \"manila_share_networks\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_3181ffc3","line":16,"in_reply_to":"fa1b9901_6df56155","updated":"2015-08-19 17:22:53.000000000","message":"I am ok with this constant. \n\nActually I would prefer to use in other contexts same approach.","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cb4af84392017e2d7f31cbc48185fbcb56f060d7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"SHARE_NETWORKS_CONTEXT_NAME \u003d \"manila_share_networks\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_6df56155","line":16,"in_reply_to":"fa1b9901_c9c4a860","updated":"2015-08-19 15:27:37.000000000","message":"I do not see here any problems to have \"constants\" module. Also, it is unclear what do you want to say by \"not good\" according to length of a var name. Var/const is used for avoiding possible bugs with mistyping of its value in multiple places. Also, simplifies update of a code base in case its value is updated.","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"}],"rally/plugins/openstack/context/manila/manila_share_networks.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a376eeb3b358cd99d6c27a13ff7b11b36f7d4cce","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONTEXT_NAME \u003d constants.SHARE_NETWORKS_CONTEXT_NAME"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@context.configure(name\u003dCONTEXT_NAME, order\u003d450)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_49489887","line":30,"updated":"2015-08-19 13:48:22.000000000","message":"Assigning one constant to other is only tangle us.","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cb4af84392017e2d7f31cbc48185fbcb56f060d7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONTEXT_NAME \u003d constants.SHARE_NETWORKS_CONTEXT_NAME"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@context.configure(name\u003dCONTEXT_NAME, order\u003d450)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_edcdf185","line":30,"in_reply_to":"fa1b9901_49489887","updated":"2015-08-19 15:27:37.000000000","message":"How? Exactly this one is very obvious.","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7c78576754dcb060a73d30586ce5df7fdfc3f88f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONTEXT_NAME \u003d constants.SHARE_NETWORKS_CONTEXT_NAME"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@context.configure(name\u003dCONTEXT_NAME, order\u003d450)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_1154fb50","line":30,"in_reply_to":"fa1b9901_edcdf185","updated":"2015-08-19 17:22:53.000000000","message":"this is ok as well","commit_id":"9f274b26fba01cdc547667046a0b58b946feb12c"}]}
