)]}'
{"rally/plugins/openstack/context/nova/servers.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"04b84601337af1bfcd0f4ad28aeaa4632428a84b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            servers \u003d nova_scenario._boot_servers(image_id, flavor_id,"},{"line_number":99,"context_line":"                                                  requests\u003dservers_per_tenant,"},{"line_number":100,"context_line":"                                                  auto_assign_nic\u003dauto_nic)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            current_servers \u003d [server.id for server in servers]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_db80a78d","line":100,"updated":"2015-08-20 16:39:15.000000000","message":"This does not work since we call scenario method from context, but scenario uses self.context which is different in this run time - it has neither \"tenant\" nor \"iteration\" data:\n\n https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/utils.py#L103\n\n https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/nova/utils.py#L106","commit_id":"9f8fb92ec001a7cd56f7ee0dbe37adffa6f47447"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"93815ac099067e2da8b2580a13b6b7809007f105","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            servers \u003d nova_scenario._boot_servers(image_id, flavor_id,"},{"line_number":99,"context_line":"                                                  requests\u003dservers_per_tenant,"},{"line_number":100,"context_line":"                                                  auto_assign_nic\u003dauto_nic)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            current_servers \u003d [server.id for server in servers]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_f9e585a3","line":100,"in_reply_to":"ba15a1d1_fc1e2562","updated":"2015-09-17 09:26:53.000000000","message":"thanks, I\u0027m back for this patch. I think this works:\n\n    \"tenant\": {\"networks\":self.context[\"tenants\"][tenant_id][\"networks\"]}}\n    iteration is the num of current iter (Line85)\n\nChris\u0027 related patch has just got +A, I will rebase when that one is actually merged :)","commit_id":"9f8fb92ec001a7cd56f7ee0dbe37adffa6f47447"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2bf13d3de7dfe283a4cb00ba687a17e3974acaad","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            servers \u003d nova_scenario._boot_servers(image_id, flavor_id,"},{"line_number":99,"context_line":"                                                  requests\u003dservers_per_tenant,"},{"line_number":100,"context_line":"                                                  auto_assign_nic\u003dauto_nic)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"            current_servers \u003d [server.id for server in servers]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_fc1e2562","line":100,"in_reply_to":"fa1b9901_db80a78d","updated":"2015-09-15 16:33:58.000000000","message":"It seems like this could be fixed by adding \"tenant\" and \"iteration\": 0 to the context object created on line 89. (Or should it be \"iteration\": -1? I\u0027m not sure.)","commit_id":"9f8fb92ec001a7cd56f7ee0dbe37adffa6f47447"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f2a977c27cef6bb7d9bec4d06c35a47a95d9b2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        flavor_id \u003d types.FlavorResourceType.transform(clients\u003dclients,"},{"line_number":84,"context_line":"                                                       resource_config\u003dflavor)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        for iter, (user, tenant_id) in enumerate(rutils.iterate_per_tenants("},{"line_number":87,"context_line":"                self.context[\"users\"])):"},{"line_number":88,"context_line":"            LOG.debug(\"Booting servers for user tenant %s \""},{"line_number":89,"context_line":"                      % (user[\"tenant_id\"]))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_3f12eb57","line":86,"updated":"2015-09-17 15:30:13.000000000","message":"`iter\u0027 clushes with built-in name (s/iter/iter_/)","commit_id":"09e636851c7cb58e747a290c3f42e74f706a7c5a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"41a220ecff19559436d95b29726fd71f3ba0da2e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            tenant \u003d self.context[\"tenants\"][tenant_id]"},{"line_number":91,"context_line":"            nova_scenario \u003d nova_utils.NovaScenario({\"user\": user,"},{"line_number":92,"context_line":"                                                     \"tenant\": tenant,"},{"line_number":93,"context_line":"                                                     \"iteration\": iter_})"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"            LOG.debug(\"Calling _boot_servers with image_id\u003d%(image_id)s \""},{"line_number":96,"context_line":"                      \"flavor_id\u003d%(flavor_id)s \""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_355e1c46","line":93,"updated":"2015-09-21 16:47:03.000000000","message":"I\u0027m not entirely certain that using a different iteration for each user-tenant combo is the optimal solution for balancing the servers, since it could result in instances getting booted in the same network as an iteration of the scenario. For instance, iter_ \u003d\u003d 0 for the first user-tenant combo; if that combo is chosen for the first iteration of the scenario itself, and the scenario boots more instances, then they\u0027ll be in the same network as the context servers.\n\nIn practice this is a really tiny issue -- how often will a user boot servers in a scenario after booting servers in a context? -- but it could affect the benchmark. I think setting iteration to -1 will result in slightly better balancing.","commit_id":"8138c415f2c562108b1ef6a391f95d33ee6bda91"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65cb126dbf106d451d62f09414c9c6ae9a1a94af","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    @atomic.action_timer(\"nova.boot_servers\")"},{"line_number":491,"context_line":"    def _boot_servers(self, image_id, flavor_id, requests, name_prefix\u003dNone,"},{"line_number":492,"context_line":"                      instances_amount\u003d1, auto_assign_nic\u003dFalse, **kwargs):"},{"line_number":493,"context_line":"        \"\"\"Boot multiple servers."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        Returns when all the servers are actually booted and are in the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_0cf62ed7","line":492,"updated":"2015-08-19 13:44:26.000000000","message":"Please, auto_assign_nic and kwargs should be document.","commit_id":"fc4c1f4a0cfde6546b1869d6fd8fd4729d1d2593"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2bf13d3de7dfe283a4cb00ba687a17e3974acaad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba15a1d1_be12e460","updated":"2015-09-15 16:33:58.000000000","message":"The change to _boot_servers seems like it should be a separate change -- and it is: https://review.openstack.org/#/c/219855/\n\n:)","commit_id":"9f8fb92ec001a7cd56f7ee0dbe37adffa6f47447"}],"tests/unit/plugins/openstack/context/nova/test_servers.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"60f2a977c27cef6bb7d9bec4d06c35a47a95d9b2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                    \"concurrent\": 10,"},{"line_number":86,"context_line":"                },"},{"line_number":87,"context_line":"                \"servers\": {"},{"line_number":88,"context_line":"                    \"auto_assign_nic\": False,"},{"line_number":89,"context_line":"                    \"servers_per_tenant\": 5,"},{"line_number":90,"context_line":"                    \"image\": {"},{"line_number":91,"context_line":"                        \"name\": \"cirros-0.3.4-x86_64-uec\","}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_17a82b76","line":88,"updated":"2015-09-17 15:30:13.000000000","message":"It would be good to improve this test and check that auto_assign_nic is actually delivered to _boot_servers()","commit_id":"09e636851c7cb58e747a290c3f42e74f706a7c5a"}]}
