)]}'
{"rally/common/db/sqlalchemy/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c159089067482a9d2c01e5150efc885e1c8d9ac8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            _FACADE \u003d db_session.EngineFacade.from_config(CONF)"},{"line_number":42,"context_line":"        except Exception as e:"},{"line_number":43,"context_line":"            raise exceptions.RallyException(\"Unable to create database from \""},{"line_number":44,"context_line":"                                            \"the config file.\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return _FACADE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_2682d8c8","line":43,"updated":"2015-08-20 22:17:49.000000000","message":"This is very very very very bad idea. \n\n  1) You are catching ALL exceptions (instead of only one that you need) \n  2) You are losing trace information (so you will get even less debug information) \n  3) You are wrapping exception with RallyExceptions (which is unclear in this situation) \n  4) You are putting information about (not able to connect to DB) and don\u0027t put information about connection string (which is the most important part of this patch)","commit_id":"f17c11fb7484b8deca14d8a8ea82f8308fe7abb8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"561c147762053232ebe3197e65df83d000ac270e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            _FACADE \u003d db_session.EngineFacade.from_config(CONF)"},{"line_number":42,"context_line":"        except Exception as e:"},{"line_number":43,"context_line":"            raise exceptions.RallyException(\"Unable to create database from \""},{"line_number":44,"context_line":"                                            \"the config file.\")"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    return _FACADE"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_4b57be25","line":43,"in_reply_to":"fa1b9901_2682d8c8","updated":"2015-08-21 09:35:27.000000000","message":"Its wip","commit_id":"f17c11fb7484b8deca14d8a8ea82f8308fe7abb8"}]}