)]}'
{"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7defd255e3c19ed1f02d10029890b91ab1cde8f","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":334,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":335,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":336,"context_line":"    def create_and_list_secgroups(self, security_group_create_args\u003dNone):"},{"line_number":337,"context_line":"        \"\"\"Create and list security groups."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_6ac0e750","line":335,"updated":"2015-08-25 14:00:07.000000000","message":"Does this cleanup removes security groups created by this scenario?","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":334,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":335,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":336,"context_line":"    def create_and_list_secgroups(self, security_group_create_args\u003dNone):"},{"line_number":337,"context_line":"        \"\"\"Create and list security groups."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3489c626","line":335,"in_reply_to":"fa1b9901_6ac0e750","updated":"2015-08-26 09:46:55.000000000","message":"Alex is right. Cleanup does not remove security groups or have any significance here (as we are not creating any nets, subnets or routers etc).\n\nPlease add a class to cleanup security-groups here https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/cleanup/resources.py#L195-L195","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7defd255e3c19ed1f02d10029890b91ab1cde8f","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @atomic.action_timer(\"neutron.create_security_group\")"},{"line_number":352,"context_line":"    def _create_security_group(self, security_group_create_args):"},{"line_number":353,"context_line":"        \"\"\"create neutron security group"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param security_group_create_args: dict, POST /v2.0/security groups"},{"line_number":356,"context_line":"                                           request options"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_4aa2c3af","line":353,"updated":"2015-08-25 14:00:07.000000000","message":"s/create/Create/","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    def _create_security_group(self, security_group_create_args):"},{"line_number":353,"context_line":"        \"\"\"create neutron security group"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        :param security_group_create_args: dict, POST /v2.0/security groups"},{"line_number":356,"context_line":"                                           request options"},{"line_number":357,"context_line":"        :returns: neutron security groups dict"},{"line_number":358,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d4adeae9","line":355,"updated":"2015-08-26 09:46:55.000000000","message":"The API should be \n\nPOST /v2.0/security-groups\n\nhttp://developer.openstack.org/api-ref-networking-v2-ext.html#security_groups","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7defd255e3c19ed1f02d10029890b91ab1cde8f","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        :returns: neutron security groups dict"},{"line_number":358,"context_line":"        \"\"\""},{"line_number":359,"context_line":"        security_group_create_args.setdefault(\"name\","},{"line_number":360,"context_line":"                                              self._generate_random_name())"},{"line_number":361,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":362,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_ca7813c7","line":360,"updated":"2015-08-25 14:00:07.000000000","message":"self._generate_random_name(\"rally_sg_\")\n\nBecause otherwise random name prefix will be \"rally_net_\" - see L28","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":362,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @atomic.action_timer(\"neutron.list_security_groups\")"},{"line_number":365,"context_line":"    def _list_security_groups(self):"},{"line_number":366,"context_line":"        \"\"\"returns security groups list.\"\"\""},{"line_number":367,"context_line":"        security_groups \u003d self.clients(\"neutron\").list_security_groups()"},{"line_number":368,"context_line":"        return security_groups[\"security_groups\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d295fde3","line":365,"updated":"2015-08-26 09:46:55.000000000","message":"Please add **kwargs and document the same.\n\ndef _list_security_groups(self, **kwargs)","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7defd255e3c19ed1f02d10029890b91ab1cde8f","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @atomic.action_timer(\"neutron.list_security_groups\")"},{"line_number":365,"context_line":"    def _list_security_groups(self):"},{"line_number":366,"context_line":"        \"\"\"returns security groups list.\"\"\""},{"line_number":367,"context_line":"        security_groups \u003d self.clients(\"neutron\").list_security_groups()"},{"line_number":368,"context_line":"        return security_groups[\"security_groups\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_4d4e5d70","line":366,"updated":"2015-08-25 14:00:07.000000000","message":"s/returns/Return/   # ref. PEP257","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0d1f3e01e07f0e184cf0045c3a04aecd08103560","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @atomic.action_timer(\"neutron.list_security_groups\")"},{"line_number":365,"context_line":"    def _list_security_groups(self):"},{"line_number":366,"context_line":"        \"\"\"returns security groups list.\"\"\""},{"line_number":367,"context_line":"        security_groups \u003d self.clients(\"neutron\").list_security_groups()"},{"line_number":368,"context_line":"        return security_groups[\"security_groups\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d021a44e","line":366,"in_reply_to":"fa1b9901_4d4e5d70","updated":"2015-08-25 14:19:06.000000000","message":"it would be better to write here similar to L357","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    @atomic.action_timer(\"neutron.list_security_groups\")"},{"line_number":365,"context_line":"    def _list_security_groups(self):"},{"line_number":366,"context_line":"        \"\"\"returns security groups list.\"\"\""},{"line_number":367,"context_line":"        security_groups \u003d self.clients(\"neutron\").list_security_groups()"},{"line_number":368,"context_line":"        return security_groups[\"security_groups\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_f2360102","line":367,"updated":"2015-08-26 09:46:55.000000000","message":"I believe it is unnecessary to assign \"security_groups\" and return \"security_groups[\"security_groups\"] \".\nIt would be good to return the complete client response object.","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"}],"samples/tasks/scenarios/neutron/create_and_list_secgroups.json":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e7defd255e3c19ed1f02d10029890b91ab1cde8f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            },"},{"line_number":12,"context_line":"            \"context\": {"},{"line_number":13,"context_line":"                \"users\": {"},{"line_number":14,"context_line":"                    \"tenants\": 1,"},{"line_number":15,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":16,"context_line":"                },"},{"line_number":17,"context_line":"                \"quotas\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa1b9901_adb3794c","line":14,"updated":"2015-08-25 14:00:07.000000000","message":"I would recommend using more tenants (you have 100 iterations)","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":11,"context_line":"            },"},{"line_number":12,"context_line":"            \"context\": {"},{"line_number":13,"context_line":"                \"users\": {"},{"line_number":14,"context_line":"                    \"tenants\": 1,"},{"line_number":15,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":16,"context_line":"                },"},{"line_number":17,"context_line":"                \"quotas\": {"}],"source_content_type":"application/json","patch_set":1,"id":"fa1b9901_f4c6ee9a","line":14,"in_reply_to":"fa1b9901_adb3794c","updated":"2015-08-26 09:46:55.000000000","message":"Yes. Make it\n\n\"teanants\": 5,\n\"users_per_tenant\": 2","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"}],"samples/tasks/scenarios/neutron/create_and_list_secgroups.yaml":[{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b547c37c97f5b5bfbef4a6bf1e39d1f4c365bf51","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      context:"},{"line_number":11,"context_line":"        users:"},{"line_number":12,"context_line":"          tenants: 1"},{"line_number":13,"context_line":"          users_per_tenant: 1"},{"line_number":14,"context_line":"        quotas:"},{"line_number":15,"context_line":"          neutron:"},{"line_number":16,"context_line":"            network: -1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa1b9901_7452dedf","line":13,"updated":"2015-08-26 09:46:55.000000000","message":"Make sure to update the changes as in json","commit_id":"7929070d5d1b32a22d451598111a46ae437e88d3"}]}