)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14168,"name":"Alexandr Nevenchannyy","email":"anevenchannyy@mirantis.com","username":"anevenchannyy"},"change_message_id":"b8fdb90ab4842e55c4657f990ca9229531455c07","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  to all plugins. This method returns information about plugin"},{"line_number":14,"context_line":"  such like title, description, arguments, plugin module"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Introduce rally plugin show and list commnds that returns"},{"line_number":17,"context_line":"  information about all plugins"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Moves info related methods from rally.common.utils to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_f57c1874","line":16,"updated":"2015-08-27 17:06:03.000000000","message":"Please, replace commnds to commands","commit_id":"54d44034fddc9c43971d2f9907ab57796be31095"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8d71734598156d7e1b172181bf7f9050d269188f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[cli] Introduce \"rally plugin\" show and list commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch does few things"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Introduce rally.common.plugin.info.InfoMixin"},{"line_number":12,"context_line":"  and adds it to plugin base. It adds method get_info()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da20952f_2eefdbea","line":9,"updated":"2015-09-08 14:29:33.000000000","message":"*A few things?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[cli] Introduce \"rally plugin\" show and list commands"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch does few things"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- Introduce rally.common.plugin.info.InfoMixin"},{"line_number":12,"context_line":"  and adds it to plugin base. It adds method get_info()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba15a1d1_b9ad6933","line":9,"in_reply_to":"da20952f_2eefdbea","updated":"2015-09-14 08:48:36.000000000","message":"Done","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8d71734598156d7e1b172181bf7f9050d269188f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  to all plugins. This method returns information about plugin"},{"line_number":14,"context_line":"  such like title, description, arguments, plugin module"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Introduce rally plugin show and list commnds that returns"},{"line_number":17,"context_line":"  information about all plugins"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Moves info related methods from rally.common.utils to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da20952f_6ee5d308","line":16,"updated":"2015-09-08 14:29:33.000000000","message":"*commands","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  to all plugins. This method returns information about plugin"},{"line_number":14,"context_line":"  such like title, description, arguments, plugin module"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- Introduce rally plugin show and list commnds that returns"},{"line_number":17,"context_line":"  information about all plugins"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Moves info related methods from rally.common.utils to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba15a1d1_59aa0d1b","line":16,"in_reply_to":"da20952f_6ee5d308","updated":"2015-09-14 08:48:36.000000000","message":"Done","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"}],"rally/cli/cliutils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e2cf5d08a1fb1f3a1c800ddc911bc432d0e161d9","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    if action_fn.__doc__:"},{"line_number":380,"context_line":"        parsed_doc \u003d info.parse_docstring(action_fn.__doc__)"},{"line_number":381,"context_line":"        short \u003d parsed_doc.get(\"short_description\")"},{"line_number":382,"context_line":"        long \u003d parsed_doc.get(\"long_description\")"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        description \u003d \"%s\\n\\n%s\" % (short, long) if long else short"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_330188b0","line":382,"updated":"2015-09-08 12:39:47.000000000","message":"`long\u0027 clashes with built-in python type","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    if action_fn.__doc__:"},{"line_number":380,"context_line":"        parsed_doc \u003d info.parse_docstring(action_fn.__doc__)"},{"line_number":381,"context_line":"        short \u003d parsed_doc.get(\"short_description\")"},{"line_number":382,"context_line":"        long \u003d parsed_doc.get(\"long_description\")"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        description \u003d \"%s\\n\\n%s\" % (short, long) if long else short"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_5ccb64a4","line":382,"in_reply_to":"da20952f_330188b0","updated":"2015-09-14 08:48:36.000000000","message":"It is not related to my patch. \nI won\u0027t fix it in this patch. \nYou can report a bug and this should be fixed with proper hacking rules.","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d84ede12d44aba66c3b5081ce7dd855b46c8d5dd","unresolved":false,"context_lines":[{"line_number":379,"context_line":"    if action_fn.__doc__:"},{"line_number":380,"context_line":"        parsed_doc \u003d info.parse_docstring(action_fn.__doc__)"},{"line_number":381,"context_line":"        short \u003d parsed_doc.get(\"short_description\")"},{"line_number":382,"context_line":"        long \u003d parsed_doc.get(\"long_description\")"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        description \u003d \"%s\\n\\n%s\" % (short, long) if long else short"},{"line_number":385,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_c4cb9471","line":382,"in_reply_to":"da20952f_5ccb64a4","updated":"2015-09-14 08:51:09.000000000","message":"Sure, sorry","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"}],"rally/cli/commands/info.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"844d67def389c034acdb6ca7011e33e3775d2a9c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from rally.task import sla"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class InfoCommands(object):"},{"line_number":52,"context_line":"    \"\"\"This command allows you to get quick doc of some rally entities."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    Available for scenario groups, scenarios, SLA, deploy engines and"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_a6ca7419","line":51,"updated":"2015-08-31 14:47:01.000000000","message":"these commands should be removed or deprecated.","commit_id":"e98226505284ff86274135eaf8b538521af58baf"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            scenario_inst \u003d scenario.Scenario.get(query)"},{"line_number":256,"context_line":"            header \u003d \"%s (task scenario)\" % scenario_inst.get_name()"},{"line_number":257,"context_line":"            result \u003d self._make_header(header)"},{"line_number":258,"context_line":"            result +\u003d \"\\n\\n\""},{"line_number":259,"context_line":"            doc \u003d info.parse_docstring(scenario_inst.__doc__)"},{"line_number":260,"context_line":"            if not doc[\"short_description\"]:"},{"line_number":261,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_bb46acbd","line":258,"updated":"2015-09-14 16:07:48.000000000","message":"Scope creep: While we\u0027re mucking around in this code, it\u0027d be nice to get rid of string mutation as well.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            scenario_inst \u003d scenario.Scenario.get(query)"},{"line_number":256,"context_line":"            header \u003d \"%s (task scenario)\" % scenario_inst.get_name()"},{"line_number":257,"context_line":"            result \u003d self._make_header(header)"},{"line_number":258,"context_line":"            result +\u003d \"\\n\\n\""},{"line_number":259,"context_line":"            doc \u003d info.parse_docstring(scenario_inst.__doc__)"},{"line_number":260,"context_line":"            if not doc[\"short_description\"]:"},{"line_number":261,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_354cdc41","line":258,"in_reply_to":"ba15a1d1_bb46acbd","updated":"2015-09-15 04:22:17.000000000","message":"This code will be purged soon. SO let\u0027s not do anything that is not required.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"}],"rally/cli/commands/plugin.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8d71734598156d7e1b172181bf7f9050d269188f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_3ba87a20","line":43,"updated":"2015-09-08 14:29:33.000000000","message":"Into the found we put plugins with name as a substring. I suggest to use approach as in info https://github.com/openstack/rally/blob/master/rally/cli/commands/info.py#L234","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_9c3c9c94","line":43,"in_reply_to":"da20952f_3ba87a20","updated":"2015-09-14 08:48:36.000000000","message":"I am going to remove that code. \"in\" works way better from UX perspective in this command.","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8d71734598156d7e1b172181bf7f9050d269188f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            print(\"NAMESPACE\\n\\t%s\" % plugin_info[\"namespace\"])"},{"line_number":61,"context_line":"            print(\"MODULE\\n\\t%s\" % plugin_info[\"module\"])"},{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCR\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_d6a8358f","line":63,"updated":"2015-09-08 14:29:33.000000000","message":"Why not \"DESCRIPTION\"?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            print(\"NAMESPACE\\n\\t%s\" % plugin_info[\"namespace\"])"},{"line_number":61,"context_line":"            print(\"MODULE\\n\\t%s\" % plugin_info[\"module\"])"},{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCR\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_c43714e2","line":63,"in_reply_to":"da20952f_d6a8358f","updated":"2015-09-14 08:48:36.000000000","message":"Done","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8d71734598156d7e1b172181bf7f9050d269188f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCR\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_b6f3419f","line":65,"updated":"2015-09-08 14:29:33.000000000","message":"Maybe add here \u0027:\u0027 or \u0027\\t\u0027?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCR\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_9c633cb1","line":65,"in_reply_to":"da20952f_b6f3419f","updated":"2015-09-14 08:48:36.000000000","message":"what is the purpose of \"\\t\" here?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"bc321c466835e830662943dfccddc2f8b712d88a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":40,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_3103ad75","line":42,"updated":"2015-09-14 10:17:54.000000000","message":"all_plugins \u003d plugin.Plugin.get_all(namespace\u003dnamespace)","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b7e3578474587bb4f5eab685f3072ed1ba3389b7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":40,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_a9cc2936","line":42,"in_reply_to":"ba15a1d1_3103ad75","updated":"2015-09-14 15:43:15.000000000","message":"Done","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"bc321c466835e830662943dfccddc2f8b712d88a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"},{"line_number":47,"context_line":"            if namespace:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_91f2b999","line":44,"updated":"2015-09-14 10:17:54.000000000","message":"exact_match","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b7e3578474587bb4f5eab685f3072ed1ba3389b7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        name_lw \u003d name.lower()"},{"line_number":42,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"},{"line_number":47,"context_line":"            if namespace:"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_69d611c7","line":44,"in_reply_to":"ba15a1d1_91f2b999","updated":"2015-09-14 15:43:15.000000000","message":"Done","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"bc321c466835e830662943dfccddc2f8b712d88a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"},{"line_number":47,"context_line":"            if namespace:"},{"line_number":48,"context_line":"                print("},{"line_number":49,"context_line":"                    \"There is no plugin: %(name)s in %(namespace)s namespace\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_f13c5531","line":46,"updated":"2015-09-14 10:17:54.000000000","message":"What if not found but exact_match?","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b7e3578474587bb4f5eab685f3072ed1ba3389b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"},{"line_number":47,"context_line":"            if namespace:"},{"line_number":48,"context_line":"                print("},{"line_number":49,"context_line":"                    \"There is no plugin: %(name)s in %(namespace)s namespace\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_29001934","line":46,"in_reply_to":"ba15a1d1_34ddd442","updated":"2015-09-14 15:43:15.000000000","message":"https://pbs.twimg.com/profile_images/1657519506/Impossibru-1287339853_400x400.jpg","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"3a955b9e50876dc84254e0c1850135435cfd4ee4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"},{"line_number":44,"context_line":"        exactly_match \u003d [p for p in found if name_lw \u003d\u003d p.get_name().lower()]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        if not found:"},{"line_number":47,"context_line":"            if namespace:"},{"line_number":48,"context_line":"                print("},{"line_number":49,"context_line":"                    \"There is no plugin: %(name)s in %(namespace)s namespace\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_34ddd442","line":46,"in_reply_to":"ba15a1d1_f13c5531","updated":"2015-09-14 13:29:46.000000000","message":"@Sergey: How could it be possible given the code above?","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"3a955b9e50876dc84254e0c1850135435cfd4ee4","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exactly_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exactly_match[0]"},{"line_number":57,"context_line":"            plugin_info \u003d plugin_.get_info()"},{"line_number":58,"context_line":"            print(cliutils.make_header(plugin_info[\"title\"]))"},{"line_number":59,"context_line":"            print(\"NAME\\n\\t%s\" % plugin_info[\"name\"])"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_d455781d","line":56,"updated":"2015-09-14 13:29:46.000000000","message":"Do we ensure somewhere that plugin name is case-insensitively unique? If not, there could be more than one exactly_match","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b7e3578474587bb4f5eab685f3072ed1ba3389b7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exactly_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exactly_match[0]"},{"line_number":57,"context_line":"            plugin_info \u003d plugin_.get_info()"},{"line_number":58,"context_line":"            print(cliutils.make_header(plugin_info[\"title\"]))"},{"line_number":59,"context_line":"            print(\"NAME\\n\\t%s\" % plugin_info[\"name\"])"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_69bb7173","line":56,"in_reply_to":"ba15a1d1_d455781d","updated":"2015-09-14 15:43:15.000000000","message":"I believe that we should add this to plugin base. \nBut let\u0027s do it as separated change.","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"bc321c466835e830662943dfccddc2f8b712d88a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                   help\u003d\"List only plugins that are in specified namespace\")"},{"line_number":78,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":79,"context_line":"    def list(self, name\u003dNone, namespace\u003dNone):"},{"line_number":80,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":81,"context_line":"        matched \u003d all_plugins"},{"line_number":82,"context_line":"        if name:"},{"line_number":83,"context_line":"            name_lw \u003d name.lower()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_f123f503","line":80,"updated":"2015-09-14 10:17:54.000000000","message":"same as above","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b7e3578474587bb4f5eab685f3072ed1ba3389b7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                   help\u003d\"List only plugins that are in specified namespace\")"},{"line_number":78,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":79,"context_line":"    def list(self, name\u003dNone, namespace\u003dNone):"},{"line_number":80,"context_line":"        all_plugins \u003d [p for p in plugin.Plugin.get_all(namespace\u003dnamespace)]"},{"line_number":81,"context_line":"        matched \u003d all_plugins"},{"line_number":82,"context_line":"        if name:"},{"line_number":83,"context_line":"            name_lw \u003d name.lower()"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba15a1d1_29aed92e","line":80,"in_reply_to":"ba15a1d1_f123f503","updated":"2015-09-14 15:43:15.000000000","message":"Done","commit_id":"ed2f7578de3bc1e2e4b2e7c8467cb0640e60e028"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_95a4c857","line":65,"updated":"2015-09-15 04:22:17.000000000","message":"PARAMETERS","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_bb7eacac","line":65,"updated":"2015-09-14 16:07:48.000000000","message":"Typo: PARAMETeRS","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"},{"line_number":69,"context_line":"                cliutils.print_list(rows, fields\u003d[\"name\", \"description\"])"},{"line_number":70,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_1b3b18ed","line":67,"updated":"2015-09-14 16:07:48.000000000","message":"Why did you use **-expansion here instead of:\n\n    rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"]) ... ]","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETRS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(**{\"name\": p[\"name\"],"},{"line_number":67,"context_line":"                                        \"description\": p[\"doc\"]})"},{"line_number":68,"context_line":"                        for p in plugin_info[\"parameters\"]]"},{"line_number":69,"context_line":"                cliutils.print_list(rows, fields\u003d[\"name\", \"description\"])"},{"line_number":70,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_35261ccf","line":67,"in_reply_to":"ba15a1d1_1b3b18ed","updated":"2015-09-15 04:22:17.000000000","message":"Done","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"15e4d35bdbefe01ae65cc5fa36ee3399fe62f338","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cliutils.print_list(rows, fields\u003d[\"name\", \"namespace\", \"title\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @cliutils.args(\"--name\", dest\u003d\"name\", type\u003dstr,"},{"line_number":36,"context_line":"                   help\u003d\"Plugin name.\")"},{"line_number":37,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr,"},{"line_number":38,"context_line":"                   help\u003d\"Plugin namespace.\")"},{"line_number":39,"context_line":"    @plugins.ensure_plugins_are_loaded"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_a3550c51","line":36,"updated":"2015-09-15 06:44:37.000000000","message":"Seems like this is not an exact match, any plugins contain matched name will be listed, so it would be nice to make this help message improved:)","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d9b79ddd5bd16b578e247d42ca2897f1a3c22034","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cliutils.print_list(rows, fields\u003d[\"name\", \"namespace\", \"title\"])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @cliutils.args(\"--name\", dest\u003d\"name\", type\u003dstr,"},{"line_number":36,"context_line":"                   help\u003d\"Plugin name.\")"},{"line_number":37,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr,"},{"line_number":38,"context_line":"                   help\u003d\"Plugin namespace.\")"},{"line_number":39,"context_line":"    @plugins.ensure_plugins_are_loaded"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_6ea242b0","line":36,"in_reply_to":"ba15a1d1_a3550c51","updated":"2015-09-16 09:24:46.000000000","message":"Disagree on this. \n\nThis method is called show(). It shows details about ONE item. \n\nIn case of user input error and multiple items were found we are displaying pretty message with samples of names that can be specified. \n\nIMHO help message should stay \"Plugin name.\"","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"15e4d35bdbefe01ae65cc5fa36ee3399fe62f338","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    % {\"name\": name, \"namespace\": namespace}"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exact_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exact_match[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_a340aca6","line":53,"updated":"2015-09-15 06:44:37.000000000","message":"i think `There is no plugin contains name: %s\u0027 would be better here.","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bee1eac1b6a7d243e2266016ee86f6b9c37a208a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    % {\"name\": name, \"namespace\": namespace}"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exact_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exact_match[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_6c97d190","line":53,"in_reply_to":"ba15a1d1_55937e4f","updated":"2015-09-15 13:55:49.000000000","message":"Illia +1","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"31af57484b8e9b5c2daeae0a16f14b4ede91f388","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    % {\"name\": name, \"namespace\": namespace}"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exact_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exact_match[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_14d39e05","line":53,"in_reply_to":"ba15a1d1_6c97d190","updated":"2015-09-16 00:42:09.000000000","message":"lllia +1","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"4239c553cac341c62e6dcf85c08e54573df2ab7e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    % {\"name\": name, \"namespace\": namespace}"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exact_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exact_match[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_55937e4f","line":53,"in_reply_to":"ba15a1d1_a340aca6","updated":"2015-09-15 08:49:52.000000000","message":"\u0027There is no plugin that contains \"%s\" in the name\u0027 ?","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d9b79ddd5bd16b578e247d42ca2897f1a3c22034","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                    % {\"name\": name, \"namespace\": namespace}"},{"line_number":51,"context_line":"                )"},{"line_number":52,"context_line":"            else:"},{"line_number":53,"context_line":"                print(\"There is no plugin: %s\" % name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        elif len(found) \u003d\u003d 1 or exact_match:"},{"line_number":56,"context_line":"            plugin_ \u003d found[0] if len(found) \u003d\u003d 1 else exact_match[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_49be91d5","line":53,"in_reply_to":"ba15a1d1_a340aca6","updated":"2015-09-16 09:24:46.000000000","message":"IMHO current name is better.  \n\nCommand is called \"show\" and it shows details about ONE item. In case of multiple found and not exactly matched names we are showing help messages for users. \n\nSo if there is nothing related to plugin it should say \"NO such plugin\" and that is all.","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"15e4d35bdbefe01ae65cc5fa36ee3399fe62f338","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            print(\"NAMESPACE\\n\\t%s\" % plugin_info[\"namespace\"])"},{"line_number":61,"context_line":"            print(\"MODULE\\n\\t%s\" % plugin_info[\"module\"])"},{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETERS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"])"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_a30d0c40","line":63,"updated":"2015-09-15 06:44:37.000000000","message":"Example command: rally plugin show SaharaClusters.create_scale_delete_cluster\n\nprint(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"].replace(\"\\n\", \"\\n\\t\"))","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bee1eac1b6a7d243e2266016ee86f6b9c37a208a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            print(\"NAMESPACE\\n\\t%s\" % plugin_info[\"namespace\"])"},{"line_number":61,"context_line":"            print(\"MODULE\\n\\t%s\" % plugin_info[\"module\"])"},{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETERS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"])"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_accac99f","line":63,"in_reply_to":"ba15a1d1_a30d0c40","updated":"2015-09-15 13:55:49.000000000","message":"Would it be better to use textwrap at this point? E.g.:\n\n    print(\"DESCRIPTION\")\n    print(textwrap.fill(plugin_info[\"description\"], initial_indent\u003d\"\\t\", subsequent_indent\u003d\"\\t\"))\n\nOr maybe:\n\n    print(textwrap.fill(\"DESCRIPTION\\n%s\" % plugin_info[\"description\"], subsequent_indent\u003d\"\\t\"))\n\nIf we wanted to be real fancy we could even detect the terminal width and wrap to it.","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d9b79ddd5bd16b578e247d42ca2897f1a3c22034","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            print(\"NAMESPACE\\n\\t%s\" % plugin_info[\"namespace\"])"},{"line_number":61,"context_line":"            print(\"MODULE\\n\\t%s\" % plugin_info[\"module\"])"},{"line_number":62,"context_line":"            if plugin_info[\"description\"]:"},{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETERS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"])"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_042285b9","line":63,"in_reply_to":"ba15a1d1_accac99f","updated":"2015-09-16 09:24:46.000000000","message":"fixed","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"15e4d35bdbefe01ae65cc5fa36ee3399fe62f338","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETERS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"])"},{"line_number":67,"context_line":"                        for p in plugin_info[\"parameters\"]]"},{"line_number":68,"context_line":"                cliutils.print_list(rows, fields\u003d[\"name\", \"description\"])"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_86b57632","line":66,"updated":"2015-09-15 06:44:37.000000000","message":"rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"].replace(\"\\n\\t\", \"\\n\"))","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"d9b79ddd5bd16b578e247d42ca2897f1a3c22034","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                print(\"DESCRIPTION\\n\\t%s\" % plugin_info[\"description\"])"},{"line_number":64,"context_line":"            if plugin_info[\"parameters\"]:"},{"line_number":65,"context_line":"                print(\"PARAMETERS\")"},{"line_number":66,"context_line":"                rows \u003d [utils.Struct(name\u003dp[\"name\"], description\u003dp[\"doc\"])"},{"line_number":67,"context_line":"                        for p in plugin_info[\"parameters\"]]"},{"line_number":68,"context_line":"                cliutils.print_list(rows, fields\u003d[\"name\", \"description\"])"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_c4024d0b","line":66,"in_reply_to":"ba15a1d1_86b57632","updated":"2015-09-16 09:24:46.000000000","message":"I fixed rally.common.plugin.info module and now this is not need","commit_id":"63e6f17abf304e07b1bbc85283fe231962408f1d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a33b6b216114b958818117ea4dd07f49b55a3a27","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr,"},{"line_number":40,"context_line":"                   help\u003d\"Plugin namespace.\")"},{"line_number":41,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":42,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":43,"context_line":"        name_lw \u003d name.lower()"},{"line_number":44,"context_line":"        all_plugins \u003d plugin.Plugin.get_all(namespace\u003dnamespace)"},{"line_number":45,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_9ff33e9e","line":42,"updated":"2015-09-16 10:04:57.000000000","message":"I think it really needed to add here some docstring. Because when I type \"rally plugin\" its not re ally clear what are commands do.\nroman@roman:~/rally$ rally plugin\nusage: rally plugin [-h] {list,show} ...\n\nCommands:\n   list   \n   show   \n\noptional arguments:\n  -h, --help  show this help message and exit\n\nAlso I think we need to help user to use this command http://paste.openstack.org/show/464401/ Its not for users output None","commit_id":"c6d1fc53259876ac8a60d63d28a31b23a86e004f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"44d53331aba63a3d19fc6b1c1b0a6567c5c49eac","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @cliutils.args(\"--namespace\", dest\u003d\"namespace\", type\u003dstr,"},{"line_number":40,"context_line":"                   help\u003d\"Plugin namespace.\")"},{"line_number":41,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":42,"context_line":"    def show(self, name, namespace\u003dNone):"},{"line_number":43,"context_line":"        name_lw \u003d name.lower()"},{"line_number":44,"context_line":"        all_plugins \u003d plugin.Plugin.get_all(namespace\u003dnamespace)"},{"line_number":45,"context_line":"        found \u003d [p for p in all_plugins if name_lw in p.get_name().lower()]"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_2838bb3c","line":42,"in_reply_to":"ba15a1d1_9ff33e9e","updated":"2015-09-16 10:24:06.000000000","message":"I don\u0027t know what we can to do now but names like \u0027images\u0027 says nothing when we type \"rally plugin list\". Maybe its a metter of taste. For the future someone need to fix empty descriptions)","commit_id":"c6d1fc53259876ac8a60d63d28a31b23a86e004f"}],"rally/common/plugin/info.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e2cf5d08a1fb1f3a1c800ddc911bc432d0e161d9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"              }"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    short_description \u003d long_description \u003d returns \u003d None"},{"line_number":47,"context_line":"    params \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if docstring:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_e2433712","line":46,"updated":"2015-09-08 12:39:47.000000000","message":"Maybe replace None with some str value like empty string or \"-\", so we will not see `None\u0027 in listings like that: http://paste.openstack.org/show/450170/","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"              }"},{"line_number":44,"context_line":"    \"\"\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    short_description \u003d long_description \u003d returns \u003d None"},{"line_number":47,"context_line":"    params \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if docstring:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_245e10ea","line":46,"in_reply_to":"da20952f_e2433712","updated":"2015-09-14 08:48:36.000000000","message":"yep we can change it to \"\"","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":23,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":24,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":25,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_1ea54603","line":23,"updated":"2015-09-14 16:07:48.000000000","message":"There are a couple of plugins that use :return: instead of :returns:, so those should be fixed:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/sahara/utils.py#L414\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/sahara/utils.py#L505\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/wrappers/network.py#L418","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":23,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":24,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":25,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_5c441473","line":23,"in_reply_to":"ba15a1d1_1ea54603","updated":"2015-09-15 04:22:17.000000000","message":"I will fix as you found them. But these mistakes are not related to plugins at all.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":23,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":24,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":25,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(boris-42): This method should be removed as it won\u0027t be used"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_de202e4c","line":25,"updated":"2015-09-14 16:07:48.000000000","message":"A few parameter docstrings need to be fixed, too:\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/wrappers/network.py#L373\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/cinder/utils.py#L221\n\nThere are also a few scenarios that use :raises:, so either that tag needs to be removed from those docstrings, or it needs to be taken into account in the regexes and docstring parsing.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":23,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":24,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":25,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(boris-42): This method should be removed as it won\u0027t be used"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_5c3bb4eb","line":25,"in_reply_to":"ba15a1d1_de202e4c","updated":"2015-09-15 04:22:17.000000000","message":"These are as well not related to plugins. But I will fix them.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2e768a651f03d1cc674b264c0d09deeae9fc701a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                long_description \u003d long_description[:long_desc_end].rstrip()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            if params_returns_desc:"},{"line_number":67,"context_line":"                def reindent(string, indent\u003d\"\\t\"):"},{"line_number":68,"context_line":"                    if \"\\n\" not in string:"},{"line_number":69,"context_line":"                        return string"},{"line_number":70,"context_line":"                    first, rest \u003d string.split(\"\\n\", 1)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_de7cae22","line":67,"updated":"2015-09-14 16:07:48.000000000","message":"AFAICT this doesn\u0027t need to be an inner function; it doesn\u0027t use any closures. And since inner functions are expensive, it should be moved up to the top level of this module.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"a937f9d98b4bd19dead212809e100897c97fa889","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                long_description \u003d long_description[:long_desc_end].rstrip()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"            if params_returns_desc:"},{"line_number":67,"context_line":"                def reindent(string, indent\u003d\"\\t\"):"},{"line_number":68,"context_line":"                    if \"\\n\" not in string:"},{"line_number":69,"context_line":"                        return string"},{"line_number":70,"context_line":"                    first, rest \u003d string.split(\"\\n\", 1)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_fc03a80d","line":67,"in_reply_to":"ba15a1d1_de7cae22","updated":"2015-09-15 04:22:17.000000000","message":"I just copy pasted old code, let\u0027s do such changes in separated patch after we cut 0.1.0 release. I will left TODO here.","commit_id":"db0f686501b62abd1fed0bc7b88691ca99fb88ac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a21cfe60032d5e498caa82410ca40911d721695","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":22,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":23,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":24,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_3e5546f9","line":22,"updated":"2015-09-16 14:47:16.000000000","message":"While we are here, can you fix a small bug( https://bugs.launchpad.net/rally/+bug/1470895 )? Just edit these regex, so param can ends by \":raises\" section at least.","commit_id":"c6d1fc53259876ac8a60d63d28a31b23a86e004f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"f9dee98c05a24786c13b17eeee134ea1093fe545","unresolved":false,"context_lines":[{"line_number":21,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":22,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":23,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":24,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# TODO(boris-42): This method should be removed as it won\u0027t be used"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_147ce11d","line":24,"updated":"2015-09-16 15:25:06.000000000","message":"These need to accommodate :raises:","commit_id":"f5152f8e09063b0003808e4d4c23789391b1958e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c2d86d2329ffecbb74e6f98d1ca22b293b8c2552","unresolved":false,"context_lines":[{"line_number":21,"context_line":"PARAM_OR_RETURNS_REGEX \u003d re.compile(\":(?:param|returns)\")"},{"line_number":22,"context_line":"RETURNS_REGEX \u003d re.compile(\":returns: (?P\u003cdoc\u003e.*)\", re.S)"},{"line_number":23,"context_line":"PARAM_REGEX \u003d re.compile(\":param (?P\u003cname\u003e[\\*\\w]+): (?P\u003cdoc\u003e.*?)\""},{"line_number":24,"context_line":"                         \"(?:(?\u003d:param)|(?\u003d:return)|\\Z)\", re.S)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# TODO(boris-42): This method should be removed as it won\u0027t be used"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba15a1d1_1d23a557","line":24,"in_reply_to":"ba15a1d1_147ce11d","updated":"2015-09-16 15:55:32.000000000","message":"Chris this is out of scope of this patch. Sorry. This code was copy pasted from info (and I already refactored it even too much)","commit_id":"f5152f8e09063b0003808e4d4c23789391b1958e"}],"tests/functional/test_cli_plugin.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e2cf5d08a1fb1f3a1c800ddc911bc432d0e161d9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(\"Dummy.dummy_random_fail_in_atomic\", result)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_show_not_found(self):"},{"line_number":50,"context_line":"        name \u003d \"Dummy666666\""},{"line_number":51,"context_line":"        result \u003d self.rally(\"plugin show %s\" % name)"},{"line_number":52,"context_line":"        self.assertIn(\"There is no plugin: %s\" % name, result)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_82003b37","line":50,"updated":"2015-09-08 12:39:47.000000000","message":"\"666666\" looks frighteningly, maybe \"42\" ?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.assertIn(\"Dummy.dummy_random_fail_in_atomic\", result)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_show_not_found(self):"},{"line_number":50,"context_line":"        name \u003d \"Dummy666666\""},{"line_number":51,"context_line":"        result \u003d self.rally(\"plugin show %s\" % name)"},{"line_number":52,"context_line":"        self.assertIn(\"There is no plugin: %s\" % name, result)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_a472207b","line":50,"in_reply_to":"da20952f_82003b37","updated":"2015-09-14 08:48:36.000000000","message":"really?","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"}],"tests/unit/common/plugin/test_info.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"e2cf5d08a1fb1f3a1c800ddc911bc432d0e161d9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_parse_complete_docstring(self):"},{"line_number":23,"context_line":"        docstring \u003d \"\"\"One-line description."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Multi-"},{"line_number":26,"context_line":"line-"},{"line_number":27,"context_line":"description."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da20952f_c23873f1","line":25,"updated":"2015-09-08 12:39:47.000000000","message":"Real docstrings have indentation","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"49c23b8cddf2ae46187d2c55297cf05b578fb62f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def test_parse_complete_docstring(self):"},{"line_number":23,"context_line":"        docstring \u003d \"\"\"One-line description."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Multi-"},{"line_number":26,"context_line":"line-"},{"line_number":27,"context_line":"description."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_04142cf3","line":25,"in_reply_to":"da20952f_c23873f1","updated":"2015-09-14 08:48:36.000000000","message":"this is real docstring*","commit_id":"89c0625a682b7c01c849807a174081a3463b298a"}]}
