)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"80031d9fa83ab2b30a28ba0d23125e6a731972a0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"          users_per_tenant: 2"},{"line_number":179,"context_line":"        quotas:"},{"line_number":180,"context_line":"          neutron:"},{"line_number":181,"context_line":"            health_monitor: -1"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  NeutronLoadbalancerV1.create_and_delete_healthmonitors:"},{"line_number":184,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"da20952f_fafb7c45","line":181,"updated":"2015-09-10 13:16:58.000000000","message":"please add sla","commit_id":"29bcf0c5cff2db73f7d32c0febc7ccc0c77519fb"}],"rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":92,"context_line":"    def create_and_list_healthmonitors(self, healthmonitors_num\u003d1,"},{"line_number":93,"context_line":"                                       healthmonitor_create_args\u003dNone):"},{"line_number":94,"context_line":"        \"\"\"Create a healthmonitor(v1) and then list healthmonitors(v1)."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Measure the \"neutron lb-healthmonitor-list\" command performance."},{"line_number":97,"context_line":"        The scenario creates a pool for every subnet and then lists"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_adda154a","line":94,"updated":"2015-09-08 11:32:36.000000000","message":"Please remove \"then\" this word means nothing here. We can\u0027t simultaneously create and list health monitors.  So its redundant word here.And I think \"Create a healthmonitor\" it must be in plural form.","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":92,"context_line":"    def create_and_list_healthmonitors(self, healthmonitors_num\u003d1,"},{"line_number":93,"context_line":"                                       healthmonitor_create_args\u003dNone):"},{"line_number":94,"context_line":"        \"\"\"Create a healthmonitor(v1) and then list healthmonitors(v1)."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Measure the \"neutron lb-healthmonitor-list\" command performance."},{"line_number":97,"context_line":"        The scenario creates a pool for every subnet and then lists"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_80b53c7f","line":94,"in_reply_to":"da20952f_adda154a","updated":"2015-09-10 08:30:39.000000000","message":"Done","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\"Create a healthmonitor(v1) and then list healthmonitors(v1)."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        Measure the \"neutron lb-healthmonitor-list\" command performance."},{"line_number":97,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":98,"context_line":"        healthmonitors."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_5350bcd4","line":97,"updated":"2015-09-08 11:32:36.000000000","message":"Please remove \"The scenario\" its redundant.","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":98,"context_line":"        healthmonitors."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":101,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":102,"context_line":"        options"},{"line_number":103,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_ed024dba","line":100,"updated":"2015-09-08 11:32:36.000000000","message":"As for me more logic name here is healthmonitors_cnt or healthmonitors_count.","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        The scenario creates a pool for every subnet and then lists"},{"line_number":98,"context_line":"        healthmonitors."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":101,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":102,"context_line":"        options"},{"line_number":103,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e01af87b","line":100,"in_reply_to":"da20952f_ed024dba","updated":"2015-09-10 08:30:39.000000000","message":"We use subnets_num for the number of subnets to be created. :) https://github.com/openstack/rally/blob/a5cf4f87cce6dc1f0c6e34c678d7b89739a16ac8/rally/plugins/openstack/wrappers/network.py#L291-L292","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":105,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":106,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":107,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":108,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_339d0867","line":107,"updated":"2015-09-08 11:32:36.000000000","message":"I think here must be \"with AtomicActomic\" to able to measure separate creates. Example https://github.com/openstack/rally/blob/master/rally/task/atomic.py#L38 and https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/murano/environments.py#L68","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":105,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":106,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":107,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":108,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e0df580a","line":107,"in_reply_to":"da20952f_339d0867","updated":"2015-09-10 08:30:39.000000000","message":"I have added atomic action in utils","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":127,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":128,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":129,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":130,"context_line":"                **healthmonitor_create_args))"},{"line_number":131,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":132,"context_line":"            self._delete_v1_healthmonitor(healthmonitor[\"health_monitor\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_f3da301d","line":129,"updated":"2015-09-08 11:32:36.000000000","message":"I think here must be \"with AtomicActomic\" to able to measure separate creates. Example https://github.com/openstack/rally/blob/master/rally/task/atomic.py#L38 and https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/murano/environments.py#L68","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":127,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":128,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":129,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":130,"context_line":"                **healthmonitor_create_args))"},{"line_number":131,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":132,"context_line":"            self._delete_v1_healthmonitor(healthmonitor[\"health_monitor\"])"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_00db6c1c","line":129,"in_reply_to":"da20952f_f3da301d","updated":"2015-09-10 08:30:39.000000000","message":"I have added atomic action in utils","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":130,"context_line":"                **healthmonitor_create_args))"},{"line_number":131,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":132,"context_line":"            self._delete_v1_healthmonitor(healthmonitor[\"health_monitor\"])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":135,"context_line":"    @validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_33c2e835","line":132,"updated":"2015-09-08 11:32:36.000000000","message":"I think here must be \"with AtomicActomic\" to able to measure separate creates. Example https://github.com/openstack/rally/blob/master/rally/task/atomic.py#L38 and https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/murano/environments.py#L68 And in similar places all around.","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":130,"context_line":"                **healthmonitor_create_args))"},{"line_number":131,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":132,"context_line":"            self._delete_v1_healthmonitor(healthmonitor[\"health_monitor\"])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":135,"context_line":"    @validation.required_openstack(users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c0033475","line":132,"in_reply_to":"da20952f_33c2e835","updated":"2015-09-10 08:30:39.000000000","message":"I have added atomic action in utils","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        healthmonitors \u003d []"},{"line_number":153,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":154,"context_line":"        healthmonitor_update_args \u003d healthmonitor_update_args or {}"},{"line_number":155,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":156,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":157,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":158,"context_line":"                **healthmonitor_create_args))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b38038c1","line":155,"updated":"2015-09-08 11:32:36.000000000","message":"Don\u0027t it could be solved by proper decorator?","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        healthmonitors \u003d []"},{"line_number":153,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":154,"context_line":"        healthmonitor_update_args \u003d healthmonitor_update_args or {}"},{"line_number":155,"context_line":"        self._check_deployment_supports_extension(\"lbaas\")"},{"line_number":156,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":157,"context_line":"            healthmonitors.append(self._create_v1_healthmonitor("},{"line_number":158,"context_line":"                **healthmonitor_create_args))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_00f28c9a","line":155,"in_reply_to":"da20952f_b38038c1","updated":"2015-09-10 08:30:39.000000000","message":"Done","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45c6a9cea27b2517a39843db0fa4ebac455bce95","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                **healthmonitor_create_args))"},{"line_number":242,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":243,"context_line":"            self._update_v1_healthmonitor(healthmonitor,"},{"line_number":244,"context_line":"                                          **healthmonitor_update_args)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_eea6a752","line":244,"updated":"2015-09-21 13:06:04.000000000","message":"What is really updated? I guess that we do not actually update resource, since in most cases we have empty dict in healthmonitor_update_args, and even if not, we would have the same update args for all healhmonitors.\n\nI think we should generate here some unique value for each update","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d9ed07b9da747ba8eedbf680e54a1c706384f94d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                **healthmonitor_create_args))"},{"line_number":242,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":243,"context_line":"            self._update_v1_healthmonitor(healthmonitor,"},{"line_number":244,"context_line":"                                          **healthmonitor_update_args)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_ba4fe669","line":244,"in_reply_to":"ba15a1d1_91f14798","updated":"2015-09-24 13:10:07.000000000","message":"Can  we update int value of HM_MAX_RETRIES, HM_DELAY, HM_TIMEOUT?","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f37c88cfa0679789e73b44d35f9d779d3d5cebf1","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                **healthmonitor_create_args))"},{"line_number":242,"context_line":"        for healthmonitor in healthmonitors:"},{"line_number":243,"context_line":"            self._update_v1_healthmonitor(healthmonitor,"},{"line_number":244,"context_line":"                                          **healthmonitor_update_args)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_91f14798","line":244,"in_reply_to":"ba15a1d1_eea6a752","updated":"2015-09-21 14:04:38.000000000","message":"Healthmonitor does not have a name. So the only thing we can do it alter the properties like admin_state_up. Would you recommend it??","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"0d750f745e52dda0efedbbe6c7bd931fcacd5a2c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            self._update_v1_vip(vip, **vip_update_args)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":177,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":178,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":179,"context_line":"    def create_and_list_healthmonitors(self, healthmonitors_num\u003d1,"},{"line_number":180,"context_line":"                                       healthmonitor_create_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_1b668d29","line":177,"updated":"2015-09-22 08:48:27.000000000","message":"it seems you forgot addvalidation.required_neutron_extensions(\"lbaas\")  here","commit_id":"feb8eea2ca19df0152f535ca79c62024199f063b"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"65d5d8f7358f6e9c87fd79b49eb339c241d4d7e2","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            self._update_v1_vip(vip, **vip_update_args)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":177,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":178,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":179,"context_line":"    def create_and_list_healthmonitors(self, healthmonitors_num\u003d1,"},{"line_number":180,"context_line":"                                       healthmonitor_create_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba15a1d1_c6283c36","line":177,"in_reply_to":"ba15a1d1_1b668d29","updated":"2015-09-22 09:06:56.000000000","message":"Done","commit_id":"feb8eea2ca19df0152f535ca79c62024199f063b"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"0832a6bda1d235f4390184a18071f0fbf823bfe5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_ec9a01c5","line":193,"updated":"2015-09-22 09:31:12.000000000","message":"I guess boris dislike the loop here, because multiple and same calls here makes output close to meaningless. In another word, rally calls API group and watch response time for each call to benchmark some stuff. If it is really necessary to call multiple and same calls together, it should use atomic here.\n\nActually I don\u0027t know why to implement healthmonitor_num here","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"41f672c31de4b7652646553a841a494da192113b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_e72a1ae7","line":193,"in_reply_to":"ba15a1d1_078b8e1f","updated":"2015-09-22 10:03:55.000000000","message":"Sorry, I get your point. I am removing num. :)\nYes, This loop is redundant . :)","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cc121d80f4c4283ba276509e7d0d4adbb898b24b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_87aa3ed1","line":193,"in_reply_to":"ba15a1d1_67136a5d","updated":"2015-09-22 09:55:23.000000000","message":"So, would you recommend to benchmark for the creation of complete hm instead of doing it individually??\nIf that is the case I am doing it. :)","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c0b121a5cd29e5c49715630c9aa52aa8040a0a47","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_078b8e1f","line":193,"in_reply_to":"ba15a1d1_876d5e9b","updated":"2015-09-22 10:00:58.000000000","message":"https://review.openstack.org/#/c/217041/9/rally/plugins/openstack/scenarios/neutron/loadbalancer_v1.py,cm Please see the last 2 functions which require this feature.\n\nWell, I removed those from this patch and would push it in a different patch.","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"3afdfb61406990bec1f3cf55a92bbff9bed94b6c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_876d5e9b","line":193,"in_reply_to":"ba15a1d1_87aa3ed1","updated":"2015-09-22 09:58:17.000000000","message":"I don\u0027t see the meaning of healthmonitors_num actually\n\nBut you could ask for other\u0027s thoughts, if this is useful, then you need atomic action for those loops","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"95df0757f8168c5b50d0a514cab4249f5133be12","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_67136a5d","line":193,"in_reply_to":"ba15a1d1_ac9e4905","updated":"2015-09-22 09:52:37.000000000","message":"If you need each response time of this call, you should use create_hm scenario. If you need create multiple hm as workloads, I don\u0027t think you prefer to see each response time of this call","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"c325553afcfa56d8ae8d08f414daba957cfa57f7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":192,"context_line":"        for i in range(healthmonitors_num):"},{"line_number":193,"context_line":"            self._create_v1_healthmonitor(**healthmonitor_create_args)"},{"line_number":194,"context_line":"        self._list_v1_healthmonitors()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_ac9e4905","line":193,"in_reply_to":"ba15a1d1_ec9a01c5","updated":"2015-09-22 09:50:01.000000000","message":"A loadbalancer pool can have more than one healthmonitors, thus I feel it is necessary to benchmark \u0027n\u0027 healthmonitors.","commit_id":"208f669d0bbf85c05d7694c06a62803eb9a7ab44"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"51ca27c6543a2746992e86203b94d16ef3210d71","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        Measure the \"neutron lb-healthmonitor-list\" command performance. This"},{"line_number":186,"context_line":"        scenario creates healthmonitors and lists them."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":189,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":190,"context_line":"        options"},{"line_number":191,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_76997778","line":188,"updated":"2015-09-24 06:46:07.000000000","message":"you forgot to remove this","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cbc820e3719dbcd48972516fb58a62e526006607","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        Measure the \"neutron lb-healthmonitor-list\" command performance. This"},{"line_number":186,"context_line":"        scenario creates healthmonitors and lists them."},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":189,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":190,"context_line":"        options"},{"line_number":191,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_564b13b1","line":188,"in_reply_to":"ba15a1d1_76997778","updated":"2015-09-24 06:55:18.000000000","message":"Done","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"51ca27c6543a2746992e86203b94d16ef3210d71","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        lb-healthmonitor-delete\" command performance. The scenario creates"},{"line_number":205,"context_line":"        healthmonitors and deletes those healthmonitors."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":208,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":209,"context_line":"        options"},{"line_number":210,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_16891b26","line":207,"updated":"2015-09-24 06:46:07.000000000","message":"ditto","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cbc820e3719dbcd48972516fb58a62e526006607","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        lb-healthmonitor-delete\" command performance. The scenario creates"},{"line_number":205,"context_line":"        healthmonitors and deletes those healthmonitors."},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":208,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":209,"context_line":"        options"},{"line_number":210,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_764897b3","line":207,"in_reply_to":"ba15a1d1_16891b26","updated":"2015-09-24 06:55:18.000000000","message":"Done","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"51ca27c6543a2746992e86203b94d16ef3210d71","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        lb-healthmonitor-update\" command performance. The scenario creates"},{"line_number":227,"context_line":"        healthmonitors and then updates them."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":230,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":231,"context_line":"        options"},{"line_number":232,"context_line":"        :param healthmonitor_update_args: dict, POST /lb/healthmonitors update"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_368e9f2e","line":229,"updated":"2015-09-24 06:46:07.000000000","message":"ditto","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"cbc820e3719dbcd48972516fb58a62e526006607","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        lb-healthmonitor-update\" command performance. The scenario creates"},{"line_number":227,"context_line":"        healthmonitors and then updates them."},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param healthmonitors_num: int, number of healthmonitors to be created"},{"line_number":230,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors request"},{"line_number":231,"context_line":"        options"},{"line_number":232,"context_line":"        :param healthmonitor_update_args: dict, POST /lb/healthmonitors update"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba15a1d1_d6cde330","line":229,"in_reply_to":"ba15a1d1_368e9f2e","updated":"2015-09-24 06:55:18.000000000","message":"Done","commit_id":"48627a0a4539f139206ae830b938d0c49b772cfd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"bfc9978d51acfe6c44abce094e1b4948edae6400","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        healthmonitor \u003d self._create_v1_healthmonitor("},{"line_number":235,"context_line":"            **healthmonitor_create_args)"},{"line_number":236,"context_line":"        self._update_v1_healthmonitor(healthmonitor,"},{"line_number":237,"context_line":"                                      **healthmonitor_update_args)"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba15a1d1_1ab3724e","line":237,"updated":"2015-09-24 13:29:06.000000000","message":"Can we update int value of HM_MAX_RETRIES, HM_DELAY, HM_TIMEOUT? (For example, using random.choice(...) for that)","commit_id":"12fff453024f50038bcbaa8d74273b454f86ec92"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"593de721d832c3cdd2dc389ab8e835bf5140070e","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        healthmonitor \u003d self._create_v1_healthmonitor("},{"line_number":235,"context_line":"            **healthmonitor_create_args)"},{"line_number":236,"context_line":"        self._update_v1_healthmonitor(healthmonitor,"},{"line_number":237,"context_line":"                                      **healthmonitor_update_args)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a1a9d01_b28d6d7d","line":237,"in_reply_to":"ba15a1d1_1ab3724e","updated":"2015-09-25 11:51:59.000000000","message":"Done","commit_id":"12fff453024f50038bcbaa8d74273b454f86ec92"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"271c344b737ff34378d70ef2aac1015698c65e0c","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        options"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":233,"context_line":"        healthmonitor_update_args \u003d healthmonitor_update_args or {}"},{"line_number":234,"context_line":"        healthmonitor \u003d self._create_v1_healthmonitor("},{"line_number":235,"context_line":"            **healthmonitor_create_args)"},{"line_number":236,"context_line":"        self._update_v1_healthmonitor(healthmonitor,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a1a9d01_1313cdb9","line":233,"updated":"2015-09-28 07:23:16.000000000","message":"To address Alex\u0027s issue, I think it\u0027s better to put random value here:\n\n    healthmonitor_update_args \u003d healthmonitor_update_args or {\"max_retries\":....}\n\nbecause your recent change may overwrite users\u0027 settings in healthmonitor_update_args","commit_id":"ce0e3726de7f087b7291bc659588d2a6ed53b9e6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"165b64f3ccf27a1373e9f43e7a00777c0fbe30b3","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        options"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        healthmonitor_create_args \u003d healthmonitor_create_args or {}"},{"line_number":233,"context_line":"        healthmonitor_update_args \u003d healthmonitor_update_args or {}"},{"line_number":234,"context_line":"        healthmonitor \u003d self._create_v1_healthmonitor("},{"line_number":235,"context_line":"            **healthmonitor_create_args)"},{"line_number":236,"context_line":"        self._update_v1_healthmonitor(healthmonitor,"}],"source_content_type":"text/x-python","patch_set":21,"id":"9a1a9d01_53ab851d","line":233,"in_reply_to":"9a1a9d01_1313cdb9","updated":"2015-09-28 07:33:22.000000000","message":"Done","commit_id":"ce0e3726de7f087b7291bc659588d2a6ed53b9e6"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    TYPE \u003d \"PING\""},{"line_number":35,"context_line":"    MAX_RETRIES \u003d 3"},{"line_number":36,"context_line":"    DELAY \u003d 20"},{"line_number":37,"context_line":"    TIMEOUT \u003d 10"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _warn_about_deprecated_name_kwarg(self, resource, kwargs):"},{"line_number":40,"context_line":"        \"\"\"Warn about use of a deprecated \u0027name\u0027 kwarg and replace it."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b3b3589a","line":37,"updated":"2015-09-08 11:32:36.000000000","message":"Isn\u0027t this variable must to be in config file?","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    TYPE \u003d \"PING\""},{"line_number":35,"context_line":"    MAX_RETRIES \u003d 3"},{"line_number":36,"context_line":"    DELAY \u003d 20"},{"line_number":37,"context_line":"    TIMEOUT \u003d 10"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _warn_about_deprecated_name_kwarg(self, resource, kwargs):"},{"line_number":40,"context_line":"        \"\"\"Warn about use of a deprecated \u0027name\u0027 kwarg and replace it."}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_2318fa74","line":37,"in_reply_to":"da20952f_b3b3589a","updated":"2015-09-10 08:30:39.000000000","message":"I am just setting global constants.","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"65dac4740f5fe61253fdf7b8439f8925e7cc89c3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                        {\"type\": list(resource.keys())[0],"},{"line_number":66,"context_line":"                         \"id\": list(resource.values())[0][\"id\"],"},{"line_number":67,"context_line":"                         \"name\": kwargs[\"name\"]})"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _check_deployment_supports_extension(self, extension):"},{"line_number":70,"context_line":"        \"\"\"Check if the deployment supports extension."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_53e0bc96","line":68,"updated":"2015-09-08 11:32:36.000000000","message":"Is this function unneeded now after https://review.openstack.org/#/c/218151/?","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                        {\"type\": list(resource.keys())[0],"},{"line_number":66,"context_line":"                         \"id\": list(resource.values())[0][\"id\"],"},{"line_number":67,"context_line":"                         \"name\": kwargs[\"name\"]})"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _check_deployment_supports_extension(self, extension):"},{"line_number":70,"context_line":"        \"\"\"Check if the deployment supports extension."},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_400c0442","line":68,"in_reply_to":"da20952f_53e0bc96","updated":"2015-09-10 08:30:39.000000000","message":"Done","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"4f31045ea43daa95001522a42adac6cc311de35a","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        :param heathmonitor: neutron lb healthmonitor dict"},{"line_number":428,"context_line":"        :returns pool dict associated with healthmonitor"},{"line_number":429,"context_line":"        \"\"\""},{"line_number":430,"context_line":"        return self.clients(\"neutron\").associate_health_monitor("},{"line_number":431,"context_line":"            pool[\"id\"], healthmonitor[\"id\"])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @atomic.action_timer(\"neutron.disassociate_healthmonitor\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_bdd250cf","line":430,"updated":"2015-09-01 12:34:42.000000000","message":"The only associate_health_monitor method I see in neutronclient takes a pool id and a body (see neutronclient/v2_0/client.py). So, does this really work? How?","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f93493feaee98bf7191da0d1ead1f33a310694e7","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        :param heathmonitor: neutron lb healthmonitor dict"},{"line_number":428,"context_line":"        :returns pool dict associated with healthmonitor"},{"line_number":429,"context_line":"        \"\"\""},{"line_number":430,"context_line":"        return self.clients(\"neutron\").associate_health_monitor("},{"line_number":431,"context_line":"            pool[\"id\"], healthmonitor[\"id\"])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @atomic.action_timer(\"neutron.disassociate_healthmonitor\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b86fbec2","line":430,"in_reply_to":"da20952f_3d7ba0bf","updated":"2015-09-01 12:41:15.000000000","message":"Typo. It is not working. And it throws an error. \n\"Unable to serialize object of type \u003d \u0027\u003ctype \u0027unicode\u0027\u003e\u0027 \"\nWhat would you recommend?","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9592db4df7c5a1ba86ea2c2a096a99a8a453b122","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        :param heathmonitor: neutron lb healthmonitor dict"},{"line_number":428,"context_line":"        :returns pool dict associated with healthmonitor"},{"line_number":429,"context_line":"        \"\"\""},{"line_number":430,"context_line":"        return self.clients(\"neutron\").associate_health_monitor("},{"line_number":431,"context_line":"            pool[\"id\"], healthmonitor[\"id\"])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @atomic.action_timer(\"neutron.disassociate_healthmonitor\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_6007c81d","line":430,"in_reply_to":"da20952f_b86fbec2","updated":"2015-09-10 08:30:39.000000000","message":"Done","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"fa5b6d02f6372e87cfe0937706e0878c38295aeb","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        :param heathmonitor: neutron lb healthmonitor dict"},{"line_number":428,"context_line":"        :returns pool dict associated with healthmonitor"},{"line_number":429,"context_line":"        \"\"\""},{"line_number":430,"context_line":"        return self.clients(\"neutron\").associate_health_monitor("},{"line_number":431,"context_line":"            pool[\"id\"], healthmonitor[\"id\"])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @atomic.action_timer(\"neutron.disassociate_healthmonitor\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_3d7ba0bf","line":430,"in_reply_to":"da20952f_bdd250cf","updated":"2015-09-01 12:38:22.000000000","message":"It works. http://logs.openstack.org/41/217041/4/check/gate-rally-dsvm-neutron-rally/130f1aa/rally-plot/results.html.gz#/NeutronLoadbalancerV1.associate_and_disassociate_healthmonitors :)","commit_id":"a1cf2a1aae42afcddb723964b8379af5b0eef41e"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"80031d9fa83ab2b30a28ba0d23125e6a731972a0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    # TODO(rkiran): modify in case LBaaS-v2 requires"},{"line_number":32,"context_line":"    LB_METHOD \u003d \"ROUND_ROBIN\""},{"line_number":33,"context_line":"    LB_PROTOCOL \u003d \"HTTP\""},{"line_number":34,"context_line":"    TYPE \u003d \"PING\""},{"line_number":35,"context_line":"    MAX_RETRIES \u003d 3"},{"line_number":36,"context_line":"    DELAY \u003d 20"},{"line_number":37,"context_line":"    TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_ba62e414","line":34,"updated":"2015-09-10 13:16:58.000000000","message":"these properties are health monitor related, so they should be prefixed (e.g. by HM_)\n\nAlso I\u0027m not sure where this kind of defaults should be. Probably it should be in config.","commit_id":"29bcf0c5cff2db73f7d32c0febc7ccc0c77519fb"}],"tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer_v1.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45c6a9cea27b2517a39843db0fa4ebac455bce95","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":250,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":251,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":252,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":253,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":254,"context_line":"    )"},{"line_number":255,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_897365b4","line":252,"updated":"2015-09-21 13:06:04.000000000","message":"Add a use case where \"healthmonitors_num\" is larger than 1","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f37c88cfa0679789e73b44d35f9d779d3d5cebf1","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":250,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":251,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":252,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":253,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":254,"context_line":"    )"},{"line_number":255,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_f19f634e","line":252,"in_reply_to":"ba15a1d1_897365b4","updated":"2015-09-21 14:04:38.000000000","message":"Done","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45c6a9cea27b2517a39843db0fa4ebac455bce95","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":277,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":278,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":279,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":280,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":281,"context_line":"    )"},{"line_number":282,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_899a85c4","line":279,"updated":"2015-09-21 13:06:04.000000000","message":"Add a use case where \"healthmonitors_num\" is larger than 1","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f37c88cfa0679789e73b44d35f9d779d3d5cebf1","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":277,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":278,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":279,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":280,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":281,"context_line":"    )"},{"line_number":282,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_319ddb59","line":279,"in_reply_to":"ba15a1d1_899a85c4","updated":"2015-09-21 14:04:38.000000000","message":"Done","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45c6a9cea27b2517a39843db0fa4ebac455bce95","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":306,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":307,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":308,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":309,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":310,"context_line":"        {\"healthmonitor_create_args\": {},"},{"line_number":311,"context_line":"         \"healthmonitor_update_args\": {\"admin_state_up\": False}},"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_a99f49b3","line":308,"updated":"2015-09-21 13:06:04.000000000","message":"Add a use case where \"healthmonitors_num\" is larger than 1","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f37c88cfa0679789e73b44d35f9d779d3d5cebf1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        {\"healthmonitors_num\": 1},"},{"line_number":306,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": None},"},{"line_number":307,"context_line":"        {\"healthmonitors_num\": 1, \"healthmonitor_create_args\": {}},"},{"line_number":308,"context_line":"        {\"healthmonitors_num\": 1,"},{"line_number":309,"context_line":"         \"healthmonitor_create_args\": {\"name\": \"given-name\"}},"},{"line_number":310,"context_line":"        {\"healthmonitor_create_args\": {},"},{"line_number":311,"context_line":"         \"healthmonitor_update_args\": {\"admin_state_up\": False}},"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba15a1d1_71935350","line":308,"in_reply_to":"ba15a1d1_a99f49b3","updated":"2015-09-21 14:04:38.000000000","message":"Done","commit_id":"8f13a7320f00263ee173af1bbb12d62ca1c333d6"}]}