)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bf0e16b7da1b2971cc4dac3556476dd177692630","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    -"},{"line_number":49,"context_line":"      args:"},{"line_number":50,"context_line":"        floating_network: \"public\""},{"line_number":51,"context_line":"        floating_ip_args:"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba15a1d1_52905f95","line":51,"updated":"2015-09-22 11:31:56.000000000","message":"You don\u0027t need to specify an empty dict here, but other people have -1\u0027d me for this sort of thing. You might want to do:\n\n    floating_ip_args: {}","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"be42f60e8036502af7f11b68e50ce646a468d541","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    -"},{"line_number":49,"context_line":"      args:"},{"line_number":50,"context_line":"        floating_network: \"public\""},{"line_number":51,"context_line":"        floating_ip_args:"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"ba15a1d1_0d264cba","line":51,"in_reply_to":"ba15a1d1_52905f95","updated":"2015-09-22 11:39:58.000000000","message":"Done","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256c234a46dde65df7c6321a2993bb6ca9256b60","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"},{"line_number":55,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_71c6b64a","line":54,"updated":"2015-09-22 15:04:19.000000000","message":"It is actually `1\u0027 - change to something greater\n\nhttp://logs.openstack.org/23/225223/15/check/gate-rally-dsvm-neutron-rally/a77dc36/rally-plot/results.html.gz#/NeutronNetworks.create_and_list_floating_ips","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"},{"line_number":55,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_b41bd27f","line":54,"in_reply_to":"ba15a1d1_71c6b64a","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256c234a46dde65df7c6321a2993bb6ca9256b60","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"},{"line_number":55,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"},{"line_number":58,"context_line":"          tenants: {{smoke or 3}}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_f1e086ce","line":55,"updated":"2015-09-22 15:04:19.000000000","message":"ditto","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: {{smoke or 40}}"},{"line_number":55,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"},{"line_number":58,"context_line":"          tenants: {{smoke or 3}}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_54127663","line":55,"in_reply_to":"ba15a1d1_f1e086ce","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256c234a46dde65df7c6321a2993bb6ca9256b60","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        floating_ip_args: {}"},{"line_number":411,"context_line":"      runner:"},{"line_number":412,"context_line":"        type: \"constant\""},{"line_number":413,"context_line":"        times: {{smoke or 40}}"},{"line_number":414,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":415,"context_line":"      context:"},{"line_number":416,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_f107267f","line":413,"updated":"2015-09-22 15:04:19.000000000","message":"ditto","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        floating_ip_args: {}"},{"line_number":411,"context_line":"      runner:"},{"line_number":412,"context_line":"        type: \"constant\""},{"line_number":413,"context_line":"        times: {{smoke or 40}}"},{"line_number":414,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":415,"context_line":"      context:"},{"line_number":416,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_140dde3d","line":413,"in_reply_to":"ba15a1d1_f107267f","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256c234a46dde65df7c6321a2993bb6ca9256b60","unresolved":false,"context_lines":[{"line_number":411,"context_line":"      runner:"},{"line_number":412,"context_line":"        type: \"constant\""},{"line_number":413,"context_line":"        times: {{smoke or 40}}"},{"line_number":414,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":415,"context_line":"      context:"},{"line_number":416,"context_line":"        users:"},{"line_number":417,"context_line":"          tenants: {{smoke or 3}}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_d12b02ea","line":414,"updated":"2015-09-22 15:04:19.000000000","message":"ditto","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":411,"context_line":"      runner:"},{"line_number":412,"context_line":"        type: \"constant\""},{"line_number":413,"context_line":"        times: {{smoke or 40}}"},{"line_number":414,"context_line":"        concurrency: {{smoke or 20}}"},{"line_number":415,"context_line":"      context:"},{"line_number":416,"context_line":"        users:"},{"line_number":417,"context_line":"          tenants: {{smoke or 3}}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ba15a1d1_d406861f","line":414,"in_reply_to":"ba15a1d1_d12b02ea","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"f853087dea98b487d5b62c05b8cc6755a2820827","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: 40"},{"line_number":55,"context_line":"        concurrency: 20"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba15a1d1_cb7a3c88","line":54,"updated":"2015-09-23 15:13:26.000000000","message":"I don\u0027t think these should have been changed -- they should have stayed {{smoke or ...}}. Let\u0027s discuss on IRC.","commit_id":"dff74724652e5808d01cab3b9a2ed7e0252a5ae8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a96f28ec89b42f2545358538f80ae7ec287dbb85","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""},{"line_number":54,"context_line":"        times: 40"},{"line_number":55,"context_line":"        concurrency: 20"},{"line_number":56,"context_line":"      context:"},{"line_number":57,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ba15a1d1_2b4df83d","line":54,"in_reply_to":"ba15a1d1_cb7a3c88","updated":"2015-09-23 15:17:18.000000000","message":"@Chris, if we use {{smoke or ...}} here, then we will have 1 iteration on gates, which is almost useless.\n\nLook at this result:\n\nhttp://logs.openstack.org/23/225223/15/check/gate-rally-dsvm-neutron-rally/a77dc36/rally-plot/results.html.gz#/NeutronNetworks.create_and_list_floating_ips","commit_id":"dff74724652e5808d01cab3b9a2ed7e0252a5ae8"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"5d05b6b6676a4f3171be6d19c39dbdad77406467","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  NeutronNetworks.create_and_list_floating_ips:"},{"line_number":48,"context_line":"    -"},{"line_number":49,"context_line":"      args:"},{"line_number":50,"context_line":"        floating_network: \"public\""},{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ba15a1d1_36a1bff8","line":50,"updated":"2015-09-24 06:39:27.000000000","message":"since rally assume resource-id in somewhere else, if you need pass the name here, it\u0027s better to use floating_network for resource-id or floadting_network_name for name\n\nor use floating_network for both, and judge id or name like what neutronclient has done","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"97a43b21b88f30d9f8dbaf661a499a56acf02799","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  NeutronNetworks.create_and_list_floating_ips:"},{"line_number":48,"context_line":"    -"},{"line_number":49,"context_line":"      args:"},{"line_number":50,"context_line":"        floating_network: \"public\""},{"line_number":51,"context_line":"        floating_ip_args: {}"},{"line_number":52,"context_line":"      runner:"},{"line_number":53,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ba15a1d1_71b3c14d","line":50,"in_reply_to":"ba15a1d1_36a1bff8","updated":"2015-09-24 07:24:58.000000000","message":"floating_network can either be a net-id or a net-name","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"}],"rally/plugins/openstack/context/quotas/neutron_quotas.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"94acc5c44ac58d3d3f9961bbd586b65dfc00bf87","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \"type\": \"integer\","},{"line_number":62,"context_line":"                \"minimum\": -1"},{"line_number":63,"context_line":"            },"},{"line_number":64,"context_line":"            \"floatingip\": {"},{"line_number":65,"context_line":"                \"type\": \"integer\","},{"line_number":66,"context_line":"                \"minimum\": -1"},{"line_number":67,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_08dbd3ee","line":64,"updated":"2015-09-21 12:42:03.000000000","message":"this already exists - L44-47","commit_id":"64547b0a33fe964c150655ed0cbe4dd956ca0a6b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"256c234a46dde65df7c6321a2993bb6ca9256b60","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \"type\": \"integer\","},{"line_number":62,"context_line":"                \"minimum\": -1"},{"line_number":63,"context_line":"            },"},{"line_number":64,"context_line":"            \"floatingip\": {"},{"line_number":65,"context_line":"                \"type\": \"integer\","},{"line_number":66,"context_line":"                \"minimum\": -1"},{"line_number":67,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_114f3abe","line":64,"updated":"2015-09-22 15:04:19.000000000","message":"As I\u0027ve mentioned before, this parameter is already added at L44-47","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \"type\": \"integer\","},{"line_number":62,"context_line":"                \"minimum\": -1"},{"line_number":63,"context_line":"            },"},{"line_number":64,"context_line":"            \"floatingip\": {"},{"line_number":65,"context_line":"                \"type\": \"integer\","},{"line_number":66,"context_line":"                \"minimum\": -1"},{"line_number":67,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_b161a4aa","line":64,"in_reply_to":"ba15a1d1_114f3abe","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"}],"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e138c2ddea73369c9655026b1a385d89f263d259","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                network_create_args\u003dnetwork_create_args,"},{"line_number":388,"context_line":"                subnet_create_args\u003dsubnet_create_args, subnets_per_network\u003d1,"},{"line_number":389,"context_line":"                subnet_cidr_start\u003dsubnet_cidr_start)"},{"line_number":390,"context_line":"        floatingip \u003d self._create_floatingip(floating_network,"},{"line_number":391,"context_line":"                                             **floating_ip_args)"},{"line_number":392,"context_line":"        self._delete_floating_ip(floatingip[\"floatingip\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f863f13f","line":390,"updated":"2015-09-18 21:18:41.000000000","message":"floating_ip I think would be better name.","commit_id":"88e8587c8680bd4793710aa7b8e168d8c5ce4282"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b027a9d835ccc24c29ddffb796092121685da6d8","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                network_create_args\u003dnetwork_create_args,"},{"line_number":388,"context_line":"                subnet_create_args\u003dsubnet_create_args, subnets_per_network\u003d1,"},{"line_number":389,"context_line":"                subnet_cidr_start\u003dsubnet_cidr_start)"},{"line_number":390,"context_line":"        floatingip \u003d self._create_floatingip(floating_network,"},{"line_number":391,"context_line":"                                             **floating_ip_args)"},{"line_number":392,"context_line":"        self._delete_floating_ip(floatingip[\"floatingip\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7f53406d","line":390,"in_reply_to":"ba15a1d1_f863f13f","updated":"2015-09-19 11:24:54.000000000","message":"Done","commit_id":"88e8587c8680bd4793710aa7b8e168d8c5ce4282"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"1ed68377091bdd26607e2b21ad3b0b115d77a709","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":355,"context_line":"    def create_and_delete_floating_ips(self, floating_network\u003dNone,"},{"line_number":356,"context_line":"                                       floating_ip_args\u003dNone):"},{"line_number":357,"context_line":"        \"\"\"Create and list floating IPs."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        Measure the \"neutron floating-ip-create\" and \"neutron"},{"line_number":360,"context_line":"        floating-ip-delete\" commands performance."}],"source_content_type":"text/x-python","patch_set":18,"id":"ba15a1d1_3729afe6","line":357,"updated":"2015-09-24 13:42:55.000000000","message":"Create and delete","commit_id":"c6ac8cc4697be39bd9d669d4d516e5cfbc376ed2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1dc62e8ae070458d5e312eb969771b2ced83746c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]})"},{"line_number":355,"context_line":"    def create_and_delete_floating_ips(self, floating_network\u003dNone,"},{"line_number":356,"context_line":"                                       floating_ip_args\u003dNone):"},{"line_number":357,"context_line":"        \"\"\"Create and list floating IPs."},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        Measure the \"neutron floating-ip-create\" and \"neutron"},{"line_number":360,"context_line":"        floating-ip-delete\" commands performance."}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_9f76323d","line":357,"in_reply_to":"ba15a1d1_3729afe6","updated":"2015-09-25 11:30:59.000000000","message":"Done","commit_id":"c6ac8cc4697be39bd9d669d4d516e5cfbc376ed2"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e138c2ddea73369c9655026b1a385d89f263d259","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        param: str, network name"},{"line_number":70,"context_line":"        param: dict, network options"},{"line_number":71,"context_line":"        returns: str, Neutron network object"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        return self.clients(\"neutron\").show_network(network, **kwargs)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_3845e9b2","line":71,"updated":"2015-09-18 21:18:41.000000000","message":"You wrote that returns Neutron network object. But I description and due to name it must return the network id. Format of docstring is wrong. There is must be params name.","commit_id":"88e8587c8680bd4793710aa7b8e168d8c5ce4282"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"b027a9d835ccc24c29ddffb796092121685da6d8","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        param: str, network name"},{"line_number":70,"context_line":"        param: dict, network options"},{"line_number":71,"context_line":"        returns: str, Neutron network object"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        return self.clients(\"neutron\").show_network(network, **kwargs)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_9f509460","line":71,"in_reply_to":"ba15a1d1_3845e9b2","updated":"2015-09-19 11:24:54.000000000","message":"Actually it runs like this\n\nwe give \n\nnetwork \u003d \"network-name\"\n\nThe return function will look like\n\n[{\"networks\":{\"id\": \"network-id\", \"name\": \"network-name\"}}]\n\nAnyway, I agree to your suggestion. :)","commit_id":"88e8587c8680bd4793710aa7b8e168d8c5ce4282"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"94acc5c44ac58d3d3f9961bbd586b65dfc00bf87","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :returns: neutron network dict"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        network_create_args.setdefault(\"name\", self._generate_random_name())"},{"line_number":89,"context_line":"        if network_create_args.get(\"router:external\") is True:"},{"line_number":90,"context_line":"            return self.admin_clients(\"neutron\").create_network("},{"line_number":91,"context_line":"                {\"network\": network_create_args})"},{"line_number":92,"context_line":"        return self.clients(\"neutron\").create_network("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_43568c07","line":89,"updated":"2015-09-21 12:42:03.000000000","message":"Maybe use casting to boolean (s/ is True//) instead of checking that value is exactly `True\u0027, since there is no check that value\u0027s type is `bool\u0027","commit_id":"64547b0a33fe964c150655ed0cbe4dd956ca0a6b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"94acc5c44ac58d3d3f9961bbd586b65dfc00bf87","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        floating_network_id \u003d self._get_network_id("},{"line_number":424,"context_line":"            floating_network)"},{"line_number":425,"context_line":"        args \u003d {\"floating_network_id\": floating_network_id}"},{"line_number":426,"context_line":"        args.update(floating_ip_args)"},{"line_number":427,"context_line":"        return self.clients(\"neutron\").create_floatingip({\"floatingip\": args})"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @atomic.action_timer(\"neutron.list_floating_ips\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_68712fe0","line":426,"updated":"2015-09-21 12:42:03.000000000","message":"Now imagine that floating_ip_args has key \"floating_network_id\" - this will overwrite existing floating_network_id\n\nBetter and more compact way:\n\n def _create_floatingip(self, floating_net_name, **kwargs):\n     \"\"\"...\"\"\"\n     kwargs[\"floating_network_id\"] \u003d self._get_network_id(\n                floating_net_name)\n     return self.clients(\"neutron\").create_floatingip(\n         {\"floatingip\": kwargs})","commit_id":"64547b0a33fe964c150655ed0cbe4dd956ca0a6b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"94acc5c44ac58d3d3f9961bbd586b65dfc00bf87","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        return self.clients(\"neutron\").list_floatingips(**kwargs)"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    @atomic.action_timer(\"neutron.delete_floating_ip\")"},{"line_number":435,"context_line":"    def _delete_floating_ip(self, floating_ip):"},{"line_number":436,"context_line":"        \"\"\"Delete floating IP."},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        :param: dict, floating IP object"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_0313b45d","line":435,"updated":"2015-09-21 12:42:03.000000000","message":"Why not use `fip_id\u0027 instead?","commit_id":"64547b0a33fe964c150655ed0cbe4dd956ca0a6b"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bf0e16b7da1b2971cc4dac3556476dd177692630","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        for network in networks:"},{"line_number":76,"context_line":"            if network[\"name\"] \u003d\u003d network_name:"},{"line_number":77,"context_line":"                return network[\"id\"]"},{"line_number":78,"context_line":"        msg \u003d (\"Network %s not found.\" % network_name)"},{"line_number":79,"context_line":"        raise exceptions.NotFoundException(message\u003dmsg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @atomic.action_timer(\"neutron.create_network\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_d2346f4b","line":78,"updated":"2015-09-22 11:31:56.000000000","message":"This message needs to be translated.","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"be42f60e8036502af7f11b68e50ce646a468d541","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        for network in networks:"},{"line_number":76,"context_line":"            if network[\"name\"] \u003d\u003d network_name:"},{"line_number":77,"context_line":"                return network[\"id\"]"},{"line_number":78,"context_line":"        msg \u003d (\"Network %s not found.\" % network_name)"},{"line_number":79,"context_line":"        raise exceptions.NotFoundException(message\u003dmsg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @atomic.action_timer(\"neutron.create_network\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_72a56345","line":78,"in_reply_to":"ba15a1d1_d2346f4b","updated":"2015-09-22 11:39:58.000000000","message":"Done","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"bf0e16b7da1b2971cc4dac3556476dd177692630","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            if network[\"name\"] \u003d\u003d network_name:"},{"line_number":77,"context_line":"                return network[\"id\"]"},{"line_number":78,"context_line":"        msg \u003d (\"Network %s not found.\" % network_name)"},{"line_number":79,"context_line":"        raise exceptions.NotFoundException(message\u003dmsg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @atomic.action_timer(\"neutron.create_network\")"},{"line_number":82,"context_line":"    def _create_network(self, network_create_args):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_b2f3fb9e","line":79,"updated":"2015-09-22 11:31:56.000000000","message":"This can be done without a loop:\n\n    try:\n        return self.clients(\"neutron\").list_networks(name\u003dnetwork_name)[\"networks\"][0]\n    except IndexError:\n        raise exceptions.NotFoundException(_(\"Network %s not found\") % network_name)\n\nYou could also avoid the try-except, if you want.","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"be42f60e8036502af7f11b68e50ce646a468d541","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            if network[\"name\"] \u003d\u003d network_name:"},{"line_number":77,"context_line":"                return network[\"id\"]"},{"line_number":78,"context_line":"        msg \u003d (\"Network %s not found.\" % network_name)"},{"line_number":79,"context_line":"        raise exceptions.NotFoundException(message\u003dmsg)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @atomic.action_timer(\"neutron.create_network\")"},{"line_number":82,"context_line":"    def _create_network(self, network_create_args):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba15a1d1_52aa9f1a","line":79,"in_reply_to":"ba15a1d1_b2f3fb9e","updated":"2015-09-22 11:39:58.000000000","message":"list may have more than one network so we will have to put it into a loop. :)\nTry catch is making it even more complicated.","commit_id":"dcf5f27e2d66c43532a1632a85e1b50c9ba04d59"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"6df7ed25557cb9e33dfa3a96b60dc5aa7c589032","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        body \u003d {\"vip\": vip_update_args}"},{"line_number":407,"context_line":"        return self.clients(\"neutron\").update_vip(vip[\"vip\"][\"id\"], body)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @atomic.action_timer(\"neutron.create_floating_ip\")"},{"line_number":410,"context_line":"    def _create_floatingip(self, floating_network, **floating_ip_args):"},{"line_number":411,"context_line":"        \"\"\"Create floating IP with floating_network."},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_63a58d02","line":409,"updated":"2015-09-22 15:09:34.000000000","message":"Look at self._get_network_id(...) below - it calls self._list_networks() which calls self.clients(\"neutron\").list_networks()\n\nThis means your atomic action calculates at least two client calls, but you need to calculate only self.clients(\"neutron\").create_floatingip(...)","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        body \u003d {\"vip\": vip_update_args}"},{"line_number":407,"context_line":"        return self.clients(\"neutron\").update_vip(vip[\"vip\"][\"id\"], body)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    @atomic.action_timer(\"neutron.create_floating_ip\")"},{"line_number":410,"context_line":"    def _create_floatingip(self, floating_network, **floating_ip_args):"},{"line_number":411,"context_line":"        \"\"\"Create floating IP with floating_network."},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_b12e84f8","line":409,"in_reply_to":"ba15a1d1_63a58d02","updated":"2015-09-22 18:26:55.000000000","message":"Done","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c8f7fb5bffddd64286bd6694eea81f038b3ad774","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        return self.clients(\"neutron\").list_floatingips(**kwargs)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @atomic.action_timer(\"neutron.delete_floating_ip\")"},{"line_number":429,"context_line":"    def _delete_floating_ip(self, floating_ip):"},{"line_number":430,"context_line":"        \"\"\"Delete floating IP."},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        :param: dict, floating IP object"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_038cd17d","line":429,"updated":"2015-09-22 15:11:31.000000000","message":"Why do not use str floating_ip_id here instead of dict `floating_ip\u0027? All that you need is fip id","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"f71677c513fdf4cd241a22b726538ff9130e0110","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        return self.clients(\"neutron\").list_floatingips(**kwargs)"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @atomic.action_timer(\"neutron.delete_floating_ip\")"},{"line_number":429,"context_line":"    def _delete_floating_ip(self, floating_ip):"},{"line_number":430,"context_line":"        \"\"\"Delete floating IP."},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        :param: dict, floating IP object"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba15a1d1_f48e2acf","line":429,"in_reply_to":"ba15a1d1_038cd17d","updated":"2015-09-22 18:26:55.000000000","message":"This is the convention in which delete functions are written in utils. SO I would like to retain it. :)","commit_id":"367073f90e37d3932e7759711df8be04b3dafbd4"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"5d05b6b6676a4f3171be6d19c39dbdad77406467","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _get_network_id(self, network_name, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Get Neutron network ID for the network name."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        param: str, network name"},{"line_number":71,"context_line":"        param: dict, network options"},{"line_number":72,"context_line":"        returns: str, Neutron network-id"},{"line_number":73,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba15a1d1_d6788380","line":70,"updated":"2015-09-24 06:39:27.000000000","message":"L70~L71, miss the param name here","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"97a43b21b88f30d9f8dbaf661a499a56acf02799","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def _get_network_id(self, network_name, **kwargs):"},{"line_number":68,"context_line":"        \"\"\"Get Neutron network ID for the network name."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        param: str, network name"},{"line_number":71,"context_line":"        param: dict, network options"},{"line_number":72,"context_line":"        returns: str, Neutron network-id"},{"line_number":73,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba15a1d1_f1cb51a2","line":70,"in_reply_to":"ba15a1d1_d6788380","updated":"2015-09-24 07:24:58.000000000","message":"Done","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"5d05b6b6676a4f3171be6d19c39dbdad77406467","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"\"\"Return user networks list.\"\"\""},{"line_number":94,"context_line":"        if atomic_action:"},{"line_number":95,"context_line":"            with atomic.ActionTimer(self, \"neutron.list_networks\"):"},{"line_number":96,"context_line":"                return self.clients(\"neutron\").list_networks()[\"networks\"]"},{"line_number":97,"context_line":"        return self.clients(\"neutron\").list_networks()[\"networks\"]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @atomic.action_timer(\"neutron.update_network\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba15a1d1_16d11b57","line":96,"updated":"2015-09-24 06:39:27.000000000","message":"btw what\u0027s the purpose of codes here? if atomic_action is set to false, the call to list network are not counted. At least, if you add new param here, you need docstring for it","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"97a43b21b88f30d9f8dbaf661a499a56acf02799","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"\"\"Return user networks list.\"\"\""},{"line_number":94,"context_line":"        if atomic_action:"},{"line_number":95,"context_line":"            with atomic.ActionTimer(self, \"neutron.list_networks\"):"},{"line_number":96,"context_line":"                return self.clients(\"neutron\").list_networks()[\"networks\"]"},{"line_number":97,"context_line":"        return self.clients(\"neutron\").list_networks()[\"networks\"]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @atomic.action_timer(\"neutron.update_network\")"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba15a1d1_91c5358f","line":96,"in_reply_to":"ba15a1d1_16d11b57","updated":"2015-09-24 07:24:58.000000000","message":"Done","commit_id":"bd6cdb0951bcfd2010b30ad84662b27306f1a9de"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"1ed68377091bdd26607e2b21ad3b0b115d77a709","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        :param kwargs: network list options"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        if atomic_action:"},{"line_number":99,"context_line":"            with atomic.ActionTimer(self, \"neutron.list_networks\"):"},{"line_number":100,"context_line":"                return self.clients(\"neutron\").list_networks("},{"line_number":101,"context_line":"                    **kwargs)[\"networks\"]"},{"line_number":102,"context_line":"        return self.clients(\"neutron\").list_networks(**kwargs)[\"networks\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba15a1d1_5a1eca0c","line":99,"updated":"2015-09-24 13:42:55.000000000","message":"There is other places in code with such code duplication. Probably we should create some sugar for such cases. E.g. dummy context manager somewhere in rally.common.costilius:\n\n dummy \u003d False if atomic_action else rally.common.costilius.DummyManager\n with dummy or atomic.ActionTimer(.....):\n   fun()\n\nor even something like this:\n\n @atomic.action_timer(\"neutron.update_network\", skip_arg\u003d\"no_timer\")","commit_id":"c6ac8cc4697be39bd9d669d4d516e5cfbc376ed2"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"1dc62e8ae070458d5e312eb969771b2ced83746c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        :param kwargs: network list options"},{"line_number":97,"context_line":"        \"\"\""},{"line_number":98,"context_line":"        if atomic_action:"},{"line_number":99,"context_line":"            with atomic.ActionTimer(self, \"neutron.list_networks\"):"},{"line_number":100,"context_line":"                return self.clients(\"neutron\").list_networks("},{"line_number":101,"context_line":"                    **kwargs)[\"networks\"]"},{"line_number":102,"context_line":"        return self.clients(\"neutron\").list_networks(**kwargs)[\"networks\"]"}],"source_content_type":"text/x-python","patch_set":18,"id":"9a1a9d01_ff796e30","line":99,"in_reply_to":"ba15a1d1_5a1eca0c","updated":"2015-09-25 11:30:59.000000000","message":"I will do it in a different patch. :)","commit_id":"c6ac8cc4697be39bd9d669d4d516e5cfbc376ed2"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"872c7b45edd2424bfe7b3751cc609c72c08cae61","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        returns: dict, neutron floating IP"},{"line_number":423,"context_line":"        \"\"\""},{"line_number":424,"context_line":"        floating_network_id \u003d self._get_network_id("},{"line_number":425,"context_line":"            floating_network)"},{"line_number":426,"context_line":"        args \u003d {\"floating_network_id\": floating_network_id}"},{"line_number":427,"context_line":"        args.update(floating_ip_args)"},{"line_number":428,"context_line":"        return self.clients(\"neutron\").create_floatingip({\"floatingip\": args})"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a1a9d01_13eaed0f","line":425,"updated":"2015-09-28 07:04:44.000000000","message":"_get_network_id calls network list api at L67~79, it is not fair to count this response time into create_floating_ip api","commit_id":"5806f21ce6cdee2fbbbd8b9507735a03880c0757"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"695d14422036ea2be263257fc2e90d2f129ae7a3","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        returns: dict, neutron floating IP"},{"line_number":423,"context_line":"        \"\"\""},{"line_number":424,"context_line":"        floating_network_id \u003d self._get_network_id("},{"line_number":425,"context_line":"            floating_network)"},{"line_number":426,"context_line":"        args \u003d {\"floating_network_id\": floating_network_id}"},{"line_number":427,"context_line":"        args.update(floating_ip_args)"},{"line_number":428,"context_line":"        return self.clients(\"neutron\").create_floatingip({\"floatingip\": args})"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a1a9d01_1338ad9f","line":425,"in_reply_to":"9a1a9d01_13eaed0f","updated":"2015-09-28 07:07:10.000000000","message":"I am passing atomic_action\u003dFalse\n\nlist_networks is not counted.\nhttp://logs.openstack.org/23/225223/19/check/gate-rally-dsvm-neutron-rally/8168774/rally-plot/results.html.gz#/NeutronNetworks.create_and_delete_floating_ips\n\nhttp://logs.openstack.org/23/225223/19/check/gate-rally-dsvm-neutron-rally/8168774/rally-plot/results.html.gz#/NeutronNetworks.create_and_list_floating_ips","commit_id":"5806f21ce6cdee2fbbbd8b9507735a03880c0757"}],"samples/tasks/scenarios/neutron/create_and_delete_floating_ips.json":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"floating_ip_args\": {},"},{"line_number":7,"context_line":"                \"network_create_args\": {},"},{"line_number":8,"context_line":"                \"subnet_create_args\": {},"},{"line_number":9,"context_line":"                \"subnet_cidr_start\": \"1.1.0.0/30\""},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_51816f4c","line":9,"updated":"2015-09-21 14:09:14.000000000","message":"create_and_delete_floating_ips doesn\u0027t take these last three arguments.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"floating_ip_args\": {},"},{"line_number":7,"context_line":"                \"network_create_args\": {},"},{"line_number":8,"context_line":"                \"subnet_create_args\": {},"},{"line_number":9,"context_line":"                \"subnet_cidr_start\": \"1.1.0.0/30\""},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_32c4d63e","line":9,"in_reply_to":"ba15a1d1_51816f4c","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                \"quotas\": {"},{"line_number":22,"context_line":"                    \"neutron\": {"},{"line_number":23,"context_line":"                        \"network\": -1,"},{"line_number":24,"context_line":"                        \"subnet\": -1,"},{"line_number":25,"context_line":"                        \"floatingip\": -1"},{"line_number":26,"context_line":"                    }"},{"line_number":27,"context_line":"                }"}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_11c9b7ac","line":24,"updated":"2015-09-21 14:09:14.000000000","message":"It\u0027s not necessary to set network and subnet quotas.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                \"quotas\": {"},{"line_number":22,"context_line":"                    \"neutron\": {"},{"line_number":23,"context_line":"                        \"network\": -1,"},{"line_number":24,"context_line":"                        \"subnet\": -1,"},{"line_number":25,"context_line":"                        \"floatingip\": -1"},{"line_number":26,"context_line":"                    }"},{"line_number":27,"context_line":"                }"}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_52bf0aaa","line":24,"in_reply_to":"ba15a1d1_11c9b7ac","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"}],"samples/tasks/scenarios/neutron/create_and_list_floating_ips.json":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"floating_ip_args\": {},"},{"line_number":7,"context_line":"                \"network_create_args\": {},"},{"line_number":8,"context_line":"                \"subnet_create_args\": {},"},{"line_number":9,"context_line":"                \"subnet_cidr_start\": \"1.1.0.0/30\""},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_b18c8b80","line":9,"updated":"2015-09-21 14:09:14.000000000","message":"create_and_list_floating_ips doesn\u0027t take these last three arguments.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                \"floating_ip_args\": {},"},{"line_number":7,"context_line":"                \"network_create_args\": {},"},{"line_number":8,"context_line":"                \"subnet_create_args\": {},"},{"line_number":9,"context_line":"                \"subnet_cidr_start\": \"1.1.0.0/30\""},{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"runner\": {"},{"line_number":12,"context_line":"                \"type\": \"constant\","}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_72ca4e51","line":9,"in_reply_to":"ba15a1d1_b18c8b80","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                \"quotas\": {"},{"line_number":22,"context_line":"                    \"neutron\": {"},{"line_number":23,"context_line":"                        \"network\": -1,"},{"line_number":24,"context_line":"                        \"subnet\": -1,"},{"line_number":25,"context_line":"                        \"floatingip\": -1"},{"line_number":26,"context_line":"                    }"},{"line_number":27,"context_line":"                }"}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_31ce3bb5","line":24,"updated":"2015-09-21 14:09:14.000000000","message":"It\u0027s not necessary to set network and subnet quotas.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                \"quotas\": {"},{"line_number":22,"context_line":"                    \"neutron\": {"},{"line_number":23,"context_line":"                        \"network\": -1,"},{"line_number":24,"context_line":"                        \"subnet\": -1,"},{"line_number":25,"context_line":"                        \"floatingip\": -1"},{"line_number":26,"context_line":"                    }"},{"line_number":27,"context_line":"                }"}],"source_content_type":"application/json","patch_set":10,"id":"ba15a1d1_92c5a23e","line":24,"in_reply_to":"ba15a1d1_31ce3bb5","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"}],"tests/unit/fakes.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"    def delete_floatingip(self, fip_id):"},{"line_number":1241,"context_line":"        if fip_id not in self.__fips:"},{"line_number":1242,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1243,"context_line":"        del self.__vips[fip_id]"},{"line_number":1244,"context_line":"        return \"\""},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def delete_port(self, port_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_d11fbf07","line":1243,"updated":"2015-09-21 14:09:14.000000000","message":"s/self.__vips/self.fips/?\n\nNot incidentally, this is why I hate the whole fakes module. We end up writing complex, untested code to test our mainline code, and that process is fraught. Since you don\u0027t use this functionality in your test, my recommendation would be to leave these changes out entirely so that we don\u0027t encourage other people to use it. :)","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"    def delete_floatingip(self, fip_id):"},{"line_number":1241,"context_line":"        if fip_id not in self.__fips:"},{"line_number":1242,"context_line":"            raise neutron_exceptions.NeutronClientException"},{"line_number":1243,"context_line":"        del self.__vips[fip_id]"},{"line_number":1244,"context_line":"        return \"\""},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"    def delete_port(self, port_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_126192a8","line":1243,"in_reply_to":"ba15a1d1_d11fbf07","updated":"2015-09-22 07:02:49.000000000","message":"Oopsy! :)","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        network_name \u003d \"network\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Valid network-name"},{"line_number":38,"context_line":"        networks \u003d [{\"id\": \"net-id\", \"name\": \"network\"}]"},{"line_number":39,"context_line":"        network_id \u003d \"net-id\""},{"line_number":40,"context_line":"        neutron_scenario._list_networks \u003d mock.Mock(return_value\u003dnetworks)"},{"line_number":41,"context_line":"        resultant_network_id \u003d neutron_scenario._get_network_id(network_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_518e4f28","line":38,"updated":"2015-09-21 14:09:14.000000000","message":"It\u0027d be nice to test this with more than one network.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        network_name \u003d \"network\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Valid network-name"},{"line_number":38,"context_line":"        networks \u003d [{\"id\": \"net-id\", \"name\": \"network\"}]"},{"line_number":39,"context_line":"        network_id \u003d \"net-id\""},{"line_number":40,"context_line":"        neutron_scenario._list_networks \u003d mock.Mock(return_value\u003dnetworks)"},{"line_number":41,"context_line":"        resultant_network_id \u003d neutron_scenario._get_network_id(network_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_12e0b2cb","line":38,"in_reply_to":"ba15a1d1_518e4f28","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def test_list_floating_ips(self):"},{"line_number":456,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":457,"context_line":"        fips_list \u003d []"},{"line_number":458,"context_line":"        fips_dict \u003d {\"floatingips\": fips_list}"},{"line_number":459,"context_line":"        self.clients(\"neutron\").list_floatingips.return_value \u003d fips_dict"},{"line_number":460,"context_line":"        return_fips_dict \u003d scenario._list_floating_ips()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_f1d763bd","line":457,"updated":"2015-09-21 14:09:14.000000000","message":"This variable is unused.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def test_list_floating_ips(self):"},{"line_number":456,"context_line":"        scenario \u003d utils.NeutronScenario()"},{"line_number":457,"context_line":"        fips_list \u003d []"},{"line_number":458,"context_line":"        fips_dict \u003d {\"floatingips\": fips_list}"},{"line_number":459,"context_line":"        self.clients(\"neutron\").list_floatingips.return_value \u003d fips_dict"},{"line_number":460,"context_line":"        return_fips_dict \u003d scenario._list_floating_ips()"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_b20ea6e3","line":457,"in_reply_to":"ba15a1d1_f1d763bd","updated":"2015-09-22 07:02:49.000000000","message":"I have used in the below line.\nI will add a fip dict here.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        fips_dict \u003d {\"floatingips\": fips_list}"},{"line_number":459,"context_line":"        self.clients(\"neutron\").list_floatingips.return_value \u003d fips_dict"},{"line_number":460,"context_line":"        return_fips_dict \u003d scenario._list_floating_ips()"},{"line_number":461,"context_line":"        self.assertEqual(fips_dict, return_fips_dict)"},{"line_number":462,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":463,"context_line":"                                       \"neutron.list_floating_ips\")"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_11b5377d","line":461,"updated":"2015-09-21 14:09:14.000000000","message":"These four lines can be much simplified as just:\n\n    self.assertEqual(scenario._list_floating_ips(),\n                     self.clients(\"neutron\").list_floatingips.return_value)","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        fips_dict \u003d {\"floatingips\": fips_list}"},{"line_number":459,"context_line":"        self.clients(\"neutron\").list_floatingips.return_value \u003d fips_dict"},{"line_number":460,"context_line":"        return_fips_dict \u003d scenario._list_floating_ips()"},{"line_number":461,"context_line":"        self.assertEqual(fips_dict, return_fips_dict)"},{"line_number":462,"context_line":"        self._test_atomic_action_timer(scenario.atomic_actions(),"},{"line_number":463,"context_line":"                                       \"neutron.list_floating_ips\")"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_b2e6a6e6","line":461,"in_reply_to":"ba15a1d1_11b5377d","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"72cc7423c9da302be1a89c4b1c0bc768dfa0ac42","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        self.assertEqual(resultant_fip, fip)"},{"line_number":705,"context_line":"        self.clients(\"neutron\").create_floatingip.assert_called_once_with("},{"line_number":706,"context_line":"            expected_fip_data)"},{"line_number":707,"context_line":"        mock_get_network_id.assert_called_once_with(floating_network)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_31487b87","line":707,"updated":"2015-09-21 14:09:14.000000000","message":"_test_atomic_action_timer() needed.","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"306434ca7da7eb5d6f29b9c84b90974e20d8f800","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        self.assertEqual(resultant_fip, fip)"},{"line_number":705,"context_line":"        self.clients(\"neutron\").create_floatingip.assert_called_once_with("},{"line_number":706,"context_line":"            expected_fip_data)"},{"line_number":707,"context_line":"        mock_get_network_id.assert_called_once_with(floating_network)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba15a1d1_d2e9dab8","line":707,"in_reply_to":"ba15a1d1_31487b87","updated":"2015-09-22 07:02:49.000000000","message":"Done","commit_id":"521c224e0e937664834d8793867886b6a5a9c699"}]}
