)]}'
{"rally/plugins/openstack/context/cinder/volumes.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"217a4f8f73f5628cc542288a395b346e0bb769a0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            self.context[\"tenants\"][tenant_id].setdefault(\"volumes\", [])"},{"line_number":60,"context_line":"            tmp_context \u003d {\"user\": user,"},{"line_number":61,"context_line":"                           \"task\": self.context[\"task\"]}"},{"line_number":62,"context_line":"            cinder_util \u003d cinder_utils.CinderScenario(tmp_context)"},{"line_number":63,"context_line":"            for i in range(volumes_per_tenant):"},{"line_number":64,"context_line":"                rnd_name \u003d self.generate_random_name()"},{"line_number":65,"context_line":"                vol \u003d cinder_util._create_volume(size, display_name\u003drnd_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_307b957d","line":62,"updated":"2015-10-02 09:13:31.000000000","message":"So we should avoid creating variables that are used only once. We should use them only in rare situation when it makes code clener (and this time it is not the case)","commit_id":"4d7e0fd36b46ffed2b2c99e19bdd13d592f465fd"}],"rally/plugins/openstack/context/glance/images.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4cf785bfe8838f01735015de2d67d482c357cb3f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":75,"context_line":"                self.context[\"users\"]):"},{"line_number":76,"context_line":"            current_images \u003d []"},{"line_number":77,"context_line":"            tmp_context \u003d {\"user\": user,"},{"line_number":78,"context_line":"                           \"task\": self.context[\"task\"]}"},{"line_number":79,"context_line":"            glance_scenario \u003d glance_utils.GlanceScenario(tmp_context)"},{"line_number":80,"context_line":"            for i in range(images_per_tenant):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_e6dd3815","line":77,"updated":"2015-10-07 07:55:45.000000000","message":"I don\u0027t think this variable is necessary.\nCan you please just add the task to the dict?","commit_id":"87dc40854c8805a47478b300571d1d62f7d4f8fa"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"429e4521626b0dc7329d50d7ae0da0baf2891581","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":75,"context_line":"                self.context[\"users\"]):"},{"line_number":76,"context_line":"            current_images \u003d []"},{"line_number":77,"context_line":"            tmp_context \u003d {\"user\": user,"},{"line_number":78,"context_line":"                           \"task\": self.context[\"task\"]}"},{"line_number":79,"context_line":"            glance_scenario \u003d glance_utils.GlanceScenario(tmp_context)"},{"line_number":80,"context_line":"            for i in range(images_per_tenant):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_44fa7d44","line":77,"updated":"2015-10-09 03:29:14.000000000","message":"please do not introduce variables where they are not required and doesn\u0027t make any sense.","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a84d8cc8a624b3dd4145233c08f79bdd2d2cc509","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":75,"context_line":"                self.context[\"users\"]):"},{"line_number":76,"context_line":"            current_images \u003d []"},{"line_number":77,"context_line":"            tmp_context \u003d {\"user\": user,"},{"line_number":78,"context_line":"                           \"task\": self.context[\"task\"]}"},{"line_number":79,"context_line":"            glance_scenario \u003d glance_utils.GlanceScenario(tmp_context)"},{"line_number":80,"context_line":"            for i in range(images_per_tenant):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_027b0429","line":77,"in_reply_to":"7a2fa921_44fa7d44","updated":"2015-10-09 12:24:05.000000000","message":"Done","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"}],"rally/plugins/openstack/context/heat/stacks.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4cf785bfe8838f01735015de2d67d482c357cb3f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.config[\"resources_per_stack\"])"},{"line_number":77,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":78,"context_line":"                self.context[\"users\"]):"},{"line_number":79,"context_line":"            tmp_context \u003d {\"user\": user, \"task\": self.context[\"task\"]}"},{"line_number":80,"context_line":"            heat_scenario \u003d heat_utils.HeatScenario(tmp_context)"},{"line_number":81,"context_line":"            self.context[\"tenants\"][tenant_id][\"stacks\"] \u003d []"},{"line_number":82,"context_line":"            for i in range(self.config[\"stacks_per_tenant\"]):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_062f14f7","line":79,"updated":"2015-10-07 07:55:45.000000000","message":"Here as well.","commit_id":"87dc40854c8805a47478b300571d1d62f7d4f8fa"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"429e4521626b0dc7329d50d7ae0da0baf2891581","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.config[\"resources_per_stack\"])"},{"line_number":77,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":78,"context_line":"                self.context[\"users\"]):"},{"line_number":79,"context_line":"            tmp_context \u003d {\"user\": user, \"task\": self.context[\"task\"]}"},{"line_number":80,"context_line":"            heat_scenario \u003d heat_utils.HeatScenario(tmp_context)"},{"line_number":81,"context_line":"            self.context[\"tenants\"][tenant_id][\"stacks\"] \u003d []"},{"line_number":82,"context_line":"            for i in range(self.config[\"stacks_per_tenant\"]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_0497a5ec","line":79,"updated":"2015-10-09 03:29:14.000000000","message":"same here","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a84d8cc8a624b3dd4145233c08f79bdd2d2cc509","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            self.config[\"resources_per_stack\"])"},{"line_number":77,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":78,"context_line":"                self.context[\"users\"]):"},{"line_number":79,"context_line":"            tmp_context \u003d {\"user\": user, \"task\": self.context[\"task\"]}"},{"line_number":80,"context_line":"            heat_scenario \u003d heat_utils.HeatScenario(tmp_context)"},{"line_number":81,"context_line":"            self.context[\"tenants\"][tenant_id][\"stacks\"] \u003d []"},{"line_number":82,"context_line":"            for i in range(self.config[\"stacks_per_tenant\"]):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_02a22499","line":79,"in_reply_to":"7a2fa921_0497a5ec","updated":"2015-10-09 12:24:05.000000000","message":"Done","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"}],"rally/plugins/openstack/context/nova/servers.py":[{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"4cf785bfe8838f01735015de2d67d482c357cb3f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                self.context[\"users\"])):"},{"line_number":88,"context_line":"            LOG.debug(\"Booting servers for user tenant %s \""},{"line_number":89,"context_line":"                      % (user[\"tenant_id\"]))"},{"line_number":90,"context_line":"            tmp_context \u003d {\"user\": user,"},{"line_number":91,"context_line":"                           \"tenant\": self.context[\"tenants\"][tenant_id],"},{"line_number":92,"context_line":"                           \"task\": self.context[\"task\"],"},{"line_number":93,"context_line":"                           \"iteration\": iter_}"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_c60fdc86","line":90,"updated":"2015-10-07 07:55:45.000000000","message":"Dunno about this though.","commit_id":"87dc40854c8805a47478b300571d1d62f7d4f8fa"}],"rally/plugins/openstack/context/sahara/sahara_image.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"429e4521626b0dc7329d50d7ae0da0baf2891581","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _create_image(self, hadoop_version, image_url, plugin_name, user,"},{"line_number":62,"context_line":"                      user_name):"},{"line_number":63,"context_line":"        tmp_context \u003d {\"user\": user,"},{"line_number":64,"context_line":"                       \"task\": self.context[\"task\"]}"},{"line_number":65,"context_line":"        scenario \u003d glance_utils.GlanceScenario(tmp_context)"},{"line_number":66,"context_line":"        image_name \u003d self.generate_random_name()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_44911df0","line":63,"updated":"2015-10-09 03:29:14.000000000","message":"same here","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a84d8cc8a624b3dd4145233c08f79bdd2d2cc509","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _create_image(self, hadoop_version, image_url, plugin_name, user,"},{"line_number":62,"context_line":"                      user_name):"},{"line_number":63,"context_line":"        tmp_context \u003d {\"user\": user,"},{"line_number":64,"context_line":"                       \"task\": self.context[\"task\"]}"},{"line_number":65,"context_line":"        scenario \u003d glance_utils.GlanceScenario(tmp_context)"},{"line_number":66,"context_line":"        image_name \u003d self.generate_random_name()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_62b998cb","line":63,"in_reply_to":"7a2fa921_44911df0","updated":"2015-10-09 12:24:05.000000000","message":"Done","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"}],"tests/unit/plugins/openstack/context/vm/test_custom_image.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"269e16d0b574d15e3b13f666d0f887f2b8423ebf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @mock.patch(\"%s.types.ImageResourceType.transform\" % BASE,"},{"line_number":130,"context_line":"                return_value\u003d\"image\")"},{"line_number":131,"context_line":"    @mock.patch(\"%s.types.FlavorResourceType.transform\" % BASE,"},{"line_number":132,"context_line":"                return_value\u003d\"flavor\")"},{"line_number":133,"context_line":"    def test_create_one_image_cleanup("},{"line_number":134,"context_line":"            self, mock_flavor_resource_type_transform,"},{"line_number":135,"context_line":"            mock_image_resource_type_transform, mock_clients, mock_vm_tasks):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_60a537a0","line":132,"updated":"2015-10-08 18:02:29.000000000","message":"something wrong with this test: http://logs.openstack.org/86/226386/8/check/gate-rally-python27/2ae18e0/console.html","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a84d8cc8a624b3dd4145233c08f79bdd2d2cc509","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @mock.patch(\"%s.types.ImageResourceType.transform\" % BASE,"},{"line_number":130,"context_line":"                return_value\u003d\"image\")"},{"line_number":131,"context_line":"    @mock.patch(\"%s.types.FlavorResourceType.transform\" % BASE,"},{"line_number":132,"context_line":"                return_value\u003d\"flavor\")"},{"line_number":133,"context_line":"    def test_create_one_image_cleanup("},{"line_number":134,"context_line":"            self, mock_flavor_resource_type_transform,"},{"line_number":135,"context_line":"            mock_image_resource_type_transform, mock_clients, mock_vm_tasks):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_c21aecc5","line":132,"in_reply_to":"7a2fa921_60a537a0","updated":"2015-10-09 12:24:05.000000000","message":"Done","commit_id":"dd852f9fdda6c30d0d12eba2d01a073403d2142f"}]}