)]}'
{"rally/plugins/openstack/scenarios/neutron/security_groups.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c9fbb4551db9fb0fd73be5b2e73d31cbba8bc7fc","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":39,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":40,"context_line":"    @scenario.configure()"},{"line_number":41,"context_line":"    def create_and_delete_security_groups(self,"},{"line_number":42,"context_line":"                                          security_group_create_args\u003dNone):"},{"line_number":43,"context_line":"        \"\"\"Create and delete Neutron security-groups."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_7e74859b","line":40,"updated":"2015-10-19 11:34:08.000000000","message":"Please add here also \"context\u003d{\"cleanup...\" as done in other scenarios.","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9d2843f4c523a7275519c3317d3c8f3dcd8c555b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @validation.required_services(consts.Service.NEUTRON)"},{"line_number":39,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":40,"context_line":"    @scenario.configure()"},{"line_number":41,"context_line":"    def create_and_delete_security_groups(self,"},{"line_number":42,"context_line":"                                          security_group_create_args\u003dNone):"},{"line_number":43,"context_line":"        \"\"\"Create and delete Neutron security-groups."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_a3d172cf","line":40,"in_reply_to":"3a29b11f_7e74859b","updated":"2015-10-20 13:29:27.000000000","message":"Cleanup not needed here. Because we are simply creating the security-groups and deleting them in the scenario itself. No leftover resources from context/scenario. So it is unnecessary.","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"a241f6e34d551e4553e94992acb2e3e1e0314b92","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                                          request options"},{"line_number":449,"context_line":"        return: dict, neutron security-group"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        security_group_create_args.setdefault("},{"line_number":452,"context_line":"            \"name\", self._generate_random_name())"},{"line_number":453,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":454,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_294846cb","line":451,"updated":"2015-10-01 09:01:54.000000000","message":"Please do not allow custom resource names.","commit_id":"4027df70fd50c2f355f961cd7ea199571220cf07"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"ff89e0c17367089b3c32077e960bd9d8c9b87bbc","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                                          request options"},{"line_number":449,"context_line":"        return: dict, neutron security-group"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        security_group_create_args.setdefault("},{"line_number":452,"context_line":"            \"name\", self._generate_random_name())"},{"line_number":453,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":454,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5f99a8c2","line":451,"in_reply_to":"9a1a9d01_294846cb","updated":"2015-10-01 10:20:25.000000000","message":"Are you sure?\nBecause I see that resource names are not allowed only in update_methods.\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/utils.py#L88-Lundefined\n\nhttps://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/utils.py#L165","commit_id":"4027df70fd50c2f355f961cd7ea199571220cf07"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"743f84ef546283a30c94c7aeb94290aa49113393","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                                          request options"},{"line_number":449,"context_line":"        return: dict, neutron security-group"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        security_group_create_args.setdefault("},{"line_number":452,"context_line":"            \"name\", self._generate_random_name())"},{"line_number":453,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":454,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_d506f984","line":451,"in_reply_to":"9a1a9d01_5f99a8c2","updated":"2015-10-01 10:44:15.000000000","message":"it should be fixed everywhere","commit_id":"4027df70fd50c2f355f961cd7ea199571220cf07"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"769e296b949543d8e503e8e7d00042eb059d9aa9","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                                          request options"},{"line_number":449,"context_line":"        return: dict, neutron security-group"},{"line_number":450,"context_line":"        \"\"\""},{"line_number":451,"context_line":"        security_group_create_args.setdefault("},{"line_number":452,"context_line":"            \"name\", self._generate_random_name())"},{"line_number":453,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":454,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_756b6d1e","line":451,"in_reply_to":"9a1a9d01_d506f984","updated":"2015-10-01 10:47:29.000000000","message":"OK. Done then. Should I submit a separate patch or shall I do it here itself?","commit_id":"4027df70fd50c2f355f961cd7ea199571220cf07"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f52c277da1d6e5fae0f1351e2b8fc41afdf282b5","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name()})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_775fda0e","line":512,"updated":"2015-10-13 15:48:18.000000000","message":"This will generate random name rally_net_\u003crandom part\u003e (see RESOURCE_NAME_PREFIX at L29) - make this name like rally_secgroup_\u003crandom part\u003e","commit_id":"ed633752a9f3ae446d046e7a7949f1f67378b857"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"90e20e9f04336040e6fa46839b939320e48227b9","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name()})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_9ccf17b0","line":512,"in_reply_to":"5a2ca52d_775fda0e","updated":"2015-10-14 08:58:06.000000000","message":"Done","commit_id":"ed633752a9f3ae446d046e7a7949f1f67378b857"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f52c277da1d6e5fae0f1351e2b8fc41afdf282b5","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                                           update options"},{"line_number":538,"context_line":"        return: dict, updated neutron security-group"},{"line_number":539,"context_line":"        \"\"\""},{"line_number":540,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":541,"context_line":"                                               security_group_update_args)"},{"line_number":542,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":543,"context_line":"        return self.clients(\"neutron\").update_security_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_57adfe86","line":540,"updated":"2015-10-13 15:48:18.000000000","message":"Look at L64 - `name\u0027 will be generated only if it is already exists in  security_group_update_args (I think that is a bug) - so if  security_group_update_args is empty dict, then name will not be set","commit_id":"ed633752a9f3ae446d046e7a7949f1f67378b857"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"90e20e9f04336040e6fa46839b939320e48227b9","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                                           update options"},{"line_number":538,"context_line":"        return: dict, updated neutron security-group"},{"line_number":539,"context_line":"        \"\"\""},{"line_number":540,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":541,"context_line":"                                               security_group_update_args)"},{"line_number":542,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":543,"context_line":"        return self.clients(\"neutron\").update_security_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_7c41db0a","line":540,"in_reply_to":"5a2ca52d_57adfe86","updated":"2015-10-14 08:58:06.000000000","message":"I will file a bug and submit a patch for that.","commit_id":"ed633752a9f3ae446d046e7a7949f1f67378b857"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"65a77845d16f6a7e78e58942716a7550ede904dc","unresolved":false,"context_lines":[{"line_number":537,"context_line":"                                           update options"},{"line_number":538,"context_line":"        return: dict, updated neutron security-group"},{"line_number":539,"context_line":"        \"\"\""},{"line_number":540,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":541,"context_line":"                                               security_group_update_args)"},{"line_number":542,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":543,"context_line":"        return self.clients(\"neutron\").update_security_group("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_289aca6e","line":540,"in_reply_to":"5a2ca52d_7c41db0a","updated":"2015-10-16 10:51:39.000000000","message":"In this case bugfix-patch should be a dependency for this patch","commit_id":"ed633752a9f3ae446d046e7a7949f1f67378b857"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c9fbb4551db9fb0fd73be5b2e73d31cbba8bc7fc","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                          request options"},{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name(\"rally_security_group_\")})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_0c552b4f","line":511,"updated":"2015-10-19 11:34:08.000000000","message":"Maybe use _warn_about_deprecated_name_kwarg?","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9d2843f4c523a7275519c3317d3c8f3dcd8c555b","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                          request options"},{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name(\"rally_security_group_\")})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_f5094ede","line":511,"in_reply_to":"3a29b11f_0c552b4f","updated":"2015-10-20 13:29:27.000000000","message":"The function is supported only for update functions :)","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"509d513e25bf59e2c9d8c8709abdb8c9d3695efd","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name(\"rally_security_group_\")})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_178f9676","line":512,"updated":"2015-10-23 13:54:19.000000000","message":"Why do you use .update() here instead of just:\n\n    security_group_create_args[\"name\"] \u003d self.generate_random_name()\n\nAlso, please use self.generate_random_name() (i.e., the new random name generator, with no prefix).","commit_id":"3bc14b55930a2d0962f976ad0c6dd74bdd614377"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"0c8c95e5ddfe9d91e0084dd32ebe538179aa8eee","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        return: dict, neutron security-group"},{"line_number":510,"context_line":"        \"\"\""},{"line_number":511,"context_line":"        security_group_create_args.update("},{"line_number":512,"context_line":"            {\"name\": self._generate_random_name(\"rally_security_group_\")})"},{"line_number":513,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":514,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":515,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_d501ef3a","line":512,"in_reply_to":"3a29b11f_178f9676","updated":"2015-10-26 10:22:11.000000000","message":"Done","commit_id":"3bc14b55930a2d0962f976ad0c6dd74bdd614377"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"509d513e25bf59e2c9d8c8709abdb8c9d3695efd","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        return: dict, updated neutron security-group"},{"line_number":539,"context_line":"        \"\"\""},{"line_number":540,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":541,"context_line":"                                               security_group_update_args)"},{"line_number":542,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":543,"context_line":"        return self.clients(\"neutron\").update_security_group("},{"line_number":544,"context_line":"            security_group[\"security_group\"][\"id\"], body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_f73a1a98","line":541,"updated":"2015-10-23 13:54:19.000000000","message":"This function is brand new, so it seems strange that it already has a deprecated argument.","commit_id":"3bc14b55930a2d0962f976ad0c6dd74bdd614377"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"0c8c95e5ddfe9d91e0084dd32ebe538179aa8eee","unresolved":false,"context_lines":[{"line_number":538,"context_line":"        return: dict, updated neutron security-group"},{"line_number":539,"context_line":"        \"\"\""},{"line_number":540,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":541,"context_line":"                                               security_group_update_args)"},{"line_number":542,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":543,"context_line":"        return self.clients(\"neutron\").update_security_group("},{"line_number":544,"context_line":"            security_group[\"security_group\"][\"id\"], body)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_95a93727","line":541,"in_reply_to":"3a29b11f_f73a1a98","updated":"2015-10-26 10:22:11.000000000","message":"Do you want this removed?","commit_id":"3bc14b55930a2d0962f976ad0c6dd74bdd614377"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"76b1127d7b6ab2397e367002621e58336a405fe5","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        return: dict, neutron security-group"},{"line_number":501,"context_line":"        \"\"\""},{"line_number":502,"context_line":"        security_group_create_args.update("},{"line_number":503,"context_line":"            {\"name\": self.generate_random_name()})"},{"line_number":504,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":505,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_87ec9f90","line":503,"updated":"2015-10-26 22:53:26.000000000","message":"Why don\u0027t you just do:\n\n    security_group_create_args[\"name\"] \u003d self.generate_random_name()\n\n?","commit_id":"dcb3aeafaa60c576718dfd3ae867a69fbc106813"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"abd98cfad3b918af8321286f10a41bb3e343e3d7","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        return: dict, neutron security-group"},{"line_number":501,"context_line":"        \"\"\""},{"line_number":502,"context_line":"        security_group_create_args.update("},{"line_number":503,"context_line":"            {\"name\": self.generate_random_name()})"},{"line_number":504,"context_line":"        return self.clients(\"neutron\").create_security_group("},{"line_number":505,"context_line":"            {\"security_group\": security_group_create_args})"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a26ad4f_b99d775b","line":503,"in_reply_to":"3a29b11f_87ec9f90","updated":"2015-10-27 07:51:20.000000000","message":"Done","commit_id":"dcb3aeafaa60c576718dfd3ae867a69fbc106813"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"76b1127d7b6ab2397e367002621e58336a405fe5","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        return: dict, updated neutron security-group"},{"line_number":530,"context_line":"        \"\"\""},{"line_number":531,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":532,"context_line":"                                               security_group_update_args)"},{"line_number":533,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":534,"context_line":"        return self.clients(\"neutron\").update_security_group("},{"line_number":535,"context_line":"            security_group[\"security_group\"][\"id\"], body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a29b11f_87a33f4f","line":532,"updated":"2015-10-26 22:53:26.000000000","message":"I guess the error message from this function doesn\u0027t specifically mention deprecation, but it still seems strange to see this in a brand new function. If we\u0027re going to warn the user about this, then I feel like we should probably rename the function, and it should probably also be abstracted out of the Neutron utils since I\u0027d wager more than just Neutron has to handle this.","commit_id":"dcb3aeafaa60c576718dfd3ae867a69fbc106813"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"abd98cfad3b918af8321286f10a41bb3e343e3d7","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        return: dict, updated neutron security-group"},{"line_number":530,"context_line":"        \"\"\""},{"line_number":531,"context_line":"        self._warn_about_deprecated_name_kwarg(security_group,"},{"line_number":532,"context_line":"                                               security_group_update_args)"},{"line_number":533,"context_line":"        body \u003d {\"security_group\": security_group_update_args}"},{"line_number":534,"context_line":"        return self.clients(\"neutron\").update_security_group("},{"line_number":535,"context_line":"            security_group[\"security_group\"][\"id\"], body)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a26ad4f_19ad8b88","line":532,"in_reply_to":"3a29b11f_87a33f4f","updated":"2015-10-27 07:51:20.000000000","message":"I am thinking of fixing this in a different patch. :)","commit_id":"dcb3aeafaa60c576718dfd3ae867a69fbc106813"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"c9fbb4551db9fb0fd73be5b2e73d31cbba8bc7fc","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario._generate_random_name\")"},{"line_number":580,"context_line":"    def test_create_security_group(self, mock__generate_random_name):"},{"line_number":581,"context_line":"        neutron_scenario \u003d utils.NeutronScenario(self.context)"},{"line_number":582,"context_line":"        random_name \u003d \"random_name\""},{"line_number":583,"context_line":"        security_group_create_args \u003d {\"description\": \"Fake security group\"}"},{"line_number":584,"context_line":"        expected_security_group \u003d {"},{"line_number":585,"context_line":"            \"security_group\": {\"id\": \"fake-id\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_0cb1ab8f","line":582,"updated":"2015-10-19 11:34:08.000000000","message":"Use this variable at line 586 too. Or better just delete it, and use hardcoded string. It\u0027s okay in tests.","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"},{"author":{"_account_id":14884,"name":"Kiran Ranganath","email":"kiran7193@gmail.com","username":"kiran"},"change_message_id":"9d2843f4c523a7275519c3317d3c8f3dcd8c555b","unresolved":false,"context_lines":[{"line_number":579,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario._generate_random_name\")"},{"line_number":580,"context_line":"    def test_create_security_group(self, mock__generate_random_name):"},{"line_number":581,"context_line":"        neutron_scenario \u003d utils.NeutronScenario(self.context)"},{"line_number":582,"context_line":"        random_name \u003d \"random_name\""},{"line_number":583,"context_line":"        security_group_create_args \u003d {\"description\": \"Fake security group\"}"},{"line_number":584,"context_line":"        expected_security_group \u003d {"},{"line_number":585,"context_line":"            \"security_group\": {\"id\": \"fake-id\","}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_95101a03","line":582,"in_reply_to":"3a29b11f_0cb1ab8f","updated":"2015-10-20 13:29:27.000000000","message":"Done","commit_id":"cc15f8264fad357bd88cb1b5400c9cb914072657"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"cb987ce29560c6ec36bf5c01c81c544f38024b6c","unresolved":false,"context_lines":[{"line_number":578,"context_line":"    @mock.patch(NEUTRON_UTILS + \"NeutronScenario.generate_random_name\")"},{"line_number":579,"context_line":"    def test_create_security_group(self, mock_generate_random_name):"},{"line_number":580,"context_line":"        neutron_scenario \u003d utils.NeutronScenario(self.context)"},{"line_number":581,"context_line":"        random_name \u003d \"random_name\""},{"line_number":582,"context_line":"        security_group_create_args \u003d {\"description\": \"Fake security group\"}"},{"line_number":583,"context_line":"        expected_security_group \u003d {"},{"line_number":584,"context_line":"            \"security_group\": {\"id\": \"fake-id\","}],"source_content_type":"text/x-python","patch_set":9,"id":"1a26ad4f_b65f9d0d","line":581,"updated":"2015-10-28 11:09:47.000000000","message":"This variable is not necessary. It is ok to use such constant stings directly in tests. (Like done here in line 594)\n\nOf course this is not blocker.","commit_id":"92f1c5d75efe59d81e816364786dd82fbc5c895b"}]}