)]}'
{"rally/verification/tempest/config.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed7cc155af6143839bf17b4e9a5fa0113a71fba0","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        horizon_url \u003d (\"http://\" +"},{"line_number":242,"context_line":"                       parse.urlparse(self.endpoint[\"auth_url\"]).hostname)"},{"line_number":243,"context_line":"        try:"},{"line_number":244,"context_line":"            horizon_req \u003d requests.get(horizon_url, timeout\u003d5)"},{"line_number":245,"context_line":"        except requests.RequestException as e:"},{"line_number":246,"context_line":"            LOG.debug(\"Failed to connect to Horizon: %s\" % e)"},{"line_number":247,"context_line":"            horizon_availability \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_26029170","line":244,"updated":"2015-10-01 22:07:24.000000000","message":"Agree with Andrey, we should avoid magic consts. Lets make it configurable if you don\u0027t mind.","commit_id":"ba81018a1e4d6967b658bffb830605746ffe11e3"},{"author":{"_account_id":15727,"name":"Rafael Chiafarelli","email":"rafael.chiafarelli@gmail.com","username":"rafael-chiafarelli"},"change_message_id":"6148e41c79fe837dce036f890251de31d71deac9","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        try:"},{"line_number":226,"context_line":"            horizon_req \u003d requests.get("},{"line_number":227,"context_line":"                horizon_url,"},{"line_number":228,"context_line":"                timeout\u003dCONF.openstack_client_http_timeout)"},{"line_number":229,"context_line":"        except requests.RequestException as e:"},{"line_number":230,"context_line":"            LOG.debug(\"Failed to connect to Horizon: %s\" % e)"},{"line_number":231,"context_line":"            horizon_availability \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_fac73a43","line":228,"updated":"2015-10-06 11:38:35.000000000","message":"Can´t you create a logic stating \"if horizon is not available set the the http_timeout... else put some standard timeout\"? Because it seams to me that the user will have to configure this variable whether horizon available or not.","commit_id":"8a27449820e016a46e3492bc60dbd78518087eb6"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5c76451807a3beceb773291a55bde803eb639591","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        try:"},{"line_number":226,"context_line":"            horizon_req \u003d requests.get("},{"line_number":227,"context_line":"                horizon_url,"},{"line_number":228,"context_line":"                timeout\u003dCONF.openstack_client_http_timeout)"},{"line_number":229,"context_line":"        except requests.RequestException as e:"},{"line_number":230,"context_line":"            LOG.debug(\"Failed to connect to Horizon: %s\" % e)"},{"line_number":231,"context_line":"            horizon_availability \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_f5f8ab7e","line":228,"in_reply_to":"7a2fa921_fac73a43","updated":"2015-10-06 11:59:48.000000000","message":"\u003eelse put some standard timeout\" ? Because it seams to me that the user will have to configure this variable whether horizon available or not.\n  \n`openstack_client_http_timeout` option has default value - https://github.com/openstack/rally/blob/master/rally/osclients.py#L30 . Also, this variable is a standart http_timeout :)","commit_id":"8a27449820e016a46e3492bc60dbd78518087eb6"}]}