)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"79d1364068e72aa338156f4f59f45f1e593e6fa7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Endre Karlson \u003cendre.karlson@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-09 20:11:50 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Designate client versioning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I737dabd51fe76e8508564d9ac3d8662019be755a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_96e9a5b9","line":7,"updated":"2015-10-16 21:47:47.000000000","message":"Please write commit message more detail.","commit_id":"eba58c7338d1199a8262f6313ae4b8bd8f123f50"}],"rally/osclients.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1a418d1e8744d9df23910fe391707bb8af91a855","unresolved":false,"context_lines":[{"line_number":361,"context_line":"        dns_api_url \u003d kc.service_catalog.url_for("},{"line_number":362,"context_line":"            service_type\u003d\"dns\","},{"line_number":363,"context_line":"            endpoint_type\u003dself.endpoint.endpoint_type,"},{"line_number":364,"context_line":"            region_name\u003dself.endpoint.region_name)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        dns_api_url +\u003d \"/v%s\" % version"},{"line_number":367,"context_line":"        token \u003d token_endpoint.Token(dns_api_url, kc.auth_token)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_8ea2424a","line":364,"updated":"2015-10-05 12:39:01.000000000","message":"I got an error http://paste.openstack.org/show/475306/ is it true for you?","commit_id":"500286693c6c6ab5e594ede7bf4200906f04f039"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1a418d1e8744d9df23910fe391707bb8af91a855","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        session \u003d ks_session.Session("},{"line_number":370,"context_line":"            auth\u003dtoken, verify\u003dself.endpoint.insecure)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        if version \u003d\u003d \"1\":"},{"line_number":373,"context_line":"            client \u003d designate.Client(version, session\u003dsession)"},{"line_number":374,"context_line":"        elif version \u003d\u003d \"2\":"},{"line_number":375,"context_line":"            client \u003d designate.Client(version, session\u003dsession)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_eeaade18","line":372,"updated":"2015-10-05 12:39:01.000000000","message":"Is there any possibility to pass version directly to the Client object and not to write if\u0027s.","commit_id":"500286693c6c6ab5e594ede7bf4200906f04f039"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1a418d1e8744d9df23910fe391707bb8af91a855","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        if version \u003d\u003d \"1\":"},{"line_number":373,"context_line":"            client \u003d designate.Client(version, session\u003dsession)"},{"line_number":374,"context_line":"        elif version \u003d\u003d \"2\":"},{"line_number":375,"context_line":"            client \u003d designate.Client(version, session\u003dsession)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        return client"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_6eb6ce8b","line":375,"updated":"2015-10-05 12:39:01.000000000","message":"373 and 375 line are the same.","commit_id":"500286693c6c6ab5e594ede7bf4200906f04f039"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a773af05cff99ae789bda65b3dcf81d5738adb68","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        \"\"\"Return designate client.\"\"\""},{"line_number":354,"context_line":"        kc \u003d self.keystone()"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        from keystoneclient.auth import token_endpoint  # noqa"},{"line_number":357,"context_line":"        from keystoneclient import session as ks_session"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        dns_api_url \u003d kc.service_catalog.url_for("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_278dfed5","line":356,"updated":"2015-10-16 21:03:15.000000000","message":"L356-368 is not only about designateclient. It can be useful for all OpenStack clients, so I prefer to move this code to separate function(something like \"_create_keystone_session\").","commit_id":"eba58c7338d1199a8262f6313ae4b8bd8f123f50"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a773af05cff99ae789bda65b3dcf81d5738adb68","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        session \u003d ks_session.Session("},{"line_number":368,"context_line":"            auth\u003dtoken, verify\u003dself.endpoint.insecure)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        from designateclient import client as designate  # noqa"},{"line_number":371,"context_line":"        client \u003d designate.Client(version, session\u003dsession)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_870e528a","line":370,"updated":"2015-10-16 21:03:15.000000000","message":"imo, this line doesn\u0027t require \"noqa\" \n\nI used \"from designateclient import client\"  import in [*] (see L400) and pep8 job passed.\n\nBtw, I prefer to get [*] merged first, but it doesn\u0027t relate to mark of this patch:)\n\n[*] - https://review.openstack.org/#/c/233727/8/rally/osclients.py","commit_id":"eba58c7338d1199a8262f6313ae4b8bd8f123f50"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"53f943927a8fa58eeb036c010f74cb7b23c961ec","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            region_name\u003dself.endpoint.region_name)"},{"line_number":109,"context_line":"        return api_url"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _get_token_auth(self, endpoint\u003dNone):"},{"line_number":112,"context_line":"        from keystoneclient.auth import token_endpoint"},{"line_number":113,"context_line":"        endpoint \u003d endpoint or self._get_endpoint()"},{"line_number":114,"context_line":"        kc \u003d self.keystone()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_485073d4","line":111,"updated":"2015-10-21 13:18:45.000000000","message":"do we need this method separated from _get_session? Imo, ti would be better to join them.","commit_id":"499b519e5f62b082b80b35902ff319b9d9e68c54"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"53f943927a8fa58eeb036c010f74cb7b23c961ec","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        version \u003d self.get_version(version)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        api_url \u003d self._get_endpoint()"},{"line_number":424,"context_line":"        api_url +\u003d \"/v%s\" % version"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        auth \u003d self._get_token_auth(endpoint\u003dapi_url)"},{"line_number":427,"context_line":"        session \u003d self._get_session(auth\u003dauth)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_28ef37ea","line":424,"updated":"2015-10-21 13:18:45.000000000","message":"also, L423-424 can be moved to self._get_session, so interface of obtaining session object will be much simpler.","commit_id":"499b519e5f62b082b80b35902ff319b9d9e68c54"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"53f943927a8fa58eeb036c010f74cb7b23c961ec","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        auth \u003d self._get_token_auth(endpoint\u003dapi_url)"},{"line_number":427,"context_line":"        session \u003d self._get_session(auth\u003dauth)"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return client.Client(version, session\u003dsession)"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a29b11f_e8a29fad","line":428,"updated":"2015-10-21 13:18:45.000000000","message":"What about adding opt for choose use session or not?","commit_id":"499b519e5f62b082b80b35902ff319b9d9e68c54"}],"tests/unit/test_osclients.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"11edae24203e50a92dee6c0d24aea7a172bc36a2","unresolved":false,"context_lines":[{"line_number":598,"context_line":"            key \u003d \"designate%s\" % {\"version\": \"1\"}"},{"line_number":599,"context_line":"            self.assertEqual(fake_designate, self.clients.cache[key])"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def test_designate_v2(self):"},{"line_number":602,"context_line":"        fake_designate \u003d fakes.FakeDesignateClient()"},{"line_number":603,"context_line":"        mock_designate \u003d mock.Mock()"},{"line_number":604,"context_line":"        mock_designate.client.Client.return_value \u003d fake_designate"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_d695dd32","line":601,"updated":"2015-10-16 21:46:55.000000000","message":"Please rewrite those tests wit usage of ddt module. Here is an example https://github.com/openstack/rally/blob/master/tests/unit/plugins/openstack/scenarios/neutron/test_loadbalancer_v1.py#L36","commit_id":"eba58c7338d1199a8262f6313ae4b8bd8f123f50"}]}