)]}'
{"rally/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"98334e6acc27df3559793f8df75b53731dc29429","unresolved":false,"context_lines":[{"line_number":288,"context_line":"class Verification(object):"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @classmethod"},{"line_number":291,"context_line":"    def verify(cls, deployment, set_name, regex, filename,"},{"line_number":292,"context_line":"               tempest_config, system_wide_install\u003dFalse):"},{"line_number":293,"context_line":"        \"\"\"Start verifying."},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2b6c8807","line":291,"updated":"2015-10-02 09:50:09.000000000","message":"I would prefer better name: \n\n  tests_list","commit_id":"ed3d2bd05cac058288e3d2e18ddc39a892a3ad6a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"d0c8e2ba5f9a54329f9d09bb1e442ce91b561d10","unresolved":false,"context_lines":[{"line_number":288,"context_line":"class Verification(object):"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @classmethod"},{"line_number":291,"context_line":"    def verify(cls, deployment, set_name, regex, filename,"},{"line_number":292,"context_line":"               tempest_config, system_wide_install\u003dFalse):"},{"line_number":293,"context_line":"        \"\"\"Start verifying."},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_4680d346","line":291,"in_reply_to":"9a1a9d01_2b6c8807","updated":"2015-10-02 09:54:15.000000000","message":"What about tests_filename?","commit_id":"ed3d2bd05cac058288e3d2e18ddc39a892a3ad6a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2ef5009ef4ec2770e7a7cea35da96acfca46deab","unresolved":false,"context_lines":[{"line_number":288,"context_line":"class Verification(object):"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @classmethod"},{"line_number":291,"context_line":"    def verify(cls, deployment, set_name, regex, tests_filename,"},{"line_number":292,"context_line":"               tempest_config, system_wide_install\u003dFalse):"},{"line_number":293,"context_line":"        \"\"\"Start verifying."},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_00b16e8f","line":291,"updated":"2015-10-06 08:24:15.000000000","message":"IMHO, tests_filename -\u003e tests_file.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9db683670029804b6e56e5fcb0d57bbd39334e0c","unresolved":false,"context_lines":[{"line_number":288,"context_line":"class Verification(object):"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    @classmethod"},{"line_number":291,"context_line":"    def verify(cls, deployment, set_name, regex, tests_filename,"},{"line_number":292,"context_line":"               tempest_config, system_wide_install\u003dFalse):"},{"line_number":293,"context_line":"        \"\"\"Start verifying."},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_630e2c36","line":291,"in_reply_to":"7a2fa921_00b16e8f","updated":"2015-10-06 08:26:42.000000000","message":"Done.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2ef5009ef4ec2770e7a7cea35da96acfca46deab","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        :param deployment: UUID or name of a deployment."},{"line_number":296,"context_line":"        :param set_name: Valid name of tempest test set."},{"line_number":297,"context_line":"        :param regex: Regular expression of test"},{"line_number":298,"context_line":"        :param tests_filename: Path to file with list of tests"},{"line_number":299,"context_line":"        :param tempest_config: User specified Tempest config file"},{"line_number":300,"context_line":"        :param system_wide_install: Use virtualenv else run tests in local"},{"line_number":301,"context_line":"                                    environment"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_20aeea2e","line":298,"updated":"2015-10-06 08:24:15.000000000","message":"Please, let\u0027s keep consistency.\n\nPath to a file with a list of Tempest tests","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9db683670029804b6e56e5fcb0d57bbd39334e0c","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        :param deployment: UUID or name of a deployment."},{"line_number":296,"context_line":"        :param set_name: Valid name of tempest test set."},{"line_number":297,"context_line":"        :param regex: Regular expression of test"},{"line_number":298,"context_line":"        :param tests_filename: Path to file with list of tests"},{"line_number":299,"context_line":"        :param tempest_config: User specified Tempest config file"},{"line_number":300,"context_line":"        :param system_wide_install: Use virtualenv else run tests in local"},{"line_number":301,"context_line":"                                    environment"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_a32be481","line":298,"in_reply_to":"7a2fa921_20aeea2e","updated":"2015-10-06 08:26:42.000000000","message":"Done.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"}],"rally/cli/commands/verify.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"98334e6acc27df3559793f8df75b53731dc29429","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        list(consts.TempestTestsAPI)))"},{"line_number":50,"context_line":"    @cliutils.args(\"--regex\", dest\u003d\"regex\", type\u003dstr, required\u003dFalse,"},{"line_number":51,"context_line":"                   help\u003d\"Regular expression of test.\")"},{"line_number":52,"context_line":"    @cliutils.args(\"--filename\", dest\u003d\"filename\", type\u003dstr, required\u003dFalse,"},{"line_number":53,"context_line":"                   help\u003d\"Path to a file with a list of Tempest tests\")"},{"line_number":54,"context_line":"    @cliutils.args(\"--tempest-config\", dest\u003d\"tempest_config\", type\u003dstr,"},{"line_number":55,"context_line":"                   required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2b3a48e8","line":52,"updated":"2015-10-02 09:50:09.000000000","message":"maybe tests_list ?","commit_id":"ed3d2bd05cac058288e3d2e18ddc39a892a3ad6a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2ef5009ef4ec2770e7a7cea35da96acfca46deab","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        :param set_name: Name of tempest test set"},{"line_number":70,"context_line":"        :param deployment: UUID or name of a deployment"},{"line_number":71,"context_line":"        :param regex: Regular expression of test"},{"line_number":72,"context_line":"        :param tests_filename: Path to file with list of tests"},{"line_number":73,"context_line":"        :param tempest_config: User specified Tempest config file location"},{"line_number":74,"context_line":"        :param do_use: Use new task as default for future operations"},{"line_number":75,"context_line":"        :param system_wide_install: Use virtualenv else run tests in"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_6072a2e7","line":72,"updated":"2015-10-06 08:24:15.000000000","message":"Please, let\u0027s keep consistency.\n\nPath to a file with a list of Tempest tests","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9db683670029804b6e56e5fcb0d57bbd39334e0c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        :param set_name: Name of tempest test set"},{"line_number":70,"context_line":"        :param deployment: UUID or name of a deployment"},{"line_number":71,"context_line":"        :param regex: Regular expression of test"},{"line_number":72,"context_line":"        :param tests_filename: Path to file with list of tests"},{"line_number":73,"context_line":"        :param tempest_config: User specified Tempest config file location"},{"line_number":74,"context_line":"        :param do_use: Use new task as default for future operations"},{"line_number":75,"context_line":"        :param system_wide_install: Use virtualenv else run tests in"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_0342d83e","line":72,"in_reply_to":"7a2fa921_6072a2e7","updated":"2015-10-06 08:26:42.000000000","message":"Done.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"69035a28d1ee8773f4cc0cc21289667552ff4315","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        if regex and set_name:"},{"line_number":80,"context_line":"            raise exceptions.InvalidArgumentsException("},{"line_number":81,"context_line":"                \"set_name and regex are not compatible\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if tests_file and set_name:"},{"line_number":84,"context_line":"            raise exceptions.InvalidArgumentsException("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_2644b772","line":81,"updated":"2015-10-06 13:12:52.000000000","message":"It is out of scope, but could you please add \u0027Arguments\u0027 at the beginning of the sentence?\n\nArguments set_name and regex are not compatible.","commit_id":"e9dcff79c65d4a4d3cb9f7c00204cf20db245434"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"69035a28d1ee8773f4cc0cc21289667552ff4315","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if tests_file and set_name:"},{"line_number":84,"context_line":"            raise exceptions.InvalidArgumentsException("},{"line_number":85,"context_line":"                \"tests_file and set_name are not compatible\")"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if tests_file and regex:"},{"line_number":88,"context_line":"            raise exceptions.InvalidArgumentsException("}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_4649b38a","line":85,"updated":"2015-10-06 13:12:52.000000000","message":"ditto.","commit_id":"e9dcff79c65d4a4d3cb9f7c00204cf20db245434"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"69035a28d1ee8773f4cc0cc21289667552ff4315","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        if tests_file and regex:"},{"line_number":88,"context_line":"            raise exceptions.InvalidArgumentsException("},{"line_number":89,"context_line":"                \"tests_file and regex are not compatible\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        if not (regex or set_name or tests_file):"},{"line_number":92,"context_line":"            set_name \u003d \"full\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_e65ebf44","line":89,"updated":"2015-10-06 13:12:52.000000000","message":"ditto.","commit_id":"e9dcff79c65d4a4d3cb9f7c00204cf20db245434"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"69035a28d1ee8773f4cc0cc21289667552ff4315","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            return (1)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if tests_file and not os.path.exists(tests_file):"},{"line_number":102,"context_line":"            print(\"File \u0027%s\u0027 with list of tests not found.\" % tests_file)"},{"line_number":103,"context_line":"            return (1)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        verification \u003d api.Verification.verify(deployment, set_name, regex,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a2fa921_0623bbbe","line":102,"updated":"2015-10-06 13:12:52.000000000","message":"I think \"File \u0027%s\u0027 not found\" will be enough :)","commit_id":"e9dcff79c65d4a4d3cb9f7c00204cf20db245434"}],"rally/verification/tempest/tempest.py":[{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"2ef5009ef4ec2770e7a7cea35da96acfca46deab","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            self.verification.set_failed()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def verify(self, set_name, regex, tests_filename):"},{"line_number":395,"context_line":"        self._prepare_and_run(set_name, regex, tests_filename)"},{"line_number":396,"context_line":"        self._save_results()"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_40444673","line":394,"updated":"2015-10-06 08:24:15.000000000","message":"filename -\u003e tests_file.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"9db683670029804b6e56e5fcb0d57bbd39334e0c","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        else:"},{"line_number":392,"context_line":"            self.verification.set_failed()"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def verify(self, set_name, regex, tests_filename):"},{"line_number":395,"context_line":"        self._prepare_and_run(set_name, regex, tests_filename)"},{"line_number":396,"context_line":"        self._save_results()"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_a379a495","line":394,"in_reply_to":"7a2fa921_40444673","updated":"2015-10-06 08:26:42.000000000","message":"Done.","commit_id":"040ccf6d8f5087c9afd1b3eaefb42fb9b9875345"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"23a32f7ff6bdcf6eb6f837bcddd28ad0761655d1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            if set_name in consts.TempestTestsAPI:"},{"line_number":305,"context_line":"                testr_arg \u003d \"tempest.api.%s\" % set_name"},{"line_number":306,"context_line":"            elif tests_file:"},{"line_number":307,"context_line":"                testr_arg \u003d \"--load-list %s\" % os.path.abspath(tests_file)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                testr_arg \u003d set_name or regex"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a29b11f_fa606437","line":307,"updated":"2015-10-20 11:07:18.000000000","message":"this will not work if file name contain spaces or quotes.\n\nthe problem is in line 355 (shell\u003dTrue), so we should fix that peace of code.","commit_id":"64f877ce31292b44a7269c2c45efe700d1e650b0"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"dbaf576e3f29344255c36496019cb9dc1d4ce616","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            if set_name in consts.TempestTestsAPI:"},{"line_number":305,"context_line":"                testr_arg \u003d \"tempest.api.%s\" % set_name"},{"line_number":306,"context_line":"            elif tests_file:"},{"line_number":307,"context_line":"                testr_arg \u003d \"--load-list %s\" % os.path.abspath(tests_file)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                testr_arg \u003d set_name or regex"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a29b11f_7dd524b7","line":307,"in_reply_to":"3a29b11f_40faca76","updated":"2015-10-20 14:29:58.000000000","message":"Yeah, lets fix this first","commit_id":"64f877ce31292b44a7269c2c45efe700d1e650b0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"e941d77884d1c478711a8d9c4c780a06ba94e21e","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            if set_name in consts.TempestTestsAPI:"},{"line_number":305,"context_line":"                testr_arg \u003d \"tempest.api.%s\" % set_name"},{"line_number":306,"context_line":"            elif tests_file:"},{"line_number":307,"context_line":"                testr_arg \u003d \"--load-list %s\" % os.path.abspath(tests_file)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                testr_arg \u003d set_name or regex"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a29b11f_c0f24f6f","line":307,"in_reply_to":"3a29b11f_7dd524b7","updated":"2015-10-20 14:45:58.000000000","message":"Sergey, IMO we can merge this patch right now and fix this issue later :)","commit_id":"64f877ce31292b44a7269c2c45efe700d1e650b0"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"6151eb291d021575c233a2e7eb4f5beda5012b02","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            if set_name in consts.TempestTestsAPI:"},{"line_number":305,"context_line":"                testr_arg \u003d \"tempest.api.%s\" % set_name"},{"line_number":306,"context_line":"            elif tests_file:"},{"line_number":307,"context_line":"                testr_arg \u003d \"--load-list %s\" % os.path.abspath(tests_file)"},{"line_number":308,"context_line":"            else:"},{"line_number":309,"context_line":"                testr_arg \u003d set_name or regex"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a29b11f_40faca76","line":307,"in_reply_to":"3a29b11f_fa606437","updated":"2015-10-20 11:29:18.000000000","message":"I think we should file some bug for this and fix in another patch.","commit_id":"64f877ce31292b44a7269c2c45efe700d1e650b0"}]}
