)]}'
{"rally/api.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b57d0cb2506d22f1d076fe46635f82842958ea57","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                   tempest_config\u003dtempest_config,"},{"line_number":330,"context_line":"                                   system_wide_install\u003dsystem_wide_install)"},{"line_number":331,"context_line":"        if not verifier.is_installed():"},{"line_number":332,"context_line":"            LOG.info(\"Tempest is not installed for the specified deployment.\")"},{"line_number":333,"context_line":"            LOG.info(\"Installing Tempest for deployment: %s\" % deployment_uuid)"},{"line_number":334,"context_line":"            verifier.install()"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_a4d89980","line":332,"updated":"2015-10-04 16:46:13.000000000","message":"using LOG.debug could keep concise here","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"17987258c5ceadc3de5879d20377cc157a2d5e1e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                                   tempest_config\u003dtempest_config,"},{"line_number":330,"context_line":"                                   system_wide_install\u003dsystem_wide_install)"},{"line_number":331,"context_line":"        if not verifier.is_installed():"},{"line_number":332,"context_line":"            LOG.info(\"Tempest is not installed for the specified deployment.\")"},{"line_number":333,"context_line":"            LOG.info(\"Installing Tempest for deployment: %s\" % deployment_uuid)"},{"line_number":334,"context_line":"            verifier.install()"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_5f5064d4","line":332,"in_reply_to":"9a1a9d01_a4d89980","updated":"2015-10-04 19:06:39.000000000","message":"IMHO, info level is more suitable.","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b57d0cb2506d22f1d076fe46635f82842958ea57","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                   system_wide_install\u003dsystem_wide_install)"},{"line_number":331,"context_line":"        if not verifier.is_installed():"},{"line_number":332,"context_line":"            LOG.info(\"Tempest is not installed for the specified deployment.\")"},{"line_number":333,"context_line":"            LOG.info(\"Installing Tempest for deployment: %s\" % deployment_uuid)"},{"line_number":334,"context_line":"            verifier.install()"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        return verifier"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_64e28131","line":333,"updated":"2015-10-04 16:46:13.000000000","message":"would you like add _() for these two logs?","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"fa4512c8d07a6adc3e6391af2edc07368fdd4f6f","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                                   system_wide_install\u003dsystem_wide_install)"},{"line_number":331,"context_line":"        if not verifier.is_installed():"},{"line_number":332,"context_line":"            LOG.info(\"Tempest is not installed for the specified deployment.\")"},{"line_number":333,"context_line":"            LOG.info(\"Installing Tempest for deployment: %s\" % deployment_uuid)"},{"line_number":334,"context_line":"            verifier.install()"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        return verifier"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_84e79511","line":333,"in_reply_to":"9a1a9d01_64e28131","updated":"2015-10-04 17:09:54.000000000","message":"_() only if keeping the info level. debug messages should not be translated.","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"}],"rally/verification/tempest/tempest.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b57d0cb2506d22f1d076fe46635f82842958ea57","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if not os.path.isdir(path_to_venv):"},{"line_number":183,"context_line":"            LOG.info(_(\"No virtual environment for Tempest found... \""},{"line_number":184,"context_line":"                     \"Installing the virtual environment.\"))"},{"line_number":185,"context_line":"            LOG.debug(\"Virtual environment directory: %s\" % path_to_venv)"},{"line_number":186,"context_line":"            required_vers \u003d (2, 7)"},{"line_number":187,"context_line":"            if sys.version_info[:2] !\u003d required_vers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_2477a9a0","line":184,"updated":"2015-10-04 16:46:13.000000000","message":"advice:\n\n    LOG.debug(_(\"No virtual environment for Tempest found.\"))\n    LOG.info(_(\"Installing virtual environment for tempest.\"))","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b57d0cb2506d22f1d076fe46635f82842958ea57","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _initialize_testr(self):"},{"line_number":241,"context_line":"        if not os.path.isdir(self.path(\".testrepository\")):"},{"line_number":242,"context_line":"            LOG.debug(\"Test Repository initialization.\")"},{"line_number":243,"context_line":"            try:"},{"line_number":244,"context_line":"                check_output(\"%s testr init\" % self.venv_wrapper,"},{"line_number":245,"context_line":"                             shell\u003dTrue, cwd\u003dself.path())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_4462ddd9","line":242,"updated":"2015-10-04 16:46:13.000000000","message":"why removing _() here?","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"23217f128fc293acdf065730b0b84281c9b512f5","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def _initialize_testr(self):"},{"line_number":241,"context_line":"        if not os.path.isdir(self.path(\".testrepository\")):"},{"line_number":242,"context_line":"            LOG.debug(\"Test Repository initialization.\")"},{"line_number":243,"context_line":"            try:"},{"line_number":244,"context_line":"                check_output(\"%s testr init\" % self.venv_wrapper,"},{"line_number":245,"context_line":"                             shell\u003dTrue, cwd\u003dself.path())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_9f46fc1f","line":242,"in_reply_to":"9a1a9d01_4462ddd9","updated":"2015-10-04 19:05:41.000000000","message":"_() is not used with debug level.","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"b57d0cb2506d22f1d076fe46635f82842958ea57","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def _clone(self):"},{"line_number":255,"context_line":"        LOG.info(_(\"Please, wait while Tempest is being cloned. \""},{"line_number":256,"context_line":"                 \"This can take a few minutes...\"))"},{"line_number":257,"context_line":"        try:"},{"line_number":258,"context_line":"            subprocess.check_call([\"git\", \"clone\","},{"line_number":259,"context_line":"                                   self.tempest_source,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_64b4c134","line":256,"updated":"2015-10-04 16:46:13.000000000","message":"actually I think the \"This can take a few minutes...\" is redundant","commit_id":"08c6fc3912ab7df58bc6c5ad095829d0049c407a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"17f25eb2606da7914832dffbb7af926a8b4e1d2d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            self.run(testr_arg)"},{"line_number":313,"context_line":"        except subprocess.CalledProcessError:"},{"line_number":314,"context_line":"            LOG.info(_(\"Test set \u0027%s\u0027 has been finished with errors. \""},{"line_number":315,"context_line":"                     \"Check logs for details.\") % set_name)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def run(self, testr_arg\u003dNone, log_file\u003dNone, tempest_conf\u003dNone):"},{"line_number":318,"context_line":"        \"\"\"Launch tempest with given arguments"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_1fd66c27","line":315,"updated":"2015-10-04 19:18:40.000000000","message":"wrong indent here","commit_id":"abbb01567be5077ddf702f921d1e85ebd6db9d5f"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"49f342fcd939273c7f5f2b3e33d4671bf06497d9","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            self.run(testr_arg)"},{"line_number":313,"context_line":"        except subprocess.CalledProcessError:"},{"line_number":314,"context_line":"            LOG.info(_(\"Test set \u0027%s\u0027 has been finished with errors. \""},{"line_number":315,"context_line":"                     \"Check logs for details.\") % set_name)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def run(self, testr_arg\u003dNone, log_file\u003dNone, tempest_conf\u003dNone):"},{"line_number":318,"context_line":"        \"\"\"Launch tempest with given arguments"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_1fbd0cd7","line":315,"in_reply_to":"9a1a9d01_1fd66c27","updated":"2015-10-04 19:22:20.000000000","message":"Hm, why? Pep8 check works for that.","commit_id":"abbb01567be5077ddf702f921d1e85ebd6db9d5f"}]}