)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"50288033e3069017bbd66028ea1e6d5257aa446c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add --json option to \"rally task detailed\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option which show summraized result in json"},{"line_number":10,"context_line":"and refactoring this method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint showing-summarized-result-in-system-readable"},{"line_number":13,"context_line":"Change-Id: Iedceb34fc146ad213dbb5dcf04df5df055e9e615"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a29b11f_23ef98b1","line":10,"updated":"2015-10-20 11:59:10.000000000","message":"Could you refactor method in other patch? It hard to review.","commit_id":"146f5360691406874f01d6da3e984e3250510ed3"}],"rally/cli/commands/task.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"50288033e3069017bbd66028ea1e6d5257aa446c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                json_obj[\"ssrs_results\"] \u003d []"},{"line_number":431,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":432,"context_line":"            # NOTE(hughsaunders): ssrs\u003dscenario specific results"},{"line_number":433,"context_line":"            ssrs \u003d []"},{"line_number":434,"context_line":"            for result in raw:"},{"line_number":435,"context_line":"                data \u003d result[\"scenario_output\"].get(\"data\")"},{"line_number":436,"context_line":"                if data:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_e0d75621","line":433,"updated":"2015-10-20 11:59:10.000000000","message":"ssrs - I think is bad alias for summarize. Maybe _print_ssrs_result \u003d\u003e _print_results_json. And ssrs to something more understandable.","commit_id":"146f5360691406874f01d6da3e984e3250510ed3"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"c63e50b4f042f3f1ea9f5502a7a8f69c8890e6b1","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                json_obj[\"ssrs_results\"] \u003d []"},{"line_number":431,"context_line":"            raw \u003d result[\"data\"][\"raw\"]"},{"line_number":432,"context_line":"            # NOTE(hughsaunders): ssrs\u003dscenario specific results"},{"line_number":433,"context_line":"            ssrs \u003d []"},{"line_number":434,"context_line":"            for result in raw:"},{"line_number":435,"context_line":"                data \u003d result[\"scenario_output\"].get(\"data\")"},{"line_number":436,"context_line":"                if data:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_ba72e5ab","line":433,"updated":"2015-10-20 13:14:57.000000000","message":"ssrs isn\u0027t alias for summarize.\nssrs is scenario specific results which VMTask scenario used.\nSo I think this alias is valid","commit_id":"146f5360691406874f01d6da3e984e3250510ed3"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"50288033e3069017bbd66028ea1e6d5257aa446c","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        ssrs_result \u003d {}"},{"line_number":469,"context_line":"                        for attr_value in zip(headers, row):"},{"line_number":470,"context_line":"                            ssrs_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":471,"context_line":"                        json_obj[\"ssrs_results\"].append(ssrs_result)"},{"line_number":472,"context_line":"                if json_obj is None:"},{"line_number":473,"context_line":"                    print(\"\\nScenario Specific Results\\n\")"},{"line_number":474,"context_line":"                    cliutils.print_list(table_rows,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_434df43c","line":471,"updated":"2015-10-20 11:59:10.000000000","message":"http://paste.openstack.org/show/476846/ at 30 line its not clear what its mean and why its empty","commit_id":"146f5360691406874f01d6da3e984e3250510ed3"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"e56f872750c317755646ed6d6f5c0c891b735b0b","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        ssrs_result \u003d {}"},{"line_number":469,"context_line":"                        for attr_value in zip(headers, row):"},{"line_number":470,"context_line":"                            ssrs_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":471,"context_line":"                        json_obj[\"ssrs_results\"].append(ssrs_result)"},{"line_number":472,"context_line":"                if json_obj is None:"},{"line_number":473,"context_line":"                    print(\"\\nScenario Specific Results\\n\")"},{"line_number":474,"context_line":"                    cliutils.print_list(table_rows,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_0aee28ec","line":471,"in_reply_to":"3a29b11f_434df43c","updated":"2015-10-20 14:05:57.000000000","message":"if you execute benchmark which doesn\u0027t output scenario specific result , ssrs is empty.\nSo this is expected behavior.","commit_id":"146f5360691406874f01d6da3e984e3250510ed3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e2927b9767b3017a4de570b6f4cb03bd1ebe45f9","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                   action\u003d\"store_true\","},{"line_number":286,"context_line":"                   help\u003d\"print detailed information in json format\")"},{"line_number":287,"context_line":"    @envutils.with_default_task_id"},{"line_number":288,"context_line":"    def detailed(self, task_id\u003dNone, iterations_data\u003dFalse, json_format\u003dFalse):"},{"line_number":289,"context_line":"        \"\"\"Display results table."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        :param task_id: Task uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_c7790efe","line":288,"updated":"2015-11-05 02:45:32.000000000","message":"It\u0027s not your fault but this method looks like a mess. Adding --json makes the situation even worse. \n\nI would suggest to the next thing: \n\n  1) Create new API method: rally.api.Task.detailed \n      that will process data and return it as a python object\n\n  2) This method will look like: \n\n     results \u003d api.Task.detailed(uuid)\n\n      if to_json:\n         print json.dumps(results)\n     else:\n         # do the magic with the results\n\n\nNew approach will have 3 benefits: \n\n   - Code will be simpler and overall better (will split processing \u0026 visualization)\n\n   - This is one of blockers to make rally as a service (we should caluldate this data on server side which is rally.api.Task and this method is run on client side) \n\n   - it will be much simpler to test this logic","commit_id":"4df9f0dc3695f284da922f15c6eccc7ae17f0433"}]}
