)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"792f78822d40ecf009ddab674a1b306719e32864","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Boris Pavlovic \u003cboris@pavlovic.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-13 01:31:55 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Gracefull shutdown on CTRL+C or SIGINT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We are changing the default signal handler for sigint during the"},{"line_number":10,"context_line":"time of execution of Engine.run()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a2ca52d_58ca2151","line":7,"updated":"2015-10-13 09:55:19.000000000","message":"Graceful","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"}],"rally/task/engine.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"792f78822d40ecf009ddab674a1b306719e32864","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"@decorator.decorator"},{"line_number":80,"context_line":"def gracefull_shutdown(f, self, *args, **kwargs):"},{"line_number":81,"context_line":"    counter \u003d multiprocessing.Value(\"I\", 0)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def signal_handler(signal, frame):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_b9a53eb6","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":13},"updated":"2015-10-13 09:55:19.000000000","message":"s/gracefull/graceful/","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"44d62f05f917bc345cc2db61356508d206b7fed1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    counter \u003d multiprocessing.Value(\"I\", 0)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def signal_handler(signal, frame):"},{"line_number":84,"context_line":"        with self.lock:"},{"line_number":85,"context_line":"            if counter.value \u003d\u003d 0:"},{"line_number":86,"context_line":"                counter.value +\u003d 1"},{"line_number":87,"context_line":"                LOG.info(\"Task %s is aborted!\" % self.task[\"uuid\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_f65763c8","line":84,"updated":"2015-10-13 18:41:34.000000000","message":"The fact that the decorator depends on the \u0027lock\u0027 attribute on instances of the class that owns the decorated function needs to be well and thoroughly documented. Or removed. I\u0027d favor removal, if possible -- that\u0027s a deeply unintuitive dependency.","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"},{"author":{"_account_id":13609,"name":"Pavel Boldin","email":"pboldin@mirantis.com","username":"pboldin"},"change_message_id":"58dced836b42ed605293350716d2492e9f873ddb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    counter \u003d multiprocessing.Value(\"I\", 0)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def signal_handler(signal, frame):"},{"line_number":84,"context_line":"        with self.lock:"},{"line_number":85,"context_line":"            if counter.value \u003d\u003d 0:"},{"line_number":86,"context_line":"                counter.value +\u003d 1"},{"line_number":87,"context_line":"                LOG.info(\"Task %s is aborted!\" % self.task[\"uuid\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_0c10a7a7","line":84,"in_reply_to":"5a2ca52d_dce4c53c","updated":"2015-10-14 13:56:45.000000000","message":"Just don\u0027t use `decorator` and instantiate a lock inside a wrapper.","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6e99ab6ec0b7c0bb7dc9734752d645ab2780f2bb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    counter \u003d multiprocessing.Value(\"I\", 0)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def signal_handler(signal, frame):"},{"line_number":84,"context_line":"        with self.lock:"},{"line_number":85,"context_line":"            if counter.value \u003d\u003d 0:"},{"line_number":86,"context_line":"                counter.value +\u003d 1"},{"line_number":87,"context_line":"                LOG.info(\"Task %s is aborted!\" % self.task[\"uuid\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_dce4c53c","line":84,"in_reply_to":"5a2ca52d_f65763c8","updated":"2015-10-13 19:48:40.000000000","message":"I will try to remove it.","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"792f78822d40ecf009ddab674a1b306719e32864","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                counter.value +\u003d 1"},{"line_number":87,"context_line":"                LOG.info(\"Task %s is aborted!\" % self.task[\"uuid\"])"},{"line_number":88,"context_line":"                self.task.abort()"},{"line_number":89,"context_line":"                counter.value +\u003d 1"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    original_signal_handler \u003d signal.getsignal(signal.SIGINT)"},{"line_number":92,"context_line":"    signal.signal(signal.SIGINT, signal_handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_9898b96c","line":89,"updated":"2015-10-13 09:55:19.000000000","message":"this line looks redundant","commit_id":"c8d08545e7f3e932c2dd472546492e0eeaf97487"}]}
