)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c4b99cb30cf05361874b8d2e4d628b4b550b7b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert scenarios to optional_action_timer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These were not included in b92b5ab because they were in review when"},{"line_number":10,"context_line":"that change was submitted for review, but merged before it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7c0d996d986e17a0fbb65b8dcd92724a8aba1769"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a2ca52d_68da02ea","line":9,"updated":"2015-10-16 11:33:47.000000000","message":"Plain commit hash is inconvenient, use URL instead (https://github.com/openstack/rally/commit/b92b5ab)","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c4b99cb30cf05361874b8d2e4d628b4b550b7b4","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        This atomic function creates healthmonitor with the provided"},{"line_number":450,"context_line":"        healthmonitor_create_args."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        :param atomic_action: True if this is an atomic action. added"},{"line_number":453,"context_line":"                              and handled by the"},{"line_number":454,"context_line":"                              optional_action_timer() decorator"},{"line_number":455,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_6b6c3c35","line":452,"updated":"2015-10-16 11:33:47.000000000","message":"This :param: should be removed as well","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"c168cac0bd32e3b652e5d1a75444a772972af3e5","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        This atomic function creates healthmonitor with the provided"},{"line_number":450,"context_line":"        healthmonitor_create_args."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        :param atomic_action: True if this is an atomic action. added"},{"line_number":453,"context_line":"                              and handled by the"},{"line_number":454,"context_line":"                              optional_action_timer() decorator"},{"line_number":455,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_1c04f015","line":452,"in_reply_to":"5a2ca52d_4615b7e2","updated":"2015-10-16 12:33:32.000000000","message":"This is how it was done in the original commit (https://github.com/openstack/rally/commit/b92b5ab). This parameter needs to be documented somewhere; we shouldn\u0027t rely on people reading the source and knowing what optional_action_timer() does to know that they can pass atomic_action() to these functions. If you\u0027ve got better ideas of how to handle documenting it I\u0027m all ears, but just removing the documentation isn\u0027t a solution.","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d56b2366d33b0c7df05b27062ddc014d441d417f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        This atomic function creates healthmonitor with the provided"},{"line_number":450,"context_line":"        healthmonitor_create_args."},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"        :param atomic_action: True if this is an atomic action. added"},{"line_number":453,"context_line":"                              and handled by the"},{"line_number":454,"context_line":"                              optional_action_timer() decorator"},{"line_number":455,"context_line":"        :param healthmonitor_create_args: dict, POST /lb/healthmonitors"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_4615b7e2","line":452,"in_reply_to":"5a2ca52d_6b6c3c35","updated":"2015-10-16 11:38:56.000000000","message":"This looks strange to declare a param that can be used by a decorator only (decorators are something optional).\n\nAlso, if we remove decorator - this param will become a part of `healthmonitor_create_args\u0027 - this looks not normal to create health_monitor with strange parameter `atomic_action\u0027","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"}],"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c4b99cb30cf05361874b8d2e4d628b4b550b7b4","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        :param address: The ip address or FloatingIP to add to the instance"},{"line_number":560,"context_line":"        :param fixed_address: The fixedIP address the FloatingIP is to be"},{"line_number":561,"context_line":"               associated with (optional)"},{"line_number":562,"context_line":"        :param atomic_action: True if this is an atomic action. added"},{"line_number":563,"context_line":"                              and handled by the"},{"line_number":564,"context_line":"                              optional_action_timer() decorator"},{"line_number":565,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_abd334d4","line":562,"updated":"2015-10-16 11:33:47.000000000","message":"This param is unused - remove it","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7c4b99cb30cf05361874b8d2e4d628b4b550b7b4","unresolved":false,"context_lines":[{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        :param server: The :class:`Server` to add an IP to."},{"line_number":578,"context_line":"        :param address: The ip address or FloatingIP to remove"},{"line_number":579,"context_line":"        :param atomic_action: True if this is an atomic action. added"},{"line_number":580,"context_line":"                              and handled by the"},{"line_number":581,"context_line":"                              optional_action_timer() decorator"},{"line_number":582,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_6b5d1c46","line":579,"updated":"2015-10-16 11:33:47.000000000","message":"Same here - remove param description","commit_id":"f09b1a57d7587c82156a195102f4d8cca2d7ad0f"}]}