)]}'
{"rally/plugins/common/runners/rps.py":[{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f9dc5374b7854a897393be8fdb8eb9eee306ae1b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":178,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":179,"context_line":"                       \"minus rps min.\")"},{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_f2524f34","line":182,"range":{"start_line":180,"start_character":0,"end_line":182,"end_character":40},"updated":"2015-11-28 07:47:48.000000000","message":"redundant?","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e724ffd00ae8574af4baab7559099a18975f706e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                       \"minus rps min.\")"},{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_e7c84657","line":182,"in_reply_to":"9a8ffd7b_f2524f34","updated":"2015-11-29 12:50:40.000000000","message":"yes. Its true","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f9dc5374b7854a897393be8fdb8eb9eee306ae1b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":186,"context_line":"                       \"with difference equal to step.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_d22e2ba4","line":183,"updated":"2015-11-28 07:47:48.000000000","message":"Do you like ignore config[\"times\"] here? If it checks this here, operators have to calculate them in his mind first...","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1adbd4b5be0a7d39ff55b75a4f11b51b48391223","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":186,"context_line":"                       \"with difference equal to step.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_e73da62b","line":183,"in_reply_to":"9a8ffd7b_07fd4a6d","updated":"2015-11-29 12:51:48.000000000","message":"I will add help message here about nearest proper `times` value.","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e724ffd00ae8574af4baab7559099a18975f706e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":186,"context_line":"                       \"with difference equal to step.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_07fd4a6d","line":183,"in_reply_to":"9a8ffd7b_d22e2ba4","updated":"2015-11-29 12:50:40.000000000","message":"Yes. We are design so. Its true. we want operators to calculate it in his mind.","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"032a6b1ca226fe853738e974a2726e197367d544","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":181,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":182,"context_line":"                       \"minus rps min.\")"},{"line_number":183,"context_line":"            elif progression_sum !\u003d config[\"times\"]:"},{"line_number":184,"context_line":"                msg \u003d (\"times should be equal to the sum of \""},{"line_number":185,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":186,"context_line":"                       \"with difference equal to step.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_36ab55d8","line":183,"in_reply_to":"9a8ffd7b_e73da62b","updated":"2015-12-02 03:35:04.000000000","message":"no problem","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f9dc5374b7854a897393be8fdb8eb9eee306ae1b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        min_rps \u003d max_rps \u003d step \u003d 0"},{"line_number":217,"context_line":"        if type(self.config[\"rps\"]) is dict:"},{"line_number":218,"context_line":"            min_rps \u003d self.config[\"rps\"][\"min\"]"},{"line_number":219,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":220,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_b5883172","line":217,"updated":"2015-11-28 07:47:48.000000000","message":"isinstance","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e724ffd00ae8574af4baab7559099a18975f706e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        min_rps \u003d max_rps \u003d step \u003d 0"},{"line_number":217,"context_line":"        if type(self.config[\"rps\"]) is dict:"},{"line_number":218,"context_line":"            min_rps \u003d self.config[\"rps\"][\"min\"]"},{"line_number":219,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":220,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_87c37a37","line":217,"in_reply_to":"9a8ffd7b_b5883172","updated":"2015-11-29 12:50:40.000000000","message":"ok","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"f9dc5374b7854a897393be8fdb8eb9eee306ae1b","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":225,"context_line":"            if type(self.config[\"rps\"]) is dict:"},{"line_number":226,"context_line":"                times \u003d rps"},{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                rps \u003d self.config[\"rps\"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_d56135d4","line":225,"updated":"2015-11-28 07:47:48.000000000","message":"using isinstance() is more pythonic ;)","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e724ffd00ae8574af4baab7559099a18975f706e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":225,"context_line":"            if type(self.config[\"rps\"]) is dict:"},{"line_number":226,"context_line":"                times \u003d rps"},{"line_number":227,"context_line":"            else:"},{"line_number":228,"context_line":"                rps \u003d self.config[\"rps\"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_47e032cd","line":225,"in_reply_to":"9a8ffd7b_d56135d4","updated":"2015-11-29 12:50:40.000000000","message":"ok","commit_id":"030bcbeb941b8712e07f7be46e732ccfefa7cc72"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    }"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @staticmethod"},{"line_number":165,"context_line":"    def validate_config_values(config):"},{"line_number":166,"context_line":"        \"\"\"Validates runner\u0027s part of task config.\"\"\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if type(config[\"rps\"]) is dict:"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_0981e1c2","line":165,"updated":"2015-12-14 15:44:08.000000000","message":"In all the error messages in this function, please s/should/must/. Cf. https://www.ietf.org/rfc/rfc2119.txt","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"68ea4dbb94caf29ff7b3268a8bb6aebdd087d74d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    }"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    @staticmethod"},{"line_number":165,"context_line":"    def validate_config_values(config):"},{"line_number":166,"context_line":"        \"\"\"Validates runner\u0027s part of task config.\"\"\""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if type(config[\"rps\"]) is dict:"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a7b0d38_f1c35287","line":165,"in_reply_to":"7a740942_0981e1c2","updated":"2015-12-29 14:32:03.000000000","message":"Good article for non-native speakers","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                min_rps + max_rps) / 2)"},{"line_number":174,"context_line":"            msg \u003d \"\""},{"line_number":175,"context_line":"            if max_rps \u003c min_rps:"},{"line_number":176,"context_line":"                msg \u003d \"rps max value shouldn\u0027t be less that rps min value.\""},{"line_number":177,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":178,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":179,"context_line":"                       \"minus rps min.\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_c9d3d902","line":176,"updated":"2015-12-14 15:44:08.000000000","message":"s/less that/less than/","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"68ea4dbb94caf29ff7b3268a8bb6aebdd087d74d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                min_rps + max_rps) / 2)"},{"line_number":174,"context_line":"            msg \u003d \"\""},{"line_number":175,"context_line":"            if max_rps \u003c min_rps:"},{"line_number":176,"context_line":"                msg \u003d \"rps max value shouldn\u0027t be less that rps min value.\""},{"line_number":177,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":178,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":179,"context_line":"                       \"minus rps min.\")"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a7b0d38_315a3a2b","line":176,"in_reply_to":"7a740942_c9d3d902","updated":"2015-12-29 14:32:03.000000000","message":"Done","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":183,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":184,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":185,"context_line":"                       % progression_sum)"},{"line_number":186,"context_line":"            if msg:"},{"line_number":187,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_e93c9530","line":185,"updated":"2015-12-14 15:44:08.000000000","message":"If \u0027times\u0027 only has one possible valid value, why does the user have to configure it at all? It should be automatically determined.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"68ea4dbb94caf29ff7b3268a8bb6aebdd087d74d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":183,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":184,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":185,"context_line":"                       % progression_sum)"},{"line_number":186,"context_line":"            if msg:"},{"line_number":187,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a7b0d38_f4dca074","line":185,"in_reply_to":"7a740942_b7ffc332","updated":"2015-12-29 14:32:03.000000000","message":"I will left this and talk to Boris about this. Maybe we want to keep this value explicitly in config","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e877e95bf8bc4cf0d530ee81e8a991fb9de0c3d1","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":183,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":184,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":185,"context_line":"                       % progression_sum)"},{"line_number":186,"context_line":"            if msg:"},{"line_number":187,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_b7ffc332","line":185,"in_reply_to":"7a740942_e93c9530","updated":"2015-12-14 17:07:08.000000000","message":"Resonable. Well noticed!","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        :returns: List of results fore each single scenario iteration,"},{"line_number":204,"context_line":"                  where each result is a dictionary"},{"line_number":205,"context_line":"        \"\"\""},{"line_number":206,"context_line":"        RPSScenarioRunner.validate_config_values(self.config)"},{"line_number":207,"context_line":"        times \u003d self.config[\"times\"]"},{"line_number":208,"context_line":"        timeout \u003d self.config.get(\"timeout\", 0)  # 0 means no timeout"},{"line_number":209,"context_line":"        iteration_gen \u003d utils.RAMInt()"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_09cfa129","line":206,"updated":"2015-12-14 15:44:08.000000000","message":"Using \u0027self\u0027 instead of RPSScenarioRunner here is better, both for inheritance and if the name of this class ever changes.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":219,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":224,"context_line":"            if isinstance(self.config[\"rps\"], dict):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_a97a0db8","line":221,"updated":"2015-12-14 15:44:08.000000000","message":"I think this would be better as:\n\n    min_rps \u003d max_rps \u003d self.config[\"rps\"]\n    step \u003d 1\n\nThen you can get rid of the if block in the for loop below that checks (again) if self.config[\"rps\"] is a dict.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"68ea4dbb94caf29ff7b3268a8bb6aebdd087d74d","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":219,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":224,"context_line":"            if isinstance(self.config[\"rps\"], dict):"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a7b0d38_37e0eaf9","line":221,"in_reply_to":"5a710552_79db72ee","updated":"2015-12-29 14:32:03.000000000","message":"I think that our own range() this is not what we must to do. Are you okay if I keep as it is? I can\u0027t I don\u0027t want to create a new big list by hand it might be not good. To check isinstance() on every iteration is not too expensive.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"37924288fd5a70a0b0a3a6b93783b21621764c34","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":219,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":224,"context_line":"            if isinstance(self.config[\"rps\"], dict):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5a710552_79db72ee","line":221,"in_reply_to":"7a740942_5a6006cf","updated":"2015-12-14 20:15:26.000000000","message":":(\n\nThe other thing you could do:\n\n    if isinstance(self.config[\"rps\"], dict):\n        rps_range \u003d range(self.config[\"rps\"][\"min\"], self.config[\"rps\"][\"max\"], self.config[\"rps\"].get(\"step\", 1))\n    else:\n        rps_range \u003d [self.config[\"rps\"]]\n\n    for rps in rps_range:\n        ...\n\nI wonder if we want to consider writing a custom range()-like function that accepts floats, though, since surely if specifying a floating-point RPS is a valid use case, then specifying a floating-point min or max RPS should be valid, as well.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e877e95bf8bc4cf0d530ee81e8a991fb9de0c3d1","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            max_rps \u003d self.config[\"rps\"][\"max\"]"},{"line_number":219,"context_line":"            step \u003d self.config[\"rps\"].get(\"step\", 1)"},{"line_number":220,"context_line":"        else:"},{"line_number":221,"context_line":"            min_rps \u003d max_rps \u003d step \u003d 1"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        for rps in range(min_rps, max_rps + 1, step):"},{"line_number":224,"context_line":"            if isinstance(self.config[\"rps\"], dict):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_5a6006cf","line":221,"in_reply_to":"7a740942_a97a0db8","updated":"2015-12-14 17:07:08.000000000","message":"I agree that its better. But we can\u0027t do like this. Look at results of 12th patchset. The main reason because range() doesn\u0027t work with float.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"ef9dc7769583858fdc819fd7fc0497b911d7f403","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    {"},{"line_number":147,"context_line":"                        \"type\": \"object\","},{"line_number":148,"context_line":"                        \"properties\": {"},{"line_number":149,"context_line":"                            \"min\": {"},{"line_number":150,"context_line":"                                \"type\": \"number\","},{"line_number":151,"context_line":"                                \"minimum\": 1"},{"line_number":152,"context_line":"                            },"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a68dd71_bfa9c292","line":149,"range":{"start_line":149,"start_character":35,"end_line":149,"end_character":36},"updated":"2016-01-26 11:36:41.000000000","message":"Pls consider \u0027from\u0027 and \u0027to\u0027 or \u0027start\u0027 and \u0027end\u0027 instead of \u0027min\u0027 and \u0027max\u0027, because \u0027min\u0027 and \u0027max\u0027 are pretty much about comparison, not counting.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"85d4bc3de66cdebdc101088d75bc632950ff6b65","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    {"},{"line_number":147,"context_line":"                        \"type\": \"object\","},{"line_number":148,"context_line":"                        \"properties\": {"},{"line_number":149,"context_line":"                            \"min\": {"},{"line_number":150,"context_line":"                                \"type\": \"number\","},{"line_number":151,"context_line":"                                \"minimum\": 1"},{"line_number":152,"context_line":"                            },"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_c2b73638","line":149,"range":{"start_line":149,"start_character":35,"end_line":149,"end_character":36},"in_reply_to":"9a68dd71_bfa9c292","updated":"2016-09-26 15:12:40.000000000","message":"+1 \nTerms `MIN and MAX` say that there is a set of numbers where minimum number is MIN and maximum is MAX, but it says nothing about order. \n\n`start and end` is more suitable.\n\nAs for me, min and max can mean that load will be \"random\" with limits MIN and MAX\n\nAlso, `start and end` allows to simulate decreasing load.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed00c66e23cfa56e6170ed26c72abac314c8f2e9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                    {"},{"line_number":147,"context_line":"                        \"type\": \"object\","},{"line_number":148,"context_line":"                        \"properties\": {"},{"line_number":149,"context_line":"                            \"min\": {"},{"line_number":150,"context_line":"                                \"type\": \"number\","},{"line_number":151,"context_line":"                                \"minimum\": 1"},{"line_number":152,"context_line":"                            },"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_8a9d81be","line":149,"range":{"start_line":149,"start_character":35,"end_line":149,"end_character":36},"in_reply_to":"9a68dd71_bfa9c292","updated":"2016-02-29 11:34:24.000000000","message":"I\u0027d like more `min` and `max`. Min load, max load...\n\nIn our case this is like upper and lower bound of the function. `Min` and `max` are more standard names for upper and lower bound of the function.\n\nAlso in other patches we will add here more difficult function of changes `rps` values then arithmetic progression and `min` `max` would be more suitable for them.\n\n`min` and `max` are mathematics terms and `from` `to` are not. I like mathematics\u003d)","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"ef9dc7769583858fdc819fd7fc0497b911d7f403","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if max_rps \u003c min_rps:"},{"line_number":192,"context_line":"                msg \u003d \"rps max value must not be less than rps min value.\""},{"line_number":193,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":194,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":195,"context_line":"                       \"minus rps min.\")"},{"line_number":196,"context_line":"            elif progression_sum !\u003d self.config[\"times\"]:"},{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""}],"source_content_type":"text/x-python","patch_set":22,"id":"9a68dd71_7ff7ca8c","line":194,"range":{"start_line":194,"start_character":39,"end_line":194,"end_character":40},"updated":"2016-01-26 11:36:41.000000000","message":"I\u0027m not sure it is a good idea. It makes picking proper values too tedious.\nSay, in example (min: 1, max: 20, step: 6} I\u0027d be fine with iterations 1, 7, 13, 19.\nIn cases when you repeat scenario with changing step, the need for changing max could be really annoying.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed00c66e23cfa56e6170ed26c72abac314c8f2e9","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if max_rps \u003c min_rps:"},{"line_number":192,"context_line":"                msg \u003d \"rps max value must not be less than rps min value.\""},{"line_number":193,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":194,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":195,"context_line":"                       \"minus rps min.\")"},{"line_number":196,"context_line":"            elif progression_sum !\u003d self.config[\"times\"]:"},{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_a771a0aa","line":194,"range":{"start_line":194,"start_character":39,"end_line":194,"end_character":40},"in_reply_to":"9a68dd71_7ff7ca8c","updated":"2016-02-29 11:34:24.000000000","message":"This was discussed with Boris to reduce the pain of developer and would be optimized in other patches.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"1dcf4cdd32871dc193ba4850d8770039eaf29ac2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            elif (max_rps - min_rps) % rps_step:"},{"line_number":194,"context_line":"                msg \u003d (\"rps step should be divisor of the rps max \""},{"line_number":195,"context_line":"                       \"minus rps min.\")"},{"line_number":196,"context_line":"            elif progression_sum !\u003d self.config[\"times\"]:"},{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""},{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7af24918_3bd9c9f3","line":196,"updated":"2016-03-04 13:38:40.000000000","message":"It will be difficult for users to synchronize these values manually. Why not omit [\"rps\"][\"max\"] at all and rename \"min\" into \"start\" - this will be much flexible, for example:\n\n AS-IS:\n\n      runner:\n        type: \"rps\"\n        times: 55  # Manual synchronization!\n        rps:\n          min: 1\n          max: 10\n          step: 1\n\n TO-BE:\n\n      runner:\n        type: \"rps\"\n        times: 55\n        rps:\n          start: 1\n          step: 1","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"ef9dc7769583858fdc819fd7fc0497b911d7f403","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""},{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a68dd71_5f73e615","line":200,"range":{"start_line":200,"start_character":63,"end_line":200,"end_character":64},"updated":"2016-01-26 11:36:41.000000000","message":"This seems way too complicated. If given min, max and, optionally, step, you know exactly what \u0027times\u0027 must be equal to, then please don\u0027t make user to do this calculation.\nIt may be not that easy to come up with proper schema, so you may just print a warning that user\u0027s \u0027times\u0027 value is ignored.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed00c66e23cfa56e6170ed26c72abac314c8f2e9","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""},{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_e45d6648","line":200,"range":{"start_line":200,"start_character":63,"end_line":200,"end_character":64},"in_reply_to":"9a68dd71_5f73e615","updated":"2016-02-29 11:34:24.000000000","message":"The idea that I discussed with Boris was to throw the error, to compel users to do calculation of the exact values. Warning is bad from my point of view because because its not obvious how to spread lefted times across runs and to maintain needed `rps`.\nFor me obvious better than hidden(in our case by warning). So I don\u0027t want to allow use to work with warning. I\u0027d better stop user and say \"Sorry, but you need...\"","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"85d4bc3de66cdebdc101088d75bc632950ff6b65","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""},{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_7f043d49","line":200,"range":{"start_line":200,"start_character":63,"end_line":200,"end_character":64},"in_reply_to":"9a68dd71_5f73e615","updated":"2016-09-26 15:12:40.000000000","message":"What about make it simple, allow specifying  \"min, max, step\" or \"min, times, step\" ?\n\nIt should help to eliminate \"wrong\" calculations and simplify configuration.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"6699b9e3ad175471fbb8fa044f5b836126d4f580","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                msg \u003d (\"`times` must be equal to the sum of \""},{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_143d0bc4","line":200,"range":{"start_line":200,"start_character":63,"end_line":200,"end_character":64},"in_reply_to":"9aed3d3a_e45d6648","updated":"2016-02-29 14:24:41.000000000","message":"what about leaving `times` as the max number of sub-jobs here? And it is understandable to raise an error when progression_sum is greater than the `times`","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"9be92a9d3ff3b910ae129cfde0435d4d21eceac6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"fa69d971_5ecd832f","line":201,"updated":"2016-01-11 16:46:24.000000000","message":"This is my only remaining concern with this patch set. Did you have a chance to talk this over with Boris?","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed00c66e23cfa56e6170ed26c72abac314c8f2e9","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                       \"arithmetic progression from rps min to rps max \""},{"line_number":199,"context_line":"                       \"with difference equal to step. For given min, max\""},{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_64f5d655","line":201,"in_reply_to":"fa69d971_5ecd832f","updated":"2016-02-29 11:34:24.000000000","message":"This was fully Boris idea.","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"ed00c66e23cfa56e6170ed26c72abac314c8f2e9","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                       \"and step the proper `times` would be %s\""},{"line_number":201,"context_line":"                       % progression_sum)"},{"line_number":202,"context_line":"            if msg:"},{"line_number":203,"context_line":"                raise exceptions.InvalidTaskException(msg)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def _run_scenario(self, cls, method_name, context, args):"},{"line_number":206,"context_line":"        \"\"\"Runs the specified benchmark scenario with given arguments."}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_07232c57","line":203,"range":{"start_line":203,"start_character":16,"end_line":203,"end_character":21},"updated":"2016-02-29 11:34:24.000000000","message":"@Illia, @Chris also I\u0027m fully like Boris idea firstly to do some working runner with changing `rps` value and then in other patches optimize it. I think that this is optimal for now from the point of proportion efforts/result because the main client for me of this feature is Boris. So: we want to throw an exception, we want to compel use to set exact values of min, max, times... in config.\n\nThank you for review!","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"85d4bc3de66cdebdc101088d75bc632950ff6b65","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        :returns: List of results fore each single scenario iteration,"},{"line_number":220,"context_line":"                  where each result is a dictionary"},{"line_number":221,"context_line":"        \"\"\""},{"line_number":222,"context_line":"        self.validate_config_values()"},{"line_number":223,"context_line":"        times \u003d self.config[\"times\"]"},{"line_number":224,"context_line":"        timeout \u003d self.config.get(\"timeout\", 0)  # 0 means no timeout"},{"line_number":225,"context_line":"        iteration_gen \u003d utils.RAMInt()"}],"source_content_type":"text/x-python","patch_set":22,"id":"5a8bc5a2_bff08592","line":222,"range":{"start_line":222,"start_character":8,"end_line":222,"end_character":37},"updated":"2016-09-26 15:12:40.000000000","message":"it should not be done in \"runtime\". Please, override validate method:\n\n    @staticmethod\n    def validate(config):\n        \"\"\"Validates runner\u0027s part of task config.\"\"\"\n        super(RPSScenarioRunner, RPSScenarioRunner).validate(config)\n        # do extra checking here","commit_id":"d4514c355358c6afdebe6766585ff8643a536bc8"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        rps \u003d rps_cfg"},{"line_number":64,"context_line":"    sleep \u003d 1.0 / rps"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    runner._log_worker_info(times\u003dtimes, rps\u003drps, timeout\u003dtimeout,"},{"line_number":67,"context_line":"                            cls\u003dcls, method_name\u003dmethod_name, args\u003dargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    time.sleep("},{"line_number":70,"context_line":"        (sleep * info[\"processes_counter\"]) / info[\"processes_to_start\"])"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_6d0bcbd6","line":67,"range":{"start_line":66,"start_character":5,"end_line":67,"end_character":72},"updated":"2016-10-20 20:53:47.000000000","message":"you should update this method to accept rps_cfg, since logging only \"start\" value is not much useful.","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a7454ed30a718befd94115c482e1c498d1c7278b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        rps \u003d rps_cfg"},{"line_number":64,"context_line":"    sleep \u003d 1.0 / rps"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    runner._log_worker_info(times\u003dtimes, rps\u003drps, timeout\u003dtimeout,"},{"line_number":67,"context_line":"                            cls\u003dcls, method_name\u003dmethod_name, args\u003dargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    time.sleep("},{"line_number":70,"context_line":"        (sleep * info[\"processes_counter\"]) / info[\"processes_to_start\"])"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_16810d4b","line":67,"range":{"start_line":66,"start_character":5,"end_line":67,"end_character":72},"in_reply_to":"fa6399be_6d0bcbd6","updated":"2016-11-07 23:30:23.000000000","message":"Agree","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                \"type\": \"number\","},{"line_number":160,"context_line":"                                \"minimum\": 1"},{"line_number":161,"context_line":"                            },"},{"line_number":162,"context_line":"                            \"end\": {"},{"line_number":163,"context_line":"                                \"type\": \"number\","},{"line_number":164,"context_line":"                                \"minimum\": 1"},{"line_number":165,"context_line":"                            },"},{"line_number":166,"context_line":"                            \"step\": {"},{"line_number":167,"context_line":"                                \"type\": \"number\","},{"line_number":168,"context_line":"                                \"minimum\": 1"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_029859bf","line":165,"range":{"start_line":162,"start_character":29,"end_line":165,"end_character":30},"updated":"2016-10-20 20:53:47.000000000","message":"L204-205 and L212-217 are only place where end is used. It looks really redundant with \"required\" tag..\nAs for me, we need to skip checks at L212, make \"times\" optional to support next workflow:\n\n- times, start, end are specified\n  * times is not finished while end step is over \u003d\u003d continue to generate load with \"end\" rps till times will be over\n  * times is finished before end step is achieved \u003d\u003d it is normal case. just finish load\n- times, start are specified and end is not \u003d\u003d just equal stairs\n- start and end are specified, while times is not \u003d\u003d calculate times manually\n\nThis workflow can be implemented in following patch, but now \"end\" argument looks redundant for me, so we can remove it at current point","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a7454ed30a718befd94115c482e1c498d1c7278b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                                \"type\": \"number\","},{"line_number":160,"context_line":"                                \"minimum\": 1"},{"line_number":161,"context_line":"                            },"},{"line_number":162,"context_line":"                            \"end\": {"},{"line_number":163,"context_line":"                                \"type\": \"number\","},{"line_number":164,"context_line":"                                \"minimum\": 1"},{"line_number":165,"context_line":"                            },"},{"line_number":166,"context_line":"                            \"step\": {"},{"line_number":167,"context_line":"                                \"type\": \"number\","},{"line_number":168,"context_line":"                                \"minimum\": 1"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_f462d1ac","line":165,"range":{"start_line":162,"start_character":29,"end_line":165,"end_character":30},"in_reply_to":"fa6399be_029859bf","updated":"2016-11-07 23:30:23.000000000","message":"Agree to do that in following patch. This is what an original idea was.\nI can\u0027t remove it in current patch and write all desired stuff in future patch. It should be done in the same patch.\nNow its impossible because calculation of progression sum at other checks in validate need it. Will do in future patch, ok?","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        max_cpu_used \u003d min(cpu_count,"},{"line_number":244,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def runs_per_second(rps_cfg, start_timer, processes_to_start):"},{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_e2e9a5b8","line":246,"range":{"start_line":246,"start_character":50,"end_line":246,"end_character":68},"updated":"2016-10-20 20:53:47.000000000","message":"In context of this function, it should be named as \"number_of_processes\"","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a7454ed30a718befd94115c482e1c498d1c7278b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        max_cpu_used \u003d min(cpu_count,"},{"line_number":244,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def runs_per_second(rps_cfg, start_timer, processes_to_start):"},{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_7655e9c4","line":246,"range":{"start_line":246,"start_character":50,"end_line":246,"end_character":68},"in_reply_to":"fa6399be_e2e9a5b8","updated":"2016-11-07 23:30:23.000000000","message":"Okey)","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"},{"line_number":250,"context_line":"                return rps_cfg"},{"line_number":251,"context_line":"            stage_order \u003d (time.time() - start_timer) / rps_cfg.get("},{"line_number":252,"context_line":"                \"duration\", 1) - 1"},{"line_number":253,"context_line":"            return ((rps_cfg[\"start\"] + rps_cfg[\"step\"] * stage_order) /"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_c29ca110","line":250,"range":{"start_line":250,"start_character":23,"end_line":250,"end_character":30},"updated":"2016-10-20 20:53:47.000000000","message":"you miss division by processes_to_start here, like it was at L185.","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a7454ed30a718befd94115c482e1c498d1c7278b","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"},{"line_number":250,"context_line":"                return rps_cfg"},{"line_number":251,"context_line":"            stage_order \u003d (time.time() - start_timer) / rps_cfg.get("},{"line_number":252,"context_line":"                \"duration\", 1) - 1"},{"line_number":253,"context_line":"            return ((rps_cfg[\"start\"] + rps_cfg[\"step\"] * stage_order) /"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_766c099d","line":250,"range":{"start_line":250,"start_character":23,"end_line":250,"end_character":30},"in_reply_to":"fa6399be_c29ca110","updated":"2016-11-07 23:30:23.000000000","message":"Oh, nice catch!","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        max_cpu_used \u003d min(cpu_count,"},{"line_number":244,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def runs_per_second(rps_cfg, start_timer, processes_to_start):"},{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"},{"line_number":250,"context_line":"                return rps_cfg"},{"line_number":251,"context_line":"            stage_order \u003d (time.time() - start_timer) / rps_cfg.get("},{"line_number":252,"context_line":"                \"duration\", 1) - 1"},{"line_number":253,"context_line":"            return ((rps_cfg[\"start\"] + rps_cfg[\"step\"] * stage_order) /"},{"line_number":254,"context_line":"                    processes_to_start)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        processes_to_start \u003d min(max_cpu_used, times,"},{"line_number":257,"context_line":"                                 self.config.get(\"max_concurrency\", times))"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_c2090186","line":254,"range":{"start_line":246,"start_character":8,"end_line":254,"end_character":39},"updated":"2016-10-20 20:53:47.000000000","message":"we should process here process/worker ID to generate exact rps. Let\u0027s add remainder of the division to the first worker.\n\nor we should convert \u0027(rps_cfg[\"start\"] + rps_cfg[\"step\"] * stage_order)\u0027 to float before division, like it was at L185(rps_per_worker)","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a7454ed30a718befd94115c482e1c498d1c7278b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        max_cpu_used \u003d min(cpu_count,"},{"line_number":244,"context_line":"                           self.config.get(\"max_cpu_count\", cpu_count))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        def runs_per_second(rps_cfg, start_timer, processes_to_start):"},{"line_number":247,"context_line":"            \"\"\"At the given second return desired rps.\"\"\""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            if not isinstance(rps_cfg, dict):"},{"line_number":250,"context_line":"                return rps_cfg"},{"line_number":251,"context_line":"            stage_order \u003d (time.time() - start_timer) / rps_cfg.get("},{"line_number":252,"context_line":"                \"duration\", 1) - 1"},{"line_number":253,"context_line":"            return ((rps_cfg[\"start\"] + rps_cfg[\"step\"] * stage_order) /"},{"line_number":254,"context_line":"                    processes_to_start)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        processes_to_start \u003d min(max_cpu_used, times,"},{"line_number":257,"context_line":"                                 self.config.get(\"max_concurrency\", times))"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a629dbe_769fa95f","line":254,"range":{"start_line":246,"start_character":8,"end_line":254,"end_character":39},"in_reply_to":"fa6399be_c2090186","updated":"2016-11-07 23:30:23.000000000","message":"I get what you mean. Solved","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fbabebb47970a10ac114679a73ae3b168d29457e","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        processes_to_start \u003d min(max_cpu_used, times,"},{"line_number":257,"context_line":"                                 self.config.get(\"max_concurrency\", times))"},{"line_number":258,"context_line":"        times_per_worker, times_overhead \u003d divmod(times,"},{"line_number":259,"context_line":"                                                  processes_to_start)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        # Determine concurrency per worker"},{"line_number":262,"context_line":"        concurrency_per_worker, concurrency_overhead \u003d divmod("}],"source_content_type":"text/x-python","patch_set":26,"id":"fa6399be_cd277710","line":259,"range":{"start_line":258,"start_character":8,"end_line":259,"end_character":69},"updated":"2016-10-20 20:53:47.000000000","message":"NIT: it is unrelated change.","commit_id":"08c38d18314dc7e85012c4ce8dd1abbe804b1728"}],"tests/unit/plugins/common/runners/test_rps.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                exceptions.InvalidTaskException,"},{"line_number":101,"context_line":"                rps.RPSScenarioRunner.validate_config_values, config)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            rps.RPSScenarioRunner.validate_config_values(config)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_rps_parameter_validate_failed(self):"},{"line_number":106,"context_line":"        config \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_7404fc13","line":103,"updated":"2015-12-14 15:44:08.000000000","message":"validate_config_values has several other failure modes that also need to be tested.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e877e95bf8bc4cf0d530ee81e8a991fb9de0c3d1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                exceptions.InvalidTaskException,"},{"line_number":101,"context_line":"                rps.RPSScenarioRunner.validate_config_values, config)"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            rps.RPSScenarioRunner.validate_config_values(config)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_rps_parameter_validate_failed(self):"},{"line_number":106,"context_line":"        config \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_3a317aa2","line":103,"in_reply_to":"7a740942_7404fc13","updated":"2015-12-14 17:07:08.000000000","message":"Ok. Reasonable.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"033ed2c4d92232ce04bbaa6773103dc5f0ede54f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    )"},{"line_number":206,"context_line":"    @ddt.unpack"},{"line_number":207,"context_line":"    @mock.patch(RUNNERS + \"rps.time.sleep\")"},{"line_number":208,"context_line":"    def test__run_scenario(self, mock_sleep, config):"},{"line_number":209,"context_line":"        runner_obj \u003d rps.RPSScenarioRunner(self.task, config)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        runner_obj._run_scenario(fakes.FakeScenario, \"do_it\","}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_b444a446","line":208,"updated":"2015-12-14 15:44:08.000000000","message":"This test is woefully incomplete. If you don\u0027t want to fix it now I guess that\u0027s okay, but we should fix it at some point, since it never actually checks anything like the number of runs per second, which might be important in the runs-per-second runner.","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"68ea4dbb94caf29ff7b3268a8bb6aebdd087d74d","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    )"},{"line_number":206,"context_line":"    @ddt.unpack"},{"line_number":207,"context_line":"    @mock.patch(RUNNERS + \"rps.time.sleep\")"},{"line_number":208,"context_line":"    def test__run_scenario(self, mock_sleep, config):"},{"line_number":209,"context_line":"        runner_obj \u003d rps.RPSScenarioRunner(self.task, config)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        runner_obj._run_scenario(fakes.FakeScenario, \"do_it\","}],"source_content_type":"text/x-python","patch_set":19,"id":"1a7b0d38_a0b49234","line":208,"in_reply_to":"7a740942_3a3c1a92","updated":"2015-12-29 14:32:03.000000000","message":"Lets left this work to another patch. Otherwise I\u0027m risking to merge current patch in a few month)","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e877e95bf8bc4cf0d530ee81e8a991fb9de0c3d1","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    )"},{"line_number":206,"context_line":"    @ddt.unpack"},{"line_number":207,"context_line":"    @mock.patch(RUNNERS + \"rps.time.sleep\")"},{"line_number":208,"context_line":"    def test__run_scenario(self, mock_sleep, config):"},{"line_number":209,"context_line":"        runner_obj \u003d rps.RPSScenarioRunner(self.task, config)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        runner_obj._run_scenario(fakes.FakeScenario, \"do_it\","}],"source_content_type":"text/x-python","patch_set":19,"id":"7a740942_3a3c1a92","line":208,"in_reply_to":"7a740942_b444a446","updated":"2015-12-14 17:07:08.000000000","message":"Oh. Its need a lot of work under tests. I will think how to do test in the simplest way","commit_id":"bbb6e75aa7ee0c8d5cdf572116e922b3e630c576"}]}
