)]}'
{"rally/osclients.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e6ddf0159207654078c0e43416e137f51ceb049b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                          \"for keystoneclient. :)\"))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    @classmethod"},{"line_number":209,"context_line":"    def validate_version(cls, version):"},{"line_number":210,"context_line":"        supported_versions \u003d cls.get_supported_versions()"},{"line_number":211,"context_line":"        if version in supported_versions:"},{"line_number":212,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_034622bf","line":209,"updated":"2015-11-25 18:32:17.000000000","message":"All this is mega complicated.\n\nIf we assume that version is string then version is string.\n\nThen \"2\" !\u003d \"2.0\" and nothing wrong with this.\n\nOr we can use tuples internally.\n\n    \"2\" -\u003e (2, 0)\n    \"2.0\" -\u003e (2, 0)","commit_id":"a78e6f7575730983fb940e1f7868f80b5c9c763b"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"ab91bfda1cda8a67160806aaa10e6c1a8c308cac","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            \"%(url)s.\", vers\u003drequired_version, url\u003durl)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @staticmethod"},{"line_number":231,"context_line":"    def _create_keystone_client(version, **kwargs):"},{"line_number":232,"context_line":"        version \u003d int(version)"},{"line_number":233,"context_line":"        if version \u003c\u003d 2:"},{"line_number":234,"context_line":"            from keystoneclient.v2_0 import client as keystone_v2"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_6b42016a","line":231,"updated":"2015-12-03 10:50:39.000000000","message":"1) Why duplicate name `keystone\u0027 here?\n\n2) Is it really required to move this code into separate method?\n\nThis method is used only once (L252) and can be merged to create_client() without problems with readability","commit_id":"3ae44e7c5fee4f594864605af756c520f37b6043"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cfba31ae74846b442ea69f7c3975218b9ccb7527","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            \"%(url)s.\", vers\u003drequired_version, url\u003durl)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    @staticmethod"},{"line_number":231,"context_line":"    def _create_keystone_client(version, **kwargs):"},{"line_number":232,"context_line":"        version \u003d int(version)"},{"line_number":233,"context_line":"        if version \u003c\u003d 2:"},{"line_number":234,"context_line":"            from keystoneclient.v2_0 import client as keystone_v2"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_f656d128","line":231,"in_reply_to":"9a8ffd7b_6b42016a","updated":"2015-12-03 12:15:52.000000000","message":"Done","commit_id":"3ae44e7c5fee4f594864605af756c520f37b6043"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"b9d4a365eb439526fd707004513aa7ffc1b9a4b2","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        # version is a string object."},{"line_number":103,"context_line":"        # For those clients which doesn\u0027t accept string value(for example"},{"line_number":104,"context_line":"        # zaqarclient), this method should be overridden."},{"line_number":105,"context_line":"        return str(choice)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def get_supported_versions(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_cb42bf68","line":105,"updated":"2015-12-09 17:31:43.000000000","message":"Which of methods above can return not string or None?","commit_id":"095d9d5b266b1a406e9fe14b65cdecbbfc70a7cf"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c00b577fdc54d1eba630c4cb7388156a4f679bf8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        # version is a string object."},{"line_number":103,"context_line":"        # For those clients which doesn\u0027t accept string value(for example"},{"line_number":104,"context_line":"        # zaqarclient), this method should be overridden."},{"line_number":105,"context_line":"        return str(choice)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @classmethod"},{"line_number":108,"context_line":"    def get_supported_versions(cls):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_52d75b23","line":105,"in_reply_to":"7a740942_cb42bf68","updated":"2015-12-10 13:41:21.000000000","message":"swift, ec2 clients do not have default versions(without changes from this patch, keystone doesn\u0027t have too), so `self.choose_version()` will return string \"None\".\n\nAbout string - There are a lot of clients(I mean python clients, not clients classes in this module), which accept both int and string values. To be more user-friendly, it would be nice to accept both int, string values  and then convert them to string.","commit_id":"095d9d5b266b1a406e9fe14b65cdecbbfc70a7cf"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"b9d4a365eb439526fd707004513aa7ffc1b9a4b2","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        return super(OSClient, cls).get(name, namespace)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"@configure(\"keystone\", supported_versions\u003d(\"2\", \"3\"))"},{"line_number":206,"context_line":"class Keystone(OSClient):"},{"line_number":207,"context_line":"    def keystone(self, *args, **kwargs):"},{"line_number":208,"context_line":"        raise exceptions.RallyException(_(\"Method \u0027keystone\u0027 is restricted \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_16254ead","line":205,"updated":"2015-12-09 17:31:43.000000000","message":"There is versions 2.0, 2.1, 3.0, 3.1\n\nWe support only 2.1 and 3.x\n\nThis is impossible with proposed implementation\n\nVersion number is converting to int in code below. Please just don\u0027t do this. Use only strings.\n\nIf we need complex checks in future, we can use objects like sys.version_info","commit_id":"095d9d5b266b1a406e9fe14b65cdecbbfc70a7cf"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c00b577fdc54d1eba630c4cb7388156a4f679bf8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        return super(OSClient, cls).get(name, namespace)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"@configure(\"keystone\", supported_versions\u003d(\"2\", \"3\"))"},{"line_number":206,"context_line":"class Keystone(OSClient):"},{"line_number":207,"context_line":"    def keystone(self, *args, **kwargs):"},{"line_number":208,"context_line":"        raise exceptions.RallyException(_(\"Method \u0027keystone\u0027 is restricted \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_12023370","line":205,"in_reply_to":"7a740942_16254ead","updated":"2015-12-10 13:41:21.000000000","message":"2.X and 3.Y versions are inner version of keystone api.","commit_id":"095d9d5b266b1a406e9fe14b65cdecbbfc70a7cf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"473d20b9ccefff9408a666254c0d3a005814d3c4","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            \"Failed to discover keystone endpoint for \u0027%(vers)s\u0027 version at \""},{"line_number":246,"context_line":"            \"%(url)s.\", vers\u003drequired_version, url\u003dbase_url)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def create_client(self, version\u003dNone):"},{"line_number":249,"context_line":"        \"\"\"Return keystone client.\"\"\""},{"line_number":250,"context_line":"        chosen_version \u003d self.choose_version(version)"},{"line_number":251,"context_line":"        base_url, major_version \u003d self._parse_auth_url()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_6e728ae7","line":248,"range":{"start_line":248,"start_character":28,"end_line":248,"end_character":35},"updated":"2016-01-28 10:52:34.000000000","message":"Since it\u0027s going to be (or it already is?) one of the most used methods of the plugin, could you pls add a description of \u0027version\u0027 param to the docstring? (Including expected type)","commit_id":"b001b977814f9651dd05e2e28328c2e3e5c13aee"}],"tests/unit/test_osclients.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"b763a3cf5a209f04aee968fc077076dfe0ce23c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a740942_c96af9b2","updated":"2015-12-14 15:31:46.000000000","message":"Please add unit tests for the various failure modes of _parse_auth_url() and _discover_endpoint().","commit_id":"b001b977814f9651dd05e2e28328c2e3e5c13aee"}]}
