)]}'
{"rally/api.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"10620779c995fde296ed101fef59519fe3b6bbb9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return int(math.ceil(int1))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        def template_eval(expr):"},{"line_number":193,"context_line":"            return eval(expr, args)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        env.globals.update(min\u003dtemplate_min, max\u003dtemplate_max,"},{"line_number":196,"context_line":"                           round\u003dtemplate_round, ceil\u003dtemplate_ceil,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_ee018e6b","line":193,"updated":"2015-10-20 09:35:21.000000000","message":"I think that its unsafe to add possibility of executing any Python expression on cloud. Possible solution is to use at line 157 http://jinja.pocoo.org/docs/dev/sandbox/","commit_id":"ff0eded63700ee1d2b39689e7d4eb2bebf442c8c"},{"author":{"_account_id":14036,"name":"Julia Varigina","email":"jvarigina@mirantis.com","username":"jvarigina"},"change_message_id":"12b38abd8e498ef986f1ced5427cf28715968c01","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            return int(math.ceil(int1))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        def template_eval(expr):"},{"line_number":193,"context_line":"            return eval(expr, args)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        env.globals.update(min\u003dtemplate_min, max\u003dtemplate_max,"},{"line_number":196,"context_line":"                           round\u003dtemplate_round, ceil\u003dtemplate_ceil,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_0f48682c","line":193,"in_reply_to":"3a29b11f_ee018e6b","updated":"2015-10-20 19:13:06.000000000","message":"OK, I\u0027ll remove eval() until I investigate sandbox vs eval()","commit_id":"ff0eded63700ee1d2b39689e7d4eb2bebf442c8c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"febfb959ca28f07b5b37f8afd372a84813ed6abb","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            import math"},{"line_number":205,"context_line":"            return int(math.ceil(float1))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        env.globals.update({\"min\": template_min, \"max\": template_max,"},{"line_number":208,"context_line":"                           \"ceil\": template_ceil, \"round\": template_round})"},{"line_number":209,"context_line":"        return"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_4efc9eb7","line":207,"updated":"2015-10-23 13:17:30.000000000","message":"I would recommend (this is not critical) to avoid implicit changes. It would be better to return `env\u0027 explicitly (and thus use `env \u003d cls.set_template_functions(env)\u0027 at L159), or even (imo better) do not update anything within this method but return {\"min\": ..., \"max\"... ...} and make update at L159","commit_id":"fbbfbcb4ad52b0fd2a789b5a5bd6f293d6bd11ac"},{"author":{"_account_id":14036,"name":"Julia Varigina","email":"jvarigina@mirantis.com","username":"jvarigina"},"change_message_id":"42095161ef704b7fcc69577bbfc239bc407f91cd","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            import math"},{"line_number":205,"context_line":"            return int(math.ceil(float1))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        env.globals.update({\"min\": template_min, \"max\": template_max,"},{"line_number":208,"context_line":"                           \"ceil\": template_ceil, \"round\": template_round})"},{"line_number":209,"context_line":"        return"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_b407b517","line":207,"in_reply_to":"3a29b11f_4efc9eb7","updated":"2015-10-23 18:31:07.000000000","message":"Good point. Will improve.","commit_id":"fbbfbcb4ad52b0fd2a789b5a5bd6f293d6bd11ac"}]}