)]}'
{"doc/specs/in-progress/improve_scenario_output_charts.rst":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":32,"context_line":"       |                    |"},{"line_number":33,"context_line":"        --------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"To get this chart rendered, each iteration results includes"},{"line_number":36,"context_line":"\"scenario_output\" data:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. code-block::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_9fe4160e","line":35,"updated":"2015-10-27 13:30:51.000000000","message":"Either results-\u003eresult or includes-\u003einclude","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":32,"context_line":"       |                    |"},{"line_number":33,"context_line":"        --------------------"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"To get this chart rendered, each iteration results includes"},{"line_number":36,"context_line":"\"scenario_output\" data:"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. code-block::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_39b93eea","line":35,"in_reply_to":"1a26ad4f_9fe4160e","updated":"2015-10-28 12:11:23.000000000","message":"Done","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":" * \"Additive\" tab for any number of charts created in additive manner"},{"line_number":71,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":72,"context_line":"   (having StackedArea and Pie for first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_7f025a40","line":72,"updated":"2015-10-27 13:30:51.000000000","message":"the first","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":" * \"Additive\" tab for any number of charts created in additive manner"},{"line_number":71,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":72,"context_line":"   (having StackedArea and Pie for first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_d9ce0a83","line":72,"in_reply_to":"1a26ad4f_7f025a40","updated":"2015-10-28 12:11:23.000000000","message":"Done","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   (having StackedArea and Pie for first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"},{"line_number":76,"context_line":"   for first time)."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"Additive\" tab UI sketch:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_bfe792ab","line":75,"updated":"2015-10-27 13:30:51.000000000","message":"\u0027are\u0027 is not needed here","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":72,"context_line":"   (having StackedArea and Pie for first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"},{"line_number":76,"context_line":"   for first time)."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"Additive\" tab UI sketch:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_f9cbc670","line":75,"in_reply_to":"1a26ad4f_bfe792ab","updated":"2015-10-28 12:11:23.000000000","message":"Done","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"},{"line_number":76,"context_line":"   for first time)."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"Additive\" tab UI sketch:"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_5fe2fea0","line":76,"updated":"2015-10-27 13:30:51.000000000","message":"the first","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts are also can have different types (StackedArea and Pie"},{"line_number":76,"context_line":"   for first time)."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"Additive\" tab UI sketch:"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_b9c54e5c","line":76,"in_reply_to":"1a26ad4f_5fe2fea0","updated":"2015-10-28 12:11:23.000000000","message":"Done","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. code-block::"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":" class ChartsMixin(object):"},{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_5248b55b","line":177,"updated":"2015-10-27 13:30:51.000000000","message":"While plural attributive nouns are not against any rules, I believe using singular is much more comfortable both in speech and in code. ChartMixin sounds better. \nBut if you feel strongly against singular, please, let me know, or just ignore my -1","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. code-block::"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":" class ChartsMixin(object):"},{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_d995aa40","line":177,"in_reply_to":"1a26ad4f_5248b55b","updated":"2015-10-28 12:11:23.000000000","message":"This mixin adds ability to process a lot of charts, not single chart, this is important for naming, otherwise this can confuse users.","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"d0341bb8b23354da6f21d6a0d510ec55a3945c10","unresolved":false,"context_lines":[{"line_number":187,"context_line":"     @scenario.configure(charts\u003d[...])."},{"line_number":188,"context_line":"     \"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     def add_charts_values(self, \u003clist charts data\u003e):"},{"line_number":191,"context_line":"         \"\"\"Add iteration values for additive chart.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     def add_complete_chart(self, \u003cdict chart data\u003e):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_d27285ad","line":190,"updated":"2015-10-27 13:30:51.000000000","message":"the same as above, add_chart_values (with chart in singular) looks better.","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c2f744cbc65cc28612883b29a61d9b619879d085","unresolved":false,"context_lines":[{"line_number":187,"context_line":"     @scenario.configure(charts\u003d[...])."},{"line_number":188,"context_line":"     \"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     def add_charts_values(self, \u003clist charts data\u003e):"},{"line_number":191,"context_line":"         \"\"\"Add iteration values for additive chart.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     def add_complete_chart(self, \u003cdict chart data\u003e):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_190c8293","line":190,"in_reply_to":"1a26ad4f_d27285ad","updated":"2015-10-28 12:11:23.000000000","message":"The main question is \"should this method add data about single chart or about all charts?\" - IMO the answer to this question will affect method name. Current proposal is adding data for all charts (argument is a list of charts data), so, I think, better name for that is `add_charts_values\u0027","commit_id":"0f6e9e8edfc57129e8c4dc1ef2a44ba1c0b0bbbf"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4e4ff9400eb1c96a4f8ce92c706eddf35706da7b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":72,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts also can have different types (StackedArea and Pie for"},{"line_number":76,"context_line":"   the first time)."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_d3a487a7","line":74,"updated":"2015-10-29 11:30:55.000000000","message":"Should this tab be optional or displayed for each task? Not sure that this tab is useful, for example, for task boot_and_delete_server.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":71,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":72,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":75,"context_line":"   These charts also can have different types (StackedArea and Pie for"},{"line_number":76,"context_line":"   the first time)."},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_2de8f70f","line":74,"in_reply_to":"1a26ad4f_d3a487a7","updated":"2015-10-29 12:58:46.000000000","message":"Both tabs are optional and will be shown only if having at least 1 chart. This note will be added in next patch set.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4e4ff9400eb1c96a4f8ce92c706eddf35706da7b","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    ..."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Unchanged for backward compatibility and marked as deprecated"},{"line_number":133,"context_line":"    \"scenario_output\": ...,"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # New structure"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_f3c66348","line":132,"updated":"2015-10-29 11:30:55.000000000","message":"How it will be marked?","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    ..."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Unchanged for backward compatibility and marked as deprecated"},{"line_number":133,"context_line":"    \"scenario_output\": ...,"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    # New structure"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_cd12a309","line":132,"in_reply_to":"1a26ad4f_f3c66348","updated":"2015-10-29 12:58:46.000000000","message":"This key will not be filled by data, but if rally generates HTML report from data with \"scenario_output\" filled, then task.processing.plot will show deprecation warning.\n\nThis note will be added in next patch set.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4e4ff9400eb1c96a4f8ce92c706eddf35706da7b","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. code-block::"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":" class ChartsMixin(object):"},{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_7316d3a8","line":177,"updated":"2015-10-29 11:30:55.000000000","message":"Not sure about name of class, methods and docstring. This Mixin doesn\u0027t relate to html reports at all, it is only about storing results data. This data can be displayed in CLI too or can be exported(as you know, this will be implemented soon) in some tests management system.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. code-block::"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":" class ChartsMixin(object):"},{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_4dff73aa","line":177,"in_reply_to":"1a26ad4f_7316d3a8","updated":"2015-10-29 12:58:46.000000000","message":"What about OutputMixin?","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"cb02762e205f080205b3dae20b120c403a98920b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."},{"line_number":181,"context_line":"     They divides on complete (competely created by iteration)"},{"line_number":182,"context_line":"     and additive (got single value from iteration, represents"},{"line_number":183,"context_line":"     statistics for the whole scenario)."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_343b85ed","line":181,"updated":"2015-10-28 13:06:38.000000000","message":"\"competely\" seems typo","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":178,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."},{"line_number":181,"context_line":"     They divides on complete (competely created by iteration)"},{"line_number":182,"context_line":"     and additive (got single value from iteration, represents"},{"line_number":183,"context_line":"     statistics for the whole scenario)."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_89c5803d","line":181,"in_reply_to":"1a26ad4f_343b85ed","updated":"2015-10-29 12:58:46.000000000","message":"Sure, thanks","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"cb02762e205f080205b3dae20b120c403a98920b","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."},{"line_number":181,"context_line":"     They divides on complete (competely created by iteration)"},{"line_number":182,"context_line":"     and additive (got single value from iteration, represents"},{"line_number":183,"context_line":"     statistics for the whole scenario)."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Complete charts can be added at any time, without limitations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_3412a563","line":182,"updated":"2015-10-28 13:06:38.000000000","message":"Sorry, but I cant get what this mean (got single value from iteration .....)","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"     Charts will be displayed in HTML report."},{"line_number":181,"context_line":"     They divides on complete (competely created by iteration)"},{"line_number":182,"context_line":"     and additive (got single value from iteration, represents"},{"line_number":183,"context_line":"     statistics for the whole scenario)."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Complete charts can be added at any time, without limitations."}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_a91cfcc1","line":182,"in_reply_to":"1a26ad4f_3412a563","updated":"2015-10-29 12:58:46.000000000","message":"I will explain this more detailed in next patch set.\n\nThis is actually not `single value\u0027 but values for single X point of chart, so that is simply \"values from iteration\" (in opposite to \"chart from iteration\")","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"cb02762e205f080205b3dae20b120c403a98920b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"     \"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     def add_charts_values(self, \u003clist charts data\u003e):"},{"line_number":191,"context_line":"         \"\"\"Add iteration values for additive chart.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     def add_complete_chart(self, \u003cdict chart data\u003e):"},{"line_number":194,"context_line":"         \"\"\"Add a complete chart.\"\"\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_2f20109b","line":191,"updated":"2015-10-28 13:06:38.000000000","message":"This is the right place to describe what _exactly_ this method receive and return.\n\nAlso it is not clear where this data will be stored.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":188,"context_line":"     \"\"\""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"     def add_charts_values(self, \u003clist charts data\u003e):"},{"line_number":191,"context_line":"         \"\"\"Add iteration values for additive chart.\"\"\""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"     def add_complete_chart(self, \u003cdict chart data\u003e):"},{"line_number":194,"context_line":"         \"\"\"Add a complete chart.\"\"\""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_499688f1","line":191,"in_reply_to":"1a26ad4f_2f20109b","updated":"2015-10-29 12:58:46.000000000","message":"Will done","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"cb02762e205f080205b3dae20b120c403a98920b","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"         # Call add_charts_values() once, with all data for predefined charts,"},{"line_number":223,"context_line":"         # referred by their index in list given to @scenario.configure(...)"},{"line_number":224,"context_line":"         self.add_charts_values("},{"line_number":225,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":226,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_cf695c8d","line":224,"updated":"2015-10-28 13:06:38.000000000","message":"Time spent on self.add_* will be counted too. Is there way to avoid this? Do this outside of scenario context somehow. (Cleanup or some other post-benchmark step)","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"b63cb6db8dadc6f783539704f11c0b51276a2aa1","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"         # Call add_charts_values() once, with all data for predefined charts,"},{"line_number":223,"context_line":"         # referred by their index in list given to @scenario.configure(...)"},{"line_number":224,"context_line":"         self.add_charts_values("},{"line_number":225,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":226,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_614038a6","line":224,"in_reply_to":"1a26ad4f_10d43045","updated":"2015-10-29 14:57:02.000000000","message":"I think that this method should remain being called within the scenario, because is only saves data to some property - that is fast. The problem is not data processing, but data generation, which probably can not be moved outside the scenario.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"359b2ac2de1d11aa9e518b6f67f2772f79ff6754","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"         # Call add_charts_values() once, with all data for predefined charts,"},{"line_number":223,"context_line":"         # referred by their index in list given to @scenario.configure(...)"},{"line_number":224,"context_line":"         self.add_charts_values("},{"line_number":225,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":226,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_10d43045","line":224,"in_reply_to":"1a26ad4f_cf695c8d","updated":"2015-10-29 13:24:07.000000000","message":"However charts that generated completely by iteration will definitely require a lot of time, so I will think about that.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"         # Call add_charts_values() once, with all data for predefined charts,"},{"line_number":223,"context_line":"         # referred by their index in list given to @scenario.configure(...)"},{"line_number":224,"context_line":"         self.add_charts_values("},{"line_number":225,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":226,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_8de34b05","line":224,"in_reply_to":"1a26ad4f_cf695c8d","updated":"2015-10-29 12:58:46.000000000","message":"These methods should only assign data to instance properties, so they should work very fast. I will check this again and add an implementation here as well.","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4e4ff9400eb1c96a4f8ce92c706eddf35706da7b","unresolved":false,"context_lines":[{"line_number":248,"context_line":"-----------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Primary assignee:"},{"line_number":251,"context_line":"  * amaretskiy"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Work Items"},{"line_number":254,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_3387fbd8","line":251,"updated":"2015-10-29 11:30:55.000000000","message":"please, add e-mail here, so everyone interested in this spec will able to contact with you.\n\n    amaretskiy \u003camaretskiy@mirantis.com\u003e","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"46e1f225f90013f613a27e4a31a14e4ba7744a74","unresolved":false,"context_lines":[{"line_number":248,"context_line":"-----------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Primary assignee:"},{"line_number":251,"context_line":"  * amaretskiy"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"Work Items"},{"line_number":254,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_2df237d3","line":251,"in_reply_to":"1a26ad4f_3387fbd8","updated":"2015-10-29 12:58:46.000000000","message":"Will done","commit_id":"b722a077f36fc092031e472670b26212373a5abd"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d44077e44f0a32d17144625714a5d8f11005d970","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":".. code-block::"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_021ce275","line":182,"updated":"2015-10-29 16:16:41.000000000","message":"Btw, why we need separate class? Why not just extend Scenario class?","commit_id":"66b4861ec399d2c0a0c2f1fb6aca5ee3a07987c9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8fdd68407a647fb7b9eeb81a80168e0c851ac4dd","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":".. code-block::"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Charts will be displayed in HTML report."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_36511f0f","line":182,"in_reply_to":"1a26ad4f_021ce275","updated":"2015-10-29 16:20:02.000000000","message":"Because (in close future) any plugin should be able to create output, not only Scenario.","commit_id":"66b4861ec399d2c0a0c2f1fb6aca5ee3a07987c9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d44077e44f0a32d17144625714a5d8f11005d970","unresolved":false,"context_lines":[{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Charts will be displayed in HTML report."},{"line_number":186,"context_line":"     They divides on complete (completely created by iteration)"},{"line_number":187,"context_line":"     and additive (iteration provides a set of values, so chart represents"},{"line_number":188,"context_line":"     statistics for the whole scenario)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_22079e1d","line":185,"updated":"2015-10-29 16:16:41.000000000","message":"please replace `Charts will be displayed in HTML report.` by something that doesn\u0027t contain word \"HTML\" :)","commit_id":"66b4861ec399d2c0a0c2f1fb6aca5ee3a07987c9"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8fdd68407a647fb7b9eeb81a80168e0c851ac4dd","unresolved":false,"context_lines":[{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to create charts."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Charts will be displayed in HTML report."},{"line_number":186,"context_line":"     They divides on complete (completely created by iteration)"},{"line_number":187,"context_line":"     and additive (iteration provides a set of values, so chart represents"},{"line_number":188,"context_line":"     statistics for the whole scenario)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a26ad4f_564cdb6f","line":185,"in_reply_to":"1a26ad4f_22079e1d","updated":"2015-10-29 16:20:02.000000000","message":"Sure","commit_id":"66b4861ec399d2c0a0c2f1fb6aca5ee3a07987c9"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_562364a7","line":3,"updated":"2015-11-06 01:58:47.000000000","message":"where are the rest of comments from this header?","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":1,"context_line":".."},{"line_number":2,"context_line":" This work is licensed under a Creative Commons Attribution 3.0 Unported"},{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_386b7620","line":3,"in_reply_to":"fa80f949_562364a7","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Improvements for scenario output charts"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_96546cff","line":8,"updated":"2015-11-06 01:58:47.000000000","message":"This improvement is just partially related to charts. We are changing actually the output of task format.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Improvements for scenario output charts"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_d877ca00","line":8,"in_reply_to":"fa80f949_96546cff","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Improvements for scenario output charts"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"},{"line_number":12,"context_line":"is poor and not flexible."},{"line_number":13,"context_line":"This specification proposes how this can be significantly improved."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_f6dff866","line":11,"updated":"2015-11-06 01:58:47.000000000","message":"This spec is not about displaying at all. This spec is about providing way to store all required data generated by third party tools (like iperf, hpcc, spec, and so on) as a part of results collected by rally. And only part of this work is related to displaying results.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Improvements for scenario output charts"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"},{"line_number":12,"context_line":"is poor and not flexible."},{"line_number":13,"context_line":"This specification proposes how this can be significantly improved."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_dd38b8f1","line":11,"in_reply_to":"fa80f949_f6dff866","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"},{"line_number":12,"context_line":"is poor and not flexible."},{"line_number":13,"context_line":"This specification proposes how this can be significantly improved."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_d6e2f42e","line":12,"updated":"2015-11-06 01:58:47.000000000","message":"here you should be more precise what is poor and not flexible.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Current implementation of displaying custom data generated by scenario"},{"line_number":12,"context_line":"is poor and not flexible."},{"line_number":13,"context_line":"This specification proposes how this can be significantly improved."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_7d398cf1","line":12,"in_reply_to":"fa80f949_d6e2f42e","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In HTML report, scenario can generate only one chart, with only one type"},{"line_number":19,"context_line":"of StackedArea."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Here is how output data looks in HTML report:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_5644c419","line":18,"updated":"2015-11-06 01:58:47.000000000","message":"Please start from scenario output format. Implementation of displaying results is not so important, like the format.\n\nDisplaying results is used just to show that new format is nice and can be easily visualized.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Problem description"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"In HTML report, scenario can generate only one chart, with only one type"},{"line_number":19,"context_line":"of StackedArea."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Here is how output data looks in HTML report:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_9d3eb0d8","line":18,"in_reply_to":"fa80f949_5644c419","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Proposed change"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The aim having two new tabs in HTML report, instead of current \"Output\" tab."},{"line_number":69,"context_line":"Both tabs are optional and will be shown only if having data."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"These tabs are:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_b66ad07f","line":68,"updated":"2015-11-06 01:58:47.000000000","message":"Please rewrite the spec:\n\nFirst write what changes will be done in format and why. After that how new format will be displayed.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":65,"context_line":"Proposed change"},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"The aim having two new tabs in HTML report, instead of current \"Output\" tab."},{"line_number":69,"context_line":"Both tabs are optional and will be shown only if having data."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"These tabs are:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_5d25a8be","line":68,"in_reply_to":"fa80f949_b66ad07f","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"These tabs are:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":" * \"Additive\" tab for any number of charts created in additive manner"},{"line_number":74,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":75,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_1654fc50","line":73,"updated":"2015-11-06 01:58:47.000000000","message":"the better name is Aggregated","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"These tabs are:"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":" * \"Additive\" tab for any number of charts created in additive manner"},{"line_number":74,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":75,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_33f607d8","line":73,"in_reply_to":"fa80f949_1654fc50","updated":"2015-11-11 11:40:12.000000000","message":"Ok, however this sounds confusing because there is no aggregation","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":74,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":75,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":78,"context_line":"   These charts also can have different types (StackedArea and Pie for"},{"line_number":79,"context_line":"   the first time)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_76c9c825","line":77,"updated":"2015-11-06 01:58:47.000000000","message":"The better name is Detailed","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":74,"context_line":"   (get values from each iteration), with different chart types"},{"line_number":75,"context_line":"   (having StackedArea and Pie for the first time)."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":" * \"Per iteration\" tab displays complete charts generated by iterations."},{"line_number":78,"context_line":"   These charts also can have different types (StackedArea and Pie for"},{"line_number":79,"context_line":"   the first time)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_d36d3b99","line":77,"in_reply_to":"fa80f949_76c9c825","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":83,"context_line":".. code-block::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"          .----------. --------------."},{"line_number":86,"context_line":"          | Additive | Per iteration |"},{"line_number":87,"context_line":"     -----\u0027          \u0027------------------------"},{"line_number":88,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":89,"context_line":"        --------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_568604dc","line":86,"updated":"2015-11-06 01:58:47.000000000","message":"Find any non Rally (and better close to management) team and as do they understand what they can expect inside. They won\u0027t know...\n\nAs well structure is bad. You should have single Tab for \"Scenario Data\"\ninside it we can have two types of data. \n\nAdditive and Per Iteration. As well these names are actually unclear for regular users. Maybe we should make them configurable. Like if person will see: \n\nIPerf Aggregated | I Perf Detailed \n\nit will be much cleaner then just Additive and Per Iteration","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":83,"context_line":".. code-block::"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"          .----------. --------------."},{"line_number":86,"context_line":"          | Additive | Per iteration |"},{"line_number":87,"context_line":"     -----\u0027          \u0027------------------------"},{"line_number":88,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":89,"context_line":"        --------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_38926458","line":86,"in_reply_to":"fa80f949_568604dc","updated":"2015-11-11 11:40:12.000000000","message":"If we make subtabs names configurable then it is not clear where to specify these names - in task config?\n\nMaybe leave them permanent for now within this spec - we can improve this later.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":89,"context_line":"        --------------------"},{"line_number":90,"context_line":"       |                    |"},{"line_number":91,"context_line":"       | StackedArea or Pie |"},{"line_number":92,"context_line":"       |                    |"},{"line_number":93,"context_line":"        --------------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_5612840a","line":91,"updated":"2015-11-06 01:58:47.000000000","message":"IMHO we must not block users to have any type of custom graphs, text tables or anything else here.\n\nsame for all other places.\n\nThat\u0027s the whole point of changing related to reports.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":89,"context_line":"        --------------------"},{"line_number":90,"context_line":"       |                    |"},{"line_number":91,"context_line":"       | StackedArea or Pie |"},{"line_number":92,"context_line":"       |                    |"},{"line_number":93,"context_line":"        --------------------"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_58e888b4","line":91,"in_reply_to":"fa80f949_5612840a","updated":"2015-11-11 11:40:12.000000000","message":"It\u0027s time to split frontend code that draws charts into `widgets\u0027 - this is the only reasonable way to control how to display data and make this control pluggable","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d94b5fd4ca37d41e6ba34a3d9d812bb42479b067","unresolved":false,"context_lines":[{"line_number":97,"context_line":"       |                    |"},{"line_number":98,"context_line":"       | StackedArea or Pie |"},{"line_number":99,"context_line":"       |                    |"},{"line_number":100,"context_line":"        --------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"       [... more charts]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_ab628bab","line":100,"updated":"2015-10-30 13:44:20.000000000","message":"Its good to have ability like \"X charts per page\". And search by name in case of many.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"806f118da7b7b0946f70a0a5304f21c49ffc1733","unresolved":false,"context_lines":[{"line_number":97,"context_line":"       |                    |"},{"line_number":98,"context_line":"       | StackedArea or Pie |"},{"line_number":99,"context_line":"       |                    |"},{"line_number":100,"context_line":"        --------------------"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"       [... more charts]"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_57f9f5c5","line":100,"in_reply_to":"1a26ad4f_ab628bab","updated":"2015-11-02 12:14:42.000000000","message":"I can not imagine that scenario can generate so many charts to split them on pages","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d94b5fd4ca37d41e6ba34a3d9d812bb42479b067","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          .--------- .--------------."},{"line_number":109,"context_line":"          | Additive | Per iteration |"},{"line_number":110,"context_line":"     -----\u0027----------\u0027               \u0027----"},{"line_number":111,"context_line":"      1 2 3 4 [5] 6 7 8 9 10"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":114,"context_line":"        --------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_0b74df65","line":111,"updated":"2015-10-30 13:44:20.000000000","message":"I think its better to make here drop down list(as for me more friendly) with possibility to input number (for a lot of iterations).","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"806f118da7b7b0946f70a0a5304f21c49ffc1733","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          .--------- .--------------."},{"line_number":109,"context_line":"          | Additive | Per iteration |"},{"line_number":110,"context_line":"     -----\u0027----------\u0027               \u0027----"},{"line_number":111,"context_line":"      1 2 3 4 [5] 6 7 8 9 10"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":114,"context_line":"        --------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_17c4dd5c","line":111,"in_reply_to":"1a26ad4f_0b74df65","updated":"2015-11-02 12:14:42.000000000","message":"Okay","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          .--------- .--------------."},{"line_number":109,"context_line":"          | Additive | Per iteration |"},{"line_number":110,"context_line":"     -----\u0027----------\u0027               \u0027----"},{"line_number":111,"context_line":"      1 2 3 4 [5] 6 7 8 9 10"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":114,"context_line":"        --------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_369d800a","line":111,"in_reply_to":"1a26ad4f_17c4dd5c","updated":"2015-11-06 01:58:47.000000000","message":"I can\u0027t fully agree with this. \n\nFirst of all scenarios that are generating rich data per iteration usually won\u0027t be run thousands times. They will be run just few times. And clicking once on the iteration is simpler then clicking on drop down list and finding the right number. \n\nHowever we can do one of next improvements: \n- Smart list of iterations that will hide some numbers and allow easily to find required iteration. \n\nor \n\n- Do the drop down if amount of iteration is \u003e some_const","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        --------------------"},{"line_number":115,"context_line":"       |                    |"},{"line_number":116,"context_line":"       | StackedArea or Pie |"},{"line_number":117,"context_line":"       |                    |"},{"line_number":118,"context_line":"        --------------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"       \u003cCustom chart title\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_b60170b1","line":117,"updated":"2015-11-06 01:58:47.000000000","message":"same as in line 91","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        --------------------"},{"line_number":115,"context_line":"       |                    |"},{"line_number":116,"context_line":"       | StackedArea or Pie |"},{"line_number":117,"context_line":"       |                    |"},{"line_number":118,"context_line":"        --------------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"       \u003cCustom chart title\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_1d2ba095","line":117,"in_reply_to":"fa80f949_b60170b1","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # This will remain for backward compatibility, but empty."},{"line_number":136,"context_line":"    # However task.processing.plot.plot() will show deprecation warning"},{"line_number":137,"context_line":"    # if this container is processed."},{"line_number":138,"context_line":"    \"scenario_output\": ...,"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # New structure"},{"line_number":141,"context_line":"    \"output\": {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_3697c03b","line":138,"updated":"2015-11-06 01:58:47.000000000","message":"i believe that this should be transferred to additive data by rally as well so we won\u0027t keep code that process scenario output","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    # This will remain for backward compatibility, but empty."},{"line_number":136,"context_line":"    # However task.processing.plot.plot() will show deprecation warning"},{"line_number":137,"context_line":"    # if this container is processed."},{"line_number":138,"context_line":"    \"scenario_output\": ...,"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # New structure"},{"line_number":141,"context_line":"    \"output\": {"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_af92b59d","line":138,"in_reply_to":"fa80f949_3697c03b","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":".. code-block::"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to save output."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Output data divides on complete (completely created by iteration)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_f104e24a","line":182,"updated":"2015-11-06 01:58:47.000000000","message":"This seems very very overdesigned\n\nWe should just add few methods inside scenario base class we won\u0027t use this anywhere else.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"edc9e4100cd19d5a8a37e38e3c580e3decf26354","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":".. code-block::"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":" class OutputMixin(object):"},{"line_number":183,"context_line":"     \"\"\"Customizes Plugin with an ability to save output."},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"     Output data divides on complete (completely created by iteration)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da85f559_1d063f1d","line":182,"in_reply_to":"fa80f949_f104e24a","updated":"2015-11-11 11:40:12.000000000","message":"Done","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d94b5fd4ca37d41e6ba34a3d9d812bb42479b067","unresolved":false,"context_lines":[{"line_number":242,"context_line":"     def foo_scenario(self):"},{"line_number":243,"context_line":"         ..."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_eb688389","line":245,"updated":"2015-10-30 13:44:20.000000000","message":"Could this be added inside decorator? This might reduce number of called functions in the scenario. My suggestion to write something like this:\ndef outer(scenario_func):\n    def inner():\n        print \"add_charts_values\"\n        with Timer() as timer:\n            output \u003d scenario_func()\n            return output, timer\n        print \"add_complete_charts\"\n    return inner\n\n@outer\ndef scenario_func():\n    pass\n\nout, timer \u003d scenario_func()\n\nAnd this timer would be used inside runner as was before.\nhttps://github.com/openstack/rally/blob/master/rally/task/runner.py#L75","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":242,"context_line":"     def foo_scenario(self):"},{"line_number":243,"context_line":"         ..."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_f1fb82bf","line":245,"in_reply_to":"1a26ad4f_77e671b1","updated":"2015-11-06 01:58:47.000000000","message":"this is totally out of the scope of this spec.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"806f118da7b7b0946f70a0a5304f21c49ffc1733","unresolved":false,"context_lines":[{"line_number":242,"context_line":"     def foo_scenario(self):"},{"line_number":243,"context_line":"         ..."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_77e671b1","line":245,"in_reply_to":"1a26ad4f_eb688389","updated":"2015-11-02 12:14:42.000000000","message":"1) decorator requires scenario to return additive values (like it works now), however this spec proposes executing some method, not return something. The idea is to store additive data in some scenario\u0027s property instead\n\n2) Real time of this operation is minimal because it just stores data into property. So we can do not care about extra atomic timings (at least for additive charts)","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"d94b5fd4ca37d41e6ba34a3d9d812bb42479b067","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("},{"line_number":249,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":250,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_6b13130e","line":247,"updated":"2015-10-30 13:44:20.000000000","message":"Agree with Sergey in second patchset.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"806f118da7b7b0946f70a0a5304f21c49ffc1733","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("},{"line_number":249,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":250,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a26ad4f_f77fe1a8","line":247,"in_reply_to":"1a26ad4f_6b13130e","updated":"2015-11-02 12:14:42.000000000","message":"As I responded in patch set 2, we can not move calculation out of scenario method, since this calculation is what actually scenario does.  About saving calculation results - this is just storing data into property, nothing more, so this is immediate action and its time can be ignored","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"5c773aac8cc7f3b0eb2c38f5d98219f929560530","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"         # Call add_additive_output_values() once, with all data for"},{"line_number":246,"context_line":"         # additive charts, referred by their index in list given to"},{"line_number":247,"context_line":"         # @scenario.configure(...)"},{"line_number":248,"context_line":"         self.add_additive_output_values("},{"line_number":249,"context_line":"             [{\"foo key 1\": 12, \"foo key 2\": 34},  # Foo chart"},{"line_number":250,"context_line":"              {\"bar key 1\": 56, \"bar key 2\": 78}]) # Bar chart"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_3124aa5e","line":247,"in_reply_to":"1a26ad4f_f77fe1a8","updated":"2015-11-06 01:58:47.000000000","message":"Imho we should think a bit amount names of methods. \n\nFirst of all they are too long and they are not enough clear that they are standard methods and not implemented somewhwere in utils.","commit_id":"50c10d18f7e9df7fbc764d695a6ed8c0a670f850"}],"doc/specs/in-progress/improve_scenario_output_format.rst":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c0d1e2bccf2dbb97c2a12aac6b9eb6d82473b425","unresolved":false,"context_lines":[{"line_number":269,"context_line":"       Aggregated   Detailed"},{"line_number":270,"context_line":"       ----------"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"       1 2 3 4 [5] 6 7 8 9 10"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"       \u003cCustom chart title\u003e"},{"line_number":275,"context_line":"        ----------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da85f559_66c33858","line":272,"updated":"2015-11-11 11:59:09.000000000","message":"Roman mentioned before that this should be a dropdown bar. I agreed with him, since I know a team which launch keystone scenario with ~2 million iterations.","commit_id":"5808d87db5ab1f9849313b1d38b644ee9d21c9dc"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5e30c3880185dcb3ec03d52f0df7fe7b90ce7ec7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"         if not hasattr(self, \"_complete_output\"):"},{"line_number":172,"context_line":"            self._complete_output \u003d data"},{"line_number":173,"context_line":"         raise RuntimeError(\"add_complete_output() can not be called twice\")"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"         if not hasattr(self, \"_complete_output\"):"},{"line_number":176,"context_line":"           self._complete_output \u003d []"},{"line_number":177,"context_line":"         self._complete_output.append(data)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_33e2f2a0","line":174,"updated":"2015-11-16 09:35:07.000000000","message":"This will never be called","commit_id":"18ad9f9add16388431b35a2d114f654261ed3832"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0fb4948ed2082b713bf399df85d0b329711cf617","unresolved":false,"context_lines":[{"line_number":171,"context_line":"         if not hasattr(self, \"_complete_output\"):"},{"line_number":172,"context_line":"            self._complete_output \u003d data"},{"line_number":173,"context_line":"         raise RuntimeError(\"add_complete_output() can not be called twice\")"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"         if not hasattr(self, \"_complete_output\"):"},{"line_number":176,"context_line":"           self._complete_output \u003d []"},{"line_number":177,"context_line":"         self._complete_output.append(data)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba8a016a_9fdcff47","line":174,"in_reply_to":"ba8a016a_33e2f2a0","updated":"2015-11-16 10:51:58.000000000","message":"Sure. Thanks","commit_id":"18ad9f9add16388431b35a2d114f654261ed3832"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3865c52c9e405a9a819af363537779019013d03b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          \"additive\": ["},{"line_number":108,"context_line":"              # Each iteration duplicates \"title\", \"chart\" and items keys,"},{"line_number":109,"context_line":"              # however this seems to be less evil than keeping aggregated"},{"line_number":110,"context_line":"              # metadata on upper level of task results schema."},{"line_number":111,"context_line":"              # \"chart\" is required by HTML report and should be a name of"},{"line_number":112,"context_line":"              # existent Chart subclass that is responsible for processing"},{"line_number":113,"context_line":"              # and displaying the data"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_ac6187d5","line":110,"updated":"2015-11-20 20:33:45.000000000","message":"Alex, \n\none comment here, the thing that is returned from scenario to engine can be post processed and stored in different way in DB. \n\nBasically we don\u0027t need to repeat information about title, description and type of chart in information of each iteration. \n\nHowever to have simple interface for scenario runner we should return this information from scenario.\n\nEven more we can do the hack, that this data will be send only once to engine.","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"74dd98a175bfe71dab62ad97d8b84a7ff8995cd2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          \"additive\": ["},{"line_number":108,"context_line":"              # Each iteration duplicates \"title\", \"chart\" and items keys,"},{"line_number":109,"context_line":"              # however this seems to be less evil than keeping aggregated"},{"line_number":110,"context_line":"              # metadata on upper level of task results schema."},{"line_number":111,"context_line":"              # \"chart\" is required by HTML report and should be a name of"},{"line_number":112,"context_line":"              # existent Chart subclass that is responsible for processing"},{"line_number":113,"context_line":"              # and displaying the data"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a740942_ba18bf85","line":110,"in_reply_to":"ba8a016a_ac6187d5","updated":"2015-12-04 12:26:07.000000000","message":"I propose to implement this later and out of this spec. This approach will simplify this spec so we will get the feature faster.","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3865c52c9e405a9a819af363537779019013d03b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    if we load task results from file)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  * as you can see, there is no container *output/errors* - that is because"},{"line_number":150,"context_line":"    value of *errors* is not used at all and not required (there is another"},{"line_number":151,"context_line":"    container for errors in iteration results)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"How scenario saves output data"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_ace66742","line":150,"updated":"2015-11-20 20:33:45.000000000","message":"I can\u0027t fully agree on this point. We will need \"error\" block to show that something went wrong during execution.","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"74dd98a175bfe71dab62ad97d8b84a7ff8995cd2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    if we load task results from file)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"  * as you can see, there is no container *output/errors* - that is because"},{"line_number":150,"context_line":"    value of *errors* is not used at all and not required (there is another"},{"line_number":151,"context_line":"    container for errors in iteration results)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"How scenario saves output data"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a740942_b5ff7000","line":150,"in_reply_to":"ba8a016a_ace66742","updated":"2015-12-04 12:26:07.000000000","message":"I will propose changes to this spec with containers for both additive and complete output errors","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3865c52c9e405a9a819af363537779019013d03b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"         if additive:"},{"line_number":173,"context_line":"             self._output[\"additive\"].append(additive)"},{"line_number":174,"context_line":"         if complete:"},{"line_number":175,"context_line":"             self._output[\"complete\"].append(complete)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Here is an example how scenario can save different output:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba8a016a_4c457b15","line":175,"updated":"2015-11-20 20:33:45.000000000","message":"I believe we should have some checks here that data has proper format","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"74dd98a175bfe71dab62ad97d8b84a7ff8995cd2","unresolved":false,"context_lines":[{"line_number":172,"context_line":"         if additive:"},{"line_number":173,"context_line":"             self._output[\"additive\"].append(additive)"},{"line_number":174,"context_line":"         if complete:"},{"line_number":175,"context_line":"             self._output[\"complete\"].append(complete)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Here is an example how scenario can save different output:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"7a740942_755828fb","line":175,"in_reply_to":"ba8a016a_4c457b15","updated":"2015-12-04 12:26:07.000000000","message":"Agreed","commit_id":"f0668a8e52135f768408aa7109e10f64ac8bed96"}]}
