)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"are updated via new context and adding new configured query"},{"line_number":11,"context_line":"parameters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It allow to find a weak places in requesting ceilometer"},{"line_number":14,"context_line":"data and extend count of scenarios which use a ceilometer."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ifbb77915267f7e339ea7adbd9dae34ca59acb78d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da85f559_cffbd577","line":13,"updated":"2015-11-12 14:31:29.000000000","message":"*allow -\u003e allowS","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"are updated via new context and adding new configured query"},{"line_number":11,"context_line":"parameters."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It allow to find a weak places in requesting ceilometer"},{"line_number":14,"context_line":"data and extend count of scenarios which use a ceilometer."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ifbb77915267f7e339ea7adbd9dae34ca59acb78d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da85f559_65e88517","line":13,"in_reply_to":"da85f559_cffbd577","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"}],"etc/rally/rally.conf.sample":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8603d040fabac43aa33952afc8b24bfbc89d35ba","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"# The back end to use for the database. (string value)"},{"line_number":545,"context_line":"# Deprecated group/name - [DEFAULT]/db_backend"},{"line_number":546,"context_line":"#backend \u003d mysql"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"# The SQLAlchemy connection string to use to connect to the database."},{"line_number":549,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a29b11f_7ee63a16","line":546,"updated":"2015-10-21 16:51:51.000000000","message":"How this can be possible? There is a test which is supposed to catch such changes.","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1d9df58448f2dba7d3ab2cf46eed7c4480a226f6","unresolved":false,"context_lines":[{"line_number":543,"context_line":""},{"line_number":544,"context_line":"# The back end to use for the database. (string value)"},{"line_number":545,"context_line":"# Deprecated group/name - [DEFAULT]/db_backend"},{"line_number":546,"context_line":"#backend \u003d mysql"},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"# The SQLAlchemy connection string to use to connect to the database."},{"line_number":549,"context_line":"# (string value)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3a29b11f_f90b44d4","line":546,"in_reply_to":"3a29b11f_7ee63a16","updated":"2015-10-21 17:00:01.000000000","message":"Sorry, I miss this test params. I will delete these changes","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"}],"rally-jobs/rally.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":440,"context_line":"      runner:"},{"line_number":441,"context_line":"         type: constant"},{"line_number":442,"context_line":"         times: 10"},{"line_number":443,"context_line":"         concurrency: 1"},{"line_number":444,"context_line":"      sla:"},{"line_number":445,"context_line":"        failure_rate:"},{"line_number":446,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_cf8c35dc","line":443,"updated":"2015-11-12 14:31:29.000000000","message":"Please increase concurrency to at least 2. To check how it works under concurrency.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":440,"context_line":"      runner:"},{"line_number":441,"context_line":"         type: constant"},{"line_number":442,"context_line":"         times: 10"},{"line_number":443,"context_line":"         concurrency: 1"},{"line_number":444,"context_line":"      sla:"},{"line_number":445,"context_line":"        failure_rate:"},{"line_number":446,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_e5dc7576","line":443,"in_reply_to":"da85f559_cf8c35dc","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":443,"context_line":"         concurrency: 1"},{"line_number":444,"context_line":"      sla:"},{"line_number":445,"context_line":"        failure_rate:"},{"line_number":446,"context_line":"          max: 0"},{"line_number":447,"context_line":"      context:"},{"line_number":448,"context_line":"         users:"},{"line_number":449,"context_line":"           tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_cf7af5bc","line":446,"updated":"2015-11-12 14:31:29.000000000","message":"For consistency better to keep sla section as the last section","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":443,"context_line":"         concurrency: 1"},{"line_number":444,"context_line":"      sla:"},{"line_number":445,"context_line":"        failure_rate:"},{"line_number":446,"context_line":"          max: 0"},{"line_number":447,"context_line":"      context:"},{"line_number":448,"context_line":"         users:"},{"line_number":449,"context_line":"           tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_a5e66d42","line":446,"in_reply_to":"da85f559_cf7af5bc","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":465,"context_line":"         concurrency: 1"},{"line_number":466,"context_line":"      sla:"},{"line_number":467,"context_line":"        failure_rate:"},{"line_number":468,"context_line":"          max: 0"},{"line_number":469,"context_line":"      context:"},{"line_number":470,"context_line":"         users:"},{"line_number":471,"context_line":"           tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_ef7579ca","line":468,"updated":"2015-11-12 14:31:29.000000000","message":"For consistency better to keep sla section as the last section","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":465,"context_line":"         concurrency: 1"},{"line_number":466,"context_line":"      sla:"},{"line_number":467,"context_line":"        failure_rate:"},{"line_number":468,"context_line":"          max: 0"},{"line_number":469,"context_line":"      context:"},{"line_number":470,"context_line":"         users:"},{"line_number":471,"context_line":"           tenants: 1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da85f559_85d48947","line":468,"in_reply_to":"da85f559_ef7579ca","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"}],"rally/plugins/openstack/scenarios/ceilometer/meters.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8603d040fabac43aa33952afc8b24bfbc89d35ba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Check all available queries for list resource request."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        @:param metadata_query: dict with metadata fields and values"},{"line_number":31,"context_line":"        @:param limit: limit of meters in response"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_5ecc9e69","line":30,"updated":"2015-10-21 16:51:51.000000000","message":"Why this \u0027@\u0027 is here? We don\u0027t use it in Rally.","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1d9df58448f2dba7d3ab2cf46eed7c4480a226f6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Check all available queries for list resource request."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        @:param metadata_query: dict with metadata fields and values"},{"line_number":31,"context_line":"        @:param limit: limit of meters in response"},{"line_number":32,"context_line":"        \"\"\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_b9286c34","line":30,"in_reply_to":"3a29b11f_5ecc9e69","updated":"2015-10-21 17:00:01.000000000","message":"Ok, I will refactor it.","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Check all available queries for list resource request."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_0afd4b6d","line":26,"updated":"2015-11-12 14:31:29.000000000","message":"Ceilometer don\u0027t have cleanup. Why we use it here?","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def list_meters(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":28,"context_line":"        \"\"\"Check all available queries for list resource request."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_8e0f9387","line":26,"in_reply_to":"da85f559_0afd4b6d","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":43,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":44,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":45,"context_line":"    def list_matched_meters(self, filter_by_user_id\u003dFalse,"},{"line_number":46,"context_line":"                            filter_by_project_id\u003dFalse,"},{"line_number":47,"context_line":"                            filter_by_resource_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_8af13b97","line":44,"updated":"2015-11-12 14:31:29.000000000","message":"as well as in line 26","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":43,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":44,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":45,"context_line":"    def list_matched_meters(self, filter_by_user_id\u003dFalse,"},{"line_number":46,"context_line":"                            filter_by_project_id\u003dFalse,"},{"line_number":47,"context_line":"                            filter_by_resource_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_2e278713","line":44,"in_reply_to":"da85f559_8af13b97","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"}],"rally/plugins/openstack/scenarios/ceilometer/resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CeilometerResource(ceiloutils.CeilometerScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for Ceilometer Resource API.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _make_timestamp_query(self, start_time\u003dNone, end_time\u003dNone):"},{"line_number":26,"context_line":"        \"\"\"Create ceilometer query for timestamp range."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param start_time: start datetime in isoformat"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_1e34b0f9","line":25,"updated":"2015-11-12 14:31:29.000000000","message":"This should be in utils.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class CeilometerResource(ceiloutils.CeilometerScenario):"},{"line_number":23,"context_line":"    \"\"\"Benchmark scenarios for Ceilometer Resource API.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _make_timestamp_query(self, start_time\u003dNone, end_time\u003dNone):"},{"line_number":26,"context_line":"        \"\"\"Create ceilometer query for timestamp range."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        :param start_time: start datetime in isoformat"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_4e220b03","line":25,"in_reply_to":"da85f559_1e34b0f9","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"}],"rally/plugins/openstack/scenarios/ceilometer/utils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8603d040fabac43aa33952afc8b24bfbc89d35ba","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return {\"field\": field, \"op\": op, \"value\": value}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _make_query(self, metadata_query\u003dNone, need_project_id\u003dNone,"},{"line_number":110,"context_line":"                    need_user_id\u003dNone, start_time\u003dNone, end_time\u003dNone):"},{"line_number":111,"context_line":"        query \u003d []"},{"line_number":112,"context_line":"        metadata_query \u003d metadata_query or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_beea9272","line":109,"updated":"2015-10-21 16:51:51.000000000","message":"We need a unit test for this and the next one. Also it would be nice to add docstrings.","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"1d9df58448f2dba7d3ab2cf46eed7c4480a226f6","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        return {\"field\": field, \"op\": op, \"value\": value}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def _make_query(self, metadata_query\u003dNone, need_project_id\u003dNone,"},{"line_number":110,"context_line":"                    need_user_id\u003dNone, start_time\u003dNone, end_time\u003dNone):"},{"line_number":111,"context_line":"        query \u003d []"},{"line_number":112,"context_line":"        metadata_query \u003d metadata_query or {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_5974b866","line":109,"in_reply_to":"3a29b11f_beea9272","updated":"2015-10-21 17:00:01.000000000","message":"ok, i will make it in next CR","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"8603d040fabac43aa33952afc8b24bfbc89d35ba","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                       if limit else [])"},{"line_number":144,"context_line":"        query_line \u003d \"_\".join("},{"line_number":145,"context_line":"            \"%s%s%s\" % (a[\"field\"],"},{"line_number":146,"context_line":"                        CeilometerScenario.TRANSFORM_OP.get(a[\"op\"], a[\"op\"]),"},{"line_number":147,"context_line":"                        a[\"value\"])"},{"line_number":148,"context_line":"            for a in query + limit_query)"},{"line_number":149,"context_line":"        key \u003d \"%s%s\" % (prefix, ((\":%s\" % query_line) if query_line else \"\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_1e9146f1","line":146,"updated":"2015-10-21 16:51:51.000000000","message":"why not just self.TRANSPORM_OP?","commit_id":"67c94a0820991720550fa4b3277b2598a7f966ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param field: filtered field"},{"line_number":86,"context_line":"        :param op: operator for filtering"},{"line_number":87,"context_line":"        :param value: matched value"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        return {\"field\": field, \"op\": op, \"value\": value}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_e1426d67","line":87,"updated":"2015-11-12 14:31:29.000000000","message":"return should be documented","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param field: filtered field"},{"line_number":86,"context_line":"        :param op: operator for filtering"},{"line_number":87,"context_line":"        :param value: matched value"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        return {\"field\": field, \"op\": op, \"value\": value}"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_ee209ff9","line":87,"in_reply_to":"da85f559_e1426d67","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def _make_general_query(self, filter_by_project_id\u003dNone,"},{"line_number":92,"context_line":"                            filter_by_user_id\u003dNone,"},{"line_number":93,"context_line":"                            filter_by_resource_id\u003dNone,"},{"line_number":94,"context_line":"                            metadata_query\u003dNone):"},{"line_number":95,"context_line":"        query \u003d []"},{"line_number":96,"context_line":"        metadata_query \u003d metadata_query or {}"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_612e7da6","line":94,"updated":"2015-11-12 14:31:29.000000000","message":"Need docs here.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    def _make_general_query(self, filter_by_project_id\u003dNone,"},{"line_number":92,"context_line":"                            filter_by_user_id\u003dNone,"},{"line_number":93,"context_line":"                            filter_by_resource_id\u003dNone,"},{"line_number":94,"context_line":"                            metadata_query\u003dNone):"},{"line_number":95,"context_line":"        query \u003d []"},{"line_number":96,"context_line":"        metadata_query \u003d metadata_query or {}"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_0e1c03c0","line":94,"in_reply_to":"da85f559_612e7da6","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if filter_by_user_id:"},{"line_number":99,"context_line":"            if (not self.context.get(\"user\") or"},{"line_number":100,"context_line":"                    not self.context[\"user\"].get(\"id\")):"},{"line_number":101,"context_line":"                msg \u003d \"Context doesn\u0027t have users for filtration\""},{"line_number":102,"context_line":"                raise exceptions.NotFoundException(msg)"},{"line_number":103,"context_line":"            user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":104,"context_line":"            query.append(self._make_query_item(\"user_id\", \"eq\", user_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_b7110754","line":101,"updated":"2015-11-12 14:31:29.000000000","message":"We always have users https://github.com/openstack/rally/blob/master/rally/task/engine.py#L258 due to this line.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if filter_by_user_id:"},{"line_number":99,"context_line":"            if (not self.context.get(\"user\") or"},{"line_number":100,"context_line":"                    not self.context[\"user\"].get(\"id\")):"},{"line_number":101,"context_line":"                msg \u003d \"Context doesn\u0027t have users for filtration\""},{"line_number":102,"context_line":"                raise exceptions.NotFoundException(msg)"},{"line_number":103,"context_line":"            user_id \u003d self.context[\"user\"][\"id\"]"},{"line_number":104,"context_line":"            query.append(self._make_query_item(\"user_id\", \"eq\", user_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_ae7937fe","line":101,"in_reply_to":"da85f559_b7110754","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if filter_by_project_id or filter_by_resource_id:"},{"line_number":107,"context_line":"            if (not self.context.get(\"tenant\") or"},{"line_number":108,"context_line":"                    not self.context[\"tenant\"].get(\"id\")):"},{"line_number":109,"context_line":"                msg \u003d \"Context doesn\u0027t have tenants for filtration\""},{"line_number":110,"context_line":"                raise exceptions.NotFoundException(msg)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_5733fbf5","line":108,"updated":"2015-11-12 14:31:29.000000000","message":"The same as for line 101","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if filter_by_project_id or filter_by_resource_id:"},{"line_number":107,"context_line":"            if (not self.context.get(\"tenant\") or"},{"line_number":108,"context_line":"                    not self.context[\"tenant\"].get(\"id\")):"},{"line_number":109,"context_line":"                msg \u003d \"Context doesn\u0027t have tenants for filtration\""},{"line_number":110,"context_line":"                raise exceptions.NotFoundException(msg)"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_ce7cbbed","line":108,"in_reply_to":"da85f559_5733fbf5","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                                   project_id))"},{"line_number":116,"context_line":"            if filter_by_resource_id:"},{"line_number":117,"context_line":"                if not self.context[\"tenant\"].get(\"resources\"):"},{"line_number":118,"context_line":"                    msg \u003d \"Context doesn\u0027t have resources for filtration\""},{"line_number":119,"context_line":"                    raise exceptions.NotFoundException(msg)"},{"line_number":120,"context_line":"                resource_id \u003d self.context[\"tenant\"][\"resources\"][0]"},{"line_number":121,"context_line":"                query.append(self._make_query_item(\"resource_id\", \"eq\","}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_77995f78","line":118,"updated":"2015-11-12 14:31:29.000000000","message":"https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/ceilometer/samples.py#L51 https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/ceilometer/samples.py#L88 We always have resources inside tenant","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :param method: Original profiler tag for method"},{"line_number":133,"context_line":"        :param query: ceilometer query which fields will be added to key"},{"line_number":134,"context_line":"        :param limit: if it exists `limit` will be added to key"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        query \u003d query or []"},{"line_number":137,"context_line":"        fields_line \u003d \"\u0026\".join(\"%s\" % a[\"field\"] for a in query)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_3788b770","line":134,"updated":"2015-11-12 14:31:29.000000000","message":"Need to document return value. There is a sense to add default values for parameters.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        :param method: Original profiler tag for method"},{"line_number":133,"context_line":"        :param query: ceilometer query which fields will be added to key"},{"line_number":134,"context_line":"        :param limit: if it exists `limit` will be added to key"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        query \u003d query or []"},{"line_number":137,"context_line":"        fields_line \u003d \"\u0026\".join(\"%s\" % a[\"field\"] for a in query)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_6e834fcd","line":134,"in_reply_to":"da85f559_3788b770","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        query \u003d query or []"},{"line_number":137,"context_line":"        fields_line \u003d \"\u0026\".join(\"%s\" % a[\"field\"] for a in query)"},{"line_number":138,"context_line":"        limit_line \u003d \"limit\" if limit else \"\""},{"line_number":139,"context_line":"        key_identifiers \u003d (limit_line +"},{"line_number":140,"context_line":"                           (\"\u0026\" if limit_line and fields_line else \"\") +"},{"line_number":141,"context_line":"                           fields_line)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_d76b6bef","line":138,"updated":"2015-11-12 14:31:29.000000000","message":"limit_line \u003d limit and \"limit\" or \"\" is more pythonic","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        query \u003d query or []"},{"line_number":137,"context_line":"        fields_line \u003d \"\u0026\".join(\"%s\" % a[\"field\"] for a in query)"},{"line_number":138,"context_line":"        limit_line \u003d \"limit\" if limit else \"\""},{"line_number":139,"context_line":"        key_identifiers \u003d (limit_line +"},{"line_number":140,"context_line":"                           (\"\u0026\" if limit_line and fields_line else \"\") +"},{"line_number":141,"context_line":"                           fields_line)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_2e6ea72f","line":138,"in_reply_to":"da85f559_d76b6bef","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                           (\"\u0026\" if limit_line and fields_line else \"\") +"},{"line_number":141,"context_line":"                           fields_line)"},{"line_number":142,"context_line":"        key \u003d \"%s%s\" % (method, ((\":%s\" % key_identifiers)"},{"line_number":143,"context_line":"                                 if key_identifiers else \"\"))"},{"line_number":144,"context_line":"        return key"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _get_alarm_dict(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_6d618cd2","line":143,"updated":"2015-11-12 14:31:29.000000000","message":"As I understand in line 139 and 142 you want to have equal behaviour but in different way. Please make this in the same way for better readability. I think that in 137,139 and 142 line We could use the same way\n  \"\u0026\".join(\"%s\" % x for x in (query) if x)\n  \"\u0026\".join(\"%s\" % x for x in (limit_line, fields_line) if x)\n  \":\".join(\"%s\" % x for x in (method, key_identifiers) if x)","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                           (\"\u0026\" if limit_line and fields_line else \"\") +"},{"line_number":141,"context_line":"                           fields_line)"},{"line_number":142,"context_line":"        key \u003d \"%s%s\" % (method, ((\":%s\" % key_identifiers)"},{"line_number":143,"context_line":"                                 if key_identifiers else \"\"))"},{"line_number":144,"context_line":"        return key"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _get_alarm_dict(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_4e69ab24","line":143,"in_reply_to":"da85f559_6d618cd2","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        return self.clients(\"ceilometer\").query_samples.query("},{"line_number":397,"context_line":"            filter, orderby, limit)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _list_resources(self, query\u003dNone, limit\u003dNone):"},{"line_number":400,"context_line":"        \"\"\"List all resources."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        :returns: list of all resources"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_37d6774f","line":399,"updated":"2015-11-12 14:31:29.000000000","message":"Please document params","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        return self.clients(\"ceilometer\").query_samples.query("},{"line_number":397,"context_line":"            filter, orderby, limit)"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _list_resources(self, query\u003dNone, limit\u003dNone):"},{"line_number":400,"context_line":"        \"\"\"List all resources."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        :returns: list of all resources"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_0e73a316","line":399,"in_reply_to":"da85f559_37d6774f","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"6ddcaa3585e66717fcdd3b33b71f375a35edbfa1","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                             limit\u003dlimit)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def _list_meters(self, query\u003dNone, limit\u003dNone):"},{"line_number":412,"context_line":"        \"\"\"Get list of user\u0027s meters."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :returns: list of all meters"},{"line_number":415,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_97c72395","line":412,"updated":"2015-11-12 14:31:29.000000000","message":"Please document params","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"d0fcdbb3bb47388b1efa2e3d8a9f760dcc581df0","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                             limit\u003dlimit)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def _list_meters(self, query\u003dNone, limit\u003dNone):"},{"line_number":412,"context_line":"        \"\"\"Get list of user\u0027s meters."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        :returns: list of all meters"},{"line_number":415,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_ae605736","line":412,"in_reply_to":"da85f559_97c72395","updated":"2015-11-16 07:53:21.000000000","message":"Done","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"}]}