)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b023ec4831bcfaa46a91e5dd8e5ab58e6fd19c5e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sla1.add_iteration(e)"},{"line_number":33,"context_line":"    sla1.add_iteration(f)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Needed for distribluted load generation."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I1bf4b5a76a2729e800928ddd7306864de4612461"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa80f949_7be9cf7f","line":35,"updated":"2015-11-05 13:45:10.000000000","message":"I\u0027m not English guru. But I think that past time is wrong here)","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    sla1.add_iteration(e)"},{"line_number":33,"context_line":"    sla1.add_iteration(f)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Needed for distribluted load generation."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Change-Id: I1bf4b5a76a2729e800928ddd7306864de4612461"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa80f949_4f0670cf","line":35,"in_reply_to":"fa80f949_7be9cf7f","updated":"2015-11-05 21:41:23.000000000","message":"It is not past time. It\u0027s a reduced from of passive voice. \nLike \u0027It is needed..\u0027","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"}],"rally/plugins/common/sla/failure_rate.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"b7f2e1fa1cfebdf4e5f980436ab66e2f9b2556cf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def details(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_1bf9a34d","line":60,"updated":"2015-11-05 13:15:47.000000000","message":"self.success and self.error_rate may be @property methods to avoid duplication","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def details(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_ef1c0415","line":60,"in_reply_to":"fa80f949_1bf9a34d","updated":"2015-11-05 21:41:23.000000000","message":"Sounds reasonable. But I had some issues definig @property in superclass (sla.SLA) and overriding it in subclasses.","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b023ec4831bcfaa46a91e5dd8e5ab58e6fd19c5e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def details(self):"},{"line_number":64,"context_line":"        return (_(\"Failure rate criteria %.2f%% \u003c\u003d %.2f%% \u003c\u003d %.2f%% - %s\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_1a1a016f","line":61,"updated":"2015-11-05 13:45:10.000000000","message":"Maybe just to call add_iteration inside merge_single_sla()?","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def details(self):"},{"line_number":64,"context_line":"        return (_(\"Failure rate criteria %.2f%% \u003c\u003d %.2f%% \u003c\u003d %.2f%% - %s\") %"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_afffdca8","line":61,"in_reply_to":"fa80f949_1a1a016f","updated":"2015-11-05 21:41:23.000000000","message":"In order to call add_iteration(..) we need that iteration. The issue with that is that SLA does not contain iterations but only contains some aggregated data.","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9c82170166bb8bc8988402d17c9f07c3d81948b0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":53,"context_line":"        return self.success"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def merge_single_sla(self, other):"},{"line_number":56,"context_line":"        self.total +\u003d other.total"},{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_cfb6198a","line":55,"updated":"2015-11-09 17:36:47.000000000","message":"I would prefer to add here type checks just in case..","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"bebae7cb7482d8d1a1d4e6ccbdf278a51836e399","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":53,"context_line":"        return self.success"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def merge_single_sla(self, other):"},{"line_number":56,"context_line":"        self.total +\u003d other.total"},{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_7a830905","line":55,"in_reply_to":"da85f559_cfb6198a","updated":"2015-11-10 10:57:02.000000000","message":"Type check is performed in rally.task.sla.py@L199\nI think it\u0027s worth making this method \u0027protected\u0027","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"174490ea83c6c1e54ece55a5ac863433a12eaeb4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.total +\u003d other.total"},{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_0f32e110","line":59,"updated":"2015-11-09 17:38:55.000000000","message":"Maybe we can have signle method for this method and add_iteration (this is really copy pasted)","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"bebae7cb7482d8d1a1d4e6ccbdf278a51836e399","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.total +\u003d other.total"},{"line_number":57,"context_line":"        self.errors +\u003d other.errors"},{"line_number":58,"context_line":"        if self.total:"},{"line_number":59,"context_line":"            self.error_rate \u003d self.errors * 100.0 / self.total"},{"line_number":60,"context_line":"        self.success \u003d self.min_percent \u003c\u003d self.error_rate \u003c\u003d self.max_percent"},{"line_number":61,"context_line":"        return self.success"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_7ab1c9e0","line":59,"in_reply_to":"da85f559_0f32e110","updated":"2015-11-10 10:57:02.000000000","message":"Actually I really hate this \"if isinstance(foo, MyType):\" approach.\nIn fact we could extract common part to a separate method but it\u0027d impact readability in a bad way.","commit_id":"98de6024553593eeebed2113e1c563e51c699901"}],"rally/plugins/common/sla/iteraion_time.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b023ec4831bcfaa46a91e5dd8e5ab58e6fd19c5e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"},{"line_number":40,"context_line":"        return self.success"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def merge_single_sla(self, other):"},{"line_number":43,"context_line":"        if other.max_iteration_time \u003e self.max_iteration_time:"},{"line_number":44,"context_line":"            self.max_iteration_time \u003d other.max_iteration_time"},{"line_number":45,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_5a3e49b9","line":42,"updated":"2015-11-05 13:45:10.000000000","message":"In the name of file is typo. Could you fix this? \u0027iteraion\u0027 - \u003e \u0027iteration\u0027","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"},{"line_number":40,"context_line":"        return self.success"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def merge_single_sla(self, other):"},{"line_number":43,"context_line":"        if other.max_iteration_time \u003e self.max_iteration_time:"},{"line_number":44,"context_line":"            self.max_iteration_time \u003d other.max_iteration_time"},{"line_number":45,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_af16fcee","line":42,"in_reply_to":"fa80f949_5a3e49b9","updated":"2015-11-05 21:41:23.000000000","message":"Done","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"}],"rally/plugins/common/sla/iteration_time.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"174490ea83c6c1e54ece55a5ac863433a12eaeb4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if other.max_iteration_time \u003e self.max_iteration_time:"},{"line_number":44,"context_line":"            self.max_iteration_time \u003d other.max_iteration_time"},{"line_number":45,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"},{"line_number":46,"context_line":"        return self.success"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def details(self):"},{"line_number":49,"context_line":"        return (_(\"Maximum seconds per iteration %.2fs \u003c\u003d %.2fs - %s\") %"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_ef3e7dd9","line":46,"updated":"2015-11-09 17:38:55.000000000","message":"same here add type check and make one method for this and add_iteration","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"bebae7cb7482d8d1a1d4e6ccbdf278a51836e399","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if other.max_iteration_time \u003e self.max_iteration_time:"},{"line_number":44,"context_line":"            self.max_iteration_time \u003d other.max_iteration_time"},{"line_number":45,"context_line":"        self.success \u003d self.max_iteration_time \u003c\u003d self.criterion_value"},{"line_number":46,"context_line":"        return self.success"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def details(self):"},{"line_number":49,"context_line":"        return (_(\"Maximum seconds per iteration %.2fs \u003c\u003d %.2fs - %s\") %"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_faba9922","line":46,"in_reply_to":"da85f559_ef3e7dd9","updated":"2015-11-10 10:57:02.000000000","message":"Pls see my response in failure_rate.py","commit_id":"98de6024553593eeebed2113e1c563e51c699901"}],"rally/plugins/common/sla/max_average_duration.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9c82170166bb8bc8988402d17c9f07c3d81948b0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.success \u003d self.avg \u003c\u003d self.criterion_value"},{"line_number":43,"context_line":"        return self.success"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def merge_single_sla(self, other):"},{"line_number":46,"context_line":"        # TODO(ikhudoshyn): Implement me"},{"line_number":47,"context_line":"        raise NotImplementedError()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_cf9ff901","line":45,"updated":"2015-11-09 17:36:47.000000000","message":"why it\u0027s not implemented in this patch?","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"bebae7cb7482d8d1a1d4e6ccbdf278a51836e399","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.success \u003d self.avg \u003c\u003d self.criterion_value"},{"line_number":43,"context_line":"        return self.success"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def merge_single_sla(self, other):"},{"line_number":46,"context_line":"        # TODO(ikhudoshyn): Implement me"},{"line_number":47,"context_line":"        raise NotImplementedError()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_3adfc16a","line":45,"in_reply_to":"da85f559_cf9ff901","updated":"2015-11-10 10:57:02.000000000","message":"It would require some refactoiring of streaming_alorythms.\nI\u0027d prefer to gather feedback on the approach before I go too far.","commit_id":"98de6024553593eeebed2113e1c563e51c699901"}],"rally/task/sla.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b023ec4831bcfaa46a91e5dd8e5ab58e6fd19c5e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            sla2.add_iteration(c)"},{"line_number":158,"context_line":"            sla2.add_iteration(d)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            sla1.merge_single_sla(sla2)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        is equivalent to"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_0fbba10f","line":160,"updated":"2015-11-05 13:45:10.000000000","message":"Personally I like interface like merge(sla1, sla2) produces new SLA() without changing sla1 or sla2.  So I suggest:\n  sla1 \u003d SLA()\n  sla1.add_iteration(a)\n\n  sla2 \u003d SLA()\n  sla2.add_iteration(b)\n\n  merge(sla1, sla2) \u003c- return new SLA()\nIts minor, of cause, you could keep write as you like.","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            sla2.add_iteration(c)"},{"line_number":158,"context_line":"            sla2.add_iteration(d)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"            sla1.merge_single_sla(sla2)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        is equivalent to"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_4fef5087","line":160,"in_reply_to":"fa80f949_0fbba10f","updated":"2015-11-05 21:41:23.000000000","message":"I\u0027m not at all against that \u0027functional\u0027 style in general, but in this particular case I\u0027d prefer merge to be a SLA method, not a function (that is, each SLA knows how to merge alikes) and having a static method would look a little weird here.\n\nMoreover, this \u0027merge\u0027 functionality is actually implemented for one particular usecase: SLA in distributed runner will \u0027gather\u0027 SLAs from remote nodes, like:\nsla \u003d SLA()\nwhile condition:\n  for node in nodes:\n     remote_sla \u003d node.get_sla()\n     if not sla.merge(remote_sla):\n        # process SLA violation\n     \nI think \u0027merge\u0027 as a method fits the usecase a little bit better than \u0027merge\u0027 as a function.","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b023ec4831bcfaa46a91e5dd8e5ab58e6fd19c5e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        The call to merge() will return True if the SLA check passed,"},{"line_number":192,"context_line":"        and False otherwise."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        :param other: another SLA object"},{"line_number":195,"context_line":"        :returns: True if the SLA check passed, False otherwise"},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_3b6fc72c","line":194,"updated":"2015-11-05 13:45:10.000000000","message":"looks like wrong param","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"cb075990fa6d96dfa5adf5841bee3c323c1efbbc","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        The call to merge() will return True if the SLA check passed,"},{"line_number":192,"context_line":"        and False otherwise."},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        :param other: another SLA object"},{"line_number":195,"context_line":"        :returns: True if the SLA check passed, False otherwise"},{"line_number":196,"context_line":"        \"\"\""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_0fde283f","line":194,"in_reply_to":"fa80f949_3b6fc72c","updated":"2015-11-05 21:41:23.000000000","message":"Done","commit_id":"45c994e370c44dc1d0589a4ef7aee9a6096a28ee"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9c82170166bb8bc8988402d17c9f07c3d81948b0","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            raise TypeError(message)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @abc.abstractmethod"},{"line_number":145,"context_line":"    def merge_single_sla(self, other):"},{"line_number":146,"context_line":"        \"\"\"Merge aggregated data from another SLA instance into self."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        Process the results of several iterations aggregated in another"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_cf57f900","line":145,"updated":"2015-11-09 17:36:47.000000000","message":"Signature of this method doesn\u0027t look nice for me.\n\nWhy not just like this: \n\n   def merge(self, sla_inst): \n        pass","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"bebae7cb7482d8d1a1d4e6ccbdf278a51836e399","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            raise TypeError(message)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    @abc.abstractmethod"},{"line_number":145,"context_line":"    def merge_single_sla(self, other):"},{"line_number":146,"context_line":"        \"\"\"Merge aggregated data from another SLA instance into self."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        Process the results of several iterations aggregated in another"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_1a319dec","line":145,"in_reply_to":"da85f559_cf57f900","updated":"2015-11-10 10:57:02.000000000","message":"Pls take a look @ line 117","commit_id":"98de6024553593eeebed2113e1c563e51c699901"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e12d0ccbe0452df557cbcc18f57ffe532b5d9a59","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _validate_sla_types(self, other):"},{"line_number":70,"context_line":"        for self_sla, other_sla in six.moves.zip_longest("},{"line_number":71,"context_line":"                self.sla_criteria, other.sla_criteria):"},{"line_number":72,"context_line":"            self_sla.validate_type(other_sla)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _validate_config(self, other):"},{"line_number":75,"context_line":"        self_config \u003d self.config.get(\"sla\", {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_3b69cb8c","line":72,"updated":"2015-12-02 19:29:49.000000000","message":"This will raise \"AttributeError NoneType has no attribute ....\" if second list is longer then first. It\u0027s okay, but may be confusing.","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"7eab1cab0a996cc1cc2373b14b3e47b2413420c5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def _validate_sla_types(self, other):"},{"line_number":70,"context_line":"        for self_sla, other_sla in six.moves.zip_longest("},{"line_number":71,"context_line":"                self.sla_criteria, other.sla_criteria):"},{"line_number":72,"context_line":"            self_sla.validate_type(other_sla)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _validate_config(self, other):"},{"line_number":75,"context_line":"        self_config \u003d self.config.get(\"sla\", {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_204e583b","line":72,"in_reply_to":"9a8ffd7b_3b69cb8c","updated":"2015-12-03 10:19:45.000000000","message":"Hm.. the actual question is, do we need this method at all. We check that configs of the SLACheckers are the same, so I guess _validate_sla_types should never fail at all. Maybe we should get rid of the latter, yet I worry a little, so it is still here.","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"}],"tests/unit/common/test_streaming_algorithms.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e12d0ccbe0452df557cbcc18f57ffe532b5d9a59","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for mean in means[1:]:"},{"line_number":60,"context_line":"            merged_mean.merge(mean)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.assertEqual(single_mean.count, merged_mean.count)"},{"line_number":63,"context_line":"        self.assertEqual(single_mean.total, merged_mean.total)"},{"line_number":64,"context_line":"        self.assertEqual(single_mean.result(), merged_mean.result())"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_1bf40759","line":62,"updated":"2015-12-02 19:29:49.000000000","message":"What if we accidentally change implementation to count sum() instead of mean()?. This test will not fail, but should.\n\nThe same with other tests.","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"7eab1cab0a996cc1cc2373b14b3e47b2413420c5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        for mean in means[1:]:"},{"line_number":60,"context_line":"            merged_mean.merge(mean)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.assertEqual(single_mean.count, merged_mean.count)"},{"line_number":63,"context_line":"        self.assertEqual(single_mean.total, merged_mean.total)"},{"line_number":64,"context_line":"        self.assertEqual(single_mean.result(), merged_mean.result())"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_80ace49f","line":62,"in_reply_to":"9a8ffd7b_1bf40759","updated":"2015-12-03 10:19:45.000000000","message":"I think the case you mentioned is not in the scope of THIS test. This test only checks if merge works. If algorithm itself works wrong then there are another tests to catch that.","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9f02960a9bdffcabcf41f93fcd12d9c0d0a0b9c6","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                min.add(val)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        merged_min \u003d mins[0]"},{"line_number":149,"context_line":"        for min in mins[1:]:"},{"line_number":150,"context_line":"            merged_min.merge(min)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.assertEqual(single_min._value, merged_min._value)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_4945bb6c","line":149,"updated":"2015-12-03 13:47:27.000000000","message":"`min\u0027 is python built-in\n\nhttp://docs.openstack.org/developer/hacking/#general","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"8d9e846fce39ef92711fb8ea8d5be8942d506ff3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                min.add(val)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        merged_min \u003d mins[0]"},{"line_number":149,"context_line":"        for min in mins[1:]:"},{"line_number":150,"context_line":"            merged_min.merge(min)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.assertEqual(single_min._value, merged_min._value)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_6c2e8d44","line":149,"in_reply_to":"9a8ffd7b_4945bb6c","updated":"2015-12-03 13:58:50.000000000","message":"Done","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9f02960a9bdffcabcf41f93fcd12d9c0d0a0b9c6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                max.add(val)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        merged_max \u003d maxs[0]"},{"line_number":188,"context_line":"        for max in maxs[1:]:"},{"line_number":189,"context_line":"            merged_max.merge(max)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.assertEqual(single_max._value, merged_max._value)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_e9790fc9","line":188,"updated":"2015-12-03 13:47:27.000000000","message":"`max\u0027 is python built-in function","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"8d9e846fce39ef92711fb8ea8d5be8942d506ff3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                max.add(val)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        merged_max \u003d maxs[0]"},{"line_number":188,"context_line":"        for max in maxs[1:]:"},{"line_number":189,"context_line":"            merged_max.merge(max)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.assertEqual(single_max._value, merged_max._value)"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_2c24055e","line":188,"in_reply_to":"9a8ffd7b_e9790fc9","updated":"2015-12-03 13:58:50.000000000","message":"Done","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"}],"tests/unit/plugins/common/sla/test_ouliers.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"9f02960a9bdffcabcf41f93fcd12d9c0d0a0b9c6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertEqual(single_sla.success, merged_sla.success)"},{"line_number":118,"context_line":"        self.assertEqual(single_sla.iterations, merged_sla.iterations)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # self.assertEqual(single_sla.threshold, merged_sla.threshold)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # NOTE(ikhudoshyn): We are unable to implement"},{"line_number":123,"context_line":"        # rally.plugins.common.sla.outliers.Outliers.merge(..) correctly"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_c928cb99","line":120,"updated":"2015-12-03 13:47:27.000000000","message":"remove this line","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a4f481565d43dec3a4fb5d95cf53f8d2dfd604f0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertEqual(single_sla.success, merged_sla.success)"},{"line_number":118,"context_line":"        self.assertEqual(single_sla.iterations, merged_sla.iterations)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # self.assertEqual(single_sla.threshold, merged_sla.threshold)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # NOTE(ikhudoshyn): We are unable to implement"},{"line_number":123,"context_line":"        # rally.plugins.common.sla.outliers.Outliers.merge(..) correctly"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_ef982fc2","line":120,"in_reply_to":"9a8ffd7b_2c0de5e7","updated":"2015-12-03 14:06:38.000000000","message":"Okay, however it would be nice to have comment above the line, not below ;)","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"8d9e846fce39ef92711fb8ea8d5be8942d506ff3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.assertEqual(single_sla.success, merged_sla.success)"},{"line_number":118,"context_line":"        self.assertEqual(single_sla.iterations, merged_sla.iterations)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # self.assertEqual(single_sla.threshold, merged_sla.threshold)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        # NOTE(ikhudoshyn): We are unable to implement"},{"line_number":123,"context_line":"        # rally.plugins.common.sla.outliers.Outliers.merge(..) correctly"}],"source_content_type":"text/x-python","patch_set":20,"id":"9a8ffd7b_2c0de5e7","line":120,"in_reply_to":"9a8ffd7b_c928cb99","updated":"2015-12-03 13:58:50.000000000","message":"I won\u0027t. This line is essential here (in test), i.e. it should be here if we consider completeness of the test, but the comment below explains why it is commented out.","commit_id":"d85e2bec705db2733e0036adefa7a11430e654c2"}]}
