)]}'
{"rally/ui/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"45fcdb9d0eab09d2bd419f20f0848f7793b28bfa","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    lookup_dirs \u003d ["},{"line_number":33,"context_line":"        templates_dir,"},{"line_number":34,"context_line":"        os.path.abspath(os.path.join(templates_dir, \"..\", \"..\", \"..\"))]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # TODO(amaretskiy): Mako templates are deprecated, so this should be"},{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_19e47939","line":34,"updated":"2015-10-26 16:16:31.000000000","message":"It doesn\u0027t relate to your patch, but please, remove this dots. It sucks and unreadable! Also, If this module will be moved in future, everything will break.\nI prefer to use this simple code:\n\n    import rally\n    lookup_dirs \u003d [templates_dir, os.path.dirname(rally)]","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4b9b9ebe568b18d4c9dcdea3524e56fe6cbb74c6","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    lookup_dirs \u003d ["},{"line_number":33,"context_line":"        templates_dir,"},{"line_number":34,"context_line":"        os.path.abspath(os.path.join(templates_dir, \"..\", \"..\", \"..\"))]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # TODO(amaretskiy): Mako templates are deprecated, so this should be"},{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_a840bf08","line":34,"in_reply_to":"3a29b11f_19e47939","updated":"2015-10-27 11:18:38.000000000","message":"I will split this into 2 patches, 1st will just add Jinja2 support, and 2nd will improve get_template() - this is because `\"..\", \"..\", \"..\"\u0027 is actually wrong directory so I will use another approach and break compatibility a bit","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"45fcdb9d0eab09d2bd419f20f0848f7793b28bfa","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"},{"line_number":38,"context_line":"    if template_path.endswith(\".mako\"):"},{"line_number":39,"context_line":"        from rally.common import log as logging"},{"line_number":40,"context_line":"        LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"        LOG.warning("},{"line_number":42,"context_line":"            (\"Mako templates are deprecated, template `%s\u0027 should be \""},{"line_number":43,"context_line":"             \"transformed to Jinja2\") % template_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_7e8233ca","line":40,"updated":"2015-10-26 16:16:31.000000000","message":"Not sure, but it seems to me, you should call https://github.com/openstack/rally/blob/master/rally/common/log.py#L47 , since it is separate entry point and https://github.com/openstack/rally/blob/master/rally/cli/cliutils.py#L465 will be not executed.","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"eca4224223badaab34f6c6828b5210b6725df211","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"},{"line_number":38,"context_line":"    if template_path.endswith(\".mako\"):"},{"line_number":39,"context_line":"        from rally.common import log as logging"},{"line_number":40,"context_line":"        LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"        LOG.warning("},{"line_number":42,"context_line":"            (\"Mako templates are deprecated, template `%s\u0027 should be \""},{"line_number":43,"context_line":"             \"transformed to Jinja2\") % template_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_9f3e56b7","line":40,"in_reply_to":"1a26ad4f_1c9a5415","updated":"2015-10-27 12:32:49.000000000","message":"I have next message from cli:\n    $ python ./rally/ui/utils.py\n    No handlers could be found for logger \"__main__\"\n\nAlso, warning message is not printed:(","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"de7cb596692db166ab9f02af3870256eeb3e4bfd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"},{"line_number":38,"context_line":"    if template_path.endswith(\".mako\"):"},{"line_number":39,"context_line":"        from rally.common import log as logging"},{"line_number":40,"context_line":"        LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"        LOG.warning("},{"line_number":42,"context_line":"            (\"Mako templates are deprecated, template `%s\u0027 should be \""},{"line_number":43,"context_line":"             \"transformed to Jinja2\") % template_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_1c9a5415","line":40,"in_reply_to":"3a29b11f_7e8233ca","updated":"2015-10-27 12:26:22.000000000","message":"After investigation I concluded that separate entry point is not required, this is simple logging message that should work with existent logging settings","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4b9b9ebe568b18d4c9dcdea3524e56fe6cbb74c6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    #                   removed after proper templates switched to Jinja2"},{"line_number":38,"context_line":"    if template_path.endswith(\".mako\"):"},{"line_number":39,"context_line":"        from rally.common import log as logging"},{"line_number":40,"context_line":"        LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"        LOG.warning("},{"line_number":42,"context_line":"            (\"Mako templates are deprecated, template `%s\u0027 should be \""},{"line_number":43,"context_line":"             \"transformed to Jinja2\") % template_path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_c845fb17","line":40,"in_reply_to":"3a29b11f_7e8233ca","updated":"2015-10-27 11:18:38.000000000","message":"Looks reasonable","commit_id":"2895c89a53376febdf3cb1a68d561c4ffa93c9d4"}]}
