)]}'
{"tests/ci/rally_verify.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"39cd0bf97aa05fe401cd7fd7c661a10f59a96b0a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if filetype:"},{"line_number":51,"context_line":"        # NOTE(andreykurilin): If filetype is presented, output will be in"},{"line_number":52,"context_line":"        # specific format, which should not be broken by debug info."},{"line_number":53,"context_line":"        data \u003d {\"cmd\": \"rally %s\" % cmd}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        filetype \u003d \"txt\""},{"line_number":56,"context_line":"        data \u003d {\"cmd\": \"rally --rally-debug %s\" % cmd}"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_405f6f72","line":53,"updated":"2015-11-09 12:09:50.000000000","message":"We can not see debug output in this case, but we need to see it in case of failure, right?\n\nIt would be much better to have separate files for stdout and stderr.\n\nAlso it would be nice to specify output file explicitly, e.g. `rally verify results --outfile results.html`","commit_id":"1f1d80cab9d044be56bf72954e6dc2181bb7e90c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1ed1418389c9711738666f228e8a79e07013553c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if filetype:"},{"line_number":51,"context_line":"        # NOTE(andreykurilin): If filetype is presented, output will be in"},{"line_number":52,"context_line":"        # specific format, which should not be broken by debug info."},{"line_number":53,"context_line":"        data \u003d {\"cmd\": \"rally %s\" % cmd}"},{"line_number":54,"context_line":"    else:"},{"line_number":55,"context_line":"        filetype \u003d \"txt\""},{"line_number":56,"context_line":"        data \u003d {\"cmd\": \"rally --rally-debug %s\" % cmd}"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_73036174","line":53,"in_reply_to":"da85f559_405f6f72","updated":"2015-11-09 16:27:31.000000000","message":"\u003eAlso it would be nice to specify output file explicitly, e.g. `rally verify results --outfile results.html`\n\nDone.","commit_id":"1f1d80cab9d044be56bf72954e6dc2181bb7e90c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9189a8a245a59b7a78504f0e18917a18666672e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"def str2bool(argument_value):"},{"line_number":123,"context_line":"    \"\"\"Argument type for argparse, which converts string to bool.\"\"\""},{"line_number":124,"context_line":"    value \u003d argument_value.lower()"},{"line_number":125,"context_line":"    if argument_value.lower() in (\"yes\", \"true\", \"t\"):"},{"line_number":126,"context_line":"        return True"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_60187385","line":125,"updated":"2015-11-09 12:58:41.000000000","message":"1) s/argument_value.lower()/value/\n\n2) add \"y\" to choices","commit_id":"1f1d80cab9d044be56bf72954e6dc2181bb7e90c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1ed1418389c9711738666f228e8a79e07013553c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"def str2bool(argument_value):"},{"line_number":123,"context_line":"    \"\"\"Argument type for argparse, which converts string to bool.\"\"\""},{"line_number":124,"context_line":"    value \u003d argument_value.lower()"},{"line_number":125,"context_line":"    if argument_value.lower() in (\"yes\", \"true\", \"t\"):"},{"line_number":126,"context_line":"        return True"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_b3cc6936","line":125,"in_reply_to":"da85f559_60187385","updated":"2015-11-09 16:27:31.000000000","message":"good catch.","commit_id":"1f1d80cab9d044be56bf72954e6dc2181bb7e90c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c9189a8a245a59b7a78504f0e18917a18666672e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        choices\u003dMODES_PARAMETERS.keys())"},{"line_number":144,"context_line":"    parser.add_argument("},{"line_number":145,"context_line":"        \"--compare\","},{"line_number":146,"context_line":"        type\u003dstr2bool,"},{"line_number":147,"context_line":"        default\u003dTrue,"},{"line_number":148,"context_line":"        help\u003d\"Launch 2 verification and compare them.\")"},{"line_number":149,"context_line":"    args \u003d parser.parse_args()"}],"source_content_type":"text/x-python","patch_set":18,"id":"da85f559_1be319a5","line":146,"updated":"2015-11-09 12:58:41.000000000","message":"it would be good to add `choices\u0027 here","commit_id":"1f1d80cab9d044be56bf72954e6dc2181bb7e90c"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"997650c9d8679adcc1d404ac830a2d09e5172205","unresolved":false,"context_lines":[{"line_number":121,"context_line":"def render_page(**render_vars):"},{"line_number":122,"context_line":"    # TODO(andreykurilin): port template to jinja2"},{"line_number":123,"context_line":"    template \u003d utils.get_template(\"ci/index_verify.mako\")"},{"line_number":124,"context_line":"    with open(\"%s/extra/index.html\" % BASE_DIR, \"w\") as f:"},{"line_number":125,"context_line":"        f.write(template.render(**render_vars))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"da85f559_54ce1e5b","line":124,"updated":"2015-11-10 10:24:25.000000000","message":"It is better to use os.path.join","commit_id":"965817f630ed4de2f760a537887b2fa809e4575c"}]}