)]}'
{"rally/common/utils.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"aafa379ff05ac465d6eeb63696068a341d577918","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return name_re.match(name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def name_matches_object(name, obj_or_tuple):"},{"line_number":376,"context_line":"    \"\"\"Determine if a resource name could have been created by an object."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    The object (or list of objects) should implement"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_21e80a10","line":375,"updated":"2015-11-05 00:48:25.000000000","message":"imho better signature is next: \n\n   def name_matches_objects(name, *objs): \n       ...\n\nthen one will use it in next way: \n\n   utils.name_matches_objects(name, Flavor)   \n   utils.name_matches_objects(name, Flavor, Image)\n\n    instead of\n   utils.name_matches_objects(name, Flavor)   \n   utils.name_matches_objects(name, (Flavor, Image))\n\n as well it will simplify DOCs of this method, as well as code (as you are always working with list out of the box)","commit_id":"8c64cb9bce2bac191ea64ea76d0b502e90f5b814"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"91b9510729862e2836935034f7418ccf4e8cd886","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return name_re.match(name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def name_matches_object(name, obj_or_tuple):"},{"line_number":376,"context_line":"    \"\"\"Determine if a resource name could have been created by an object."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    The object (or list of objects) should implement"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_9244a674","line":375,"in_reply_to":"fa80f949_21e80a10","updated":"2015-11-05 03:42:12.000000000","message":"Done","commit_id":"8c64cb9bce2bac191ea64ea76d0b502e90f5b814"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f7973d8d03fabc7c299659dcb1bb69e623680d91","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return name_re.match(name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def name_matches_object(name, *objects):"},{"line_number":376,"context_line":"    \"\"\"Determine if a resource name could have been created by an object."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    The object (or list of objects) should implement"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_3047af4c","line":375,"updated":"2015-11-06 13:25:31.000000000","message":"Maybe rename name_matches_object -\u003e name_matches_objects()?","commit_id":"9a2e42be28baa181635c6ea512a5407f8a049afd"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"98ee1393521eb9f98dc544644fbbccb5c62a4261","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return name_re.match(name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def name_matches_object(name, *objects):"},{"line_number":376,"context_line":"    \"\"\"Determine if a resource name could have been created by an object."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    The object (or list of objects) should implement"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_d0be6364","line":375,"in_reply_to":"fa80f949_3047af4c","updated":"2015-11-06 13:43:34.000000000","message":"As for me is ok. \"name matches any object\"","commit_id":"9a2e42be28baa181635c6ea512a5407f8a049afd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1b2f7ca6bfb00441370733e70a2a13e7c3b05e43","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    return name_re.match(name)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def name_matches_object(name, *objects):"},{"line_number":376,"context_line":"    \"\"\"Determine if a resource name could have been created by an object."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    The object (or list of objects) should implement"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_be412d65","line":375,"in_reply_to":"fa80f949_d0be6364","updated":"2015-11-06 15:05:00.000000000","message":"Done. I think changing the name is a good idea to contrast it with name_matches_pattern(), which can only ever accept a single pattern.","commit_id":"9a2e42be28baa181635c6ea512a5407f8a049afd"}],"tests/unit/common/test_utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f7973d8d03fabc7c299659dcb1bb69e623680d91","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @mock.patch(\"rally.common.utils.name_matches_pattern\","},{"line_number":365,"context_line":"                return_value\u003dFalse)"},{"line_number":366,"context_line":"    def test_name_matches_object_identical_list(self,"},{"line_number":367,"context_line":"                                                mock_name_matches_pattern):"},{"line_number":368,"context_line":"        class One(utils.RandomNameGeneratorMixin):"},{"line_number":369,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_b0cddfb8","line":366,"updated":"2015-11-06 13:25:31.000000000","message":"Consider about using ddt for testing `name_matches_object\u0027, within a single test","commit_id":"9a2e42be28baa181635c6ea512a5407f8a049afd"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1b2f7ca6bfb00441370733e70a2a13e7c3b05e43","unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    @mock.patch(\"rally.common.utils.name_matches_pattern\","},{"line_number":365,"context_line":"                return_value\u003dFalse)"},{"line_number":366,"context_line":"    def test_name_matches_object_identical_list(self,"},{"line_number":367,"context_line":"                                                mock_name_matches_pattern):"},{"line_number":368,"context_line":"        class One(utils.RandomNameGeneratorMixin):"},{"line_number":369,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_5ee04196","line":366,"in_reply_to":"fa80f949_b0cddfb8","updated":"2015-11-06 15:05:00.000000000","message":"ddt isn\u0027t a great fit for this because the expected behavior is so different, particularly between ..._identical_list() and ..._differing_list(). The amount of abstraction code that would need to be written would outweigh any gains.","commit_id":"9a2e42be28baa181635c6ea512a5407f8a049afd"}]}