)]}'
{"rally/cli/commands/verify.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6e27c87ffa8cedcd082547e46b0669bede14b39","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.show(verification_uuid, sort_by, True)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @cliutils.args(\"--uuid-1\", type\u003dstr, dest\u003d\"uuid1\","},{"line_number":265,"context_line":"                   help\u003d\"UUID of the first verification\")"},{"line_number":266,"context_line":"    @cliutils.args(\"--uuid-2\", type\u003dstr, dest\u003d\"uuid2\","},{"line_number":267,"context_line":"                   help\u003d\"UUID of the second verification\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_f5baae22","line":264,"updated":"2015-11-05 12:08:21.000000000","message":"https://docs.python.org/3/library/argparse.html#required\n\n\u003eIn general, the argparse module assumes that flags like -f and --bar indicate optional arguments, which can always be omitted at the command line. To make an option required, True can be specified for the required\u003d keyword argument\n\nPlease add here required\u003dTrue option","commit_id":"21471902b8dd2138c84691be278480f404f35bd3"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"ca479dbb46fad4bc416286cc0faf2ea1e20000bf","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        self.show(verification_uuid, sort_by, True)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @cliutils.args(\"--uuid-1\", type\u003dstr, dest\u003d\"uuid1\","},{"line_number":265,"context_line":"                   help\u003d\"UUID of the first verification\")"},{"line_number":266,"context_line":"    @cliutils.args(\"--uuid-2\", type\u003dstr, dest\u003d\"uuid2\","},{"line_number":267,"context_line":"                   help\u003d\"UUID of the second verification\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_95afa293","line":264,"in_reply_to":"fa80f949_f5baae22","updated":"2015-11-05 12:13:32.000000000","message":"thx, I will fix later.","commit_id":"21471902b8dd2138c84691be278480f404f35bd3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6e27c87ffa8cedcd082547e46b0669bede14b39","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @cliutils.args(\"--uuid-1\", type\u003dstr, dest\u003d\"uuid1\","},{"line_number":265,"context_line":"                   help\u003d\"UUID of the first verification\")"},{"line_number":266,"context_line":"    @cliutils.args(\"--uuid-2\", type\u003dstr, dest\u003d\"uuid2\","},{"line_number":267,"context_line":"                   help\u003d\"UUID of the second verification\")"},{"line_number":268,"context_line":"    @cliutils.args(\"--csv\", action\u003d\"store_true\", dest\u003d\"output_csv\","},{"line_number":269,"context_line":"                   help\u003d(\"Save results in csv format to specified file\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_b583c655","line":266,"updated":"2015-11-05 12:08:21.000000000","message":"same here","commit_id":"21471902b8dd2138c84691be278480f404f35bd3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f6e27c87ffa8cedcd082547e46b0669bede14b39","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        \"\"\""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        try:"},{"line_number":297,"context_line":"            if (not uuid1) or (not uuid2):"},{"line_number":298,"context_line":"                raise exceptions.InvalidArgumentsException("},{"line_number":299,"context_line":"                    \"The uuid can not be empty.\")"},{"line_number":300,"context_line":"            results1 \u003d db.verification_result_get(uuid1)[\"data\"][\"test_cases\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_55485a2d","line":297,"updated":"2015-11-05 12:08:21.000000000","message":"this check can be and should be handled by argparse","commit_id":"21471902b8dd2138c84691be278480f404f35bd3"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"ca479dbb46fad4bc416286cc0faf2ea1e20000bf","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        \"\"\""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        try:"},{"line_number":297,"context_line":"            if (not uuid1) or (not uuid2):"},{"line_number":298,"context_line":"                raise exceptions.InvalidArgumentsException("},{"line_number":299,"context_line":"                    \"The uuid can not be empty.\")"},{"line_number":300,"context_line":"            results1 \u003d db.verification_result_get(uuid1)[\"data\"][\"test_cases\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_159c1268","line":297,"in_reply_to":"fa80f949_55485a2d","updated":"2015-11-05 12:13:32.000000000","message":"Done","commit_id":"21471902b8dd2138c84691be278480f404f35bd3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"578b51dacce781c812ebc44b1b7f8e580b5aa78c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_3c424169","line":301,"updated":"2015-11-06 03:03:11.000000000","message":"Message could be improved: \"The verification is not found: %s\" % six.text_type(e)\n\nAnd could you fix the message for \u0027results\u0027 and \u0027show\u0027 also?","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"01e441a8261bec113ba813cd3280119370e6882b","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d1019e07","line":301,"updated":"2015-11-06 02:10:49.000000000","message":"use [:-1] or strip or rstrip just from my side.","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"9b6bc60a58cd2116c5fdc7f1b7c4f3e49c5a7212","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_b81f166b","line":301,"in_reply_to":"fa80f949_02c7cf96","updated":"2015-11-06 08:20:18.000000000","message":"Done","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"7a96d0b4a96ca53d7faf6a0b30ede0b97393b3db","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_ff4108aa","line":301,"in_reply_to":"fa80f949_3c424169","updated":"2015-11-06 06:26:36.000000000","message":"Yingjun,thx.\nif the exception is occur,\n\u003cprint six.text_type(e)\u003e \u003d \u003cNot found.\u003e\nthe massage is unfriendly. and other method.\nModify the NotFoundException of class in exceptions.py.\nChange (\"Not found\") to (\"The resource can not be found.\").\nWhich way do you think is better?","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"},{"author":{"_account_id":15086,"name":"WangXiaoFei","email":"xiaofeix.wang@icloud.com","username":"wangxf"},"change_message_id":"7a96d0b4a96ca53d7faf6a0b30ede0b97393b3db","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_3cb24107","line":301,"in_reply_to":"fa80f949_d1019e07","updated":"2015-11-06 06:26:36.000000000","message":"Done","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aa994de074d788f6b6d43366bd3a87b9d16d1388","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            results2 \u003d db.verification_result_get(uuid2)[\"data\"][\"test_cases\"]"},{"line_number":299,"context_line":"            _diff \u003d diff.Diff(results1, results2, threshold)"},{"line_number":300,"context_line":"        except exceptions.NotFoundException as e:"},{"line_number":301,"context_line":"            print (\"The uuid %s in database.\" % (six.text_type(e)).lower()[0:-1])"},{"line_number":302,"context_line":"            return 1"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        result \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_02c7cf96","line":301,"in_reply_to":"fa80f949_ff4108aa","updated":"2015-11-06 06:55:50.000000000","message":"I\u0027d prefer change the message in  NotFoundException:)","commit_id":"a841aba44848bd856bbd7c2ad20a670ae0e26357"}]}