)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8e603891269ad9d7c90989e578a6ee7c20b7b999","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename \"endpoint\" to \"credential\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first patch for Bug #1447682, added rally/common/objects/credential.py and changed deployment related files."},{"line_number":10,"context_line":"rally/common/objects/endpoint.py is still remained, in order not to break other components. It will be removed in the final patch."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia62881473d1bf63f952528b66e7420eea6323f08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_59414937","line":9,"updated":"2015-11-06 10:17:09.000000000","message":"Please, try to split lines in commit message by 79 chars per line","commit_id":"efef48cbc2cd6924de92314801b4d48be8260f49"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"db60681ed7b89416d8b486d9643bbf0b9be88a42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename \"endpoint\" to \"credential\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the first patch for Bug #1447682."},{"line_number":10,"context_line":"Added rally/common/objects/credential.py"},{"line_number":11,"context_line":"Marked rally/common/objects/endpoint.py as deprecated since Rally 0.1.2."},{"line_number":12,"context_line":"Renmaed \"endpoint\" to \"credential\" for  deployment related files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_6855d5c4","line":9,"updated":"2015-11-08 08:50:15.000000000","message":"it\u0027s better to add to remove this line and change title to: \n\nRename \"endpoint\" to \"credential\" (part 1)","commit_id":"d06d7430bf1cf97f1da610e88e44b68ac4be6931"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"5c777a10d2479b8689b735c1c071bbae29eee77e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-11 23:28:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename \"endpoint\" to \"credential\" (part 1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Renamed rally/common/objects/endpoint.py and objects.Endpoint"},{"line_number":10,"context_line":"to rally/common/objects/credential.py and objects.Credential"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_640a108c","line":7,"updated":"2015-11-12 12:34:14.000000000","message":"Why its part 1? What would be in the second?","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"b42de320e5d201746db0f8870d21f69350fea526","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bo Chi \u003cshcbo@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-11 23:28:39 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename \"endpoint\" to \"credential\" (part 1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Renamed rally/common/objects/endpoint.py and objects.Endpoint"},{"line_number":10,"context_line":"to rally/common/objects/credential.py and objects.Credential"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da85f559_1ccec6b4","line":7,"in_reply_to":"da85f559_640a108c","updated":"2015-11-13 09:45:24.000000000","message":"the thought is part 1 rename the class name and where it is used.\npart 2 to rename all the other variable names that should be changed","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"}],"rally/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"46a937a8791a1d7a512932fea4cf42c978b8735d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        with deployer:"},{"line_number":68,"context_line":"            credentials \u003d deployer.make_deploy()"},{"line_number":69,"context_line":"            deployment.update_credentials(credentials)"},{"line_number":70,"context_line":"            return deployment"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e85785c8","line":69,"updated":"2015-11-08 08:53:17.000000000","message":"as you are refactoring this, why not just: \n\n\n  deploymnet.update_credentials(deployer.make_deploy())","commit_id":"d06d7430bf1cf97f1da610e88e44b68ac4be6931"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"46a937a8791a1d7a512932fea4cf42c978b8735d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        with deployer:"},{"line_number":101,"context_line":"            deployer.make_cleanup()"},{"line_number":102,"context_line":"            credentials \u003d deployer.make_deploy()"},{"line_number":103,"context_line":"            deployment.update_credentials(credentials)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @classmethod"},{"line_number":106,"context_line":"    def get(cls, deployment):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_085d29e9","line":103,"updated":"2015-11-08 08:53:17.000000000","message":"same here","commit_id":"d06d7430bf1cf97f1da610e88e44b68ac4be6931"}],"rally/cli/commands/deployment.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"46a937a8791a1d7a512932fea4cf42c978b8735d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            users \u003d deployment[\"users\"]"},{"line_number":244,"context_line":"            for credential_dict in users:"},{"line_number":245,"context_line":"                osclients.Clients("},{"line_number":246,"context_line":"                    objects.Endpoint(**credential_dict)).keystone()"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        except keystone_exceptions.ConnectionRefused:"},{"line_number":249,"context_line":"            print(_(\"Unable to connect %s.\") % deployment[\"admin\"][\"auth_url\"])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_c86f2191","line":246,"updated":"2015-11-08 08:53:17.000000000","message":"objects.Credential should be here","commit_id":"d06d7430bf1cf97f1da610e88e44b68ac4be6931"}],"rally/common/objects/__init__.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"11e665728cf3af7e90c2ff72209a1aa6787e8283","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.common.objects.credential import Credential  # noqa"},{"line_number":18,"context_line":"from rally.common.objects.deploy import Deployment  # noqa"},{"line_number":19,"context_line":"from rally.common.objects.task import Task  # noqa"},{"line_number":20,"context_line":"from rally.common.objects.verification import Verification  # noqa"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_afebf1da","line":20,"updated":"2015-11-12 23:37:12.000000000","message":"currently, we have a hacking rule that checks that only rally.common.objects is imported(instead of rally.common.objects.endpoind and others), so we can add here a warning class:\n\n    class Endpoint(Credentials):\n        def __init__(self, *args, **kwargs):\n             super(Endpoint, self).__init__(*args, **kwargs)\n             import warnings  # import this library only when it required\n             warnings.warn(\"Endpoint is deprecated...\")","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"b42de320e5d201746db0f8870d21f69350fea526","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.common.objects.credential import Credential  # noqa"},{"line_number":18,"context_line":"from rally.common.objects.deploy import Deployment  # noqa"},{"line_number":19,"context_line":"from rally.common.objects.task import Task  # noqa"},{"line_number":20,"context_line":"from rally.common.objects.verification import Verification  # noqa"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_fc5502fa","line":20,"in_reply_to":"da85f559_afebf1da","updated":"2015-11-13 09:45:24.000000000","message":"I renamed all the places that use objects.Endpoint to objects.Credential, do I still need to remain objects.Endpoint?","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ecd8c73f032ed1769b374c5b92aac1d112efa0f3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.common.objects.credential import Credential  # noqa"},{"line_number":18,"context_line":"from rally.common.objects.deploy import Deployment  # noqa"},{"line_number":19,"context_line":"from rally.common.objects.task import Task  # noqa"},{"line_number":20,"context_line":"from rally.common.objects.verification import Verification  # noqa"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_5c2f6ef6","line":20,"in_reply_to":"da85f559_fc5502fa","updated":"2015-11-13 09:59:46.000000000","message":"Unfortunately, yes. Most of things in Rally are plugins. It means that someone can use this object and we will break his functional without any warning:)","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"}],"rally/deployment/serverprovider/providers/openstack.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"11e665728cf3af7e90c2ff72209a1aa6787e8283","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            self.glance \u003d clients.glance()"},{"line_number":146,"context_line":"        except KeyError:"},{"line_number":147,"context_line":"            self.glance \u003d None"},{"line_number":148,"context_line":"            LOG.warning(_(\"Glance credential not available in service catalog\""},{"line_number":149,"context_line":"                          \", only existing images can be used\"))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_image_uuid(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_4f92854d","line":148,"updated":"2015-11-12 23:37:12.000000000","message":"You should leave here word \"endpoint\". It doesn\u0027t relate to objects.Endpoint","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"b42de320e5d201746db0f8870d21f69350fea526","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            self.glance \u003d clients.glance()"},{"line_number":146,"context_line":"        except KeyError:"},{"line_number":147,"context_line":"            self.glance \u003d None"},{"line_number":148,"context_line":"            LOG.warning(_(\"Glance credential not available in service catalog\""},{"line_number":149,"context_line":"                          \", only existing images can be used\"))"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_image_uuid(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_c10b772a","line":148,"in_reply_to":"da85f559_4f92854d","updated":"2015-11-13 09:45:24.000000000","message":"Done","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"}],"rally/plugins/openstack/context/keystone/existing_users.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"11e665728cf3af7e90c2ff72209a1aa6787e8283","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"name\": user_kclient.tenant_name"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            self.context[\"users\"].append({"},{"line_number":62,"context_line":"                \"credential\": user_credential,"},{"line_number":63,"context_line":"                \"id\": user_kclient.user_id,"},{"line_number":64,"context_line":"                \"tenant_id\": user_kclient.tenant_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_4f1b6581","line":61,"updated":"2015-11-12 23:37:12.000000000","message":"I don\u0027t now how, but we should leave \"endpoint\" key too and somehow warn people that it is deprecated.[you can ignore this comment, until we have solution]","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"b42de320e5d201746db0f8870d21f69350fea526","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"name\": user_kclient.tenant_name"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            self.context[\"users\"].append({"},{"line_number":62,"context_line":"                \"credential\": user_credential,"},{"line_number":63,"context_line":"                \"id\": user_kclient.user_id,"},{"line_number":64,"context_line":"                \"tenant_id\": user_kclient.tenant_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_9c8cf680","line":61,"in_reply_to":"da85f559_4f1b6581","updated":"2015-11-13 09:45:24.000000000","message":"This \"endpoint\" is the key name for a objects.Endpoint instance, since I have renamed Endpoint to Credential, shouldn\u0027t the key name be changed?\n\nor do you mean I should not modify objects.Endpoint to objects.Credential for where it is used, and add warning as you suggested in rally/common/objects/__init__.py?","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ecd8c73f032ed1769b374c5b92aac1d112efa0f3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"name\": user_kclient.tenant_name"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            self.context[\"users\"].append({"},{"line_number":62,"context_line":"                \"credential\": user_credential,"},{"line_number":63,"context_line":"                \"id\": user_kclient.user_id,"},{"line_number":64,"context_line":"                \"tenant_id\": user_kclient.tenant_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_fc6bc2ef","line":61,"in_reply_to":"da85f559_9c8cf680","updated":"2015-11-13 09:59:46.000000000","message":"\u003eThis \"endpoint\" is the key name for a objects.Endpoint instance, since I have renamed Endpoint to Credential, shouldn\u0027t the key name be changed?\n\nWe should add new key(credentials) and leave old key for some releases. But while I don\u0027t know how to add warning message for old key, so currently keep old key will not be helpful(users will not see warning -\u003e users will not change deprecated key to new one)\n\n\u003eor do you mean I should not modify objects.Endpoint to objects.Credential\n\nNo, you work on moving objects.Endpoint to objects.Credential is correct, but we still need to leave objects.Endpoint for backward compatibility.","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a7f0eb7e820da1f5de3b8180fc21fcb56d32cd93","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    \"name\": user_kclient.tenant_name"},{"line_number":59,"context_line":"                }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            self.context[\"users\"].append({"},{"line_number":62,"context_line":"                \"credential\": user_credential,"},{"line_number":63,"context_line":"                \"id\": user_kclient.user_id,"},{"line_number":64,"context_line":"                \"tenant_id\": user_kclient.tenant_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_908cd636","line":61,"in_reply_to":"da85f559_9c8cf680","updated":"2015-11-13 11:30:31.000000000","message":"Please, wait a bit, while I finish https://review.openstack.org/#/c/245094 . It should help for such changes.","commit_id":"1678bffc4ae80e06bb6243ca2580007a6df78a3e"}],"rally/plugins/openstack/context/swift/utils.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"6290acc309ec42762d7da3066bd50cf0ab27c579","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        containers \u003d []"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        def publish(queue):"},{"line_number":39,"context_line":"            print(\"publish\")"},{"line_number":40,"context_line":"            for user, tenant_id in (rutils.iterate_per_tenants("},{"line_number":41,"context_line":"                    context.get(\"users\", []))):"},{"line_number":42,"context_line":"                context[\"tenants\"][tenant_id][\"containers\"] \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_babf5ecf","line":39,"updated":"2015-11-09 15:38:35.000000000","message":"this should not be here","commit_id":"b53179746e60cb94cc4ac319d6dd3963ddae314a"}],"tests/hacking/checks.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"6290acc309ec42762d7da3066bd50cf0ab27c579","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    if filename \u003d\u003d \"./rally/common/objects/__init__.py\":"},{"line_number":274,"context_line":"        return"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    if filename \u003d\u003d \"./rally/common/objects/endpoint.py\":"},{"line_number":277,"context_line":"        return"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    if (logical_line.startswith(\"from rally.common.objects\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_ba099e97","line":276,"updated":"2015-11-09 15:38:35.000000000","message":"Why this is here? There no this file anymore","commit_id":"b53179746e60cb94cc4ac319d6dd3963ddae314a"}],"tests/unit/cli/commands/test_deployment.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"6290acc309ec42762d7da3066bd50cf0ab27c579","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            mock_update_env_file.assert_called_once_with(os.path.expanduser("},{"line_number":240,"context_line":"                \"~/.rally/globals\"),"},{"line_number":241,"context_line":"                \"RALLY_DEPLOYMENT\", \"%s\\n\" % deployment_id)"},{"line_number":242,"context_line":"            print(\"fake_endpoint\")"},{"line_number":243,"context_line":"            mock_file.return_value.write.assert_any_call("},{"line_number":244,"context_line":"                \"export OS_ENDPOINT\u003dfake_endpoint\\n\")"},{"line_number":245,"context_line":"            print(\"fake_auth\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_7a3a5638","line":242,"updated":"2015-11-09 15:38:35.000000000","message":"Please remove this two prints","commit_id":"b53179746e60cb94cc4ac319d6dd3963ddae314a"}]}
