)]}'
{"rally/plugins/openstack/scenarios/ceilometer/samples.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"05729ff2f01e8e088962f2b50ae66ecc328f56b1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def list_matched_samples(self, filter_by_resource_id\u003dFalse,"},{"line_number":28,"context_line":"                             filter_by_project_id\u003dFalse,"},{"line_number":29,"context_line":"                             filter_by_user_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_7e87a80f","line":26,"updated":"2015-11-17 09:49:41.000000000","message":"ceilometer doesn\u0027t have cleanup. So we don\u0027t need to call cleanup.","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2828e06d2d80a1d5cf1580dfdbc36cb18d2fb1a7","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def list_matched_samples(self, filter_by_resource_id\u003dFalse,"},{"line_number":28,"context_line":"                             filter_by_project_id\u003dFalse,"},{"line_number":29,"context_line":"                             filter_by_user_id\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_cf693627","line":26,"in_reply_to":"ba8a016a_7e87a80f","updated":"2015-11-17 13:14:31.000000000","message":"Done","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"05729ff2f01e8e088962f2b50ae66ecc328f56b1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":46,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":48,"context_line":"    def list_samples(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Fetch all available samples for list samples request."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_de76d43d","line":47,"updated":"2015-11-17 09:49:41.000000000","message":"ceilometer doesn\u0027t have cleanup. So we don\u0027t need to call cleanup.","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2828e06d2d80a1d5cf1580dfdbc36cb18d2fb1a7","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":46,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":48,"context_line":"    def list_samples(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Fetch all available samples for list samples request."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_6f784af3","line":47,"in_reply_to":"ba8a016a_de76d43d","updated":"2015-11-17 13:14:31.000000000","message":"Done","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"05729ff2f01e8e088962f2b50ae66ecc328f56b1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":48,"context_line":"    def list_samples(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Fetch all available samples for list samples request."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":52,"context_line":"        :param limit: count of samples in response"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_aaccea35","line":49,"updated":"2015-11-17 09:49:41.000000000","message":"it would be not clear for user what is going inside scenario","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2828e06d2d80a1d5cf1580dfdbc36cb18d2fb1a7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":47,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":48,"context_line":"    def list_samples(self, metadata_query\u003dNone, limit\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"Fetch all available samples for list samples request."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":52,"context_line":"        :param limit: count of samples in response"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_cf505661","line":49,"in_reply_to":"ba8a016a_aaccea35","updated":"2015-11-17 13:14:31.000000000","message":"Done","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"}],"tests/unit/plugins/openstack/scenarios/ceilometer/test_samples.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"05729ff2f01e8e088962f2b50ae66ecc328f56b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CeilometerSamplesTestCase(test.ScenarioTestCase):"},{"line_number":22,"context_line":"    def test_all_list_samples(self):"},{"line_number":23,"context_line":"        scenario \u003d samples.CeilometerSamples(self.context)"},{"line_number":24,"context_line":"        scenario.list_matched_samples \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_1ec53c8d","line":21,"updated":"2015-11-17 09:49:41.000000000","message":"Please add one empty line here.","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2828e06d2d80a1d5cf1580dfdbc36cb18d2fb1a7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CeilometerSamplesTestCase(test.ScenarioTestCase):"},{"line_number":22,"context_line":"    def test_all_list_samples(self):"},{"line_number":23,"context_line":"        scenario \u003d samples.CeilometerSamples(self.context)"},{"line_number":24,"context_line":"        scenario.list_matched_samples \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_af5f1240","line":21,"in_reply_to":"ba8a016a_1ec53c8d","updated":"2015-11-17 13:14:31.000000000","message":"Done","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"}],"tests/unit/plugins/openstack/scenarios/ceilometer/test_utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"05729ff2f01e8e088962f2b50ae66ecc328f56b1","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            self.scenario._list_samples(),"},{"line_number":201,"context_line":"            self.clients(\"ceilometer\").samples.list.return_value)"},{"line_number":202,"context_line":"        self.clients(\"ceilometer\").samples.list.assert_called_once_with("},{"line_number":203,"context_line":"            q\u003dNone, limit\u003dNone)"},{"line_number":204,"context_line":"        self._test_atomic_action_timer(self.scenario.atomic_actions(),"},{"line_number":205,"context_line":"                                       \"ceilometer.list_samples\")"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_1e21bc4d","line":203,"updated":"2015-11-17 09:49:41.000000000","message":"Please add test were we specify \u0027q\u0027 and \u0027limit\u0027. Also check that _make_profiler_key function was called. If you wrote second test like test__list_samples_with_params then better use ddt module","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"2828e06d2d80a1d5cf1580dfdbc36cb18d2fb1a7","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            self.scenario._list_samples(),"},{"line_number":201,"context_line":"            self.clients(\"ceilometer\").samples.list.return_value)"},{"line_number":202,"context_line":"        self.clients(\"ceilometer\").samples.list.assert_called_once_with("},{"line_number":203,"context_line":"            q\u003dNone, limit\u003dNone)"},{"line_number":204,"context_line":"        self._test_atomic_action_timer(self.scenario.atomic_actions(),"},{"line_number":205,"context_line":"                                       \"ceilometer.list_samples\")"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_d20f992c","line":203,"in_reply_to":"ba8a016a_1e21bc4d","updated":"2015-11-17 13:14:31.000000000","message":"Done","commit_id":"1f205f8be7a57e493adbba3c8986412741362292"}]}