)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"198b013bb0575b9587e022152e63c83013eaf7d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"with using new Ceilometer context and adding new configured"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It allow to find a weak places in requesting Ceilometer data."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iccde7422016e87f20237721b7fc1fb379646adf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a8ffd7b_741f3908","line":14,"updated":"2015-11-27 16:58:01.000000000","message":"*allows","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"e7943a60612d92768f354b64ebe745a189cd811c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"with using new Ceilometer context and adding new configured"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It allow to find a weak places in requesting Ceilometer data."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iccde7422016e87f20237721b7fc1fb379646adf8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a8ffd7b_6ec2e154","line":14,"in_reply_to":"9a8ffd7b_741f3908","updated":"2015-11-30 14:29:37.000000000","message":"Done","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"}],"rally/plugins/openstack/scenarios/ceilometer/stats.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b3637e9de8017d0abffcb83b8c1b9578d388ead","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def create_meter_and_get_stats(self, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Create a meter and fetch its statistics."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        Meter is first created and then statistics is fetched for the same"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_dd54a855","side":"PARENT","line":27,"updated":"2015-11-17 00:43:05.000000000","message":"I think that this is not backward compatibility change. Therefore we need to add the new one(and mark this scenario with deprecated msg if we plan to extract it in future) instead of modifying existed.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d76ae78d87b6c46c10c6cc464ddbf4813794b09b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def create_meter_and_get_stats(self, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Create a meter and fetch its statistics."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        Meter is first created and then statistics is fetched for the same"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_03b5d5ec","side":"PARENT","line":27,"in_reply_to":"ba8a016a_dd54a855","updated":"2015-11-17 13:59:40.000000000","message":"It was not a bencmark scenario just api works test. Now when we can create samples in context this new scenario will test statistics performance.","commit_id":"a5ec86eca381764a08309a05131d6a076046868a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b3637e9de8017d0abffcb83b8c1b9578d388ead","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def get_stats(self, meter_name, filter_by_user_id\u003dFalse,"},{"line_number":28,"context_line":"                  filter_by_project_id\u003dFalse, filter_by_resource_id\u003dFalse,"},{"line_number":29,"context_line":"                  metadata_query\u003dNone, period\u003dNone, groupby\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_fd92cc56","line":26,"updated":"2015-11-17 00:43:05.000000000","message":"Ceilometer don\u0027t have cleanup. So we don\u0027t need it.","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d76ae78d87b6c46c10c6cc464ddbf4813794b09b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"ceilometer\"]})"},{"line_number":27,"context_line":"    def get_stats(self, meter_name, filter_by_user_id\u003dFalse,"},{"line_number":28,"context_line":"                  filter_by_project_id\u003dFalse, filter_by_resource_id\u003dFalse,"},{"line_number":29,"context_line":"                  metadata_query\u003dNone, period\u003dNone, groupby\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_6362a1af","line":26,"in_reply_to":"ba8a016a_fd92cc56","updated":"2015-11-17 13:59:40.000000000","message":"Done","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"198b013bb0575b9587e022152e63c83013eaf7d0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @validation.required_services(consts.Service.CEILOMETER)"},{"line_number":25,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":26,"context_line":"    @scenario.configure()"},{"line_number":27,"context_line":"    def get_stats(self, meter_name, filter_by_user_id\u003dFalse,"},{"line_number":28,"context_line":"                  filter_by_project_id\u003dFalse, filter_by_resource_id\u003dFalse,"},{"line_number":29,"context_line":"                  metadata_query\u003dNone, period\u003dNone, groupby\u003dNone,"},{"line_number":30,"context_line":"                  aggregates\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_f4d6c94d","line":27,"updated":"2015-11-27 16:58:01.000000000","message":"We need to do this in backward compatible style. Please mark old method with deprecation decorator https://github.com/openstack/rally/blob/master/rally/common/log.py#L216 and create the new one - get_stats.","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"7cfc47278d60c8c62430df26d6308ddf4ff62239","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":41,"context_line":"        :param period: the length of the time range covered by these stats"},{"line_number":42,"context_line":"        :param groupby: the fields used to group the samples"},{"line_number":43,"context_line":"        :param aggregates: function for samples aggregation"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        :returns: list of statistics data"},{"line_number":46,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_5051a1d7","line":43,"updated":"2015-11-20 13:47:52.000000000","message":"Maybe `function name\u0027, not just function? It is impossible to use callable in scenario arguments","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"198b013bb0575b9587e022152e63c83013eaf7d0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":41,"context_line":"        :param period: the length of the time range covered by these stats"},{"line_number":42,"context_line":"        :param groupby: the fields used to group the samples"},{"line_number":43,"context_line":"        :param aggregates: function for samples aggregation"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        :returns: list of statistics data"},{"line_number":46,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_9425fd5c","line":43,"in_reply_to":"ba8a016a_5051a1d7","updated":"2015-11-27 16:58:01.000000000","message":"Agree. Looks like its a list of something https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/v2/statistics.py#L50","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"e7943a60612d92768f354b64ebe745a189cd811c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        :param metadata_query: dict with metadata fields and values for query"},{"line_number":41,"context_line":"        :param period: the length of the time range covered by these stats"},{"line_number":42,"context_line":"        :param groupby: the fields used to group the samples"},{"line_number":43,"context_line":"        :param aggregates: function for samples aggregation"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        :returns: list of statistics data"},{"line_number":46,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_4eda7d18","line":43,"in_reply_to":"ba8a016a_5051a1d7","updated":"2015-11-30 14:29:37.000000000","message":"Done","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"}],"rally/plugins/openstack/scenarios/ceilometer/utils.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b3637e9de8017d0abffcb83b8c1b9578d388ead","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    def _get_stats(self, meter_name, q\u003dNone, period\u003dNone, groupby\u003dNone):"},{"line_number":306,"context_line":"        \"\"\"Get stats for a specific meter."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param meter_name: Name of ceilometer meter"},{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        return self.clients(\"ceilometer\").statistics.list(meter_name, q\u003dNone,"},{"line_number":311,"context_line":"                                                          period\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bd31a4ee","line":308,"updated":"2015-11-17 00:43:05.000000000","message":"Here are more parameters. Please doc all of them. Also here is exists return value.","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d76ae78d87b6c46c10c6cc464ddbf4813794b09b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"    def _get_stats(self, meter_name, q\u003dNone, period\u003dNone, groupby\u003dNone):"},{"line_number":306,"context_line":"        \"\"\"Get stats for a specific meter."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param meter_name: Name of ceilometer meter"},{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        return self.clients(\"ceilometer\").statistics.list(meter_name, q\u003dNone,"},{"line_number":311,"context_line":"                                                          period\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_5ef2d270","line":308,"in_reply_to":"ba8a016a_bd31a4ee","updated":"2015-11-17 13:59:40.000000000","message":"Done","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b3637e9de8017d0abffcb83b8c1b9578d388ead","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        return self.clients(\"ceilometer\").statistics.list(meter_name, q\u003dNone,"},{"line_number":311,"context_line":"                                                          period\u003dNone,"},{"line_number":312,"context_line":"                                                          groupby\u003dNone)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @atomic.action_timer(\"ceilometer.create_meter\")"},{"line_number":315,"context_line":"    def _create_meter(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bd4684bd","line":312,"updated":"2015-11-17 00:43:05.000000000","message":"It also have https://github.com/openstack/python-ceilometerclient/blob/master/ceilometerclient/v2/statistics.py#L48 \u0027aggregates\u0027 parameter. Please add it.","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d76ae78d87b6c46c10c6cc464ddbf4813794b09b","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        \"\"\""},{"line_number":310,"context_line":"        return self.clients(\"ceilometer\").statistics.list(meter_name, q\u003dNone,"},{"line_number":311,"context_line":"                                                          period\u003dNone,"},{"line_number":312,"context_line":"                                                          groupby\u003dNone)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    @atomic.action_timer(\"ceilometer.create_meter\")"},{"line_number":315,"context_line":"    def _create_meter(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_1eec4a8e","line":312,"in_reply_to":"ba8a016a_bd4684bd","updated":"2015-11-17 13:59:40.000000000","message":"Done","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"198b013bb0575b9587e022152e63c83013eaf7d0","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        \"\"\"Get stats for a specific meter."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        :param meter_name: Name of ceilometer meter"},{"line_number":325,"context_line":"        :param q: list of queries"},{"line_number":326,"context_line":"        :param period: the length of the time range covered by these stats"},{"line_number":327,"context_line":"        :param groupby: the fields used to group the samples"},{"line_number":328,"context_line":"        :param aggregates: function for samples aggregation"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_3450d1d3","line":325,"updated":"2015-11-27 16:58:01.000000000","message":"Agree with Illia. This is bad name for variable","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"e7943a60612d92768f354b64ebe745a189cd811c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        \"\"\"Get stats for a specific meter."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        :param meter_name: Name of ceilometer meter"},{"line_number":325,"context_line":"        :param q: list of queries"},{"line_number":326,"context_line":"        :param period: the length of the time range covered by these stats"},{"line_number":327,"context_line":"        :param groupby: the fields used to group the samples"},{"line_number":328,"context_line":"        :param aggregates: function for samples aggregation"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2e1859d2","line":325,"in_reply_to":"9a8ffd7b_3450d1d3","updated":"2015-11-30 14:29:37.000000000","message":"Done","commit_id":"b778df9b1eb23d8c15c28ddbe44c062f6d2c12a4"}],"tests/unit/plugins/openstack/scenarios/ceilometer/test_stats.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9a5f018cce74a000c376adde850f1cc8107c5f60","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CeilometerStatsTestCase(test.ScenarioTestCase):"},{"line_number":22,"context_line":"    def test_get_stats(self):"},{"line_number":23,"context_line":"        scenario \u003d stats.CeilometerStats(self.context)"},{"line_number":24,"context_line":"        scenario._get_stats \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_deb9f42f","line":21,"updated":"2015-11-17 07:49:29.000000000","message":"Add one empty line here please.","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d76ae78d87b6c46c10c6cc464ddbf4813794b09b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tests.unit import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class CeilometerStatsTestCase(test.ScenarioTestCase):"},{"line_number":22,"context_line":"    def test_get_stats(self):"},{"line_number":23,"context_line":"        scenario \u003d stats.CeilometerStats(self.context)"},{"line_number":24,"context_line":"        scenario._get_stats \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_d90fbc2c","line":21,"in_reply_to":"ba8a016a_deb9f42f","updated":"2015-11-17 13:59:40.000000000","message":"Done","commit_id":"7ea66b631f9eb7790426832ac9e185fea460a6bc"}]}