)]}'
{"doc/specs/in-progress/deployment_plugin_base.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f29aedac949e225c4ce4bbd7d536e80f9385af91","unresolved":false,"context_lines":[{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":" Move Rally deployment to plugin base"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_f148565e","line":6,"updated":"2015-12-02 15:50:12.000000000","message":"Here is missed paragraph - AFAIK it should be copied as-is from spec template (starts with \"This template should be in ReSTructured text.\")","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"3f6da49f7893c35aafb25ce0ee228b97b4601a23","unresolved":false,"context_lines":[{"line_number":3,"context_line":" License."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":" Move Rally deployment to plugin base"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_6f2d1ffd","line":6,"in_reply_to":"9a8ffd7b_f148565e","updated":"2015-12-03 15:31:05.000000000","message":"https://raw.githubusercontent.com/openstack/rally/master/doc/specs/in-progress/cleanup_refactoring.rst\n\nhttps://raw.githubusercontent.com/openstack/rally/master/doc/specs/in-progress/consistent_resource_names.rst","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f29aedac949e225c4ce4bbd7d536e80f9385af91","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # Implemented in successor"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def __init__(self, credential\u003dNone, **attributes)"},{"line_number":67,"context_line":"    \"\"\" Create credential object and store to database or use provided \"\"\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def validate(self)"},{"line_number":70,"context_line":"    \"\"\" Validate JSON schema and try to connect to application"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_34a56ca1","line":67,"updated":"2015-12-02 15:50:12.000000000","message":"One-line docstring must end with period https://www.python.org/dev/peps/pep-0257/#one-line-docstrings","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"3f6da49f7893c35aafb25ce0ee228b97b4601a23","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # Implemented in successor"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def __init__(self, credential\u003dNone, **attributes)"},{"line_number":67,"context_line":"    \"\"\" Create credential object and store to database or use provided \"\"\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def validate(self)"},{"line_number":70,"context_line":"    \"\"\" Validate JSON schema and try to connect to application"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_ef410faa","line":67,"in_reply_to":"9a8ffd7b_34a56ca1","updated":"2015-12-03 15:31:05.000000000","message":"Done","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"f29aedac949e225c4ce4bbd7d536e80f9385af91","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. code-block:: python"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  class Credential(BASE, RallyBase):"},{"line_number":104,"context_line":"      \"\"\"Represent credential.\"\"\""},{"line_number":105,"context_line":"      __tablename__ \u003d \"credentials\""},{"line_number":106,"context_line":"      __table_args__ \u003d ("}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a8ffd7b_9759ba37","line":103,"updated":"2015-12-02 15:50:12.000000000","message":"Is that normal to widely use Credential instances that are not saved to the database - for example when we create users by users context (each user should have its own Credential and therefore osclients.Clients instance).\n\nSuch usage of unsaved models looks something strange - this is not the case models are intended for.","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"3f6da49f7893c35aafb25ce0ee228b97b4601a23","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. code-block:: python"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  class Credential(BASE, RallyBase):"},{"line_number":104,"context_line":"      \"\"\"Represent credential.\"\"\""},{"line_number":105,"context_line":"      __tablename__ \u003d \"credentials\""},{"line_number":106,"context_line":"      __table_args__ \u003d ("}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a740942_f4e1b0d1","line":103,"in_reply_to":"9a8ffd7b_9759ba37","updated":"2015-12-03 15:31:05.000000000","message":"Done","commit_id":"fe7bc047b7457f33f3de0a192262ee1ade198ce4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":14,"context_line":" To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":" Move Rally deployment to plugin base"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Make Rally be able to examine any kind of software, not only OpenStack."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_a41ebd6d","line":17,"updated":"2015-12-08 19:33:42.000000000","message":"They are already based on plugin base. Did you see the code? \nhttps://github.com/openstack/rally/blob/master/rally/deployment/engine.py#L42","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Problem description"},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Rally is not able to examine anything but applications with openstack/keystone"},{"line_number":26,"context_line":"(OpenStack derivatives) because \u0027deployment\u0027 and \u0027endpoint\u0027"},{"line_number":27,"context_line":"objects are designed to store \u0027keystone\u0027 related data. Variety of applications"},{"line_number":28,"context_line":"and solutions enforce Rally to be able to manipulate variety of endpoint data"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_9f7aee86","line":25,"updated":"2015-12-08 19:33:42.000000000","message":"Rally is able to examine only system that use Keystone as a authentication services, which limits sphere where Rally is suitable.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Rally is not able to examine anything but applications with openstack/keystone"},{"line_number":26,"context_line":"(OpenStack derivatives) because \u0027deployment\u0027 and \u0027endpoint\u0027"},{"line_number":27,"context_line":"objects are designed to store \u0027keystone\u0027 related data. Variety of applications"},{"line_number":28,"context_line":"and solutions enforce Rally to be able to manipulate variety of endpoint data"},{"line_number":29,"context_line":"structures, from empty structure to some very complicated one."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_5f432613","line":26,"updated":"2015-12-08 19:33:42.000000000","message":"credentials not endpoint, we finally rename all places.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"and solutions enforce Rally to be able to manipulate variety of endpoint data"},{"line_number":29,"context_line":"structures, from empty structure to some very complicated one."},{"line_number":30,"context_line":"Scenarios and contexts depend of commutication interface and application"},{"line_number":31,"context_line":"architecture, thus we have to match which application scenario can examine."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_3faada85","line":31,"updated":"2015-12-08 19:33:42.000000000","message":"I don\u0027t understand this sentence \u003d( \n\nMaybe you were trying to say something like:\n\nAt the moment to Run Rally Task or Rally Verify you must specify OpenStack deployment which contains credentials of it. These credentials are used in Rally Task \u0026 Verify for different setups and validations.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e0ad3d27dd941a44006e42c528c324035ac4afdb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Remove deployment engines and server providers, cause this makes difficult"},{"line_number":37,"context_line":"  to provide engines for deploy test deployment of any supported"},{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_c085075a","line":36,"updated":"2015-12-08 14:17:17.000000000","message":"I like this idea, but we should ensure that nobody use them.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Remove deployment engines and server providers, cause this makes difficult"},{"line_number":37,"context_line":"  to provide engines for deploy test deployment of any supported"},{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_9f1e6e6e","line":36,"in_reply_to":"7a740942_93119b06","updated":"2015-12-08 19:33:42.000000000","message":"I disagree on this a LOT I will disagree even more if I could:  \n\n  - This doesn\u0027t make any sense \n\n  - I know people who is using this\n\n  - It doesn\u0027t make anything difficult \n\n  - We don\u0027t need to provide deploying mechanism for everything. Who said that? We just need to provide ability to write such plugging. \n\n  - We need to provide only plugins for using existing \"tool\". \n\n  - We can use any tool for deploying in plugins\n\nAnd I really DO NOT know how it\u0027s even close related to task that you are resolving.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"f11461aba94614fd6c63d6ae3c4ce9caba4fd4b4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"Proposed change"},{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Remove deployment engines and server providers, cause this makes difficult"},{"line_number":37,"context_line":"  to provide engines for deploy test deployment of any supported"},{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_93119b06","line":36,"in_reply_to":"7a740942_c085075a","updated":"2015-12-08 14:54:11.000000000","message":"Agree","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e0ad3d27dd941a44006e42c528c324035ac4afdb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Merge rally.common.objects.deploy.Deployment and"},{"line_number":42,"context_line":"  rally.common.objects.crededential.Credential because without data related to"},{"line_number":43,"context_line":"  deployment engine deployment object will contain only endpoint data. But"},{"line_number":44,"context_line":"  unlike Credential object, Deployment is persistent, has name and can be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_a0cc7bbb","line":41,"updated":"2015-12-08 14:17:17.000000000","message":"In case of existing users, how big number of \"credentials\"(old meaning) will be stored?","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"564e71eee9d7ca0dfeafa8b92c6bbb7f4ddb35b7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Merge rally.common.objects.deploy.Deployment and"},{"line_number":42,"context_line":"  rally.common.objects.crededential.Credential because without data related to"},{"line_number":43,"context_line":"  deployment engine deployment object will contain only endpoint data. But"},{"line_number":44,"context_line":"  unlike Credential object, Deployment is persistent, has name and can be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_acea3472","line":41,"in_reply_to":"7a740942_5176cb70","updated":"2015-12-08 15:14:53.000000000","message":"I\u0027m not talking about db part. Currently, I\u0027m able to execute next code:\n\n    deployment \u003d api.Deployment.get(\"uuid\")\n    print(\"Admin credentials: %s \" % deployment[\"admin\"])\n    print(\"Users credentials:\")\n    for user in deployment[\"users\"]:\n        print(\"\\t%s\" % user)\n\nHow this code will look after proposed change?","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"f11461aba94614fd6c63d6ae3c4ce9caba4fd4b4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Merge rally.common.objects.deploy.Deployment and"},{"line_number":42,"context_line":"  rally.common.objects.crededential.Credential because without data related to"},{"line_number":43,"context_line":"  deployment engine deployment object will contain only endpoint data. But"},{"line_number":44,"context_line":"  unlike Credential object, Deployment is persistent, has name and can be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_5176cb70","line":41,"in_reply_to":"7a740942_a0cc7bbb","updated":"2015-12-08 14:54:11.000000000","message":"So... in mysql we are able to store 65,535 bytes in TEXT column (21,844 haracters if the charset is UTF8).\n\nSQLite:\nThe maximum number of bytes in a string or BLOB in SQLite is defined by the preprocessor macro SQLITE_MAX_LENGTH. The default value of this macro is 1 billion (1 thousand million or 1,000,000,000). You can raise or lower this value at compile-time using a command-line option.\n\nPostgres:\nLimitless","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"8735c912379147432822c9bc0698de8ae47c569d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  software/service. There are many powerful IT management solutions: Puppet,"},{"line_number":39,"context_line":"  Ansible etc."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* Merge rally.common.objects.deploy.Deployment and"},{"line_number":42,"context_line":"  rally.common.objects.crededential.Credential because without data related to"},{"line_number":43,"context_line":"  deployment engine deployment object will contain only endpoint data. But"},{"line_number":44,"context_line":"  unlike Credential object, Deployment is persistent, has name and can be"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_870b917c","line":41,"in_reply_to":"7a740942_acea3472","updated":"2015-12-08 15:26:35.000000000","message":"Well, as this example is openstack related, so, in this case, according to changes, described in this spec, you\u0027ll get an objects.Credantial instance and be able to do something like\nprint(result[\"accounts\"][\"admin\"]) or\nprint(result[\"accounts\"][\"user\"])\nFinal structure should be developed later, i think.\nOr you are welcome to propose another approach.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  unlike Credential object, Deployment is persistent, has name and can be"},{"line_number":45,"context_line":"  set with cli during task start."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* New entity (let\u0027s call it Credential) has to be a successor of"},{"line_number":48,"context_line":"  rally.common.plugin.plugin.Plugin class."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Each Credential plugin has to contain JSON schema validation data and methods"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_1f0b5e2b","line":47,"updated":"2015-12-08 19:33:42.000000000","message":"no","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* New entity (let\u0027s call it Credential) has to be a successor of"},{"line_number":48,"context_line":"  rally.common.plugin.plugin.Plugin class."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"* Each Credential plugin has to contain JSON schema validation data and methods"},{"line_number":51,"context_line":"  to validate provided data."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* Current \u0027Credential\u0027 object is related to openstack deployments, so"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_bf056a14","line":50,"updated":"2015-12-08 19:33:42.000000000","message":"no","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0dfd3d6cf84fe6d80f17f45acd63592b250326e8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"* Each Credential plugin has to contain JSON schema validation data and methods"},{"line_number":51,"context_line":"  to validate provided data."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"* Current \u0027Credential\u0027 object is related to openstack deployments, so"},{"line_number":54,"context_line":"  should be reimplemented as part of openstack plugins."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_3a08a827","line":53,"updated":"2015-12-08 19:33:42.000000000","message":"no","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e0ad3d27dd941a44006e42c528c324035ac4afdb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    \"\"\" Delete this credential from database. \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"*rally.common.db.sqlalchemy.models.Credential*"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. code-block:: python"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_40eb57df","line":111,"updated":"2015-12-08 14:17:17.000000000","message":"Unfortunately, rally did not support db migrations yet. It means that we can\u0027t change database schema.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"f11461aba94614fd6c63d6ae3c4ce9caba4fd4b4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    \"\"\" Delete this credential from database. \"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"*rally.common.db.sqlalchemy.models.Credential*"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. code-block:: python"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_73598f8d","line":111,"in_reply_to":"7a740942_40eb57df","updated":"2015-12-08 14:54:11.000000000","message":"Boris told, that we\u0027ll change db schema. So.. I believe, that there were several patches, that change db schema for different purposes, and release will be cut.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"86f76233038e62f5b2c42559b902da4d2d19d74a","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* Update openstack context, scenario and osclients plugins to use dict instead"},{"line_number":177,"context_line":"  of \u0027objects.credential.Credential\u0027."},{"line_number":178,"context_line":"  Remove \u0027objects.Credential\u0027 object."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Implement new plugin based \u0027BaseCredential\u0027 and openstack Credential plugin"},{"line_number":181,"context_line":"  with validation."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_ef299938","line":178,"updated":"2015-12-04 15:59:59.000000000","message":"This really looks like a redundant step. We\u0027re to refactor a lot of code here, and don\u0027t forget tests. Why not just implement BaseCredential and then drop objects.credential.Credential?","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"f24aea25918cac20f646a3ed45e69abbcb666014","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"* Update openstack context, scenario and osclients plugins to use dict instead"},{"line_number":177,"context_line":"  of \u0027objects.credential.Credential\u0027."},{"line_number":178,"context_line":"  Remove \u0027objects.Credential\u0027 object."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"* Implement new plugin based \u0027BaseCredential\u0027 and openstack Credential plugin"},{"line_number":181,"context_line":"  with validation."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7a740942_3a30419e","line":178,"in_reply_to":"7a740942_ef299938","updated":"2015-12-04 16:12:39.000000000","message":"Current objects.Credential is used for non persistent accaunts, geterated by contexts and scenarios. New \nCredential is more like objects.Deployment and will be used\naccordingly. Cause current Credential is openstack related and is used, basicaly, as container we should reimplement it as dict. I believe that this is separate complicated step.","commit_id":"48eafc82ecfad540e54ab8b5b53978a36b32763e"}],"doc/specs/in-progress/deployment_type.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"Deployment"},{"line_number":19,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Make Rally be able to examine any kind of software, not only OpenStack."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_d7699dbf","line":18,"updated":"2015-12-18 11:25:00.000000000","message":"This header looks too short. Maybe something like \"Making Deployment more flexible\" or \"Unbound Deployment from OpenStack\" or something else with few words what is this spec about","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"Proposed change"},{"line_number":35,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* Add \u0027type\u0027 attribute to deployment, that well be automaticaly set by"},{"line_number":38,"context_line":"  deployment engine."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Modify \u0027Deployment\u0027 database model to be anle to store any kind and structure"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_b7ff31a9","line":37,"updated":"2015-12-18 11:25:00.000000000","message":"1) s/well/will/\n2) Please clarify which exact `deployment\u0027 entity is this about - models.Deployment, objects.deploy.Deployment or even maybe deployment.engine.Engine?","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"* Add \u0027type\u0027 attribute to deployment, that well be automaticaly set by"},{"line_number":38,"context_line":"  deployment engine."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"* Modify \u0027Deployment\u0027 database model to be anle to store any kind and structure"},{"line_number":41,"context_line":"  of credentials."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Implement validator for credentials according deployment type."}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_3a87a8d8","line":40,"updated":"2015-12-18 11:25:00.000000000","message":"s/anle/able/","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Modify \u0027Deployment\u0027 database model to be anle to store any kind and structure"},{"line_number":41,"context_line":"  of credentials."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Implement validator for credentials according deployment type."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Update cli to show deployment type in output of \u0027rally deployment list\u0027."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_7503010e","line":43,"updated":"2015-12-18 11:25:00.000000000","message":"How this validator will work? JsonSchema verification only or maybe some extra actions are possible like checking that remote environment is available?","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Assignee(s)"},{"line_number":60,"context_line":"-----------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Work Items"},{"line_number":65,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_554e0570","line":62,"updated":"2015-12-18 11:25:00.000000000","message":"Add at least one assignee","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"c3d92069c40f71e0880b5421a376621c9f99313f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"Work Items"},{"line_number":65,"context_line":"----------"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Dependencies"},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a7e1126_954c6d71","line":67,"updated":"2015-12-18 11:25:00.000000000","message":"This section can not be empty","commit_id":"c359e99b90d462d26f5a6645a97dd2a4cdf2cd95"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Rally Task \u0026 Verify for different setups and validations."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Rally is not able to store more than one credential for one deployment, so"},{"line_number":25,"context_line":"it is impossible to support multi-scenario runs."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_cbfd1d3c","line":25,"updated":"2016-03-02 09:04:24.000000000","message":"so this is not fully fair. \n\nWe are able to add multi-scenario load however there is no abbility to run multi-scenario where scenarios are related to different systems (e.g. IPMI scenario with Zabbix and OpenStack scenarios together)","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Rally Task \u0026 Verify for different setups and validations."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Rally is not able to store more than one credential for one deployment, so"},{"line_number":25,"context_line":"it is impossible to support multi-scenario runs."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_6e14c643","line":25,"in_reply_to":"7af24918_cbfd1d3c","updated":"2016-03-02 13:56:09.000000000","message":"I will rephrase it.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Modify \u0027Deployment\u0027 database model to be able to store any kind and structure"},{"line_number":32,"context_line":"  of credentials, adding type of deployment."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Now we have model Deployment with admin and users columns,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_aba6d150","line":31,"updated":"2016-03-02 09:04:24.000000000","message":"Actually not \"any\" rather we should say pluggable model that supports storing info about many systems.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Modify \u0027Deployment\u0027 database model to be able to store any kind and structure"},{"line_number":32,"context_line":"  of credentials, adding type of deployment."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Now we have model Deployment with admin and users columns,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_e4e9151c","line":31,"in_reply_to":"7af24918_aba6d150","updated":"2016-03-02 13:56:09.000000000","message":"Will fix","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"We need to decouple deployment from OpenStack and"},{"line_number":54,"context_line":"make credentials more flexible, we describe it in one column named"},{"line_number":55,"context_line":"``credentials``, where we can store anything, including type of creds."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: python"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_bda61851","line":55,"updated":"2016-03-02 09:04:24.000000000","message":"nope we can\u0027t store anything. We can store special strucutre that allows us to store credentials for many different systems.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"We need to decouple deployment from OpenStack and"},{"line_number":54,"context_line":"make credentials more flexible, we describe it in one column named"},{"line_number":55,"context_line":"``credentials``, where we can store anything, including type of creds."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. code-block:: python"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_247dbd6e","line":55,"in_reply_to":"7af24918_bda61851","updated":"2016-03-02 13:56:09.000000000","message":"Will fix","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        ],"},{"line_number":87,"context_line":"        ["},{"line_number":88,"context_line":"            \"zabbix\","},{"line_number":89,"context_line":"            {\"login\": admin, \"password\": \"admin\"}"},{"line_number":90,"context_line":"        ]"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_1d4bcc88","line":89,"updated":"2016-03-02 09:04:24.000000000","message":"you should have at least URL here.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        ],"},{"line_number":87,"context_line":"        ["},{"line_number":88,"context_line":"            \"zabbix\","},{"line_number":89,"context_line":"            {\"login\": admin, \"password\": \"admin\"}"},{"line_number":90,"context_line":"        ]"},{"line_number":91,"context_line":"    ]"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_33451717","line":89,"in_reply_to":"7af24918_1d4bcc88","updated":"2016-03-02 13:56:09.000000000","message":"Will do, but I add it just for example, I don\u0027t know which params are necessary for zabbix.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Future summarized schema in DB:"},{"line_number":94,"context_line":"``credentials \u003d [\u003ctype\u003e, \u003cCredentials\u003e], ... ]``"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"To implement this proposal we need to write db migration, tests for it"},{"line_number":97,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":98,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_a0554b51","line":96,"updated":"2016-03-02 09:04:24.000000000","message":"could you keep this as a list (or remove list * on 100 line)","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":93,"context_line":"Future summarized schema in DB:"},{"line_number":94,"context_line":"``credentials \u003d [\u003ctype\u003e, \u003cCredentials\u003e], ... ]``"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"To implement this proposal we need to write db migration, tests for it"},{"line_number":97,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":98,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_51241bae","line":96,"in_reply_to":"7af24918_a0554b51","updated":"2016-03-02 13:56:09.000000000","message":"I am going to change \"proposal\" to \"point\", because this sentence is about first point of proposal changes.","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"368ce8819aceeefb34d29c5039822d8d821eced9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"``credentials \u003d [\u003ctype\u003e, \u003cCredentials\u003e], ... ]``"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"To implement this proposal we need to write db migration, tests for it"},{"line_number":97,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":98,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Get rid of ``rally.common.objects.credential.Credential`` class"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_20c81b22","line":97,"updated":"2016-03-02 09:04:24.000000000","message":"write dummies? why?","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"9a0126ed76fe3c8b649cd0eb60365b0bb4a3aed1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"``credentials \u003d [\u003ctype\u003e, \u003cCredentials\u003e], ... ]``"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"To implement this proposal we need to write db migration, tests for it"},{"line_number":97,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":98,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"* Get rid of ``rally.common.objects.credential.Credential`` class"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7af24918_0ba37450","line":97,"in_reply_to":"7af24918_20c81b22","updated":"2016-03-02 13:56:09.000000000","message":"I mean code like this:\n\nvalues.setdefault(\n    \"credentials\",\n    [\n        [\"openstack\",\n         {\"admin\": values.get(\"admin\"),\n          \"users\": values.get(\"users\", [])}]\n    ]\n)\ndeployment.update(values)\n\n\nand for example like this:\n@property\ndef admin(self):\n    return self.credentials[0][1][\"admin\"]\n\nBecause we don\u0027t have multiple credentials dispatcher now, am i right?","commit_id":"48d7ec810fdc9cbb1abc9bd0116ead37f39ba7ec"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"65442a9e328e24f288c2d789f53b3c36e20378ab","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        users \u003d sa.Column(types.PickleType, default\u003d[], nullable\u003dFalse)"},{"line_number":45,"context_line":"        ..."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"and columns in DB something like that:"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"``admin \u003d {admin_creds} or None``"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_dce906b9","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":11},"updated":"2016-03-03 12:33:07.000000000","message":"Maybe something like \"values of columns\"?","commit_id":"c4859ca97af173b6eac7d8859d4ed7a3e73ec4cb"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"65442a9e328e24f288c2d789f53b3c36e20378ab","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    ]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Future summarized schema in DB:"},{"line_number":95,"context_line":"``credentials \u003d [\u003ctype\u003e, \u003cCredentials\u003e], ... ]``"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"To implement this point we need to write db migration, tests for it"},{"line_number":98,"context_line":"and write \"dummies\" for credentials get/create/update methods,"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7af24918_bc2cfa02","line":95,"range":{"start_line":95,"start_character":16,"end_line":95,"end_character":17},"updated":"2016-03-03 12:33:07.000000000","message":"one more \"[\" is required here:)","commit_id":"c4859ca97af173b6eac7d8859d4ed7a3e73ec4cb"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Rally Deployment Unification"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make Rally be able to examine any kind of software, unbound it from OpenStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_675dde78","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":40},"updated":"2016-03-09 13:17:14.000000000","message":"I think that not \"any kind software\" but \"any software through the API\" possibly","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Rally Deployment Unification"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make Rally be able to examine any kind of software, unbound it from OpenStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_a7c99328","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":40},"in_reply_to":"5aef4532_675dde78","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Modify \u0027Deployment\u0027 database model to be able to store credentials"},{"line_number":32,"context_line":"  about many different systems, adding type of system."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Now we have model Deployment with admin and users columns,"},{"line_number":35,"context_line":"which are credentials for Keystone (tight coupled with OpenStack)."}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_42289086","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":7},"updated":"2016-03-09 13:17:14.000000000","message":"about -\u003e of ?","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* Modify \u0027Deployment\u0027 database model to be able to store credentials"},{"line_number":32,"context_line":"  about many different systems, adding type of system."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Now we have model Deployment with admin and users columns,"},{"line_number":35,"context_line":"which are credentials for Keystone (tight coupled with OpenStack)."}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_0702073d","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":7},"in_reply_to":"5aef4532_42289086","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":98,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":99,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Get rid of ``rally.common.objects.credential.Credential`` class"},{"line_number":102,"context_line":"  and fix it usages mostly in ``rally.osclients`` if needed."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Refactor all usages of passing ``rally.common.objects.credential.Credential``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_dbc64699","line":101,"updated":"2016-03-09 13:17:14.000000000","message":"As clarification. We don\u0027t want to \"get rid of\" because of backward compatibility. For example we want get rid of creation https://github.com/openstack/rally/blob/master/rally/api.py#L142 object of this class, but not from class itself.","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"and write \"dummies\" for credentials get/create/update methods,"},{"line_number":99,"context_line":"mostly for support backward compatibility in ``rally.api`` module methods."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* Get rid of ``rally.common.objects.credential.Credential`` class"},{"line_number":102,"context_line":"  and fix it usages mostly in ``rally.osclients`` if needed."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Refactor all usages of passing ``rally.common.objects.credential.Credential``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_3d2bd495","line":101,"in_reply_to":"5aef4532_dbc64699","updated":"2016-03-09 17:02:31.000000000","message":"Shouldn\u0027t we?\nI think, that we should remove rally.common.objects.credential.Credential class,\nthen we should add new plugin-based subclass OpenStackCredentials(Credentials(Plugin)) which will play old Credentials class role.","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Refactor all usages of passing ``rally.common.objects.credential.Credential``"},{"line_number":105,"context_line":"to ``rally.osclients.OSClient``, make possible to take dict as credentials"},{"line_number":106,"context_line":"for ``rally.osclients.OSClient`` class, make"},{"line_number":107,"context_line":"``rally.plugins.openstack.credentials.OpenStackCredentials`` class constructor"},{"line_number":108,"context_line":"in ``OSClient`` ``__init__`` method."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_fb44e2b7","line":106,"range":{"start_line":106,"start_character":40,"end_line":106,"end_character":44},"updated":"2016-03-09 13:17:14.000000000","message":"I don\u0027t understand \"make class constructor in\". Maybe you meant initialise or use verb there?","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Refactor all usages of passing ``rally.common.objects.credential.Credential``"},{"line_number":105,"context_line":"to ``rally.osclients.OSClient``, make possible to take dict as credentials"},{"line_number":106,"context_line":"for ``rally.osclients.OSClient`` class, make"},{"line_number":107,"context_line":"``rally.plugins.openstack.credentials.OpenStackCredentials`` class constructor"},{"line_number":108,"context_line":"in ``OSClient`` ``__init__`` method."},{"line_number":109,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_b82372a6","line":106,"range":{"start_line":106,"start_character":40,"end_line":106,"end_character":44},"in_reply_to":"5aef4532_fb44e2b7","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Base class for credentials will be inherited from plugins.Plugin"},{"line_number":111,"context_line":"and must implement validation method,"},{"line_number":112,"context_line":"it will live in ``rally.plugins.common.credentials``:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. code-block:: python"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_59336614","line":112,"updated":"2016-03-09 13:17:14.000000000","message":"live? -\u003e placed. it will be placed at","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Base class for credentials will be inherited from plugins.Plugin"},{"line_number":111,"context_line":"and must implement validation method,"},{"line_number":112,"context_line":"it will live in ``rally.plugins.common.credentials``:"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":".. code-block:: python"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_186b86b8","line":112,"in_reply_to":"5aef4532_59336614","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":114,"context_line":".. code-block:: python"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @six.add_metaclass(abc.ABCMeta)"},{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_fb534237","line":117,"updated":"2016-03-09 13:17:14.000000000","message":"I suggest not to use pruning here \"base_credentials\"","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":114,"context_line":".. code-block:: python"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @six.add_metaclass(abc.ABCMeta)"},{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_78a28afe","line":117,"in_reply_to":"5aef4532_fb534237","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45b24f4161e204ab9b092fcb1f9e82235230a688","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"},{"line_number":121,"context_line":"            self.validate(credentials)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def __getattr__(self, item):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7af24918_04c2b6e8","line":120,"updated":"2016-03-04 10:13:30.000000000","message":"If `credentials\u0027 is a dict part, so we probably should save credentials str type (like \"openstack\" or \"zabbix\") in some property too, shouldn\u0027t we?","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0116b3eec07b2e1cec0ab93d0a1d8232487fc4a5","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"},{"line_number":121,"context_line":"            self.validate(credentials)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def __getattr__(self, item):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_eb5db0ed","line":120,"in_reply_to":"5aef4532_0baa9cd4","updated":"2016-03-07 12:18:39.000000000","message":"@Sergey, look at L84 and L89 - these values \"openstack\" and \"zabbix\" are stored in the database - but how we bind these credentials with some Credentials subclasses?","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"},{"line_number":121,"context_line":"            self.validate(credentials)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def __getattr__(self, item):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_b85b72f5","line":120,"in_reply_to":"5aef4532_e149deb8","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d978687e5f6024805510e6180f9c5dfd2efd5d19","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"},{"line_number":121,"context_line":"            self.validate(credentials)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def __getattr__(self, item):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_e149deb8","line":120,"in_reply_to":"5aef4532_eb5db0ed","updated":"2016-03-09 10:49:38.000000000","message":"This is OK now. We simply set type via @configure decorator.","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"d242687ecc627b72cfa9b935a607b74639f563ce","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @plugin.configure(name\u003d\"base_creds\", schema\u003d\"{...}\")"},{"line_number":118,"context_line":"    class Credentials(plugin.Plugin):"},{"line_number":119,"context_line":"        def __init__(self, credentials):"},{"line_number":120,"context_line":"            self.credentials \u003d credentials"},{"line_number":121,"context_line":"            self.validate(credentials)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        def __getattr__(self, item):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_0baa9cd4","line":120,"in_reply_to":"7af24918_04c2b6e8","updated":"2016-03-07 12:14:35.000000000","message":"For what? Credentials type is class itself:\n\nclass OpenStack(credentials.Credentials):\n  pass","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"45b24f4161e204ab9b092fcb1f9e82235230a688","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        def __getattr__(self, item):"},{"line_number":124,"context_line":"            if item in self.__dict__:"},{"line_number":125,"context_line":"                return self.__dict__[item]"},{"line_number":126,"context_line":"            return self.credentials[item]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def __setattr__(self, key, value):"},{"line_number":129,"context_line":"            if key in self.__dict__:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7af24918_44d31ed5","line":126,"updated":"2016-03-04 10:13:30.000000000","message":"This will fall into recursion","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        def __getattr__(self, item):"},{"line_number":124,"context_line":"            if item in self.__dict__:"},{"line_number":125,"context_line":"                return self.__dict__[item]"},{"line_number":126,"context_line":"            return self.credentials[item]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def __setattr__(self, key, value):"},{"line_number":129,"context_line":"            if key in self.__dict__:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_78656ab3","line":126,"in_reply_to":"5aef4532_5c38793d","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d978687e5f6024805510e6180f9c5dfd2efd5d19","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        def __getattr__(self, item):"},{"line_number":124,"context_line":"            if item in self.__dict__:"},{"line_number":125,"context_line":"                return self.__dict__[item]"},{"line_number":126,"context_line":"            return self.credentials[item]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def __setattr__(self, key, value):"},{"line_number":129,"context_line":"            if key in self.__dict__:"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_5c38793d","line":126,"in_reply_to":"7af24918_44d31ed5","updated":"2016-03-09 10:49:38.000000000","message":"1) http://paste.openstack.org/show/489810/\n\nHowever \"super(Credentials, self).__setattr__(\"credentials\", credentials)\" in __init__ will solve this\n\n2) this raises KeyError, but should raise AttributeError","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"a1e3529cb7809edaa056e63a3e3169e759ea08eb","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def __setattr__(self, key, value):"},{"line_number":129,"context_line":"            if key in self.__dict__:"},{"line_number":130,"context_line":"                self.__dict__[key] \u003d value"},{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"7af24918_3fdfff3a","line":130,"updated":"2016-03-04 10:17:02.000000000","message":"This should prevent self.credentials from overwriting (with key \u003d\u003d \"credentials\")","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        def __setattr__(self, key, value):"},{"line_number":129,"context_line":"            if key in self.__dict__:"},{"line_number":130,"context_line":"                self.__dict__[key] \u003d value"},{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_588fce74","line":130,"in_reply_to":"7af24918_3fdfff3a","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d978687e5f6024805510e6180f9c5dfd2efd5d19","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def to_dict():"},{"line_number":135,"context_line":"            return self.credentials.copy()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        def validate(self, obj):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_bcb1bd49","line":134,"updated":"2016-03-09 10:49:38.000000000","message":"def to_dict(self):","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def to_dict():"},{"line_number":135,"context_line":"            return self.credentials.copy()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        def validate(self, obj):"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_f80b3a28","line":134,"in_reply_to":"5aef4532_bcb1bd49","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def to_dict():"},{"line_number":135,"context_line":"            return self.credentials.copy()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        def validate(self, obj):"},{"line_number":138,"context_line":"            jsonschema.validate(obj, self._meta_get(\"schema\"))"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_206bb786","line":135,"updated":"2016-03-09 13:17:14.000000000","message":"credential argument can be in the same time: instance of rally.common.objects.credential.Credential or dictionary for one specific openstack deployment user. So need to convert object to dict also","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                self.credentials[key] \u003d value"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def to_dict():"},{"line_number":135,"context_line":"            return self.credentials.copy()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        def validate(self, obj):"},{"line_number":138,"context_line":"            jsonschema.validate(obj, self._meta_get(\"schema\"))"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_471c0fc1","line":135,"in_reply_to":"5aef4532_206bb786","updated":"2016-03-09 17:02:31.000000000","message":"No, it can not be.\nOSClient should support of passing into rally.common.objects.credential.Credential or dictionary, not new plugin-based Credentials class.","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":190,"context_line":"-----------"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Primary assignee:"},{"line_number":193,"context_line":"  rpromyshlennikov aka Rodion Promyshlennikov"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_6c5bfef6","line":193,"updated":"2016-03-09 13:17:14.000000000","message":"Please add here e-mail contacts","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"-----------"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Primary assignee:"},{"line_number":193,"context_line":"  rpromyshlennikov aka Rodion Promyshlennikov"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_448fedcb","line":193,"in_reply_to":"5aef4532_6c5bfef6","updated":"2016-03-09 17:02:31.000000000","message":"Done","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"63392d5c71eb474b5815335e86d6bdb0e5f028fd","unresolved":false,"context_lines":[{"line_number":199,"context_line":"- Change Deployment db model class"},{"line_number":200,"context_line":"- Write migrations"},{"line_number":201,"context_line":"- Make \"dummies\" for credentials get/create/update methods for temporary"},{"line_number":202,"context_line":"  support changed data format"},{"line_number":203,"context_line":"- Remove all usages of passing ``rally.common.objects.credential.Credential``"},{"line_number":204,"context_line":"  to ``rally.osclients.OSClient``"},{"line_number":205,"context_line":"- Create new plugin based class for credentials"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_3bce4a2e","line":202,"updated":"2016-03-09 13:17:14.000000000","message":"Could you provide a bit more details how this would be used or what will be inside? And I don\u0027t understand the usage of word \"dummн\" here. What is it?","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"},{"author":{"_account_id":19267,"name":"Rodion Promyshlennikov","email":"rpromyshlennikov@mirantis.com","username":"rodion"},"change_message_id":"20e5b588d9f6ec9929e9455fa0ad07b397043a0b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"- Change Deployment db model class"},{"line_number":200,"context_line":"- Write migrations"},{"line_number":201,"context_line":"- Make \"dummies\" for credentials get/create/update methods for temporary"},{"line_number":202,"context_line":"  support changed data format"},{"line_number":203,"context_line":"- Remove all usages of passing ``rally.common.objects.credential.Credential``"},{"line_number":204,"context_line":"  to ``rally.osclients.OSClient``"},{"line_number":205,"context_line":"- Create new plugin based class for credentials"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5aef4532_e71efb5d","line":202,"in_reply_to":"5aef4532_3bce4a2e","updated":"2016-03-09 17:02:31.000000000","message":"Rephrase to adapters.\nYou can see them in https://review.openstack.org/#/c/276821.","commit_id":"6bcfc37eabc1e9b8663fc5f74bff340db5702f93"}],"doc/specs/in-progress/deployment_type_attribute.rst":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54fe45fabe46936e8a5dbbd5d1dc48d5c22b5cba","unresolved":false,"context_lines":[{"line_number":8,"context_line":" Move Rally deployment to plugin base"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make Rally be able to load any kind of software, not only OpenStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_f0c0a32c","line":11,"updated":"2015-12-01 12:21:06.000000000","message":"load -\u003e benchmark?","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"c3d2cca2221b33bb8d6905bd4d6539e0f46d6c34","unresolved":false,"context_lines":[{"line_number":8,"context_line":" Move Rally deployment to plugin base"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Make Rally be able to load any kind of software, not only OpenStack."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Problem description"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_13b3e7ea","line":11,"in_reply_to":"9a8ffd7b_f0c0a32c","updated":"2015-12-01 14:56:31.000000000","message":"Done","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54fe45fabe46936e8a5dbbd5d1dc48d5c22b5cba","unresolved":false,"context_lines":[{"line_number":18,"context_line":"objects are designed to store \u0027keystone\u0027 related data. Variety of applications"},{"line_number":19,"context_line":"and solutions enforce Rally to be able to manipulate variety of endpoint data"},{"line_number":20,"context_line":"structures, from empty structure to some very complicated one."},{"line_number":21,"context_line":"Scenarios and contexts are interface related, thus we have to match which"},{"line_number":22,"context_line":"software/service scenario can burn."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d076bf05","line":21,"updated":"2015-12-01 12:21:06.000000000","message":"This \u0027interface related\u0027 piece does not make any sense to me even though I actually know what you mean.","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"c3d2cca2221b33bb8d6905bd4d6539e0f46d6c34","unresolved":false,"context_lines":[{"line_number":18,"context_line":"objects are designed to store \u0027keystone\u0027 related data. Variety of applications"},{"line_number":19,"context_line":"and solutions enforce Rally to be able to manipulate variety of endpoint data"},{"line_number":20,"context_line":"structures, from empty structure to some very complicated one."},{"line_number":21,"context_line":"Scenarios and contexts are interface related, thus we have to match which"},{"line_number":22,"context_line":"software/service scenario can burn."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_73f2739c","line":21,"in_reply_to":"9a8ffd7b_d076bf05","updated":"2015-12-01 14:56:31.000000000","message":"Done","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54fe45fabe46936e8a5dbbd5d1dc48d5c22b5cba","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Remove rally.deployment module"},{"line_number":53,"context_line":"* MergeDeployment and Credential classes."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"*rally.common.objects.credential.Credential*"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_9094b7e8","line":53,"updated":"2015-12-01 12:21:06.000000000","message":"space missed","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"c3d2cca2221b33bb8d6905bd4d6539e0f46d6c34","unresolved":false,"context_lines":[{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"* Remove rally.deployment module"},{"line_number":53,"context_line":"* MergeDeployment and Credential classes."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"*rally.common.objects.credential.Credential*"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d0f475d0","line":53,"in_reply_to":"9a8ffd7b_9094b7e8","updated":"2015-12-01 14:56:31.000000000","message":"Done","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54fe45fabe46936e8a5dbbd5d1dc48d5c22b5cba","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _update(self, values)"},{"line_number":87,"context_line":"    \"\"\" Update this credential \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def update_name(self, name)"},{"line_number":90,"context_line":"    \"\"\" Update this credential name \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def update_data(self, data)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_50af2f7d","line":89,"updated":"2015-12-01 12:21:06.000000000","message":"Why would we want to change the name?","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"c3d2cca2221b33bb8d6905bd4d6539e0f46d6c34","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    def _update(self, values)"},{"line_number":87,"context_line":"    \"\"\" Update this credential \"\"\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def update_name(self, name)"},{"line_number":90,"context_line":"    \"\"\" Update this credential name \"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def update_data(self, data)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_d06d559a","line":89,"in_reply_to":"9a8ffd7b_50af2f7d","updated":"2015-12-01 14:56:31.000000000","message":"This is inherited from \u0027Deployment\u0027 object and is a good idea.\nCause we have to be able to rename (for reorganization purposes, enhance some output readability etc) our credential containers from cli.","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54fe45fabe46936e8a5dbbd5d1dc48d5c22b5cba","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Remove rally.common.db.sqlalchemy.models.Resource"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* Remove _DployStatus, _EndpointPermission, _EndpointType from rally.consts"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Assignee(s)"},{"line_number":153,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_90627715","line":150,"updated":"2015-12-01 12:21:06.000000000","message":"typo? _DployStatus-\u003e_DeployStatus","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"},{"author":{"_account_id":9601,"name":"Oleh Anufriiev","email":"oanufriev@mirantis.com","username":"oanufriev"},"change_message_id":"c3d2cca2221b33bb8d6905bd4d6539e0f46d6c34","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"* Remove rally.common.db.sqlalchemy.models.Resource"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"* Remove _DployStatus, _EndpointPermission, _EndpointType from rally.consts"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Assignee(s)"},{"line_number":153,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a8ffd7b_302621bb","line":150,"in_reply_to":"9a8ffd7b_90627715","updated":"2015-12-01 14:56:31.000000000","message":"Done","commit_id":"72fc1680464bc6150edb63b02e69e4e46b69f107"}]}
