)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"667fb40108e2f40d8b16ff8b9022a8c8f73cdbf9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the hability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_2d439f6d","line":9,"updated":"2015-11-12 06:37:57.000000000","message":"*hability-\u003eability","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"6e6c051b584ec65319b0e72845df8b051b153618","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the hability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_bbb9adee","line":9,"in_reply_to":"da85f559_2d439f6d","updated":"2015-11-13 17:35:42.000000000","message":"You are right, I mixed the Spanish word with the English one haha, sorry for my spanglish. Fixed.","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"667fb40108e2f40d8b16ff8b9022a8c8f73cdbf9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the hability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."},{"line_number":13,"context_line":"$ rally verify start --failing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_ed611706","line":10,"updated":"2015-11-12 06:37:57.000000000","message":"\u0027Some times\u0027 -\u003e \u0027Sometime\u0027","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"6e6c051b584ec65319b0e72845df8b051b153618","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the hability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."},{"line_number":13,"context_line":"$ rally verify start --failing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_fb4df5c4","line":10,"in_reply_to":"da85f559_ed611706","updated":"2015-11-13 17:35:42.000000000","message":"Thanks for catching that mistake, however I think you meant \"sometimes\" instead of \"sometime\", because what I meant was \"on occasion\".\n\nSometime: When written as one word, this adverb implies a vague time in the future. It can frequently be replaced by someday.\n\nSometimes: When written as one word and ending in s, this adverb implies occasionally.\n\nReference: http://www.grammarly.com/handbook/grammar/adjectives-and-adverbs/19/sometime-sometimes-and-some-time/","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"667fb40108e2f40d8b16ff8b9022a8c8f73cdbf9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."},{"line_number":13,"context_line":"$ rally verify start --failing"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieccb6d2a28175c3445d028e81ae2718e4fce375b"},{"line_number":16,"context_line":"Implements: blueprint re-run-failed-tempest-tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_4ddf033a","line":13,"updated":"2015-11-12 06:37:57.000000000","message":"I want to see \u0027rally verify start --failed\u0027. Because You might want to re-run already failed tests(past time). \u0027failing\u0027 - its a process(present continuous)","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"6e6c051b584ec65319b0e72845df8b051b153618","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Some times Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":"e.g."},{"line_number":13,"context_line":"$ rally verify start --failing"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ieccb6d2a28175c3445d028e81ae2718e4fce375b"},{"line_number":16,"context_line":"Implements: blueprint re-run-failed-tempest-tests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_de9fbfb2","line":13,"in_reply_to":"da85f559_4ddf033a","updated":"2015-11-13 17:35:42.000000000","message":"Sure, I can change it to --failed, I decided to go with --failing instead of --failed just to be consisent with the command in testr. Testr already provides this functionality and the command they use for this is --failing, as shown here (https://testrepository.readthedocs.org/en/latest/MANUAL.html#running-tests):\n# Run the failed tests\n$ testr run --failing\n\nSo I thought that for someone familiar with testr it would make more sense to use the same command argument, but I have no problem with changing it to --failed.","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d36af65085c591593b543f867e3d8b0241a498a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the ability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Sometimes Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_3d225eba","line":9,"updated":"2016-02-04 16:20:31.000000000","message":"It seems like the description is exceeding the limit of 72 characters","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"49ec36a65a916cde21a9c6e5daca44b6b00a670c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Re-run failed Tempest tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the ability to re-run the tempest tests that failed in the last test execution."},{"line_number":10,"context_line":"Sometimes Tempest tests fail due to a special temporary condition in the environment,"},{"line_number":11,"context_line":"in such cases it is very useful to be able to re-execute those tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_6bbb1ee6","line":9,"in_reply_to":"5a5ae5dd_3d225eba","updated":"2016-02-04 21:46:16.000000000","message":"Done","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"}],"rally/api.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"667fb40108e2f40d8b16ff8b9022a8c8f73cdbf9","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        :param tempest_config: User specified Tempest config file"},{"line_number":335,"context_line":"        :param system_wide_install: Use virtualenv else run tests in local"},{"line_number":336,"context_line":"                                    environment"},{"line_number":337,"context_line":"        :param failing: Re-run the tests that failed in the last execution"},{"line_number":338,"context_line":"        :returns: Verification object"},{"line_number":339,"context_line":"        \"\"\""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_cda773a5","line":337,"updated":"2015-11-12 06:37:57.000000000","message":"Its better to say \u0027 Re-run the tests that failed in the last execution\u0027 -\u003e \u0027 Re-run tests failed during the last execution\u0027","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"6e6c051b584ec65319b0e72845df8b051b153618","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        :param tempest_config: User specified Tempest config file"},{"line_number":335,"context_line":"        :param system_wide_install: Use virtualenv else run tests in local"},{"line_number":336,"context_line":"                                    environment"},{"line_number":337,"context_line":"        :param failing: Re-run the tests that failed in the last execution"},{"line_number":338,"context_line":"        :returns: Verification object"},{"line_number":339,"context_line":"        \"\"\""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_04c4163e","line":337,"in_reply_to":"da85f559_cda773a5","updated":"2015-11-13 17:35:42.000000000","message":"Done","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dad7bdf8ca5256cf07c118c092c90b0d6c573335","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @classmethod"},{"line_number":326,"context_line":"    def verify(cls, deployment, set_name, regex, tests_file,"},{"line_number":327,"context_line":"               tempest_config, system_wide_install\u003dFalse, failing\u003dFalse):"},{"line_number":328,"context_line":"        \"\"\"Start verifying."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        :param deployment: UUID or name of a deployment."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cd9d7867","line":327,"updated":"2015-11-26 13:56:18.000000000","message":"I prefer to not add one more argument to this and other methods. Let\u0027s change a bit interface and put all optional vars in \"context\" var, which should be a dict:\n\n     def verify(cls, deployment, context)","commit_id":"7ba450771c6817643a104ff4673bb6af679c674f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"941624f0361edc5eff0bc2ef4dff3080992454bf","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003d{}):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_8bd0a4f7","line":360,"updated":"2016-01-24 10:52:25.000000000","message":"Please change empty dict to None. And then in the code use:\ncontext \u003d context or {}\nAlso how about backward compatibility? Possibly we should deprecate old usage first. I will clarify this soon","commit_id":"a6bd1987074d2013dcee43cb699613c571961f2a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"dceff746a60125759bafc558f673719c184fd3d9","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003d{}):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_67ef97e9","line":360,"in_reply_to":"9a68dd71_8bd0a4f7","updated":"2016-01-24 12:46:51.000000000","message":"No you don\u0027t need to deprecate it. Just change default value","commit_id":"a6bd1987074d2013dcee43cb699613c571961f2a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"941624f0361edc5eff0bc2ef4dff3080992454bf","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        verification.set_running()"},{"line_number":402,"context_line":"        verifier.verify("},{"line_number":403,"context_line":"            set_name\u003dcontext.get(\"set_name\", \"\"),"},{"line_number":404,"context_line":"            regex\u003dcontext.get(\"regex\", None),"},{"line_number":405,"context_line":"            tests_file\u003dcontext.get(\"tests_file\", None),"},{"line_number":406,"context_line":"            expected_failures\u003dcontext.get(\"expected_failures\", None),"},{"line_number":407,"context_line":"            concur\u003dcontext.get(\"concur\", 0),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_6b41b0a8","line":404,"updated":"2016-01-24 10:52:25.000000000","message":"Please don\u0027t use None as a default value. Its already None by default.","commit_id":"a6bd1987074d2013dcee43cb699613c571961f2a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"92e1cb820769e32d3b231defcba9ba9bd23c00c1","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003dNone):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_707621da","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":46},"updated":"2016-01-26 10:15:56.000000000","message":"Please, don\u0027t do this.\n1. Context has a special meaning in Rally, so it is not a good idea to give this name to a (just) dict.\n\n2. I\u0027d really love to keep method\u0027s signature as explicit as possible. Hiding params into dict is error-prone and decreases readability. \n\nIf you don\u0027t want to type all these params, when calling the method, you could just make a dict and use **kwargs syntax.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"49ec36a65a916cde21a9c6e5daca44b6b00a670c","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003dNone):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ebb06e45","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":46},"in_reply_to":"7a5de9d1_8925bd5d","updated":"2016-02-04 21:46:16.000000000","message":"I removed the dictionary with the parameters and left the signature explicit again.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4c5d9b708c6e90647a503e8d3c2fc3e50bcbaa60","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003dNone):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_935abf4f","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":46},"in_reply_to":"9a68dd71_707621da","updated":"2016-01-26 11:00:49.000000000","message":"Agreed with @Illia. I do not see advantage of introducing dict container for all arguments","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"3ceec32624a06f31ef75d16a8fcf9576ab285ce3","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003dNone):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_8925bd5d","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":46},"in_reply_to":"9a68dd71_7f24aac5","updated":"2016-01-27 09:56:52.000000000","message":"@Andrey well, you actually mentioned two reasons:\n\n- there are too many params -- yet this does not look like an issue for me. Passing lots of separate params seems to be more pythonic then passing a dict. I believe this could be considered as a best practice in other langs/envs as well. And ALL of the params do have default value.  And one still can prepare \u0027context\u0027 in advance and call \u0027verify\u0027 with **context.\n\n- there are two groups of params - generic and implementation-specific. I believe it would be better first to face the actual situation and then to separate these params explicitly and provide an accurate description.\nIf we just keep a single dict then two years from now in some specific implementation diggig in a \u0027context\u0027 for a required param gbonna be such a pain.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7fbfb670b7e7071986a9fefd020cc22e27a50229","unresolved":false,"context_lines":[{"line_number":357,"context_line":"class Verification(object):"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @classmethod"},{"line_number":360,"context_line":"    def verify(cls, deployment, context\u003dNone):"},{"line_number":361,"context_line":"        \"\"\"Start verification."},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        :param deployment: UUID or name of a deployment"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_7f24aac5","line":360,"range":{"start_line":360,"start_character":0,"end_line":360,"end_character":46},"in_reply_to":"9a68dd71_935abf4f","updated":"2016-01-26 11:40:00.000000000","message":"I\u0027m not agree. We have a lot of arguments and some of them are tempest-specific, others can be used for any type of Verifier. In future we will have more and more specific variables, so I prefer to use such \"context\".","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"92e1cb820769e32d3b231defcba9ba9bd23c00c1","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        verification \u003d objects.Verification(deployment_uuid\u003ddeployment_uuid)"},{"line_number":389,"context_line":"        verifier \u003d tempest.Tempest("},{"line_number":390,"context_line":"            deployment_uuid, verification\u003dverification,"},{"line_number":391,"context_line":"            tempest_config\u003dcontext.get(\"tempest_config\", None),"},{"line_number":392,"context_line":"            system_wide\u003dcontext.get(\"system_wide\", False))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if not verifier.is_installed():"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_103565f6","line":391,"range":{"start_line":391,"start_character":27,"end_line":391,"end_character":34},"updated":"2016-01-26 10:15:56.000000000","message":"These dict.get()\u0027 s all over the code do not look like a good/needed thing as well.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"49ec36a65a916cde21a9c6e5daca44b6b00a670c","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        verification \u003d objects.Verification(deployment_uuid\u003ddeployment_uuid)"},{"line_number":389,"context_line":"        verifier \u003d tempest.Tempest("},{"line_number":390,"context_line":"            deployment_uuid, verification\u003dverification,"},{"line_number":391,"context_line":"            tempest_config\u003dcontext.get(\"tempest_config\", None),"},{"line_number":392,"context_line":"            system_wide\u003dcontext.get(\"system_wide\", False))"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if not verifier.is_installed():"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_0baceaeb","line":391,"range":{"start_line":391,"start_character":27,"end_line":391,"end_character":34},"in_reply_to":"9a68dd71_103565f6","updated":"2016-02-04 21:46:16.000000000","message":"Done","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"}],"rally/cli/commands/verify.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"667fb40108e2f40d8b16ff8b9022a8c8f73cdbf9","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            return (1)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if failing and (set_name or tests_file):"},{"line_number":110,"context_line":"            print(\"When using --failing, all tests that failed in the last \""},{"line_number":111,"context_line":"                  \"execution will be re-run. Choosing a set or a tests file \""},{"line_number":112,"context_line":"                  \"while using this argument has no point, they will be \""},{"line_number":113,"context_line":"                  \"ignored.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_edfb5777","line":110,"updated":"2015-11-12 06:37:57.000000000","message":"I think that its useful ability to run failed tests from some specified set(if I understand for what purpose this file exists). So its should be implemented.","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"6e6c051b584ec65319b0e72845df8b051b153618","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            return (1)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if failing and (set_name or tests_file):"},{"line_number":110,"context_line":"            print(\"When using --failing, all tests that failed in the last \""},{"line_number":111,"context_line":"                  \"execution will be re-run. Choosing a set or a tests file \""},{"line_number":112,"context_line":"                  \"while using this argument has no point, they will be \""},{"line_number":113,"context_line":"                  \"ignored.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_84400609","line":110,"in_reply_to":"da85f559_edfb5777","updated":"2015-11-13 17:35:42.000000000","message":"The problem with that Roman is that I am using the functionality already provided by testr to re-run test cases that failed in the last execution (see https://testrepository.readthedocs.org/en/latest/MANUAL.html#running-tests), so testr does not allow you to choose a set either, if you run the command \"testr run --failing\" it will re run the test cases that failed in the last execution from whatever set was chosen during that execution.\n\nI am reusing that command to implement this functionality, so when using \"rally verify start --failed\" it will always run the test cases that failed in the last execution of the active deployment. So what you are proposing cannot be implemented... at least not this way.","commit_id":"20449b1502fde20711762168ac8991c3fda84a7d"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"92e1cb820769e32d3b231defcba9ba9bd23c00c1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                   required\u003dFalse,"},{"line_number":79,"context_line":"                   help\u003d\"How many processes to use to run Tempest tests. \""},{"line_number":80,"context_line":"                        \"The default value (0) auto-detects your CPU count\")"},{"line_number":81,"context_line":"    @cliutils.args(\"--failed\", dest\u003d\"failing\", required\u003dFalse,"},{"line_number":82,"context_line":"                   help\u003d\"Re-run the tests that failed in the last execution\","},{"line_number":83,"context_line":"                   action\u003d\"store_true\")"},{"line_number":84,"context_line":"    @envutils.with_default_deployment(cli_arg_name\u003d\"deployment\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_334af356","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":62},"updated":"2016-01-26 10:15:56.000000000","message":"I\u0027ve noticed previous discussion about \u0027failing\u0027 vs \u0027failed\u0027.\nI\u0027m pretty fine with either, but please keep it consistent, e.g. \"--failed\" and dest\u003d\"failed\", or \"failing\" in both places","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4c5d9b708c6e90647a503e8d3c2fc3e50bcbaa60","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                   required\u003dFalse,"},{"line_number":79,"context_line":"                   help\u003d\"How many processes to use to run Tempest tests. \""},{"line_number":80,"context_line":"                        \"The default value (0) auto-detects your CPU count\")"},{"line_number":81,"context_line":"    @cliutils.args(\"--failed\", dest\u003d\"failing\", required\u003dFalse,"},{"line_number":82,"context_line":"                   help\u003d\"Re-run the tests that failed in the last execution\","},{"line_number":83,"context_line":"                   action\u003d\"store_true\")"},{"line_number":84,"context_line":"    @envutils.with_default_deployment(cli_arg_name\u003d\"deployment\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_c62397a6","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":62},"in_reply_to":"9a68dd71_334af356","updated":"2016-01-26 11:00:49.000000000","message":"Agreed with @Illia","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"49ec36a65a916cde21a9c6e5daca44b6b00a670c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                   required\u003dFalse,"},{"line_number":79,"context_line":"                   help\u003d\"How many processes to use to run Tempest tests. \""},{"line_number":80,"context_line":"                        \"The default value (0) auto-detects your CPU count\")"},{"line_number":81,"context_line":"    @cliutils.args(\"--failed\", dest\u003d\"failing\", required\u003dFalse,"},{"line_number":82,"context_line":"                   help\u003d\"Re-run the tests that failed in the last execution\","},{"line_number":83,"context_line":"                   action\u003d\"store_true\")"},{"line_number":84,"context_line":"    @envutils.with_default_deployment(cli_arg_name\u003d\"deployment\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ebde2e6c","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":62},"in_reply_to":"9a68dd71_c62397a6","updated":"2016-02-04 21:46:16.000000000","message":"I\u0027m changing this back to --failing as it was originally to be consistent with testr","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"92e1cb820769e32d3b231defcba9ba9bd23c00c1","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                   \"expected_failures\": expected_failures,"},{"line_number":152,"context_line":"                   \"system_wide\": system_wide, \"concur\": concur,"},{"line_number":153,"context_line":"                   \"failing\": failing}"},{"line_number":154,"context_line":"        verification \u003d api.Verification.verify(deployment, context)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        if do_use:"},{"line_number":157,"context_line":"            self.use(verification[\"uuid\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_d3127709","line":154,"range":{"start_line":154,"start_character":0,"end_line":154,"end_character":67},"updated":"2016-01-26 10:15:56.000000000","message":"You don\u0027t have to change \u0027verify\u0027 signature here, just call it \u0027verify(deployment, **context)\u0027.\n\nBut as I wrote @https://review.openstack.org/#/c/244361/4/rally/api.py this in fact is inferior to what it was before.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"}],"rally/verification/tempest/tempest.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dad7bdf8ca5256cf07c118c092c90b0d6c573335","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            self.generate_config_file()"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        if failing:"},{"line_number":301,"context_line":"            testr_arg \u003d \"failing\""},{"line_number":302,"context_line":"            set_name \u003d \"re-run-failed\""},{"line_number":303,"context_line":"        elif set_name \u003d\u003d \"full\":"},{"line_number":304,"context_line":"            testr_arg \u003d \"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6d380c3e","line":301,"updated":"2015-11-26 13:56:18.000000000","message":"You don\u0027t need to modify set_name variable\nif failing:\n   testr_arg \u003d \"--failing\"","commit_id":"7ba450771c6817643a104ff4673bb6af679c674f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"dad7bdf8ca5256cf07c118c092c90b0d6c573335","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            self.config_file \u003d tempest_conf"},{"line_number":338,"context_line":"        LOG.info(_(\"Tempest config file: %s\") % self.config_file)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        test_discovery_mechanism \u003d \"subunit\""},{"line_number":341,"context_line":"        if testr_arg \u003d\u003d \"failing\":"},{"line_number":342,"context_line":"            testr_arg \u003d \"\""},{"line_number":343,"context_line":"            test_discovery_mechanism \u003d \"failing\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_8ddf700c","line":340,"updated":"2015-11-26 13:56:18.000000000","message":"it is not discovery mechanism. subunit is a output format and it is required for our parser.","commit_id":"7ba450771c6817643a104ff4673bb6af679c674f"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"92e1cb820769e32d3b231defcba9ba9bd23c00c1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        testr_args \u003d \"--concurrency %d\" % concur"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        if failing:"},{"line_number":307,"context_line":"            testr_args +\u003d \" --failing\""},{"line_number":308,"context_line":"            set_name \u003d \"re-run-failed\""},{"line_number":309,"context_line":"        elif set_name:"},{"line_number":310,"context_line":"            if set_name \u003d\u003d \"full\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_5372074b","line":307,"range":{"start_line":307,"start_character":0,"end_line":307,"end_character":38},"updated":"2016-01-26 10:15:56.000000000","message":"@Roman, by the way, here is a pretty good reason why we\u0027d want to use \u0027failing\u0027 and not \u0027failed\u0027 -- \u0027cos testr does.\n\n@Castulo, I don\u0027t actually insist on any of the two above. Of course you could keep what you like.","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"}],"tests/unit/verification/test_tempest.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"d36af65085c591593b543f867e3d8b0241a498a2","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        set_name \u003d \"compute\""},{"line_number":359,"context_line":"        fake_call \u003d self._get_fake_call(\"tempest.api.%s\" % set_name)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        self.verifier.verify(set_name, None, None, None, 0, False)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        self.assertEqual(2, mock_tempest_is_configured.call_count)"},{"line_number":364,"context_line":"        mock_tempest_config.assert_called_once_with(self.verifier.deployment)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_30a04590","line":361,"updated":"2016-02-04 16:20:31.000000000","message":"Isn\u0027t this method has default values?","commit_id":"a0bcb1d2f8ebcc7b7ae0b013df0e6e24d0873e9a"}]}