)]}'
{"doc/specs/in-progress/cleanup_refactoring.rst":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0b2e919d30af6b5335950537cb96d7ecdb34d758","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   would be ``rally.task.context.Context``, and for global cleanup it"},{"line_number":84,"context_line":"   would be ``rally.common.plugin.plugin.Plugin``. (In all three cases"},{"line_number":85,"context_line":"   we would also require"},{"line_number":86,"context_line":"   ``rally.common.utils.RandomNameGeneratorMixin`` as a superclass.)"},{"line_number":87,"context_line":"#. For each resource manager, list resources."},{"line_number":88,"context_line":"#. If the resource name matches the list of possible patterns gleaned"},{"line_number":89,"context_line":"   from the set of classes, delete it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_de0ad325","line":86,"updated":"2016-01-11 16:52:59.000000000","message":"Scenario and Context already have RandomNameGeneratorMixin in their bases, but I\u0027m in doubts that we should add this mixin to plugin.Plugin bases - this change touches the most base class. Please substantiate this idea","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1dc99ffa9ffc70f741b65eb883f47f1778562e58","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   would be ``rally.task.context.Context``, and for global cleanup it"},{"line_number":84,"context_line":"   would be ``rally.common.plugin.plugin.Plugin``. (In all three cases"},{"line_number":85,"context_line":"   we would also require"},{"line_number":86,"context_line":"   ``rally.common.utils.RandomNameGeneratorMixin`` as a superclass.)"},{"line_number":87,"context_line":"#. For each resource manager, list resources."},{"line_number":88,"context_line":"#. If the resource name matches the list of possible patterns gleaned"},{"line_number":89,"context_line":"   from the set of classes, delete it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_6eef72b1","line":86,"in_reply_to":"fa69d971_d952ed66","updated":"2016-01-11 17:30:54.000000000","message":"I think I just need to clarify my verbiage (and code) here. We should not add RandomNameGeneratorMixin to ``plugin.Plugin``; we should only operate on plugins that already have RandomNameGeneratorMixin as a superclass. That was profoundly unclear, but I hope the new patchset makes it clearer.","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ce617802f4949ec3f22e05c32d794fef93f1b9de","unresolved":false,"context_lines":[{"line_number":83,"context_line":"   would be ``rally.task.context.Context``, and for global cleanup it"},{"line_number":84,"context_line":"   would be ``rally.common.plugin.plugin.Plugin``. (In all three cases"},{"line_number":85,"context_line":"   we would also require"},{"line_number":86,"context_line":"   ``rally.common.utils.RandomNameGeneratorMixin`` as a superclass.)"},{"line_number":87,"context_line":"#. For each resource manager, list resources."},{"line_number":88,"context_line":"#. If the resource name matches the list of possible patterns gleaned"},{"line_number":89,"context_line":"   from the set of classes, delete it."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_d952ed66","line":86,"in_reply_to":"fa69d971_de0ad325","updated":"2016-01-11 17:00:49.000000000","message":"hm I missed this, really we should not add in plugin.Plugin this mixin..","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0b2e919d30af6b5335950537cb96d7ecdb34d758","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  the cleanup context to do scenario cleanup, but also to do"},{"line_number":105,"context_line":"  out-of-band cleanup of all resources."},{"line_number":106,"context_line":"* A new function, ``name()``, will need to be added to"},{"line_number":107,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager.ResourceManager``"},{"line_number":108,"context_line":"  so that we can determine the name of a resource in order to match it."},{"line_number":109,"context_line":"* A ``task_id`` keyword argument will be added to"},{"line_number":110,"context_line":"  ``name_matches_object`` and ``name_matches_pattern`` in order to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_734680c1","line":107,"updated":"2016-01-11 16:52:59.000000000","message":"base.ResourceManager","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1dc99ffa9ffc70f741b65eb883f47f1778562e58","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  the cleanup context to do scenario cleanup, but also to do"},{"line_number":105,"context_line":"  out-of-band cleanup of all resources."},{"line_number":106,"context_line":"* A new function, ``name()``, will need to be added to"},{"line_number":107,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager.ResourceManager``"},{"line_number":108,"context_line":"  so that we can determine the name of a resource in order to match it."},{"line_number":109,"context_line":"* A ``task_id`` keyword argument will be added to"},{"line_number":110,"context_line":"  ``name_matches_object`` and ``name_matches_pattern`` in order to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_2e2dfa45","line":107,"in_reply_to":"fa69d971_734680c1","updated":"2016-01-11 17:30:54.000000000","message":"Done","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"0b2e919d30af6b5335950537cb96d7ecdb34d758","unresolved":false,"context_lines":[{"line_number":121,"context_line":"or for any rally-created resource at all, regardless of task ID. This"},{"line_number":122,"context_line":"will not be ``rally task cleanup`` because it can be run with or"},{"line_number":123,"context_line":"without a task."},{"line_number":124,"context_line":"py): refactoring-"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Alternatives"},{"line_number":127,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_3ed44f1e","line":124,"updated":"2016-01-11 16:52:59.000000000","message":"This line looks unnecessary","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"1dc99ffa9ffc70f741b65eb883f47f1778562e58","unresolved":false,"context_lines":[{"line_number":121,"context_line":"or for any rally-created resource at all, regardless of task ID. This"},{"line_number":122,"context_line":"will not be ``rally task cleanup`` because it can be run with or"},{"line_number":123,"context_line":"without a task."},{"line_number":124,"context_line":"py): refactoring-"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Alternatives"},{"line_number":127,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa69d971_aefa4abb","line":124,"in_reply_to":"fa69d971_3ed44f1e","updated":"2016-01-11 17:30:54.000000000","message":"Done","commit_id":"81461d7f8b2ef9de22e1415a79178ee61d7a3259"}],"doc/specs/in-progress/cleanup_refactoring_2.rst":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36a2edbc58d86fc17f1c4c2a0391b5564a2ee344","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Refactoring Rally Cleanup, Part II"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This proposal attempts to provide more technical details to complement"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_1c518f62","line":8,"updated":"2015-11-20 21:39:06.000000000","message":"why we can\u0027t merge 2 specs?","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"ea2efe99c73da341ebdc79d8e6d10169f1c0bb8c","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Refactoring Rally Cleanup, Part II"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This proposal attempts to provide more technical details to complement"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a8ffd7b_5cd2d701","line":8,"in_reply_to":"ba8a016a_1c518f62","updated":"2015-11-25 14:57:34.000000000","message":"I wasn\u0027t sure if that was acceptable. I\u0027ll do that.","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36a2edbc58d86fc17f1c4c2a0391b5564a2ee344","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Refactoring Rally Cleanup, Part II"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This proposal attempts to provide more technical details to complement"},{"line_number":12,"context_line":"the `Refactoring Rally Cleanup"},{"line_number":13,"context_line":"\u003chttps://github.com/openstack/rally/blob/master/doc/specs/in-progress/cleanup_refactoring.rst\u003e`_"},{"line_number":14,"context_line":"spec."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_5280b046","line":11,"updated":"2015-11-20 21:39:06.000000000","message":"I believe it\u0027s better to merge this data to first spec.","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36a2edbc58d86fc17f1c4c2a0391b5564a2ee344","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"There are three cases we need to be able to handle:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"* Cleanup of all resources created by a single scenario run;"},{"line_number":28,"context_line":"* Cleanup of all resources created by contexts; and"},{"line_number":29,"context_line":"* Cleanup of all resources, possibly (or probably) out-of-band."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_b28f9c74","line":27,"updated":"2015-11-20 21:39:06.000000000","message":"Actually in new terminology it should be called \"subtask run\" not \"scenario run\"","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36a2edbc58d86fc17f1c4c2a0391b5564a2ee344","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#. Generate a list of subclasses to delete resources for. In this case"},{"line_number":48,"context_line":"   we use ``rally.task.scenario.Scenario``, but for context cleanup it"},{"line_number":49,"context_line":"   would be ``rally.task.context.Context``, and for global cleanup it"},{"line_number":50,"context_line":"   would be ``rally.common.plugin.plugin.Plugin``."},{"line_number":51,"context_line":"#. For each resource manager, list resources."},{"line_number":52,"context_line":"#. If the resource name matches the list of possible patterns gleaned"},{"line_number":53,"context_line":"   from the set of classes, delete it."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_9293784f","line":50,"updated":"2015-11-20 21:39:06.000000000","message":"Maybe it\u0027s better to use only classes that have Plugin and RandomNameGeneratorMixin as a parents? Otherwise some issues may occur","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"ea2efe99c73da341ebdc79d8e6d10169f1c0bb8c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#. Generate a list of subclasses to delete resources for. In this case"},{"line_number":48,"context_line":"   we use ``rally.task.scenario.Scenario``, but for context cleanup it"},{"line_number":49,"context_line":"   would be ``rally.task.context.Context``, and for global cleanup it"},{"line_number":50,"context_line":"   would be ``rally.common.plugin.plugin.Plugin``."},{"line_number":51,"context_line":"#. For each resource manager, list resources."},{"line_number":52,"context_line":"#. If the resource name matches the list of possible patterns gleaned"},{"line_number":53,"context_line":"   from the set of classes, delete it."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a8ffd7b_dcc7a710","line":50,"in_reply_to":"ba8a016a_9293784f","updated":"2015-11-25 14:57:34.000000000","message":"Done","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"36a2edbc58d86fc17f1c4c2a0391b5564a2ee344","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager`` and"},{"line_number":66,"context_line":"  ``rally.plugins.openstack.context.cleanup.resources`` need to be"},{"line_number":67,"context_line":"  moved out of the context space, since they will be used not only by"},{"line_number":68,"context_line":"  the cleanup context to do scenario cleanup, but also to do"},{"line_number":69,"context_line":"  out-of-band cleanup of all resources."},{"line_number":70,"context_line":"* A new function, ``name()``, will need to be added to"},{"line_number":71,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager.ResourceManager``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba8a016a_52b8b0e5","line":68,"updated":"2015-11-20 21:39:06.000000000","message":"This actually really makes sense. What about rally.common.cleanup module ?","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"ea2efe99c73da341ebdc79d8e6d10169f1c0bb8c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager`` and"},{"line_number":66,"context_line":"  ``rally.plugins.openstack.context.cleanup.resources`` need to be"},{"line_number":67,"context_line":"  moved out of the context space, since they will be used not only by"},{"line_number":68,"context_line":"  the cleanup context to do scenario cleanup, but also to do"},{"line_number":69,"context_line":"  out-of-band cleanup of all resources."},{"line_number":70,"context_line":"* A new function, ``name()``, will need to be added to"},{"line_number":71,"context_line":"  ``rally.plugins.openstack.context.cleanup.manager.ResourceManager``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a8ffd7b_9ce83f7e","line":68,"in_reply_to":"ba8a016a_52b8b0e5","updated":"2015-11-25 14:57:34.000000000","message":"Since these are all OpenStack-specific, I think they should probably wind up in the rally.plugins.openstack space somewhere.","commit_id":"32e2918a97b10f0ae414f77bb93e368d76fe9d39"}]}
