)]}'
{"tests/unit/verification/test_config.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e6b2e45bdd8a6236f27f6bc6c69b1321624dc775","unresolved":false,"context_lines":[{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"ENDPOINT \u003d {"},{"line_number":32,"context_line":"    \"username\": \"test\","},{"line_number":33,"context_line":"    \"tenant_name\": \"test\","},{"line_number":34,"context_line":"    \"password\": \"test\","}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_18b94215","line":31,"updated":"2015-11-19 14:03:03.000000000","message":"Now this should be called credentials. So please rename it to credentials","commit_id":"266d4b7508470b63ce8362a9e1b8333f3c6d079d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e6b2e45bdd8a6236f27f6bc6c69b1321624dc775","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    @mock.patch(\"rally.common.objects.deploy.db.deployment_get\","},{"line_number":335,"context_line":"                return_value\u003d{\"admin\": ENDPOINT})"},{"line_number":336,"context_line":"    def test__configure_service_not_available_horizon("},{"line_number":337,"context_line":"            self, mock_deployment_get, mock_clients, mock_isfile, mock_get):"},{"line_number":338,"context_line":"        tempest_conf \u003d config.TempestConfig(\"fake_deployment\")"},{"line_number":339,"context_line":"        tempest_conf._configure_service_available()"},{"line_number":340,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_98b212e4","line":337,"updated":"2015-11-19 14:03:03.000000000","message":"Methods in 324 and 336 line are the perfect examples for use ddt module. Please use ddt module here.","commit_id":"266d4b7508470b63ce8362a9e1b8333f3c6d079d"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8833106ba4f98804bb58cdbab3a81e7fe7faaf96","unresolved":false,"context_lines":[{"line_number":334,"context_line":"    @mock.patch(\"rally.common.objects.deploy.db.deployment_get\","},{"line_number":335,"context_line":"                return_value\u003d{\"admin\": ENDPOINT})"},{"line_number":336,"context_line":"    def test__configure_service_not_available_horizon("},{"line_number":337,"context_line":"            self, mock_deployment_get, mock_clients, mock_isfile, mock_get):"},{"line_number":338,"context_line":"        tempest_conf \u003d config.TempestConfig(\"fake_deployment\")"},{"line_number":339,"context_line":"        tempest_conf._configure_service_available()"},{"line_number":340,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_e586dc15","line":337,"in_reply_to":"ba8a016a_98b212e4","updated":"2015-11-20 12:38:21.000000000","message":"I cannot use ddt here because I have different mock effects for requests.get. In the first case it is return_value\u003dmock.MagicMock(status_code\u003d200). In the second one it is side_effect\u003drequests.Timeout().","commit_id":"266d4b7508470b63ce8362a9e1b8333f3c6d079d"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"e6b2e45bdd8a6236f27f6bc6c69b1321624dc775","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    @mock.patch(\"rally.common.objects.deploy.db.deployment_get\","},{"line_number":358,"context_line":"                return_value\u003d{\"admin\": ENDPOINT})"},{"line_number":359,"context_line":"    def test__configure_validation_if_novanetwork(self, mock_deployment_get,"},{"line_number":360,"context_line":"                                                  mock_clients, mock_isfile):"},{"line_number":361,"context_line":"        tempest_conf \u003d config.TempestConfig(\"fake_deployment\")"},{"line_number":362,"context_line":"        tempest_conf.available_services \u003d [\"nova\"]"},{"line_number":363,"context_line":"        tempest_conf._configure_validation()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_58a26a9a","line":360,"updated":"2015-11-19 14:03:03.000000000","message":"Methods in 347 and 359 line are the perfect examples for use ddt module. Please use ddt module here.","commit_id":"266d4b7508470b63ce8362a9e1b8333f3c6d079d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8bd83acd1e69e2d47075fb6e2f3f7a88cfedc03a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        mock_deployment_get.start()"},{"line_number":59,"context_line":"        mock_clients.start()"},{"line_number":60,"context_line":"        mock_isfile.start()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        self.tempest_conf \u003d config.TempestConfig(\"fake_deployment\")"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_123dddc3","line":60,"updated":"2015-11-26 13:36:32.000000000","message":"self.mock_isfile \u003d mock_isfile.start()","commit_id":"8400d0bfb8a1b920ba9e40b7548ec482d703da17"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8bd83acd1e69e2d47075fb6e2f3f7a88cfedc03a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            CONF.image.cirros_img_url, stream\u003dTrue)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @mock.patch(\"requests.get\")"},{"line_number":75,"context_line":"    @mock.patch(\"os.path.isfile\", return_value\u003dFalse)"},{"line_number":76,"context_line":"    @ddt.data(404, 500)"},{"line_number":77,"context_line":"    def test__download_cirros_image_failure(self, status_code,"},{"line_number":78,"context_line":"                                            mock_isfile, mock_get):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_d232f5f1","line":75,"updated":"2015-11-26 13:36:32.000000000","message":"remove this line, since this module already mocked in setUp","commit_id":"8400d0bfb8a1b920ba9e40b7548ec482d703da17"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8bd83acd1e69e2d47075fb6e2f3f7a88cfedc03a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @ddt.data(404, 500)"},{"line_number":77,"context_line":"    def test__download_cirros_image_failure(self, status_code,"},{"line_number":78,"context_line":"                                            mock_isfile, mock_get):"},{"line_number":79,"context_line":"        mock_get.return_value \u003d mock.MagicMock(status_code\u003dstatus_code)"},{"line_number":80,"context_line":"        self.assertRaises(exceptions.TempestConfigCreationFailure,"},{"line_number":81,"context_line":"                          self.tempest_conf._download_cirros_image)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_526cc5cf","line":79,"updated":"2015-11-26 13:36:32.000000000","message":"add here:\nself.mock_isfile.return_value \u003d False","commit_id":"8400d0bfb8a1b920ba9e40b7548ec482d703da17"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8bd83acd1e69e2d47075fb6e2f3f7a88cfedc03a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                          self.tempest_conf._download_cirros_image)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    @mock.patch(\"requests.get\", side_effect\u003drequests.ConnectionError())"},{"line_number":84,"context_line":"    @mock.patch(\"os.path.isfile\", return_value\u003dFalse)"},{"line_number":85,"context_line":"    def test__download_cirros_image_connection_error(self, mock_isfile,"},{"line_number":86,"context_line":"                                                     mock_requests_get):"},{"line_number":87,"context_line":"        self.assertRaises(exceptions.TempestConfigCreationFailure,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_d260b5d1","line":84,"updated":"2015-11-26 13:36:32.000000000","message":"same here","commit_id":"8400d0bfb8a1b920ba9e40b7548ec482d703da17"}]}