)]}'
{"rally/api.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"b29e8f5f69c34294026c3bf1f8232ed326aba479","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @classmethod"},{"line_number":478,"context_line":"    def list(cls):"},{"line_number":479,"context_line":"        return db.verification_list()"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d47221e3","line":478,"updated":"2015-11-23 12:37:00.000000000","message":"We do not use \u0027cls\u0027  in all three methods here. @staticmethod looks more suitable here.","commit_id":"d62c0cb4163cfdfc667d69bb9383f9e57d606612"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"7186a58b29c555fc342d5e3b6e83181d1a9ed7d7","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @classmethod"},{"line_number":478,"context_line":"    def list(cls):"},{"line_number":479,"context_line":"        return db.verification_list()"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1d93edfb","line":478,"in_reply_to":"ba8a016a_d47221e3","updated":"2015-11-23 13:13:15.000000000","message":"Done","commit_id":"d62c0cb4163cfdfc667d69bb9383f9e57d606612"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"75eb4ff47580582a8ace3ad992e5c9133e5e454a","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @staticmethod"},{"line_number":479,"context_line":"    def list(status\u003dNone):"},{"line_number":480,"context_line":"        return db.verification_list(status)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_d5782cfb","line":479,"updated":"2015-11-24 11:42:54.000000000","message":"please add this method to objects.verification","commit_id":"06e3083373e8f2b40a0ffb53f7b85af4277d9855"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"8726adf030bcbf377e02e584a07c160fae4d041b","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    @staticmethod"},{"line_number":479,"context_line":"    def list(status\u003dNone):"},{"line_number":480,"context_line":"        return db.verification_list(status)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_3e036c75","line":479,"in_reply_to":"9a8ffd7b_d5782cfb","updated":"2015-11-25 01:45:17.000000000","message":"Done","commit_id":"06e3083373e8f2b40a0ffb53f7b85af4277d9855"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"3be6789bc8c01df1ee664827bd956aee258839e1","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @staticmethod"},{"line_number":478,"context_line":"    def list(status\u003dNone):"},{"line_number":479,"context_line":"        return objects.Verification.list(status)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_18ba64c1","line":478,"updated":"2015-11-30 15:06:14.000000000","message":"Tests for these new methods missing in tests/unit/test_api.py","commit_id":"3cbc83fd62883733be48a248d912453f905b759b"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"7389cbf15caf5518d9e14b5cee06dec0a0450481","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                    \"conf_path\": verifier.config_file}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    @staticmethod"},{"line_number":478,"context_line":"    def list(status\u003dNone):"},{"line_number":479,"context_line":"        return objects.Verification.list(status)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_9acb8d1e","line":478,"in_reply_to":"9a8ffd7b_18ba64c1","updated":"2015-12-01 02:55:39.000000000","message":"Done","commit_id":"3cbc83fd62883733be48a248d912453f905b759b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e856627befd23d5e2baea687cdbf6041890c33e3","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    @staticmethod"},{"line_number":486,"context_line":"    def get_test_cases(verification):"},{"line_number":487,"context_line":"        tests \u003d verification.get_results()"},{"line_number":488,"context_line":"        return [objects.Verification(test)"},{"line_number":489,"context_line":"                for test in six.itervalues(tests[\"test_cases\"])]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_92f7e4f4","line":488,"updated":"2015-12-01 10:26:55.000000000","message":"I understand that this code was produced not by you and not in this patch, but it completely wrong! Partial test is not a Verification. I suppose, this method should be removed at all.\n\nCLI should do something like:\n\n    from rally.common import utils\n    verification \u003d api.get_verification(uuid)\n    results \u003d verification.get_results()[\"test_cases\"]\n    tests \u003d [utils.Struct(**results[test_name]) for test_name in results]\n    cli_utils.print_list(tests)","commit_id":"0f0065bd4cea0057e6e367ae0902095a03916e86"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"deeb0128e8c8c5eabaa41625f4e514a064b95543","unresolved":false,"context_lines":[{"line_number":485,"context_line":"    @staticmethod"},{"line_number":486,"context_line":"    def get_test_cases(verification):"},{"line_number":487,"context_line":"        tests \u003d verification.get_results()"},{"line_number":488,"context_line":"        return [objects.Verification(test)"},{"line_number":489,"context_line":"                for test in six.itervalues(tests[\"test_cases\"])]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_46d8e1ef","line":488,"in_reply_to":"9a8ffd7b_92f7e4f4","updated":"2015-12-01 11:10:02.000000000","message":"Thanks for the info !","commit_id":"0f0065bd4cea0057e6e367ae0902095a03916e86"}],"rally/common/objects/verification.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"3be6789bc8c01df1ee664827bd956aee258839e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return cls(db.verification_get(uuid))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def list(cls, status\u003dNone):"},{"line_number":49,"context_line":"        return db.verification_list(status)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_d8b93c7b","line":48,"updated":"2015-11-30 15:06:14.000000000","message":"Please add simple test for this method in tests/unit/common/objects/test_verification.py","commit_id":"3cbc83fd62883733be48a248d912453f905b759b"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"7389cbf15caf5518d9e14b5cee06dec0a0450481","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return cls(db.verification_get(uuid))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @classmethod"},{"line_number":48,"context_line":"    def list(cls, status\u003dNone):"},{"line_number":49,"context_line":"        return db.verification_list(status)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_e5e31e32","line":48,"in_reply_to":"9a8ffd7b_d8b93c7b","updated":"2015-12-01 02:55:39.000000000","message":"Done","commit_id":"3cbc83fd62883733be48a248d912453f905b759b"}],"tests/unit/test_api.py":[{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e5a5d8959f3c03f1357215cecf61e86bbc4987cb","unresolved":false,"context_lines":[{"line_number":488,"context_line":"    @mock.patch(\"rally.common.objects.Verification.list\")"},{"line_number":489,"context_line":"    def test_delete(self, mock_verification_list):"},{"line_number":490,"context_line":"        api.Verification.list()"},{"line_number":491,"context_line":"        mock_verification_list.assert_called_once_with(None)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    @mock.patch(\"rally.common.objects.Verification.get\")"},{"line_number":494,"context_line":"    def test_get(self, mock_verification_get):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_3f126ab5","line":491,"updated":"2015-12-01 15:52:44.000000000","message":"Return value should be checked too:\n\n  retval \u003d api.Verification.list()\n  self.assertEqual(mock_verification_list.return_value, retval)","commit_id":"3ff90745f87e00b42e2bad96ba13a034115b3074"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"e5a5d8959f3c03f1357215cecf61e86bbc4987cb","unresolved":false,"context_lines":[{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    @mock.patch(\"rally.common.objects.Verification.get\")"},{"line_number":494,"context_line":"    def test_get(self, mock_verification_get):"},{"line_number":495,"context_line":"        api.Verification.get(\"fake_id\")"},{"line_number":496,"context_line":"        mock_verification_get.assert_called_once_with(\"fake_id\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_df21defd","line":495,"updated":"2015-12-01 15:52:44.000000000","message":"ditto","commit_id":"3ff90745f87e00b42e2bad96ba13a034115b3074"}]}