)]}'
{"rally/plugins/openstack/context/designate/zones.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally import consts"},{"line_number":19,"context_line":"from rally.plugins.openstack.context.cleanup import manager as resource_manager"},{"line_number":20,"context_line":"from rally.plugins.openstack.scenarios.designate import ("},{"line_number":21,"context_line":"    utils as designate_utils)"},{"line_number":22,"context_line":"from rally.task import context"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_0e81e7fa","line":21,"updated":"2015-12-08 22:20:12.000000000","message":"lets not to use `as` here if it allow us not to use parenthesis","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"4f2b8b25551e9d915ee7124102412adb967b06c4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from rally import consts"},{"line_number":19,"context_line":"from rally.plugins.openstack.context.cleanup import manager as resource_manager"},{"line_number":20,"context_line":"from rally.plugins.openstack.scenarios.designate import ("},{"line_number":21,"context_line":"    utils as designate_utils)"},{"line_number":22,"context_line":"from rally.task import context"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_8ecffb28","line":21,"in_reply_to":"7a740942_0e81e7fa","updated":"2015-12-09 11:14:53.000000000","message":"Done","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@context.configure(name\u003d\"zones\", order\u003d300)"},{"line_number":29,"context_line":"class ZoneGenerator(context.Context):"},{"line_number":30,"context_line":"    \"\"\"Context class for adding temporary zones for benchmarks."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_e3d914f4","line":28,"updated":"2015-12-08 22:20:12.000000000","message":"Quotas have this order please use differ number","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"4f2b8b25551e9d915ee7124102412adb967b06c4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@context.configure(name\u003d\"zones\", order\u003d300)"},{"line_number":29,"context_line":"class ZoneGenerator(context.Context):"},{"line_number":30,"context_line":"    \"\"\"Context class for adding temporary zones for benchmarks."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_ce5c23f3","line":28,"in_reply_to":"7a740942_e3d914f4","updated":"2015-12-09 11:14:53.000000000","message":"Done","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@context.configure(name\u003d\"zones\", order\u003d300)"},{"line_number":29,"context_line":"class ZoneGenerator(context.Context):"},{"line_number":30,"context_line":"    \"\"\"Context class for adding temporary zones for benchmarks."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Zones are added for each tenant."}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_0e57a7ca","line":29,"updated":"2015-12-08 22:20:12.000000000","message":"You should inherit the class from designate utils class and from context.Context","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@context.configure(name\u003d\"zones\", order\u003d300)"},{"line_number":29,"context_line":"class ZoneGenerator(context.Context):"},{"line_number":30,"context_line":"    \"\"\"Context class for adding temporary zones for benchmarks."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Zones are added for each tenant."},{"line_number":33,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_2e22a3a3","line":30,"updated":"2015-12-08 22:20:12.000000000","message":"Adds `zones_per_tenant` zones for each tenant. Other looks like redundant","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"4f2b8b25551e9d915ee7124102412adb967b06c4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@context.configure(name\u003d\"zones\", order\u003d300)"},{"line_number":29,"context_line":"class ZoneGenerator(context.Context):"},{"line_number":30,"context_line":"    \"\"\"Context class for adding temporary zones for benchmarks."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Zones are added for each tenant."},{"line_number":33,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_4e1fd309","line":30,"in_reply_to":"7a740942_2e22a3a3","updated":"2015-12-09 11:14:53.000000000","message":"Done","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Zones`\"))"},{"line_number":52,"context_line":"    def setup(self):"},{"line_number":53,"context_line":"        zones_per_tenant \u003d self.config[\"zones_per_tenant\"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":56,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_6e7aeb89","line":53,"updated":"2015-12-08 22:20:12.000000000","message":"this variable uses only once and not even improve identation. Do we need it?","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"4f2b8b25551e9d915ee7124102412adb967b06c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @logging.log_task_wrapper(LOG.info, _(\"Enter context: `Zones`\"))"},{"line_number":52,"context_line":"    def setup(self):"},{"line_number":53,"context_line":"        zones_per_tenant \u003d self.config[\"zones_per_tenant\"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        for user, tenant_id in rutils.iterate_per_tenants("},{"line_number":56,"context_line":"                self.context[\"users\"]):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_0ec30b3a","line":53,"in_reply_to":"7a740942_6e7aeb89","updated":"2015-12-09 11:14:53.000000000","message":"Done","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"c4706d93cf891f713d7ab0fcb01682d7032444b2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                {\"user\": user,"},{"line_number":60,"context_line":"                 \"task\": self.context[\"task\"]})"},{"line_number":61,"context_line":"            for i in range(zones_per_tenant):"},{"line_number":62,"context_line":"                rnd_name \u003d self.generate_random_name()"},{"line_number":63,"context_line":"                zone \u003d designate_util._create_zone(name\u003drnd_name)"},{"line_number":64,"context_line":"                self.context[\"tenants\"][tenant_id][\"zones\"].append(zone)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_8eb8772b","line":62,"updated":"2015-12-08 22:20:12.000000000","message":"Lets move generating name inside _create_zone if we not pass the name","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"4f2b8b25551e9d915ee7124102412adb967b06c4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                {\"user\": user,"},{"line_number":60,"context_line":"                 \"task\": self.context[\"task\"]})"},{"line_number":61,"context_line":"            for i in range(zones_per_tenant):"},{"line_number":62,"context_line":"                rnd_name \u003d self.generate_random_name()"},{"line_number":63,"context_line":"                zone \u003d designate_util._create_zone(name\u003drnd_name)"},{"line_number":64,"context_line":"                self.context[\"tenants\"][tenant_id][\"zones\"].append(zone)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_2e4a87ad","line":62,"in_reply_to":"7a740942_8eb8772b","updated":"2015-12-09 11:14:53.000000000","message":"Ref IRC conversation","commit_id":"28c0f3a88068524d7f20092a6739e492e738d762"}]}
