)]}'
{".ropeproject/objectdb":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"ʀ煽⸁"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"7a740942_c923d954","line":1,"updated":"2015-12-08 22:38:46.000000000","message":"Those files should be deleted)","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"}],"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a71ea713d979109f1dc929f5b66d6ec7a117d05","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Endre Karlson \u003cendre.karlson@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 11:39:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Designate V2 - part 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add Zone context dependant RecordSet scenarios"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9a68dd71_113acccc","line":7,"updated":"2016-01-22 13:25:29.000000000","message":"Add designate create_and_delete_recordset sceanrio","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"}],"rally-jobs/rally-designate.yaml":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"          users_per_tenant: 2"},{"line_number":142,"context_line":"      sla:"},{"line_number":143,"context_line":"        failure_rate:"},{"line_number":144,"context_line":"          max: 0"},{"line_number":145,"context_line":"  DesignateBasic.create_and_list_recordsets:"},{"line_number":146,"context_line":"    -"},{"line_number":147,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_49ecc929","line":144,"updated":"2015-12-08 22:38:46.000000000","message":"Need one empty line","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"07e61206c375d288ef477d082c29f1593c4c18b5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"          users_per_tenant: 2"},{"line_number":142,"context_line":"      sla:"},{"line_number":143,"context_line":"        failure_rate:"},{"line_number":144,"context_line":"          max: 0"},{"line_number":145,"context_line":"  DesignateBasic.create_and_list_recordsets:"},{"line_number":146,"context_line":"    -"},{"line_number":147,"context_line":"      runner:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a7e1126_8c402e58","line":144,"in_reply_to":"7a740942_49ecc929","updated":"2015-12-17 13:10:07.000000000","message":"Done","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      runner:"},{"line_number":148,"context_line":"        type: \"constant\""},{"line_number":149,"context_line":"        times: 10"},{"line_number":150,"context_line":"        concurrency: 1"},{"line_number":151,"context_line":"      context:"},{"line_number":152,"context_line":"        users:"},{"line_number":153,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_2eb86374","line":150,"updated":"2015-12-08 22:38:46.000000000","message":"Lets increase to at least 2.","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"07e61206c375d288ef477d082c29f1593c4c18b5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"      runner:"},{"line_number":148,"context_line":"        type: \"constant\""},{"line_number":149,"context_line":"        times: 10"},{"line_number":150,"context_line":"        concurrency: 1"},{"line_number":151,"context_line":"      context:"},{"line_number":152,"context_line":"        users:"},{"line_number":153,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a7e1126_82179550","line":150,"in_reply_to":"7a740942_2eb86374","updated":"2015-12-17 13:10:07.000000000","message":"Done","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        type: \"constant\""},{"line_number":149,"context_line":"        times: 10"},{"line_number":150,"context_line":"        concurrency: 1"},{"line_number":151,"context_line":"      context:"},{"line_number":152,"context_line":"        users:"},{"line_number":153,"context_line":"          tenants: 2"},{"line_number":154,"context_line":"          users_per_tenant: 2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_ae00d302","line":151,"updated":"2015-12-08 22:38:46.000000000","message":"At parent patch you add zone context. Lets check it. Add the task with it. Ad such scenario better to add in patch with context.","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      runner:"},{"line_number":162,"context_line":"        type: \"constant\""},{"line_number":163,"context_line":"        times: 10"},{"line_number":164,"context_line":"        concurrency: 1"},{"line_number":165,"context_line":"      context:"},{"line_number":166,"context_line":"        users:"},{"line_number":167,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a740942_0eb5677c","line":164,"updated":"2015-12-08 22:38:46.000000000","message":"Lets increase to at least 2.","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"07e61206c375d288ef477d082c29f1593c4c18b5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"      runner:"},{"line_number":162,"context_line":"        type: \"constant\""},{"line_number":163,"context_line":"        times: 10"},{"line_number":164,"context_line":"        concurrency: 1"},{"line_number":165,"context_line":"      context:"},{"line_number":166,"context_line":"        users:"},{"line_number":167,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a7e1126_42ae8d2f","line":164,"in_reply_to":"7a740942_0eb5677c","updated":"2015-12-17 13:10:07.000000000","message":"Done","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6ff5b6f035c84deac398780940adedc4c8f52862","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        failure_rate:"},{"line_number":158,"context_line":"          max: 0"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  DesignateBasic.create_and_delete_recordset:"},{"line_number":161,"context_line":"    -"},{"line_number":162,"context_line":"      runner:"},{"line_number":163,"context_line":"        type: \"constant\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa69d971_b2708fdd","line":160,"range":{"start_line":160,"start_character":17,"end_line":160,"end_character":44},"updated":"2016-01-05 11:51:08.000000000","message":"wrong name of scenario. s/recordset/recordsets","commit_id":"db8f02507d421775d6104adcca6ccd8262529496"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a71ea713d979109f1dc929f5b66d6ec7a117d05","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      runner:"},{"line_number":107,"context_line":"        type: \"constant\""},{"line_number":108,"context_line":"        times: 10"},{"line_number":109,"context_line":"        concurrency: 2"},{"line_number":110,"context_line":"      context:"},{"line_number":111,"context_line":"        users:"},{"line_number":112,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a68dd71_1113ac5c","line":109,"updated":"2016-01-22 13:25:29.000000000","message":"Looks like delete server in designate under concurrency is broken. If its possible please fix it","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"f7ae8c1d65e0b806a56e2a10165e1b61ffdd6275","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      runner:"},{"line_number":107,"context_line":"        type: \"constant\""},{"line_number":108,"context_line":"        times: 10"},{"line_number":109,"context_line":"        concurrency: 2"},{"line_number":110,"context_line":"      context:"},{"line_number":111,"context_line":"        users:"},{"line_number":112,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a5de9d1_e1194189","line":109,"in_reply_to":"7a5de9d1_d0c3d455","updated":"2016-01-30 11:03:44.000000000","message":"Note thet I wrote \"if its possible\". Ok, then lets make it 1.","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"3ae916f590c852f95ffd6390b95763504ceab7ed","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      runner:"},{"line_number":107,"context_line":"        type: \"constant\""},{"line_number":108,"context_line":"        times: 10"},{"line_number":109,"context_line":"        concurrency: 2"},{"line_number":110,"context_line":"      context:"},{"line_number":111,"context_line":"        users:"},{"line_number":112,"context_line":"          tenants: 2"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7a5de9d1_d0c3d455","line":109,"in_reply_to":"9a68dd71_1113ac5c","updated":"2016-01-29 13:07:09.000000000","message":"Humm, Honestly.. I\u0027m not sure we\u0027ll see that API fixed soon. It\u0027s used all of about once per designate deployment, and does HUGE amount of work when you have lots of domains in the system. On top of that, it\u0027s slowly being phased out entirely.","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8e69145d656383dce59ad95e8e860c91b03cb45a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"      context:"},{"line_number":167,"context_line":"        users:"},{"line_number":168,"context_line":"          tenants: 2"},{"line_number":169,"context_line":"          users_per_tenant: 2"},{"line_number":170,"context_line":"      sla:"},{"line_number":171,"context_line":"        failure_rate:"},{"line_number":172,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bae84128_922f413e","line":169,"updated":"2016-02-24 00:15:33.000000000","message":"You forget to add here zone section http://logs.openstack.org/14/249314/14/experimental/gate-rally-dsvm-designate-rally/ec3d2a9/console.html#_2016-02-23_18_43_39_011","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"c8c593c602ff3267a69bd487091ca11eca1e8224","unresolved":false,"context_lines":[{"line_number":166,"context_line":"      context:"},{"line_number":167,"context_line":"        users:"},{"line_number":168,"context_line":"          tenants: 2"},{"line_number":169,"context_line":"          users_per_tenant: 2"},{"line_number":170,"context_line":"      sla:"},{"line_number":171,"context_line":"        failure_rate:"},{"line_number":172,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bae84128_5d5c7e18","line":169,"in_reply_to":"bae84128_922f413e","updated":"2016-02-24 15:53:11.000000000","message":"Done","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8e69145d656383dce59ad95e8e860c91b03cb45a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      context:"},{"line_number":181,"context_line":"        users:"},{"line_number":182,"context_line":"          tenants: 2"},{"line_number":183,"context_line":"          users_per_tenant: 2"},{"line_number":184,"context_line":"      sla:"},{"line_number":185,"context_line":"        failure_rate:"},{"line_number":186,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bae84128_72327da8","line":183,"range":{"start_line":183,"start_character":11,"end_line":183,"end_character":12},"updated":"2016-02-24 00:15:33.000000000","message":"You forget to add here zone section http://logs.openstack.org/14/249314/14/experimental/gate-rally-dsvm-designate-rally/ec3d2a9/console.html#_2016-02-23_18_43_39_011","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"c8c593c602ff3267a69bd487091ca11eca1e8224","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      context:"},{"line_number":181,"context_line":"        users:"},{"line_number":182,"context_line":"          tenants: 2"},{"line_number":183,"context_line":"          users_per_tenant: 2"},{"line_number":184,"context_line":"      sla:"},{"line_number":185,"context_line":"        failure_rate:"},{"line_number":186,"context_line":"          max: 0"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"bae84128_9da0c6f5","line":183,"range":{"start_line":183,"start_character":11,"end_line":183,"end_character":12},"in_reply_to":"bae84128_72327da8","updated":"2016-02-24 15:53:11.000000000","message":"Done","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"}],"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8e69145d656383dce59ad95e8e860c91b03cb45a","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        return getattr(self.user, self._service)(version)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def list(self):"},{"line_number":523,"context_line":"        criterion \u003d {\"name\": \"rally_*\"}"},{"line_number":524,"context_line":"        for zone in self._walk_pages(self._client().zones.list,"},{"line_number":525,"context_line":"                                     criterion\u003dcriterion):"},{"line_number":526,"context_line":"            for recordset in self._walk_pages(self._client().recordsets.list,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_3250f5d3","line":523,"updated":"2016-02-24 00:15:33.000000000","message":"There is other prefix to delete resources(\"s_rally_...\"). Lets keep it consistent for all resource and not to cleanup by specific prefix(just list all zones). This job would be done by Chris.","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"c8c593c602ff3267a69bd487091ca11eca1e8224","unresolved":false,"context_lines":[{"line_number":520,"context_line":"        return getattr(self.user, self._service)(version)"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def list(self):"},{"line_number":523,"context_line":"        criterion \u003d {\"name\": \"rally_*\"}"},{"line_number":524,"context_line":"        for zone in self._walk_pages(self._client().zones.list,"},{"line_number":525,"context_line":"                                     criterion\u003dcriterion):"},{"line_number":526,"context_line":"            for recordset in self._walk_pages(self._client().recordsets.list,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_cb33ab12","line":523,"in_reply_to":"bae84128_3250f5d3","updated":"2016-02-24 15:53:11.000000000","message":"Done","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"}],"rally/plugins/openstack/context/cleanup/resources.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4a71ea713d979109f1dc929f5b66d6ec7a117d05","unresolved":false,"context_lines":[{"line_number":468,"context_line":"_designate_order \u003d get_order(900)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"class DesignateResource(SynchronizedDeletion, base.ResourceManager):"},{"line_number":472,"context_line":"    def _manager(self):"},{"line_number":473,"context_line":"        # Map resource names to api / client version"},{"line_number":474,"context_line":"        resource_versions \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_661a707f","line":471,"updated":"2016-01-22 13:25:29.000000000","message":"There is no here recordset. You need to add it to resources.","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"b7b9cf286cd08a1b2ed881c0396c09d615535838","unresolved":false,"context_lines":[{"line_number":468,"context_line":"_designate_order \u003d get_order(900)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"class DesignateResource(SynchronizedDeletion, base.ResourceManager):"},{"line_number":472,"context_line":"    def _manager(self):"},{"line_number":473,"context_line":"        # Map resource names to api / client version"},{"line_number":474,"context_line":"        resource_versions \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a57f1b5_603864d4","line":471,"in_reply_to":"5a5ae5dd_18169ea7","updated":"2016-02-10 14:06:27.000000000","message":"Yes its needed. Because better not have dependencies one resource from other. Please add it.","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"46399190597b63a0f7396d4f30ec0cc68b172d16","unresolved":false,"context_lines":[{"line_number":468,"context_line":"_designate_order \u003d get_order(900)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"class DesignateResource(SynchronizedDeletion, base.ResourceManager):"},{"line_number":472,"context_line":"    def _manager(self):"},{"line_number":473,"context_line":"        # Map resource names to api / client version"},{"line_number":474,"context_line":"        resource_versions \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_18169ea7","line":471,"in_reply_to":"9a68dd71_661a707f","updated":"2016-02-04 12:30:51.000000000","message":"I\u0027m not sure that is needed because if you delete the zone the recordset follows? :)","commit_id":"4382a3b1ae43e622c57ca8e75c7588408b3c1e35"}],"rally/plugins/openstack/scenarios/designate/basic.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":236,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"designate\"],"},{"line_number":237,"context_line":"                                 \"zones\": {}})"},{"line_number":238,"context_line":"    def create_and_delete_recordsets(self, recordsets_per_zone\u003d5):"},{"line_number":239,"context_line":"        \"\"\"Create and then delete recordsets."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        Measure the performance of creating and deleting recordsets"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_a92e8d89","line":238,"updated":"2015-12-08 22:38:46.000000000","message":"Lets use 1 by default.","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"07e61206c375d288ef477d082c29f1593c4c18b5","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":236,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"designate\"],"},{"line_number":237,"context_line":"                                 \"zones\": {}})"},{"line_number":238,"context_line":"    def create_and_delete_recordsets(self, recordsets_per_zone\u003d5):"},{"line_number":239,"context_line":"        \"\"\"Create and then delete recordsets."},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        Measure the performance of creating and deleting recordsets"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_dd6c9e9e","line":238,"in_reply_to":"7a740942_a92e8d89","updated":"2015-12-17 13:10:07.000000000","message":"No, we have 5 on the other scenarios from before, I\u0027d like to keep them the same","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"7b348193acf40b631b64127d35d27eb4159b7f0a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":264,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"designate\"],"},{"line_number":265,"context_line":"                                 \"zones\": {}})"},{"line_number":266,"context_line":"    def create_and_list_recordsets(self, recordsets_per_zone\u003d5):"},{"line_number":267,"context_line":"        \"\"\"Create and then list recordsets."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        If you have only 1 user in your context, you will"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_29705da3","line":266,"updated":"2015-12-08 22:38:46.000000000","message":"Lets use 1 by default","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"07e61206c375d288ef477d082c29f1593c4c18b5","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    @validation.required_openstack(users\u003dTrue)"},{"line_number":264,"context_line":"    @scenario.configure(context\u003d{\"cleanup\": [\"designate\"],"},{"line_number":265,"context_line":"                                 \"zones\": {}})"},{"line_number":266,"context_line":"    def create_and_list_recordsets(self, recordsets_per_zone\u003d5):"},{"line_number":267,"context_line":"        \"\"\"Create and then list recordsets."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        If you have only 1 user in your context, you will"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_9d05b6c3","line":266,"in_reply_to":"7a740942_29705da3","updated":"2015-12-17 13:10:07.000000000","message":"See other comment.","commit_id":"02e69da642d049571a8794c5ee9118cc1b5eb968"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3a50e65accc885e68038a1367a4bbdbd79b0df52","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        :param recordsets_per_zone: recordsets to create pr zone."},{"line_number":257,"context_line":"        \"\"\""},{"line_number":258,"context_line":"        zone \u003d self._create_zone()"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        recordsets \u003d []"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_40c5288c","line":258,"updated":"2016-02-10 14:11:03.000000000","message":"Better to use for that context https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/designate/zones.py#L28 please use it","commit_id":"df08103f912a9d2d22b800dbfaf78ecd2f22e0b2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3a50e65accc885e68038a1367a4bbdbd79b0df52","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        :param recordsets_per_zone: recordsets to create pr zone."},{"line_number":288,"context_line":"        \"\"\""},{"line_number":289,"context_line":"        zone \u003d self._create_zone()"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        key \u003d \"designate.create_%s_recordsets\" % recordsets_per_zone"},{"line_number":292,"context_line":"        with atomic.ActionTimer(self, key):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_e03c5495","line":289,"updated":"2016-02-10 14:11:03.000000000","message":"the same as in line 258","commit_id":"df08103f912a9d2d22b800dbfaf78ecd2f22e0b2"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"8e69145d656383dce59ad95e8e860c91b03cb45a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        key \u003d \"designate.create_%s_recordsets\" % recordsets_per_zone"},{"line_number":264,"context_line":"        with atomic.ActionTimer(self, key):"},{"line_number":265,"context_line":"            for i in range(recordsets_per_zone):"},{"line_number":266,"context_line":"                recordset \u003d self._create_recordset(zone, atomic_action\u003dFalse)"},{"line_number":267,"context_line":"                recordsets.append(recordset)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        key \u003d \"designate.delete_%s_recordsets\" % recordsets_per_zone"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_f20a0d25","line":266,"updated":"2016-02-24 00:15:33.000000000","message":"possibly better to choose random zone inside the loop otherwise why we create them more then one and not to use just [0]. But then choosing will be included into atomic.\nSo lets just take zone \u003d self.context[\"tenant\"][\"zones\"][0] and don\u0027t import random\u003d)\nWhat will happen if we create many recordsets from the same zone?","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"c8c593c602ff3267a69bd487091ca11eca1e8224","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        key \u003d \"designate.create_%s_recordsets\" % recordsets_per_zone"},{"line_number":264,"context_line":"        with atomic.ActionTimer(self, key):"},{"line_number":265,"context_line":"            for i in range(recordsets_per_zone):"},{"line_number":266,"context_line":"                recordset \u003d self._create_recordset(zone, atomic_action\u003dFalse)"},{"line_number":267,"context_line":"                recordsets.append(recordset)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        key \u003d \"designate.delete_%s_recordsets\" % recordsets_per_zone"}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_5d175e44","line":266,"in_reply_to":"bae84128_f20a0d25","updated":"2016-02-24 15:53:11.000000000","message":"I think we should use random since that\u0027s the behaviour of the similar test from before to use different","commit_id":"6f4fd03e038dc5e52de1c7ce6de4a706ac4ccb2f"}],"rally/plugins/openstack/scenarios/designate/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d156edfd036b9c59697510ea432541d44ccf8163","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":"        recordset \u003d recordset or {}"},{"line_number":201,"context_line":"        recordset.setdefault(\"type_\", recordset.pop(\"type\", \"A\"))"},{"line_number":202,"context_line":"        recordset.setdefault(\"name\", \"%s.%s\" % (self.generate_random_name(),"},{"line_number":203,"context_line":"                                                zone[\"name\"]))"},{"line_number":204,"context_line":"        recordset.setdefault(\"records\", [\"10.0.0.1\"])"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_b9b59cce","line":202,"updated":"2016-02-26 13:27:23.000000000","message":"Just a recommendation (not critical): in this case it is desirable to use \"if\" statement to prevent useless calling self.generate_random_name() if \"name\" exists:\n\n if \"name\" not in recordset:\n     recordset[\"name\"] \u003d \"%s.%s\" % (self.generate_random_name(), zone[\"name\"]))","commit_id":"a36f2521bb95fc23cffbfb6926ad1c08edbcf523"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"61e895f1bc32658b9fb3520e3923fdcc1fd972a7","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        if \"name\" not in recordset:"},{"line_number":203,"context_line":"            recordset[\"name\"] \u003d \"%s.%s\" % (self.generate_random_name(),"},{"line_number":204,"context_line":"                                           zone[\"name\"])"},{"line_number":205,"context_line":"        if \"records\" not in recordset:"},{"line_number":206,"context_line":"            recordset[\"records\"] \u003d [\"10.0.0.1\"]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        client \u003d self.clients(\"designate\", version\u003d\"2\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_5d91d351","line":205,"updated":"2016-02-26 15:01:37.000000000","message":"Here setdefault() is OK :)","commit_id":"55fb754a2d82d5dcdcf045aea47c95800b90f44e"}],"tests/unit/plugins/openstack/cleanup/test_resources.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"d156edfd036b9c59697510ea432541d44ccf8163","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class AllResourceManagerTestCase(test.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_res_manager_special_field(self):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        for res_mgr in discover.itersubclasses(base.ResourceManager):"},{"line_number":34,"context_line":"            manager_name \u003d \"%s.%s\" % (res_mgr.__module__, res_mgr.__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_6f94e636","side":"PARENT","line":31,"updated":"2016-02-26 13:27:23.000000000","message":"I\u0027m not sure we should remove this test case. Can you explain why this is better then making resource.DesignateResource conforming this test?","commit_id":"a58d3e3c574dbafb5336fa339835dbe335377d82"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aae9dc984e32646a1bea19d548699a4524e85324","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class AllResourceManagerTestCase(test.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_res_manager_special_field(self):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        for res_mgr in discover.itersubclasses(base.ResourceManager):"},{"line_number":34,"context_line":"            manager_name \u003d \"%s.%s\" % (res_mgr.__module__, res_mgr.__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_c5f35309","side":"PARENT","line":31,"in_reply_to":"9aed3d3a_6f94e636","updated":"2016-02-26 13:49:58.000000000","message":"It was a suggestion from me. This test doesn\u0027t allow to create help methods like \"walk_pages\" in DesignateResource. So, imo, we should reduce code duplication and allow to create custom methods in resource classes\n\n@Endre: please, describe the reason in commit message","commit_id":"a58d3e3c574dbafb5336fa339835dbe335377d82"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"a1aa4ccaf5a599291c139ce825cc61ade589c112","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class AllResourceManagerTestCase(test.TestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_res_manager_special_field(self):"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        for res_mgr in discover.itersubclasses(base.ResourceManager):"},{"line_number":34,"context_line":"            manager_name \u003d \"%s.%s\" % (res_mgr.__module__, res_mgr.__name__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_6ae214d7","side":"PARENT","line":31,"in_reply_to":"9aed3d3a_6f94e636","updated":"2016-02-26 13:40:26.000000000","message":"Oh. I\u0027m also don\u0027t understand why you have done this","commit_id":"a58d3e3c574dbafb5336fa339835dbe335377d82"}]}
