)]}'
{"rally/verification/tempest/tempest.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0fd8c4e8c9c9eb1f6fb2c022d07ef21d6b8e2922","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        LOG.info, _(\"Saving verification results.\"))"},{"line_number":389,"context_line":"    def _save_results(self, log_file\u003dNone):"},{"line_number":390,"context_line":"        results \u003d self.parse_results(log_file)"},{"line_number":391,"context_line":"        if results is not None and results.tests and self.verification:"},{"line_number":392,"context_line":"            self.verification.finish_verification(total\u003dresults.total,"},{"line_number":393,"context_line":"                                                  test_cases\u003dresults.tests)"},{"line_number":394,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_8544c849","line":391,"updated":"2015-11-30 07:43:03.000000000","message":"This code looks terribly unclear. \n\nCan we just refactor verify(), _prepare_and_run() and _save_results() method and merge these methods together to avoid such bad code...\n\n_prepare_and_run() is called only from verify() and _save_results() is called on from verify() even more run() is called only once from protected method _prepare_and_run() which is absolutely bad design.","commit_id":"e6a7243e5ddbc41378fd58b36dd16f0f533000de"}]}
