)]}'
{"rally/plugins/openstack/scenarios/vm/utils.py":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8ba3e33a738a9673014aadc9f4d872b30de7d0a2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if sys.platform.startswith(\"linux\"):"},{"line_number":67,"context_line":"            cmd \u003d [ping, \"-c1\", \"-w1\", server.ip.format()]"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            cmd \u003d [ping, \"-c1\", str(server.ip.format())]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        proc \u003d subprocess.Popen(cmd,"},{"line_number":72,"context_line":"                                stdout\u003dsubprocess.PIPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6341e737","line":69,"updated":"2016-01-05 12:42:51.000000000","message":"calling str() is unnesessary","commit_id":"43586f1895b139cf90e6a41272ce2e7da4823e33"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d3999a463b06955251bc83405708d4403c40d2cb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if sys.platform.startswith(\"linux\"):"},{"line_number":67,"context_line":"            cmd \u003d [ping, \"-c1\", \"-w1\", server.ip.format()]"},{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            cmd \u003d [ping, \"-c1\", str(server.ip.format())]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        proc \u003d subprocess.Popen(cmd,"},{"line_number":72,"context_line":"                                stdout\u003dsubprocess.PIPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_dec18c55","line":69,"in_reply_to":"fa69d971_6341e737","updated":"2016-01-05 13:00:51.000000000","message":"Done","commit_id":"43586f1895b139cf90e6a41272ce2e7da4823e33"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"8ba3e33a738a9673014aadc9f4d872b30de7d0a2","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __eq__(self, other):"},{"line_number":84,"context_line":"        if not isinstance(other, Host):"},{"line_number":85,"context_line":"            raise ValueError(\"%s should be an instance of %s\" % ("},{"line_number":86,"context_line":"                other, Host.__class__.__name__))"},{"line_number":87,"context_line":"        return self.ip \u003d\u003d other.ip and self.status \u003d\u003d other.status"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_63dd676e","line":85,"updated":"2016-01-05 12:42:51.000000000","message":"1) TypeError\n2) We use explicit class Host so its name can not be changed in runtime, so I recommend to use it as-is:\n\n  \"%s should be an instance of Host\" % other","commit_id":"43586f1895b139cf90e6a41272ce2e7da4823e33"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d3999a463b06955251bc83405708d4403c40d2cb","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __eq__(self, other):"},{"line_number":84,"context_line":"        if not isinstance(other, Host):"},{"line_number":85,"context_line":"            raise ValueError(\"%s should be an instance of %s\" % ("},{"line_number":86,"context_line":"                other, Host.__class__.__name__))"},{"line_number":87,"context_line":"        return self.ip \u003d\u003d other.ip and self.status \u003d\u003d other.status"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_fec6d066","line":85,"in_reply_to":"fa69d971_63dd676e","updated":"2016-01-05 13:00:51.000000000","message":"1) done\n\n  2) I prefer to not hard-code name","commit_id":"43586f1895b139cf90e6a41272ce2e7da4823e33"}]}