)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"06a1f5e40766bd179a9fac553b18ac2df1722fba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yuki Nishiwaki \u003cuckey.1067@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-09 00:58:07 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add detaied function to rally.api.Task"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The task detailed method return summerized"},{"line_number":10,"context_line":"results of the task as a python object."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_237a1e78","line":7,"updated":"2015-12-16 16:27:20.000000000","message":"detaied -\u003e detailed, function -\u003e method","commit_id":"87e4cee3a4d32bf2a4230febf2631c486d276733"}],"rally/api.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"49438cfae3ce589d4e5c72b93a0e90c9ffc9cc36","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"                atomic_action_result \u003d {}"},{"line_number":374,"context_line":"                for attr_value in zip(summarized_items, data):"},{"line_number":375,"context_line":"                    atomic_action_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":376,"context_line":"                scenario_obj[\"summarized_results\"].append(atomic_action_result)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"            if iterations_data:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_29ce84b4","line":375,"updated":"2015-12-07 11:44:40.000000000","message":"The three lines above could be easily rewritten as\natomic_action_result \u003d dict(zip(summarized_items, data))","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"900d85b741d33b0c68b1c45648179ff0162634ad","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"                atomic_action_result \u003d {}"},{"line_number":374,"context_line":"                for attr_value in zip(summarized_items, data):"},{"line_number":375,"context_line":"                    atomic_action_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":376,"context_line":"                scenario_obj[\"summarized_results\"].append(atomic_action_result)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"            if iterations_data:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_058cc1d8","line":375,"in_reply_to":"7a740942_29ce84b4","updated":"2015-12-07 14:21:36.000000000","message":"Done","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"49438cfae3ce589d4e5c72b93a0e90c9ffc9cc36","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                            action \u003d \"%(no)i. %(action)s\" % {\"no\": c,"},{"line_number":390,"context_line":"                                                             \"action\": a}"},{"line_number":391,"context_line":"                            headers.append(action)"},{"line_number":392,"context_line":"                        break"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"                for (c, r) in enumerate(raw_results, 1):"},{"line_number":395,"context_line":"                    dlist \u003d [c]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e4d98184","line":392,"updated":"2015-12-07 11:44:40.000000000","message":"Why do we need two loops for raw_result in raw_results ?\nPlease consider the following\nfor raw_result in raw_results:\n  if not raw_result[\"error\"] and raw_result.get(\"atomic_actions\"):\n    atomic_actions \u003d raw_result[\"atomic_actions\"].keys()\n      for (c, a) in enumerate(atomic_actions, 1):\n        action \u003d ...\n        headers.append(action)\n      break","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"900d85b741d33b0c68b1c45648179ff0162634ad","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                            action \u003d \"%(no)i. %(action)s\" % {\"no\": c,"},{"line_number":390,"context_line":"                                                             \"action\": a}"},{"line_number":391,"context_line":"                            headers.append(action)"},{"line_number":392,"context_line":"                        break"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"                for (c, r) in enumerate(raw_results, 1):"},{"line_number":395,"context_line":"                    dlist \u003d [c]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_85be7163","line":392,"in_reply_to":"7a740942_e4d98184","updated":"2015-12-07 14:21:36.000000000","message":"Done","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"49438cfae3ce589d4e5c72b93a0e90c9ffc9cc36","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                            dlist.append(r[\"atomic_actions\"].get(action) or 0)"},{"line_number":400,"context_line":"                    iteration_result \u003d {}"},{"line_number":401,"context_line":"                    for attr_value in zip(headers, dlist):"},{"line_number":402,"context_line":"                        iteration_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":403,"context_line":"                    scenario_obj[\"iterations_data\"].append(iteration_result)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            # NOTE(Yuki Nishiwaki): ssrs\u003dscenario specific results"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_24af8995","line":402,"updated":"2015-12-07 11:44:40.000000000","message":"Please use dict(zip(headers, dlist)) as in the comment above","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"900d85b741d33b0c68b1c45648179ff0162634ad","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                            dlist.append(r[\"atomic_actions\"].get(action) or 0)"},{"line_number":400,"context_line":"                    iteration_result \u003d {}"},{"line_number":401,"context_line":"                    for attr_value in zip(headers, dlist):"},{"line_number":402,"context_line":"                        iteration_result[attr_value[0]] \u003d attr_value[1]"},{"line_number":403,"context_line":"                    scenario_obj[\"iterations_data\"].append(iteration_result)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"            # NOTE(Yuki Nishiwaki): ssrs\u003dscenario specific results"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_65b90579","line":402,"in_reply_to":"7a740942_24af8995","updated":"2015-12-07 14:21:36.000000000","message":"Done","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"49438cfae3ce589d4e5c72b93a0e90c9ffc9cc36","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                for key in keys:"},{"line_number":419,"context_line":"                    values \u003d [float(ssr[key]) for ssr in ssrs if key in ssr]"},{"line_number":420,"context_line":"                    if values:"},{"line_number":421,"context_line":"                        row \u003d [str(key),"},{"line_number":422,"context_line":"                               round(min(values), 3),"},{"line_number":423,"context_line":"                               round(utils.median(values), 3),"},{"line_number":424,"context_line":"                               round(utils.percentile(values, 0.90), 3),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_4405f577","line":421,"updated":"2015-12-07 11:44:40.000000000","message":"This really looks like copy-paste from line 358 and on. Please refactor it into a separate method.","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":14764,"name":"Yuki Nishiwaki","email":"uckey.1067@gmail.com","username":"ukinau"},"change_message_id":"900d85b741d33b0c68b1c45648179ff0162634ad","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                for key in keys:"},{"line_number":419,"context_line":"                    values \u003d [float(ssr[key]) for ssr in ssrs if key in ssr]"},{"line_number":420,"context_line":"                    if values:"},{"line_number":421,"context_line":"                        row \u003d [str(key),"},{"line_number":422,"context_line":"                               round(min(values), 3),"},{"line_number":423,"context_line":"                               round(utils.median(values), 3),"},{"line_number":424,"context_line":"                               round(utils.percentile(values, 0.90), 3),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_25b0dd89","line":421,"in_reply_to":"7a740942_4405f577","updated":"2015-12-07 14:21:36.000000000","message":"Done","commit_id":"b554a207d86fbd72f16bc7947808e1abfaa0d51a"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"06a1f5e40766bd179a9fac553b18ac2df1722fba","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        :param iterations_data: If set to True,"},{"line_number":330,"context_line":"                                then return iterations data as well."},{"line_number":331,"context_line":"        \"\"\""},{"line_number":332,"context_line":"        task \u003d db.task_get_detailed(task_uuid)"},{"line_number":333,"context_line":"        if task is None:"},{"line_number":334,"context_line":"            return None"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_c32f9a86","line":332,"updated":"2015-12-16 16:27:20.000000000","message":"This can be obtained via already imported `objects\u0027 https://github.com/openstack/rally/blob/master/rally/common/objects/task.py#L249","commit_id":"87e4cee3a4d32bf2a4230febf2631c486d276733"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"06a1f5e40766bd179a9fac553b18ac2df1722fba","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            return result"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        result[\"scenarios\"] \u003d []"},{"line_number":344,"context_line":"        for scenario_res in task[\"results\"]:"},{"line_number":345,"context_line":"            scenario_obj \u003d {}"},{"line_number":346,"context_line":"            key \u003d scenario_res[\"key\"]"},{"line_number":347,"context_line":"            scenario_obj[\"scenario\"] \u003d key[\"name\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_c3c31a56","line":344,"updated":"2015-12-16 16:27:20.000000000","message":"It looks not clear for me why this transformation (I mean making \"detailed\" result) is added to rally.api. The proper place is rally.cli.commands.task, isn\u0027t it?","commit_id":"87e4cee3a4d32bf2a4230febf2631c486d276733"}],"rally/task/processing/utils.py":[{"author":{"_account_id":8491,"name":"Illia Khudoshyn","email":"ikhudoshyn@mirantis.com","username":"ikhudoshyn"},"change_message_id":"54621ffffe32ba5955f157051fbb7e03b27d2368","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    return actions_data"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def summarize_data(source, if_nothing\u003dNone):"},{"line_number":104,"context_line":"    summarized_items \u003d [\"min\", \"median\", \"90%ile\", \"95%ile\", \"max\", \"avg\"]"},{"line_number":105,"context_line":"    if source:"},{"line_number":106,"context_line":"        data \u003d [round(min(source), 3),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_05ed64b6","line":103,"updated":"2015-12-08 13:15:01.000000000","message":"Please add docstring","commit_id":"a44c9352e95d5058427ef23e001849072b097695"}]}
