)]}'
{"rally/common/objects/task.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e2a813c4d79356fdc712a028bd88c873f820d81c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"items\": {"},{"line_number":29,"context_line":"        \"type\": \"object\","},{"line_number":30,"context_line":"        \"properties\": {"},{"line_number":31,"context_line":"            \"title\": {\"type\": \"string\"},"},{"line_number":32,"context_line":"            \"chart\": {\"type\": \"string\"},"},{"line_number":33,"context_line":"            \"items\": {"},{"line_number":34,"context_line":"                \"type\": \"array\","}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_969d3b0c","line":31,"updated":"2015-12-28 13:16:11.000000000","message":"where is description?","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4903f291cd32139280dfd773b05df46a32253640","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    \"items\": {"},{"line_number":29,"context_line":"        \"type\": \"object\","},{"line_number":30,"context_line":"        \"properties\": {"},{"line_number":31,"context_line":"            \"title\": {\"type\": \"string\"},"},{"line_number":32,"context_line":"            \"chart\": {\"type\": \"string\"},"},{"line_number":33,"context_line":"            \"items\": {"},{"line_number":34,"context_line":"                \"type\": \"array\","}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_70a06891","line":31,"in_reply_to":"1a7b0d38_969d3b0c","updated":"2015-12-29 16:56:16.000000000","message":"Will be added","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e2a813c4d79356fdc712a028bd88c873f820d81c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"OUTPUT_SCHEMA \u003d {"},{"line_number":90,"context_line":"    \"type\": \"object\","},{"line_number":91,"context_line":"    \"properties\": {"},{"line_number":92,"context_line":"        \"additive\": ADDITIVE_OUTPUT_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_1692abf6","line":89,"updated":"2015-12-28 13:16:11.000000000","message":"where is this used ? \n\nSeems like this is half of patch.","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4903f291cd32139280dfd773b05df46a32253640","unresolved":false,"context_lines":[{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"OUTPUT_SCHEMA \u003d {"},{"line_number":90,"context_line":"    \"type\": \"object\","},{"line_number":91,"context_line":"    \"properties\": {"},{"line_number":92,"context_line":"        \"additive\": ADDITIVE_OUTPUT_SCHEMA,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_b0b4a0d1","line":89,"in_reply_to":"1a7b0d38_1692abf6","updated":"2015-12-29 16:56:16.000000000","message":"I will merge this patch with the next one in the chain","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"e2a813c4d79356fdc712a028bd88c873f820d81c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"OUTPUT_SCHEMA \u003d {"},{"line_number":90,"context_line":"    \"type\": \"object\","},{"line_number":91,"context_line":"    \"properties\": {"},{"line_number":92,"context_line":"        \"additive\": ADDITIVE_OUTPUT_SCHEMA,"},{"line_number":93,"context_line":"        \"complete\": COMPLETE_OUTPUT_SCHEMA"},{"line_number":94,"context_line":"    },"},{"line_number":95,"context_line":"    \"required\": [\"additive\", \"complete\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_36a6c753","line":92,"updated":"2015-12-28 13:16:11.000000000","message":"I am 100% sure that we won\u0027t use ADDITIVE_OUTPUT_SCHEMA and COMPELTE_OUTPUT_SCHEMA outside of this place, so I will just suggest to remove both of them and put schemas in-place. \n\nBtw as well I am not sure that we will need OUTPUT_SCHEMA","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"4903f291cd32139280dfd773b05df46a32253640","unresolved":false,"context_lines":[{"line_number":89,"context_line":"OUTPUT_SCHEMA \u003d {"},{"line_number":90,"context_line":"    \"type\": \"object\","},{"line_number":91,"context_line":"    \"properties\": {"},{"line_number":92,"context_line":"        \"additive\": ADDITIVE_OUTPUT_SCHEMA,"},{"line_number":93,"context_line":"        \"complete\": COMPLETE_OUTPUT_SCHEMA"},{"line_number":94,"context_line":"    },"},{"line_number":95,"context_line":"    \"required\": [\"additive\", \"complete\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_50f8c47c","line":92,"in_reply_to":"1a7b0d38_36a6c753","updated":"2015-12-29 16:56:16.000000000","message":"This is not in use right now, but these schemas splitted specially for planned output validation - additive and complete output should be validated separately during Scenario.add_output() call. This will be implemented after proper changes to the spec are merged (or maybe even earlier).\n\nOUTPUT_SCHEMA is used in runner.","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"42030e3f926d1b653bcc33cbacd4a961cc0b41dd","unresolved":false,"context_lines":[{"line_number":89,"context_line":"OUTPUT_SCHEMA \u003d {"},{"line_number":90,"context_line":"    \"type\": \"object\","},{"line_number":91,"context_line":"    \"properties\": {"},{"line_number":92,"context_line":"        \"additive\": ADDITIVE_OUTPUT_SCHEMA,"},{"line_number":93,"context_line":"        \"complete\": COMPLETE_OUTPUT_SCHEMA"},{"line_number":94,"context_line":"    },"},{"line_number":95,"context_line":"    \"required\": [\"additive\", \"complete\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ade4330d","line":92,"in_reply_to":"fa69d971_50f8c47c","updated":"2015-12-30 10:53:21.000000000","message":"Since there is a schema validation in runner, there maybe no reason for using additional validation in add_output, so I will remove separate constants ADDITIVE_OUTPUT_SCHEMA and COMPLETE_OUTPUT_SCHEMA and keep only OUTPUT_SCHEMA","commit_id":"847d750573fdfd30a4d77fe10237b1afdc3f49f6"}],"rally/task/runner.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c17ebc739100176b7308ce3b693fe16526abcf85","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":62,"context_line":"    try:"},{"line_number":63,"context_line":"        with rutils.Timer() as timer:"},{"line_number":64,"context_line":"            # NOTE(amaretskiy): Output as return value is deprecated"},{"line_number":65,"context_line":"            #     but supported for backward compatibility"},{"line_number":66,"context_line":"            deprecated_output \u003d getattr(scenario_inst, method_name)(**kwargs)"},{"line_number":67,"context_line":"            if deprecated_output:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_49b3bde9","line":64,"updated":"2016-01-05 00:41:36.000000000","message":"it\u0027s better to LOG warning message if deprecated way is used.\n\nHowever it should be add when alternative way to add output will be added.","commit_id":"73f5fc4614783807a3bcddc3bac3392691765a29"}]}