)]}'
{"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"35a98a3a75a94630578e823ddaf6e29be96d5f43","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        \"\"\""},{"line_number":285,"context_line":"        if \"networks\" in self.context[\"tenant\"]:"},{"line_number":286,"context_line":"            return {\"network\":"},{"line_number":287,"context_line":"                    random.choice(self.context[\"tenant\"][\"networks\"])}"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            LOG.warning(_(\"Running this scenario without either the \u0027network\u0027 \""},{"line_number":290,"context_line":"                          \"or \u0027existing_network\u0027 context is deprecated\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fd0d37e8","line":287,"updated":"2015-12-08 21:12:45.000000000","message":"Not a big deal but I wonder if this formatting is pep8... ?\n\nI\u0027d do:\nreturn {\n    \"network\": \u003cblah\u003e,\n}","commit_id":"20b05f2a513ffe88917bf53c5630d07f9b2a1022"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6fdb601f9bcb22843cb34da33d009cfaf9977be6","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        \"\"\""},{"line_number":285,"context_line":"        if \"networks\" in self.context[\"tenant\"]:"},{"line_number":286,"context_line":"            return {\"network\":"},{"line_number":287,"context_line":"                    random.choice(self.context[\"tenant\"][\"networks\"])}"},{"line_number":288,"context_line":"        else:"},{"line_number":289,"context_line":"            LOG.warning(_(\"Running this scenario without either the \u0027network\u0027 \""},{"line_number":290,"context_line":"                          \"or \u0027existing_network\u0027 context is deprecated\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_37ef531f","line":287,"in_reply_to":"7a740942_fd0d37e8","updated":"2015-12-09 01:05:38.000000000","message":"so we have all pep8 rules enabled in gates and all of them passed.\n\nSo seems like it\u0027s valid from pep8 point of view","commit_id":"20b05f2a513ffe88917bf53c5630d07f9b2a1022"}],"tests/unit/plugins/openstack/scenarios/neutron/test_utils.py":[{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"35a98a3a75a94630578e823ddaf6e29be96d5f43","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        network \u003d scenario._get_or_create_network(network_create_args)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        # ensure that the return value is the proper type either way"},{"line_number":445,"context_line":"        self.assertIn(\"network\", network)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if \"networks\" in context[\"tenant\"]:"},{"line_number":448,"context_line":"            self.assertEqual(network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1d436314","line":445,"updated":"2015-12-08 21:12:45.000000000","message":"Why don\u0027t you check that network is equal to the object created above?\nAs in:\nmock_network \u003d {\"network\": mock.Mock()}\n# blah blah\nreturned_network \u003d scenario._get_or_create_network(network_create_args)\nself.assertEquals(mock_network, returned_network)","commit_id":"20b05f2a513ffe88917bf53c5630d07f9b2a1022"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"3380c35d389e72fdfde1b76b83fcd069ade490b0","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        network \u003d scenario._get_or_create_network(network_create_args)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        # ensure that the return value is the proper type either way"},{"line_number":445,"context_line":"        self.assertIn(\"network\", network)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if \"networks\" in context[\"tenant\"]:"},{"line_number":448,"context_line":"            self.assertEqual(network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_3d8bbf20","line":445,"in_reply_to":"7a740942_1d436314","updated":"2015-12-08 21:17:31.000000000","message":"_create_network() isn\u0027t always called, so the actual return value can vary.","commit_id":"20b05f2a513ffe88917bf53c5630d07f9b2a1022"},{"author":{"_account_id":18364,"name":"Raphaël Badin","email":"rabadin@cisco.com","username":"rvba"},"change_message_id":"35a98a3a75a94630578e823ddaf6e29be96d5f43","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        self.assertIn(\"network\", network)"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if \"networks\" in context[\"tenant\"]:"},{"line_number":448,"context_line":"            self.assertEqual(network,"},{"line_number":449,"context_line":"                             {\"network\": context[\"tenant\"][\"networks\"][0]})"},{"line_number":450,"context_line":"            self.assertFalse(scenario._create_network.called)"},{"line_number":451,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fd5697cc","line":448,"updated":"2015-12-08 21:12:45.000000000","message":"The test is backwards I think.  The reference value should be the first argument.  This is so that the failure message (when it fails) is consistent.","commit_id":"20b05f2a513ffe88917bf53c5630d07f9b2a1022"}]}
