)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a109432e6147379025a5deb9107fc235ed519ace","unresolved":false,"context_lines":[{"line_number":10,"context_line":"can be added according to the related specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0bb50dfbf89fbf59c415d7d551b6ca07fe16b64d"},{"line_number":13,"context_line":"Implements: spec improve_scenario_output_format.rst"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_ad00e502","line":13,"updated":"2016-01-06 20:58:30.000000000","message":"Shouldn\u0027t this reference a blueprint instead of a spec? At a minimum, Gerrit knows how to handle (and auto-linkify) \u0027Implements: blueprint ...\u0027 lines.","commit_id":"4b1f23a75ae6d2885c66d00dd230197ebc8a893b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"f4b5f586eee23af5e5e526522041b35b7fc5ae9b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"can be added according to the related specification."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0bb50dfbf89fbf59c415d7d551b6ca07fe16b64d"},{"line_number":13,"context_line":"Implements: spec improve_scenario_output_format.rst"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_ed7c81ed","line":13,"in_reply_to":"fa69d971_ad00e502","updated":"2016-01-07 10:39:49.000000000","message":"yep next time we should introduce blueprint. Soon I hope it will happen but let\u0027s for now just remove this.","commit_id":"4b1f23a75ae6d2885c66d00dd230197ebc8a893b"}],"rally/task/runner.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"131d9b316ef19dc3bf05c9bf061e76af2ece4c2c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            deprecated_output \u003d getattr(scenario_inst, method_name)(**kwargs)"},{"line_number":67,"context_line":"            if hasattr(scenario_inst, \"_output\"):"},{"line_number":68,"context_line":"                output \u003d scenario_inst._output"},{"line_number":69,"context_line":"            elif deprecated_output:"},{"line_number":70,"context_line":"                LOG.warning(\"returning output data by scenario is \""},{"line_number":71,"context_line":"                            \"deprecated in favor of calling add_output()\")"},{"line_number":72,"context_line":"                output[\"additive\"].append({"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a1804dc1","line":69,"updated":"2016-01-05 02:18:00.000000000","message":"what about the case where user is using both approaches together?\n\nI believe in such we should just log that depreacated output way was ignored.","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3992403de9473e6f7b3ee7e837e35debbfe69aca","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            deprecated_output \u003d getattr(scenario_inst, method_name)(**kwargs)"},{"line_number":67,"context_line":"            if hasattr(scenario_inst, \"_output\"):"},{"line_number":68,"context_line":"                output \u003d scenario_inst._output"},{"line_number":69,"context_line":"            elif deprecated_output:"},{"line_number":70,"context_line":"                LOG.warning(\"returning output data by scenario is \""},{"line_number":71,"context_line":"                            \"deprecated in favor of calling add_output()\")"},{"line_number":72,"context_line":"                output[\"additive\"].append({"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_6281e8c2","line":69,"in_reply_to":"fa69d971_a1804dc1","updated":"2016-01-05 10:41:40.000000000","message":"Will do","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"}],"rally/task/scenario.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"131d9b316ef19dc3bf05c9bf061e76af2ece4c2c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if not hasattr(self, \"_output\"):"},{"line_number":175,"context_line":"            self._output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":176,"context_line":"        if additive:"},{"line_number":177,"context_line":"            self._output[\"additive\"].append(additive)"},{"line_number":178,"context_line":"        if complete:"},{"line_number":179,"context_line":"            self._output[\"complete\"].append(complete)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_21777dd4","line":177,"updated":"2016-01-05 02:18:00.000000000","message":"It will be much better to raise here exception if format of addtivie or complete is wrong. \n\nIt will save a lot of time to scenario developers","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3992403de9473e6f7b3ee7e837e35debbfe69aca","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if not hasattr(self, \"_output\"):"},{"line_number":175,"context_line":"            self._output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":176,"context_line":"        if additive:"},{"line_number":177,"context_line":"            self._output[\"additive\"].append(additive)"},{"line_number":178,"context_line":"        if complete:"},{"line_number":179,"context_line":"            self._output[\"complete\"].append(complete)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a2be0063","line":177,"in_reply_to":"fa69d971_21777dd4","updated":"2016-01-05 10:41:40.000000000","message":"Will do","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9416e405f7bb2e8d8a6de262bb3ed067b7026df1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common. objects import task"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"},{"line_number":25,"context_line":"from rally.common import utils"},{"line_number":26,"context_line":"from rally import consts"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_baf4a85a","line":23,"updated":"2016-01-06 16:05:08.000000000","message":"remove redundant space here","commit_id":"adcfd88cb33491486c84211c94891f5dae9cfd04"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"306ae14587be04e3776105597b25fdc4b56a2b2c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common. objects import task"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"},{"line_number":25,"context_line":"from rally.common import utils"},{"line_number":26,"context_line":"from rally import consts"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_3a2438c3","line":23,"in_reply_to":"fa69d971_baf4a85a","updated":"2016-01-06 16:08:23.000000000","message":"Done","commit_id":"adcfd88cb33491486c84211c94891f5dae9cfd04"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"a109432e6147379025a5deb9107fc235ed519ace","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        :param complete: dict with complete output"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        if not hasattr(self, \"_output\"):"},{"line_number":177,"context_line":"            self._output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":178,"context_line":"        for key, value in ((\"additive\", additive), (\"complete\", complete)):"},{"line_number":179,"context_line":"            if value:"},{"line_number":180,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_380bd525","line":177,"updated":"2016-01-06 20:58:30.000000000","message":"Why not just define self._output in __init__()?","commit_id":"4b1f23a75ae6d2885c66d00dd230197ebc8a893b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"f4b5f586eee23af5e5e526522041b35b7fc5ae9b","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        :param complete: dict with complete output"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        if not hasattr(self, \"_output\"):"},{"line_number":177,"context_line":"            self._output \u003d {\"additive\": [], \"complete\": []}"},{"line_number":178,"context_line":"        for key, value in ((\"additive\", additive), (\"complete\", complete)):"},{"line_number":179,"context_line":"            if value:"},{"line_number":180,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_0dda3518","line":177,"in_reply_to":"fa69d971_380bd525","updated":"2016-01-07 10:39:49.000000000","message":"yep sounds reasonable","commit_id":"4b1f23a75ae6d2885c66d00dd230197ebc8a893b"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1eafee1b9f72787e3a7c0b0009ec4b9c554161cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common.objects import task  # noqa"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"},{"line_number":25,"context_line":"from rally.common import utils"},{"line_number":26,"context_line":"from rally import consts"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_42c23d54","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":32},"updated":"2016-01-07 10:33:22.000000000","message":"Why noqa is here?","commit_id":"ab919a5f3a737d93bef4433757c25cbd105d6a2a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8d83d0f638c3d297660f9380f8620c2146234f44","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from rally.common import logging"},{"line_number":23,"context_line":"from rally.common.objects import task  # noqa"},{"line_number":24,"context_line":"from rally.common.plugin import plugin"},{"line_number":25,"context_line":"from rally.common import utils"},{"line_number":26,"context_line":"from rally import consts"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_adb769f4","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":32},"in_reply_to":"fa69d971_42c23d54","updated":"2016-01-07 10:34:03.000000000","message":"because..","commit_id":"ab919a5f3a737d93bef4433757c25cbd105d6a2a"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"1eafee1b9f72787e3a7c0b0009ec4b9c554161cd","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        \"\"\"Add iteration values for additive output."},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        :param additive: dict with additive output"},{"line_number":174,"context_line":"        :param complete: dict with complete output"},{"line_number":175,"context_line":"        \"\"\""},{"line_number":176,"context_line":"        if not hasattr(self, \"_output\"):"},{"line_number":177,"context_line":"            self._output \u003d {\"additive\": [], \"complete\": []}"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_d87620a3","line":174,"updated":"2016-01-07 10:33:22.000000000","message":"It also should document raises section here","commit_id":"ab919a5f3a737d93bef4433757c25cbd105d6a2a"}],"tests/unit/fakes.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"131d9b316ef19dc3bf05c9bf061e76af2ece4c2c","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"    def with_add_output(self, **kwargs):"},{"line_number":1602,"context_line":"        self._output \u003d {"},{"line_number":1603,"context_line":"            \"additive\": [{\"title\": \"Additive\", \"chart\": \"Chart\","},{"line_number":1604,"context_line":"                          \"items\": [(\"a\", 1)]}],"},{"line_number":1605,"context_line":"            \"complete\": [{\"title\": \"Complete\", \"widget\": \"Widget\","},{"line_number":1606,"context_line":"                          \"data\": [(\"a\", [3, 2, 1])]}]}"},{"line_number":1607,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a1512d38","line":1604,"updated":"2016-01-05 02:18:00.000000000","message":"this looks like ugly hack. You should just call self.add_output here","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"},{"author":{"_account_id":10475,"name":"Alexander Maretskiy","email":"amaretskiy@mirantis.com","username":"maretskiy"},"change_message_id":"3992403de9473e6f7b3ee7e837e35debbfe69aca","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"    def with_add_output(self, **kwargs):"},{"line_number":1602,"context_line":"        self._output \u003d {"},{"line_number":1603,"context_line":"            \"additive\": [{\"title\": \"Additive\", \"chart\": \"Chart\","},{"line_number":1604,"context_line":"                          \"items\": [(\"a\", 1)]}],"},{"line_number":1605,"context_line":"            \"complete\": [{\"title\": \"Complete\", \"widget\": \"Widget\","},{"line_number":1606,"context_line":"                          \"data\": [(\"a\", [3, 2, 1])]}]}"},{"line_number":1607,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_02a6ec52","line":1604,"in_reply_to":"fa69d971_a1512d38","updated":"2016-01-05 10:41:40.000000000","message":"Will do","commit_id":"7caa208a2fd1f5751704b515d845191133f6ee16"}]}