)]}'
{"rally/plugins/common/sla/iteration_time.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from rally.task import sla"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"@sla.configure(name\u003d\"seconds_per_iteration\")"},{"line_number":28,"context_line":"class IterationTime(sla.SLA):"},{"line_number":29,"context_line":"    \"\"\"Maximum and Minimum time for one iteration in seconds.\"\"\""},{"line_number":30,"context_line":"    CONFIG_SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_27b3089c","line":27,"updated":"2015-12-11 11:35:51.000000000","message":"I don\u0027t like such name. But I can\u0027t suggest something more reasonable now.","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \"properties\": {"},{"line_number":34,"context_line":"            \"max_seconds_per_iteration\": {\"type\": \"number\", \"minimum\": 0.0, "},{"line_number":35,"context_line":"                   \"exclusiveMinimum\": True},"},{"line_number":36,"context_line":"            \"max_seconds_per_iteration\": {\"type\": \"number\", \"minimum\": 0.0,"},{"line_number":37,"context_line":"                   \"exclusiveMinimum\": True}"},{"line_number":38,"context_line":"        }"},{"line_number":39,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_c1df94d4","line":36,"updated":"2015-12-11 11:35:51.000000000","message":"line 34 and 36 the same","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.max_iteration_time \u003d self.criterion_value.get("},{"line_number":44,"context_line":"                           \"max_seconds_per_iteration\", 0)"},{"line_number":45,"context_line":"        self.min_iteration_time \u003d self.criterion_value.get("},{"line_number":46,"context_line":"                           \"min_seconds_per_iteration\", 0)"},{"line_number":47,"context_line":"        self.duration \u003d 0.0 "},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def add_iteration(self, iteration):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_6464ae21","line":46,"updated":"2015-12-11 11:35:51.000000000","message":"You don\u0027t use above two variables nowhere except __init__","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.duration \u003d 0.0 "},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def add_iteration(self, iteration):"},{"line_number":50,"context_line":"        self.duration \u003d iteration[\"duration\"]"},{"line_number":51,"context_line":"        self.success \u003d (self.min_iteration_time \u003c\u003d self.duration"},{"line_number":52,"context_line":"                         \u003c\u003d self.max_iteration_time)"},{"line_number":53,"context_line":"        return self.success"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e7d2e0ff","line":50,"updated":"2015-12-11 11:35:51.000000000","message":"Why you assign to self.duration. You need to update variables `max_iteration_time` and `min_iteration_time`","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def add_iteration(self, iteration):"},{"line_number":50,"context_line":"        self.duration \u003d iteration[\"duration\"]"},{"line_number":51,"context_line":"        self.success \u003d (self.min_iteration_time \u003c\u003d self.duration"},{"line_number":52,"context_line":"                         \u003c\u003d self.max_iteration_time)"},{"line_number":53,"context_line":"        return self.success"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_2709c884","line":51,"updated":"2015-12-11 11:35:51.000000000","message":"You should use `self.criterion_value` for calculating success","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"3dd7b9e80623bad9a5f1b5ffc3296e5973e6d6dc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return self.success"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def merge(self, other):"},{"line_number":56,"context_line":"        self.success \u003d (self.min_iteration_time \u003c\u003d other.duration"},{"line_number":57,"context_line":"                         \u003c\u003d self.max_iteration_time)"},{"line_number":58,"context_line":"        return self.success"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_e7550050","line":56,"updated":"2015-12-11 11:35:51.000000000","message":"Totally wrong. Merge need to mantain invarian that `max_iteration_time` is the maximum time among iteration durations, the same for `min_iteration_time`.","commit_id":"a79e44098a7072d1fbfa763b3b73240fbe0306ee"}]}